summaryrefslogtreecommitdiff
path: root/spec/lib/banzai/filter/reference_filter_spec.rb
diff options
context:
space:
mode:
Diffstat (limited to 'spec/lib/banzai/filter/reference_filter_spec.rb')
-rw-r--r--spec/lib/banzai/filter/reference_filter_spec.rb88
1 files changed, 10 insertions, 78 deletions
diff --git a/spec/lib/banzai/filter/reference_filter_spec.rb b/spec/lib/banzai/filter/reference_filter_spec.rb
index d5978db13c0..2888965dbc4 100644
--- a/spec/lib/banzai/filter/reference_filter_spec.rb
+++ b/spec/lib/banzai/filter/reference_filter_spec.rb
@@ -110,20 +110,6 @@ RSpec.describe Banzai::Filter::ReferenceFilter do
expect(filter.instance_variable_get(:@new_nodes)).to eq({ index => [filter.each_node.to_a[index]] })
end
-
- context "with update_nodes_for_banzai_reference_filter feature flag disabled" do
- before do
- stub_feature_flags(update_nodes_for_banzai_reference_filter: false)
- end
-
- it 'does not call replace_and_update_new_nodes' do
- expect(filter).not_to receive(:replace_and_update_new_nodes).with(filter.nodes[index], index, html)
-
- filter.send(method_name, *args) do
- html
- end
- end
- end
end
end
@@ -198,49 +184,20 @@ RSpec.describe Banzai::Filter::ReferenceFilter do
end
describe "#call_and_update_nodes" do
- context "with update_nodes_for_banzai_reference_filter feature flag enabled" do
- include_context 'new nodes'
- let(:document) { Nokogiri::HTML.fragment('<a href="foo">foo</a>') }
- let(:filter) { described_class.new(document, project: project) }
-
- before do
- stub_feature_flags(update_nodes_for_banzai_reference_filter: true)
- end
-
- it "updates all new nodes", :aggregate_failures do
- filter.instance_variable_set('@nodes', nodes)
-
- expect(filter).to receive(:call) { filter.instance_variable_set('@new_nodes', new_nodes) }
- expect(filter).to receive(:with_update_nodes).and_call_original
- expect(filter).to receive(:update_nodes!).and_call_original
-
- filter.call_and_update_nodes
-
- expect(filter.result[:reference_filter_nodes]).to eq(expected_nodes)
- end
- end
-
- context "with update_nodes_for_banzai_reference_filter feature flag disabled" do
- include_context 'new nodes'
-
- before do
- stub_feature_flags(update_nodes_for_banzai_reference_filter: false)
- end
+ include_context 'new nodes'
+ let(:document) { Nokogiri::HTML.fragment('<a href="foo">foo</a>') }
+ let(:filter) { described_class.new(document, project: project) }
- it "does not change nodes", :aggregate_failures do
- document = Nokogiri::HTML.fragment('<a href="foo">foo</a>')
- filter = described_class.new(document, project: project)
- filter.instance_variable_set('@nodes', nodes)
+ it "updates all new nodes", :aggregate_failures do
+ filter.instance_variable_set('@nodes', nodes)
- expect(filter).to receive(:call) { filter.instance_variable_set('@new_nodes', new_nodes) }
- expect(filter).not_to receive(:with_update_nodes)
- expect(filter).not_to receive(:update_nodes!)
+ expect(filter).to receive(:call) { filter.instance_variable_set('@new_nodes', new_nodes) }
+ expect(filter).to receive(:with_update_nodes).and_call_original
+ expect(filter).to receive(:update_nodes!).and_call_original
- filter.call_and_update_nodes
+ filter.call_and_update_nodes
- expect(filter.nodes).to eq(nodes)
- expect(filter.result[:reference_filter_nodes]).to be nil
- end
+ expect(filter.result[:reference_filter_nodes]).to eq(expected_nodes)
end
end
@@ -251,10 +208,6 @@ RSpec.describe Banzai::Filter::ReferenceFilter do
let(:result) { { reference_filter_nodes: nodes } }
- before do
- stub_feature_flags(update_nodes_for_banzai_reference_filter: true)
- end
-
it "updates all nodes", :aggregate_failures do
expect_next_instance_of(described_class) do |filter|
expect(filter).to receive(:call_and_update_nodes).and_call_original
@@ -267,26 +220,5 @@ RSpec.describe Banzai::Filter::ReferenceFilter do
expect(result[:reference_filter_nodes]).to eq(expected_nodes)
end
-
- context "with update_nodes_for_banzai_reference_filter feature flag disabled" do
- let(:result) { {} }
-
- before do
- stub_feature_flags(update_nodes_for_banzai_reference_filter: false)
- end
-
- it "updates all nodes", :aggregate_failures do
- expect_next_instance_of(described_class) do |filter|
- expect(filter).to receive(:call_and_update_nodes).and_call_original
- expect(filter).not_to receive(:with_update_nodes)
- expect(filter).to receive(:call) { filter.instance_variable_set('@new_nodes', new_nodes) }
- expect(filter).not_to receive(:update_nodes!)
- end
-
- described_class.call(document, { project: project }, result)
-
- expect(result[:reference_filter_nodes]).to be nil
- end
- end
end
end