diff options
Diffstat (limited to 'spec/lib/bulk_imports/groups')
6 files changed, 53 insertions, 194 deletions
diff --git a/spec/lib/bulk_imports/groups/graphql/get_group_query_spec.rb b/spec/lib/bulk_imports/groups/graphql/get_group_query_spec.rb index b0f8f74783b..d03b8d8b5b2 100644 --- a/spec/lib/bulk_imports/groups/graphql/get_group_query_spec.rb +++ b/spec/lib/bulk_imports/groups/graphql/get_group_query_spec.rb @@ -3,14 +3,27 @@ require 'spec_helper' RSpec.describe BulkImports::Groups::Graphql::GetGroupQuery do + let_it_be(:tracker) { create(:bulk_import_tracker) } + let_it_be(:context) { BulkImports::Pipeline::Context.new(tracker) } + + subject(:query) { described_class.new(context: context) } + + it 'has a valid query' do + parsed_query = GraphQL::Query.new( + GitlabSchema, + query.to_s, + variables: query.variables + ) + result = GitlabSchema.static_validator.validate(parsed_query) + + expect(result[:errors]).to be_empty + end + describe '#variables' do it 'returns query variables based on entity information' do - entity = double(source_full_path: 'test', bulk_import: nil) - tracker = double(entity: entity) - context = BulkImports::Pipeline::Context.new(tracker) - expected = { full_path: entity.source_full_path } + expected = { full_path: tracker.entity.source_full_path } - expect(described_class.variables(context)).to eq(expected) + expect(subject.variables).to eq(expected) end end @@ -18,7 +31,7 @@ RSpec.describe BulkImports::Groups::Graphql::GetGroupQuery do it 'returns data path' do expected = %w[data group] - expect(described_class.data_path).to eq(expected) + expect(subject.data_path).to eq(expected) end end @@ -26,7 +39,7 @@ RSpec.describe BulkImports::Groups::Graphql::GetGroupQuery do it 'returns pagination information path' do expected = %w[data group page_info] - expect(described_class.page_info_path).to eq(expected) + expect(subject.page_info_path).to eq(expected) end end end diff --git a/spec/lib/bulk_imports/groups/graphql/get_members_query_spec.rb b/spec/lib/bulk_imports/groups/graphql/get_members_query_spec.rb deleted file mode 100644 index d0c4bb817b2..00000000000 --- a/spec/lib/bulk_imports/groups/graphql/get_members_query_spec.rb +++ /dev/null @@ -1,35 +0,0 @@ -# frozen_string_literal: true - -require 'spec_helper' - -RSpec.describe BulkImports::Groups::Graphql::GetMembersQuery do - it 'has a valid query' do - tracker = create(:bulk_import_tracker) - context = BulkImports::Pipeline::Context.new(tracker) - - query = GraphQL::Query.new( - GitlabSchema, - described_class.to_s, - variables: described_class.variables(context) - ) - result = GitlabSchema.static_validator.validate(query) - - expect(result[:errors]).to be_empty - end - - describe '#data_path' do - it 'returns data path' do - expected = %w[data group group_members nodes] - - expect(described_class.data_path).to eq(expected) - end - end - - describe '#page_info_path' do - it 'returns pagination information path' do - expected = %w[data group group_members page_info] - - expect(described_class.page_info_path).to eq(expected) - end - end -end diff --git a/spec/lib/bulk_imports/groups/graphql/get_projects_query_spec.rb b/spec/lib/bulk_imports/groups/graphql/get_projects_query_spec.rb index 1a7c5a4993c..fe28e3959a0 100644 --- a/spec/lib/bulk_imports/groups/graphql/get_projects_query_spec.rb +++ b/spec/lib/bulk_imports/groups/graphql/get_projects_query_spec.rb @@ -3,25 +3,25 @@ require 'spec_helper' RSpec.describe BulkImports::Groups::Graphql::GetProjectsQuery do - describe '#variables' do - it 'returns valid variables based on entity information' do - tracker = create(:bulk_import_tracker) - context = BulkImports::Pipeline::Context.new(tracker) - - query = GraphQL::Query.new( - GitlabSchema, - described_class.to_s, - variables: described_class.variables(context) - ) - result = GitlabSchema.static_validator.validate(query) - - expect(result[:errors]).to be_empty - end + let_it_be(:tracker) { create(:bulk_import_tracker) } + let_it_be(:context) { BulkImports::Pipeline::Context.new(tracker) } + + subject(:query) { described_class.new(context: context) } + + it 'has a valid query' do + parsed_query = GraphQL::Query.new( + GitlabSchema, + query.to_s, + variables: query.variables + ) + result = GitlabSchema.static_validator.validate(parsed_query) + + expect(result[:errors]).to be_empty + end - context 'with invalid variables' do - it 'raises an error' do - expect { GraphQL::Query.new(GitlabSchema, described_class.to_s, variables: 'invalid') }.to raise_error(ArgumentError) - end + context 'with invalid variables' do + it 'raises an error' do + expect { GraphQL::Query.new(GitlabSchema, subject.to_s, variables: 'invalid') }.to raise_error(ArgumentError) end end @@ -29,7 +29,7 @@ RSpec.describe BulkImports::Groups::Graphql::GetProjectsQuery do it 'returns data path' do expected = %w[data group projects nodes] - expect(described_class.data_path).to eq(expected) + expect(subject.data_path).to eq(expected) end end @@ -37,7 +37,7 @@ RSpec.describe BulkImports::Groups::Graphql::GetProjectsQuery do it 'returns pagination information path' do expected = %w[data group projects page_info] - expect(described_class.page_info_path).to eq(expected) + expect(subject.page_info_path).to eq(expected) end end end diff --git a/spec/lib/bulk_imports/groups/pipelines/members_pipeline_spec.rb b/spec/lib/bulk_imports/groups/pipelines/members_pipeline_spec.rb deleted file mode 100644 index 0126acb320b..00000000000 --- a/spec/lib/bulk_imports/groups/pipelines/members_pipeline_spec.rb +++ /dev/null @@ -1,119 +0,0 @@ -# frozen_string_literal: true - -require 'spec_helper' - -RSpec.describe BulkImports::Groups::Pipelines::MembersPipeline do - let_it_be(:member_user1) { create(:user, email: 'email1@email.com') } - let_it_be(:member_user2) { create(:user, email: 'email2@email.com') } - - let_it_be(:user) { create(:user) } - let_it_be(:group) { create(:group) } - let_it_be(:bulk_import) { create(:bulk_import, user: user) } - let_it_be(:entity) { create(:bulk_import_entity, bulk_import: bulk_import, group: group) } - let_it_be(:tracker) { create(:bulk_import_tracker, entity: entity) } - let_it_be(:context) { BulkImports::Pipeline::Context.new(tracker) } - - subject { described_class.new(context) } - - describe '#run' do - it 'maps existing users to the imported group' do - first_page = extracted_data(email: member_user1.email, has_next_page: true) - last_page = extracted_data(email: member_user2.email) - - allow_next_instance_of(BulkImports::Common::Extractors::GraphqlExtractor) do |extractor| - allow(extractor) - .to receive(:extract) - .and_return(first_page, last_page) - end - - expect { subject.run }.to change(GroupMember, :count).by(2) - - members = group.members.map { |m| m.slice(:user_id, :access_level) } - - expect(members).to contain_exactly( - { user_id: member_user1.id, access_level: 30 }, - { user_id: member_user2.id, access_level: 30 } - ) - end - end - - describe '#load' do - it 'does nothing when there is no data' do - expect { subject.load(context, nil) }.not_to change(GroupMember, :count) - end - - it 'creates the member' do - data = { - 'user_id' => member_user1.id, - 'created_by_id' => member_user2.id, - 'access_level' => 30, - 'created_at' => '2020-01-01T00:00:00Z', - 'updated_at' => '2020-01-01T00:00:00Z', - 'expires_at' => nil - } - - expect { subject.load(context, data) }.to change(GroupMember, :count).by(1) - - member = group.members.last - - expect(member.user).to eq(member_user1) - expect(member.created_by).to eq(member_user2) - expect(member.access_level).to eq(30) - expect(member.created_at).to eq('2020-01-01T00:00:00Z') - expect(member.updated_at).to eq('2020-01-01T00:00:00Z') - expect(member.expires_at).to eq(nil) - end - - context 'when user_id is current user id' do - it 'does not create new member' do - data = { 'user_id' => user.id } - - expect { subject.load(context, data) }.not_to change(GroupMember, :count) - end - end - end - - describe 'pipeline parts' do - it { expect(described_class).to include_module(BulkImports::Pipeline) } - it { expect(described_class).to include_module(BulkImports::Pipeline::Runner) } - - it 'has extractors' do - expect(described_class.get_extractor) - .to eq( - klass: BulkImports::Common::Extractors::GraphqlExtractor, - options: { - query: BulkImports::Groups::Graphql::GetMembersQuery - } - ) - end - - it 'has transformers' do - expect(described_class.transformers) - .to contain_exactly( - { klass: BulkImports::Common::Transformers::ProhibitedAttributesTransformer, options: nil }, - { klass: BulkImports::Groups::Transformers::MemberAttributesTransformer, options: nil } - ) - end - end - - def extracted_data(email:, has_next_page: false) - data = { - 'created_at' => '2020-01-01T00:00:00Z', - 'updated_at' => '2020-01-01T00:00:00Z', - 'expires_at' => nil, - 'access_level' => { - 'integer_value' => 30 - }, - 'user' => { - 'public_email' => email - } - } - - page_info = { - 'has_next_page' => has_next_page, - 'next_page' => has_next_page ? 'cursor' : nil - } - - BulkImports::Pipeline::ExtractedData.new(data: data, page_info: page_info) - end -end diff --git a/spec/lib/bulk_imports/groups/stage_spec.rb b/spec/lib/bulk_imports/groups/stage_spec.rb index 55a8e40f480..b6bb8a7d195 100644 --- a/spec/lib/bulk_imports/groups/stage_spec.rb +++ b/spec/lib/bulk_imports/groups/stage_spec.rb @@ -9,7 +9,7 @@ RSpec.describe BulkImports::Groups::Stage do [ [0, BulkImports::Groups::Pipelines::GroupPipeline], [1, BulkImports::Groups::Pipelines::SubgroupEntitiesPipeline], - [1, BulkImports::Groups::Pipelines::MembersPipeline], + [1, BulkImports::Common::Pipelines::MembersPipeline], [1, BulkImports::Common::Pipelines::LabelsPipeline], [1, BulkImports::Common::Pipelines::MilestonesPipeline], [1, BulkImports::Common::Pipelines::BadgesPipeline], diff --git a/spec/lib/bulk_imports/groups/transformers/member_attributes_transformer_spec.rb b/spec/lib/bulk_imports/groups/transformers/member_attributes_transformer_spec.rb index af99428e0c1..c8935f71f10 100644 --- a/spec/lib/bulk_imports/groups/transformers/member_attributes_transformer_spec.rb +++ b/spec/lib/bulk_imports/groups/transformers/member_attributes_transformer_spec.rb @@ -48,12 +48,12 @@ RSpec.describe BulkImports::Groups::Transformers::MemberAttributesTransformer do data = member_data(email: user.email) expect(subject.transform(context, data)).to eq( - 'access_level' => 30, - 'user_id' => user.id, - 'created_by_id' => user.id, - 'created_at' => '2020-01-01T00:00:00Z', - 'updated_at' => '2020-01-01T00:00:00Z', - 'expires_at' => nil + access_level: 30, + user_id: user.id, + created_by_id: user.id, + created_at: '2020-01-01T00:00:00Z', + updated_at: '2020-01-01T00:00:00Z', + expires_at: nil ) end @@ -62,12 +62,12 @@ RSpec.describe BulkImports::Groups::Transformers::MemberAttributesTransformer do data = member_data(email: secondary_email) expect(subject.transform(context, data)).to eq( - 'access_level' => 30, - 'user_id' => user.id, - 'created_by_id' => user.id, - 'created_at' => '2020-01-01T00:00:00Z', - 'updated_at' => '2020-01-01T00:00:00Z', - 'expires_at' => nil + access_level: 30, + user_id: user.id, + created_by_id: user.id, + created_at: '2020-01-01T00:00:00Z', + updated_at: '2020-01-01T00:00:00Z', + expires_at: nil ) end |