diff options
Diffstat (limited to 'spec/lib/gitlab/ci/build/step_spec.rb')
-rw-r--r-- | spec/lib/gitlab/ci/build/step_spec.rb | 52 |
1 files changed, 31 insertions, 21 deletions
diff --git a/spec/lib/gitlab/ci/build/step_spec.rb b/spec/lib/gitlab/ci/build/step_spec.rb index 84e6e0e177f..9c1a8cf5e91 100644 --- a/spec/lib/gitlab/ci/build/step_spec.rb +++ b/spec/lib/gitlab/ci/build/step_spec.rb @@ -4,39 +4,49 @@ require 'spec_helper' describe Gitlab::Ci::Build::Step do describe '#from_commands' do - shared_examples 'has correct script' do - subject { described_class.from_commands(job) } + subject { described_class.from_commands(job) } - before do - job.run! - end + before do + job.run! + end + shared_examples 'has correct script' do it 'fabricates an object' do expect(subject.name).to eq(:script) expect(subject.script).to eq(script) - expect(subject.timeout).to eq(job.metadata_timeout) expect(subject.when).to eq('on_success') expect(subject.allow_failure).to be_falsey end end context 'when script option is specified' do - it_behaves_like 'has correct script' do - let(:job) { create(:ci_build, :no_options, options: { script: ["ls -la\necho aaa", "date"] }) } - let(:script) { ["ls -la\necho aaa", 'date'] } - end + let(:job) { create(:ci_build, :no_options, options: { script: ["ls -la\necho aaa", "date"] }) } + let(:script) { ["ls -la\necho aaa", 'date'] } + + it_behaves_like 'has correct script' end context 'when before and script option is specified' do - it_behaves_like 'has correct script' do - let(:job) do - create(:ci_build, options: { - before_script: ["ls -la\necho aaa"], - script: ["date"] - }) - end - - let(:script) { ["ls -la\necho aaa", 'date'] } + let(:job) do + create(:ci_build, options: { + before_script: ["ls -la\necho aaa"], + script: ["date"] + }) + end + + let(:script) { ["ls -la\necho aaa", 'date'] } + + it_behaves_like 'has correct script' + end + + context 'when timeout option is specified in seconds' do + let(:job) { create(:ci_build, options: { job_timeout: 3, script: ["ls -la\necho aaa", 'date'] }) } + let(:script) { ["ls -la\necho aaa", 'date'] } + + it_behaves_like 'has correct script' + + it 'has job level timeout' do + expect(subject.timeout).to eq(3) end end end @@ -57,12 +67,12 @@ describe Gitlab::Ci::Build::Step do end context 'when after_script is not empty' do - let(:job) { create(:ci_build, options: { script: ['bash'], after_script: ['ls -la', 'date'] }) } + let(:job) { create(:ci_build, options: { job_timeout: 60, script: ['bash'], after_script: ['ls -la', 'date'] }) } it 'fabricates an object' do expect(subject.name).to eq(:after_script) expect(subject.script).to eq(['ls -la', 'date']) - expect(subject.timeout).to eq(job.metadata_timeout) + expect(subject.timeout).to eq(60) expect(subject.when).to eq('always') expect(subject.allow_failure).to be_truthy end |