6 files changed, 587 insertions, 3 deletions

diff --git a/spec/lib/gitlab/ci/reports/accessibility_reports_comparer_spec.rb b/spec/lib/gitlab/ci/reports/accessibility_reports_comparer_spec.rb
new file mode 100644
index 00000000000..31a330f46b1
--- /dev/null
+++ b/spec/lib/gitlab/ci/reports/accessibility_reports_comparer_spec.rb
@@ -0,0 +1,270 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Gitlab::Ci::Reports::AccessibilityReportsComparer do
+  let(:comparer) { described_class.new(base_reports, head_reports) }
+  let(:base_reports) { Gitlab::Ci::Reports::AccessibilityReports.new }
+  let(:head_reports) { Gitlab::Ci::Reports::AccessibilityReports.new }
+  let(:url) { "https://gitlab.com" }
+  let(:single_error) do
+    [
+      {
+        "code" => "WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.A.NoContent",
+        "type" => "error",
+        "typeCode" => 1,
+        "message" => "Anchor element found with a valid href attribute, but no link content has been supplied.",
+        "context" => %{<a href="/" class="navbar-brand animated"><svg height="36" viewBox="0 0 1...</a>},
+        "selector" => "#main-nav > div:nth-child(1) > a",
+        "runner" => "htmlcs",
+        "runnerExtras" => {}
+      }
+    ]
+  end
+  let(:different_error) do
+    [
+      {
+        "code" => "WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail",
+        "type" => "error",
+        "typeCode" => 1,
+        "message" => "This element has insufficient contrast at this conformance level.",
+        "context" => %{<a href="/stages-devops-lifecycle/" class="main-nav-link">Product</a>},
+        "selector" => "#main-nav > div:nth-child(2) > ul > li:nth-child(1) > a",
+        "runner" => "htmlcs",
+        "runnerExtras" => {}
+      }
+    ]
+  end
+
+  describe '#status' do
+    subject { comparer.status }
+
+    context 'when head report has an error' do
+      before do
+        head_reports.add_url(url, single_error)
+      end
+
+      it 'returns status failed' do
+        expect(subject).to eq(described_class::STATUS_FAILED)
+      end
+    end
+
+    context 'when head reports does not have errors' do
+      before do
+        head_reports.add_url(url, [])
+      end
+
+      it 'returns status success' do
+        expect(subject).to eq(described_class::STATUS_SUCCESS)
+      end
+    end
+  end
+
+  describe '#errors_count' do
+    subject { comparer.errors_count }
+
+    context 'when head report has an error' do
+      before do
+        head_reports.add_url(url, single_error)
+      end
+
+      it 'returns the number of new errors' do
+        expect(subject).to eq(1)
+      end
+    end
+
+    context 'when head reports does not have an error' do
+      before do
+        head_reports.add_url(url, [])
+      end
+
+      it 'returns the number new errors' do
+        expect(subject).to eq(0)
+      end
+    end
+  end
+
+  describe '#resolved_count' do
+    subject { comparer.resolved_count }
+
+    context 'when base reports has an error and head has a different error' do
+      before do
+        base_reports.add_url(url, single_error)
+        head_reports.add_url(url, different_error)
+      end
+
+      it 'returns the resolved count' do
+        expect(subject).to eq(1)
+      end
+    end
+
+    context 'when base reports has errors head has no errors' do
+      before do
+        base_reports.add_url(url, single_error)
+        head_reports.add_url(url, [])
+      end
+
+      it 'returns the resolved count' do
+        expect(subject).to eq(1)
+      end
+    end
+
+    context 'when base reports has errors and head has the same error' do
+      before do
+        base_reports.add_url(url, single_error)
+        head_reports.add_url(url, single_error)
+      end
+
+      it 'returns zero' do
+        expect(subject).to eq(0)
+      end
+    end
+
+    context 'when base reports does not have errors and head has errors' do
+      before do
+        head_reports.add_url(url, single_error)
+      end
+
+      it 'returns the number of resolved errors' do
+        expect(subject).to eq(0)
+      end
+    end
+  end
+
+  describe '#total_count' do
+    subject { comparer.total_count }
+
+    context 'when base reports has an error' do
+      before do
+        base_reports.add_url(url, single_error)
+      end
+
+      it 'returns the error count' do
+        expect(subject).to eq(1)
+      end
+    end
+
+    context 'when head report has an error' do
+      before do
+        head_reports.add_url(url, single_error)
+      end
+
+      it 'returns the error count' do
+        expect(subject).to eq(1)
+      end
+    end
+
+    context 'when base report has errors and head report has errors' do
+      before do
+        base_reports.add_url(url, single_error)
+        head_reports.add_url(url, different_error)
+      end
+
+      it 'returns the error count' do
+        expect(subject).to eq(2)
+      end
+    end
+  end
+
+  describe '#existing_errors' do
+    subject { comparer.existing_errors }
+
+    context 'when base report has errors and head has a different error' do
+      before do
+        base_reports.add_url(url, single_error)
+        head_reports.add_url(url, different_error)
+      end
+
+      it 'returns the existing errors' do
+        expect(subject.size).to eq(1)
+        expect(subject.first["code"]).to eq("WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.A.NoContent")
+      end
+    end
+
+    context 'when base report does not have errors and head has errors' do
+      before do
+        base_reports.add_url(url, [])
+        head_reports.add_url(url, single_error)
+      end
+
+      it 'returns an empty array' do
+        expect(subject).to be_empty
+      end
+    end
+  end
+
+  describe '#new_errors' do
+    subject { comparer.new_errors }
+
+    context 'when base reports has errors and head has more errors' do
+      before do
+        base_reports.add_url(url, single_error)
+        head_reports.add_url(url, single_error + different_error)
+      end
+
+      it 'returns new errors between base and head reports' do
+        expect(subject.size).to eq(1)
+        expect(subject.first["code"]).to eq("WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail")
+      end
+    end
+
+    context 'when base reports has an error and head has no errors' do
+      before do
+        base_reports.add_url(url, single_error)
+        head_reports.add_url(url, [])
+      end
+
+      it 'returns an empty array' do
+        expect(subject).to be_empty
+      end
+    end
+
+    context 'when base reports does not have errors and head has errors' do
+      before do
+        head_reports.add_url(url, single_error)
+      end
+
+      it 'returns the new error' do
+        expect(subject.size).to eq(1)
+        expect(subject.first["code"]).to eq("WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.A.NoContent")
+      end
+    end
+  end
+
+  describe '#resolved_errors' do
+    subject { comparer.resolved_errors }
+
+    context 'when base report has errors and head has more errors' do
+      before do
+        base_reports.add_url(url, single_error)
+        head_reports.add_url(url, single_error + different_error)
+      end
+
+      it 'returns an empty array' do
+        expect(subject).to be_empty
+      end
+    end
+
+    context 'when base reports has errors and head has a different error' do
+      before do
+        base_reports.add_url(url, single_error)
+        head_reports.add_url(url, different_error)
+      end
+
+      it 'returns the resolved errors' do
+        expect(subject.size).to eq(1)
+        expect(subject.first["code"]).to eq("WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.A.NoContent")
+      end
+    end
+
+    context 'when base reports does not have errors and head has errors' do
+      before do
+        head_reports.add_url(url, single_error)
+      end
+
+      it 'returns an empty array' do
+        expect(subject).to be_empty
+      end
+    end
+  end
+end
diff --git a/spec/lib/gitlab/ci/reports/accessibility_reports_spec.rb b/spec/lib/gitlab/ci/reports/accessibility_reports_spec.rb
new file mode 100644
index 00000000000..0dc13b464b1
--- /dev/null
+++ b/spec/lib/gitlab/ci/reports/accessibility_reports_spec.rb
@@ -0,0 +1,232 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Gitlab::Ci::Reports::AccessibilityReports do
+  let(:accessibility_report) { described_class.new }
+  let(:url) { 'https://gitlab.com' }
+  let(:data) do
+    [
+      {
+        "code": "WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.A.NoContent",
+        "type": "error",
+        "typeCode": 1,
+        "message": "Anchor element found with a valid href attribute, but no link content has been supplied.",
+        "context": %{<a href="/customers/worldline"><svg viewBox="0 0 509 89" xmln...</a>},
+        "selector": "html > body > div:nth-child(9) > div:nth-child(2) > a:nth-child(17)",
+        "runner": "htmlcs",
+        "runnerExtras": {}
+      },
+      {
+        "code": "WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.A.NoContent",
+        "type": "error",
+        "typeCode": 1,
+        "message": "Anchor element found with a valid href attribute, but no link content has been supplied.",
+        "context": %{<a href="/customers/equinix"><svg xmlns="http://www.w3.org/...</a>},
+        "selector": "html > body > div:nth-child(9) > div:nth-child(2) > a:nth-child(18)",
+        "runner": "htmlcs",
+        "runnerExtras": {}
+      }
+    ]
+  end
+
+  describe '#scans_count' do
+    subject { accessibility_report.scans_count }
+
+    context 'when data has errors' do
+      let(:different_url) { 'https://about.gitlab.com' }
+
+      before do
+        accessibility_report.add_url(url, data)
+        accessibility_report.add_url(different_url, data)
+      end
+
+      it 'returns the scans_count' do
+        expect(subject).to eq(2)
+      end
+    end
+
+    context 'when data has no errors' do
+      before do
+        accessibility_report.add_url(url, [])
+      end
+
+      it 'returns the scans_count' do
+        expect(subject).to eq(1)
+      end
+    end
+
+    context 'when data has no url' do
+      before do
+        accessibility_report.add_url("", [])
+      end
+
+      it 'returns the scans_count' do
+        expect(subject).to eq(0)
+      end
+    end
+  end
+
+  describe '#passes_count' do
+    subject { accessibility_report.passes_count }
+
+    context 'when data has errors' do
+      before do
+        accessibility_report.add_url(url, data)
+      end
+
+      it 'returns the passes_count' do
+        expect(subject).to eq(0)
+      end
+    end
+
+    context 'when data has no errors' do
+      before do
+        accessibility_report.add_url(url, [])
+      end
+
+      it 'returns the passes_count' do
+        expect(subject).to eq(1)
+      end
+    end
+
+    context 'when data has no url' do
+      before do
+        accessibility_report.add_url("", [])
+      end
+
+      it 'returns the scans_count' do
+        expect(subject).to eq(0)
+      end
+    end
+  end
+
+  describe '#errors_count' do
+    subject { accessibility_report.errors_count }
+
+    context 'when data has errors' do
+      let(:different_url) { 'https://about.gitlab.com' }
+
+      before do
+        accessibility_report.add_url(url, data)
+        accessibility_report.add_url(different_url, data)
+      end
+
+      it 'returns the errors_count' do
+        expect(subject).to eq(4)
+      end
+    end
+
+    context 'when data has no errors' do
+      before do
+        accessibility_report.add_url(url, [])
+      end
+
+      it 'returns the errors_count' do
+        expect(subject).to eq(0)
+      end
+    end
+
+    context 'when data has no url' do
+      before do
+        accessibility_report.add_url("", [])
+      end
+
+      it 'returns the errors_count' do
+        expect(subject).to eq(0)
+      end
+    end
+  end
+
+  describe '#add_url' do
+    subject { accessibility_report.add_url(url, data) }
+
+    context 'when data has errors' do
+      it 'adds urls and data to accessibility report' do
+        expect { subject }.not_to raise_error
+
+        expect(accessibility_report.urls.keys).to eq([url])
+        expect(accessibility_report.urls.values.flatten.size).to eq(2)
+      end
+    end
+
+    context 'when data does not have errors' do
+      let(:data) { [] }
+
+      it 'adds data to accessibility report' do
+        expect { subject }.not_to raise_error
+
+        expect(accessibility_report.urls.keys).to eq([url])
+        expect(accessibility_report.urls.values.flatten.size).to eq(0)
+      end
+    end
+
+    context 'when url does not exist' do
+      let(:url) { '' }
+      let(:data) { [{ message: "Protocol error (Page.navigate): Cannot navigate to invalid URL" }] }
+
+      it 'sets error_message and decreases total' do
+        expect { subject }.not_to raise_error
+
+        expect(accessibility_report.scans_count).to eq(0)
+        expect(accessibility_report.error_message).to eq('Empty URL detected in gl-accessibility.json')
+      end
+    end
+  end
+
+  describe '#set_error_message' do
+    let(:set_accessibility_error) { accessibility_report.set_error_message('error') }
+
+    context 'when error is nil' do
+      it 'returns the error' do
+        expect(set_accessibility_error).to eq('error')
+      end
+
+      it 'sets the error' do
+        set_accessibility_error
+
+        expect(accessibility_report.error_message).to eq('error')
+      end
+    end
+
+    context 'when a error has already been set' do
+      before do
+        accessibility_report.set_error_message('old error')
+      end
+
+      it 'overwrites the existing message' do
+        expect { set_accessibility_error }.to change(accessibility_report, :error_message).from('old error').to('error')
+      end
+    end
+  end
+
+  describe '#all_errors' do
+    subject { accessibility_report.all_errors }
+
+    context 'when data has errors' do
+      before do
+        accessibility_report.add_url(url, data)
+      end
+
+      it 'returns all errors' do
+        expect(subject.size).to eq(2)
+      end
+    end
+
+    context 'when data has no errors' do
+      before do
+        accessibility_report.add_url(url, [])
+      end
+
+      it 'returns an empty array' do
+        expect(subject).to eq([])
+      end
+    end
+
+    context 'when accessibility report has no data' do
+      it 'returns an empty array' do
+        expect(subject).to eq([])
+      end
+    end
+  end
+end
diff --git a/spec/lib/gitlab/ci/reports/terraform_reports_spec.rb b/spec/lib/gitlab/ci/reports/terraform_reports_spec.rb
new file mode 100644
index 00000000000..061029299ac
--- /dev/null
+++ b/spec/lib/gitlab/ci/reports/terraform_reports_spec.rb
@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Gitlab::Ci::Reports::TerraformReports do
+  it 'initializes plans with and empty hash' do
+    expect(subject.plans).to eq({})
+  end
+
+  describe '#add_plan' do
+    context 'when providing two unique plans' do
+      it 'returns two plans' do
+        subject.add_plan('a/tfplan.json', { 'create' => 0, 'update' => 1, 'delete' => 0 })
+        subject.add_plan('b/tfplan.json', { 'create' => 0, 'update' => 1, 'delete' => 0 })
+
+        expect(subject.plans).to eq({
+          'a/tfplan.json' => { 'create' => 0, 'update' => 1, 'delete' => 0 },
+          'b/tfplan.json' => { 'create' => 0, 'update' => 1, 'delete' => 0 }
+        })
+      end
+    end
+
+    context 'when providing the same plan twice' do
+      it 'returns the last added plan' do
+        subject.add_plan('tfplan.json', { 'create' => 0, 'update' => 0, 'delete' => 0 })
+        subject.add_plan('tfplan.json', { 'create' => 0, 'update' => 1, 'delete' => 0 })
+
+        expect(subject.plans).to eq({
+          'tfplan.json' => { 'create' => 0, 'update' => 1, 'delete' => 0 }
+        })
+      end
+    end
+  end
+end
diff --git a/spec/lib/gitlab/ci/reports/test_case_spec.rb b/spec/lib/gitlab/ci/reports/test_case_spec.rb
index c0652288cca..b5883867983 100644
--- a/spec/lib/gitlab/ci/reports/test_case_spec.rb
+++ b/spec/lib/gitlab/ci/reports/test_case_spec.rb
@@ -62,7 +62,7 @@ describe Gitlab::Ci::Reports::TestCase do
     end
 
     context 'when attachment is present' do
-      let(:attachment_test_case) { build(:test_case, :with_attachment) }
+      let(:attachment_test_case) { build(:test_case, :failed_with_attachment) }
 
       it "initializes the attachment if present" do
         expect(attachment_test_case.attachment).to eq("some/path.png")
diff --git a/spec/lib/gitlab/ci/reports/test_reports_spec.rb b/spec/lib/gitlab/ci/reports/test_reports_spec.rb
index 638acde69eb..e51728496e1 100644
--- a/spec/lib/gitlab/ci/reports/test_reports_spec.rb
+++ b/spec/lib/gitlab/ci/reports/test_reports_spec.rb
@@ -127,7 +127,7 @@ describe Gitlab::Ci::Reports::TestReports do
 
     context 'when test suites contain an attachment' do
       let(:test_case_succes) { build(:test_case) }
-      let(:test_case_with_attachment) { build(:test_case, :with_attachment) }
+      let(:test_case_with_attachment) { build(:test_case, :failed_with_attachment) }
 
       before do
         test_reports.get_suite('rspec').add_test_case(test_case_succes)
@@ -141,6 +141,29 @@ describe Gitlab::Ci::Reports::TestReports do
     end
   end
 
+  describe '#suite_errors' do
+    subject { test_reports.suite_errors }
+
+    context 'when a suite has normal spec errors or failures' do
+      before do
+        test_reports.get_suite('junit').add_test_case(create_test_case_java_success)
+        test_reports.get_suite('junit').add_test_case(create_test_case_java_failed)
+        test_reports.get_suite('junit').add_test_case(create_test_case_java_error)
+      end
+
+      it { is_expected.to be_empty }
+    end
+
+    context 'when there is an error test case' do
+      before do
+        test_reports.get_suite('rspec').add_test_case(create_test_case_rspec_success)
+        test_reports.get_suite('junit').set_suite_error('Existential parsing error')
+      end
+
+      it { is_expected.to eq({ 'junit' => 'Existential parsing error' }) }
+    end
+  end
+
   Gitlab::Ci::Reports::TestCase::STATUS_TYPES.each do |status_type|
     describe "##{status_type}_count" do
       subject { test_reports.public_send("#{status_type}_count") }
diff --git a/spec/lib/gitlab/ci/reports/test_suite_spec.rb b/spec/lib/gitlab/ci/reports/test_suite_spec.rb
index 9d9774afc82..e0b2593353a 100644
--- a/spec/lib/gitlab/ci/reports/test_suite_spec.rb
+++ b/spec/lib/gitlab/ci/reports/test_suite_spec.rb
@@ -101,7 +101,7 @@ describe Gitlab::Ci::Reports::TestSuite do
     end
 
     context 'when test cases contain an attachment' do
-      let(:test_case_with_attachment) { build(:test_case, :with_attachment)}
+      let(:test_case_with_attachment) { build(:test_case, :failed_with_attachment)}
 
       before do
         test_suite.add_test_case(test_case_with_attachment)
@@ -114,6 +114,31 @@ describe Gitlab::Ci::Reports::TestSuite do
     end
   end
 
+  describe '#set_suite_error' do
+    let(:set_suite_error) { test_suite.set_suite_error('message') }
+
+    context 'when @suite_error is nil' do
+      it 'returns message' do
+        expect(set_suite_error).to eq('message')
+      end
+
+      it 'sets the new message' do
+        set_suite_error
+        expect(test_suite.suite_error).to eq('message')
+      end
+    end
+
+    context 'when a suite_error has already been set' do
+      before do
+        test_suite.set_suite_error('old message')
+      end
+
+      it 'overwrites the existing message' do
+        expect { set_suite_error }.to change(test_suite, :suite_error).from('old message').to('message')
+      end
+    end
+  end
+
   Gitlab::Ci::Reports::TestCase::STATUS_TYPES.each do |status_type|
     describe "##{status_type}" do
       subject { test_suite.public_send("#{status_type}") }