diff options
Diffstat (limited to 'spec/models/experiment_spec.rb')
-rw-r--r-- | spec/models/experiment_spec.rb | 113 |
1 files changed, 102 insertions, 11 deletions
diff --git a/spec/models/experiment_spec.rb b/spec/models/experiment_spec.rb index 587f410c9be..1bf7b8b4850 100644 --- a/spec/models/experiment_spec.rb +++ b/spec/models/experiment_spec.rb @@ -7,6 +7,7 @@ RSpec.describe Experiment do describe 'associations' do it { is_expected.to have_many(:experiment_users) } + it { is_expected.to have_many(:experiment_subjects) } end describe 'validations' do @@ -19,20 +20,21 @@ RSpec.describe Experiment do let_it_be(:experiment_name) { :experiment_key } let_it_be(:user) { 'a user' } let_it_be(:group) { 'a group' } + let_it_be(:context) { { a: 42 } } - subject(:add_user) { described_class.add_user(experiment_name, group, user) } + subject(:add_user) { described_class.add_user(experiment_name, group, user, context) } context 'when an experiment with the provided name does not exist' do it 'creates a new experiment record' do allow_next_instance_of(described_class) do |experiment| - allow(experiment).to receive(:record_user_and_group).with(user, group) + allow(experiment).to receive(:record_user_and_group).with(user, group, context) end expect { add_user }.to change(described_class, :count).by(1) end - it 'forwards the user and group_type to the instance' do + it 'forwards the user, group_type, and context to the instance' do expect_next_instance_of(described_class) do |experiment| - expect(experiment).to receive(:record_user_and_group).with(user, group) + expect(experiment).to receive(:record_user_and_group).with(user, group, context) end add_user end @@ -43,18 +45,95 @@ RSpec.describe Experiment do it 'does not create a new experiment record' do allow_next_found_instance_of(described_class) do |experiment| - allow(experiment).to receive(:record_user_and_group).with(user, group) + allow(experiment).to receive(:record_user_and_group).with(user, group, context) end expect { add_user }.not_to change(described_class, :count) end - it 'forwards the user and group_type to the instance' do + it 'forwards the user, group_type, and context to the instance' do expect_next_found_instance_of(described_class) do |experiment| - expect(experiment).to receive(:record_user_and_group).with(user, group) + expect(experiment).to receive(:record_user_and_group).with(user, group, context) end add_user end end + + it 'works without the optional context argument' do + allow_next_instance_of(described_class) do |experiment| + expect(experiment).to receive(:record_user_and_group).with(user, group, {}) + end + + expect { described_class.add_user(experiment_name, group, user) }.not_to raise_error + end + end + + describe '.record_conversion_event' do + let_it_be(:user) { build(:user) } + + let(:experiment_key) { :test_experiment } + + subject(:record_conversion_event) { described_class.record_conversion_event(experiment_key, user) } + + context 'when no matching experiment exists' do + it 'creates the experiment and uses it' do + expect_next_instance_of(described_class) do |experiment| + expect(experiment).to receive(:record_conversion_event_for_user) + end + expect { record_conversion_event }.to change { described_class.count }.by(1) + end + + context 'but we are unable to successfully create one' do + let(:experiment_key) { nil } + + it 'raises a RecordInvalid error' do + expect { record_conversion_event }.to raise_error(ActiveRecord::RecordInvalid) + end + end + end + + context 'when a matching experiment already exists' do + before do + create(:experiment, name: experiment_key) + end + + it 'sends record_conversion_event_for_user to the experiment instance' do + expect_next_found_instance_of(described_class) do |experiment| + expect(experiment).to receive(:record_conversion_event_for_user).with(user) + end + record_conversion_event + end + end + end + + describe '#record_conversion_event_for_user' do + let_it_be(:user) { create(:user) } + let_it_be(:experiment) { create(:experiment) } + + subject(:record_conversion_event_for_user) { experiment.record_conversion_event_for_user(user) } + + context 'when no existing experiment_user record exists for the given user' do + it 'does not update or create an experiment_user record' do + expect { record_conversion_event_for_user }.not_to change { ExperimentUser.all.to_a } + end + end + + context 'when an existing experiment_user exists for the given user' do + context 'but it has already been converted' do + let!(:experiment_user) { create(:experiment_user, experiment: experiment, user: user, converted_at: 2.days.ago) } + + it 'does not update the converted_at value' do + expect { record_conversion_event_for_user }.not_to change { experiment_user.converted_at } + end + end + + context 'and it has not yet been converted' do + let(:experiment_user) { create(:experiment_user, experiment: experiment, user: user) } + + it 'updates the converted_at value' do + expect { record_conversion_event_for_user }.to change { experiment_user.reload.converted_at } + end + end + end end describe '#record_user_and_group' do @@ -62,8 +141,9 @@ RSpec.describe Experiment do let_it_be(:user) { create(:user) } let(:group) { :control } + let(:context) { { a: 42 } } - subject(:record_user_and_group) { experiment.record_user_and_group(user, group) } + subject(:record_user_and_group) { experiment.record_user_and_group(user, group, context) } context 'when an experiment_user does not yet exist for the given user' do it 'creates a new experiment_user record' do @@ -74,24 +154,35 @@ RSpec.describe Experiment do record_user_and_group expect(ExperimentUser.last.group_type).to eq('control') end + + it 'adds the correct context to the experiment_user' do + record_user_and_group + expect(ExperimentUser.last.context).to eq({ 'a' => 42 }) + end end context 'when an experiment_user already exists for the given user' do before do # Create an existing experiment_user for this experiment and the :control group - experiment.record_user_and_group(user, :control) + experiment.record_user_and_group(user, :control, context) end it 'does not create a new experiment_user record' do expect { record_user_and_group }.not_to change(ExperimentUser, :count) end - context 'but the group_type has changed' do + context 'but the group_type and context has changed' do let(:group) { :experimental } + let(:context) { { b: 37 } } - it 'updates the existing experiment_user record' do + it 'updates the existing experiment_user record with group_type' do expect { record_user_and_group }.to change { ExperimentUser.last.group_type } end + + it 'updates the existing experiment_user record with context' do + record_user_and_group + expect(ExperimentUser.last.context).to eq({ 'b' => 37 }) + end end end end |