diff options
Diffstat (limited to 'spec/models/project_repository_storage_move_spec.rb')
-rw-r--r-- | spec/models/project_repository_storage_move_spec.rb | 94 |
1 files changed, 11 insertions, 83 deletions
diff --git a/spec/models/project_repository_storage_move_spec.rb b/spec/models/project_repository_storage_move_spec.rb index d32867efb39..88535f6dd6e 100644 --- a/spec/models/project_repository_storage_move_spec.rb +++ b/spec/models/project_repository_storage_move_spec.rb @@ -3,102 +3,30 @@ require 'spec_helper' RSpec.describe ProjectRepositoryStorageMove, type: :model do - describe 'associations' do - it { is_expected.to belong_to(:project) } - end - - describe 'validations' do - it { is_expected.to validate_presence_of(:project) } - it { is_expected.to validate_presence_of(:state) } - it { is_expected.to validate_presence_of(:source_storage_name) } - it { is_expected.to validate_presence_of(:destination_storage_name) } - - context 'source_storage_name inclusion' do - subject { build(:project_repository_storage_move, source_storage_name: 'missing') } - - it "does not allow repository storages that don't match a label in the configuration" do - expect(subject).not_to be_valid - expect(subject.errors[:source_storage_name].first).to match(/is not included in the list/) - end - end - - context 'destination_storage_name inclusion' do - subject { build(:project_repository_storage_move, destination_storage_name: 'missing') } - - it "does not allow repository storages that don't match a label in the configuration" do - expect(subject).not_to be_valid - expect(subject.errors[:destination_storage_name].first).to match(/is not included in the list/) - end - end - - context 'project repository read-only' do - subject { build(:project_repository_storage_move, project: project) } - - let(:project) { build(:project, repository_read_only: true) } + let_it_be_with_refind(:project) { create(:project) } - it "does not allow the project to be read-only on create" do - expect(subject).not_to be_valid - expect(subject.errors[:project].first).to match(/is read only/) - end - end - end - - describe 'defaults' do - context 'destination_storage_name' do - subject { build(:project_repository_storage_move) } - - it 'picks storage from ApplicationSetting' do - expect(Gitlab::CurrentSettings).to receive(:pick_repository_storage).and_return('picked').at_least(:once) - - expect(subject.destination_storage_name).to eq('picked') - end - end + it_behaves_like 'handles repository moves' do + let(:container) { project } + let(:repository_storage_factory_key) { :project_repository_storage_move } + let(:error_key) { :project } + let(:repository_storage_worker) { ProjectUpdateRepositoryStorageWorker } end describe 'state transitions' do - let(:project) { create(:project) } + let(:storage) { 'test_second_storage' } before do - stub_storage_settings('test_second_storage' => { 'path' => 'tmp/tests/extra_storage' }) - end - - context 'when in the default state' do - subject(:storage_move) { create(:project_repository_storage_move, project: project, destination_storage_name: 'test_second_storage') } - - context 'and transits to scheduled' do - it 'triggers ProjectUpdateRepositoryStorageWorker' do - expect(ProjectUpdateRepositoryStorageWorker).to receive(:perform_async).with(project.id, 'test_second_storage', storage_move.id) - - storage_move.schedule! - - expect(project).to be_repository_read_only - end - end - - context 'and transits to started' do - it 'does not allow the transition' do - expect { storage_move.start! } - .to raise_error(StateMachines::InvalidTransition) - end - end + stub_storage_settings(storage => { 'path' => 'tmp/tests/extra_storage' }) end context 'when started' do - subject(:storage_move) { create(:project_repository_storage_move, :started, project: project, destination_storage_name: 'test_second_storage') } + subject(:storage_move) { create(:project_repository_storage_move, :started, container: project, destination_storage_name: storage) } context 'and transits to replicated' do - it 'sets the repository storage and marks the project as writable' do + it 'sets the repository storage and marks the container as writable' do storage_move.finish_replication! - expect(project.repository_storage).to eq('test_second_storage') - expect(project).not_to be_repository_read_only - end - end - - context 'and transits to failed' do - it 'marks the project as writable' do - storage_move.do_fail! - + expect(project.repository_storage).to eq(storage) expect(project).not_to be_repository_read_only end end |