diff options
Diffstat (limited to 'spec/models/resource_milestone_event_spec.rb')
-rw-r--r-- | spec/models/resource_milestone_event_spec.rb | 69 |
1 files changed, 3 insertions, 66 deletions
diff --git a/spec/models/resource_milestone_event_spec.rb b/spec/models/resource_milestone_event_spec.rb index 76ffb358d80..0a5292b2d16 100644 --- a/spec/models/resource_milestone_event_spec.rb +++ b/spec/models/resource_milestone_event_spec.rb @@ -8,77 +8,14 @@ RSpec.describe ResourceMilestoneEvent, type: :model do it_behaves_like 'a resource event for merge requests' it_behaves_like 'having unique enum values' + it_behaves_like 'timebox resource event validations' + it_behaves_like 'timebox resource event states' + it_behaves_like 'timebox resource event actions' describe 'associations' do it { is_expected.to belong_to(:milestone) } end - describe 'validations' do - context 'when issue and merge_request are both nil' do - subject { build(described_class.name.underscore.to_sym, issue: nil, merge_request: nil) } - - it { is_expected.not_to be_valid } - end - - context 'when issue and merge_request are both set' do - subject { build(described_class.name.underscore.to_sym, issue: build(:issue), merge_request: build(:merge_request)) } - - it { is_expected.not_to be_valid } - end - - context 'when issue is set' do - subject { create(described_class.name.underscore.to_sym, issue: create(:issue), merge_request: nil) } - - it { is_expected.to be_valid } - end - - context 'when merge_request is set' do - subject { create(described_class.name.underscore.to_sym, issue: nil, merge_request: create(:merge_request)) } - - it { is_expected.to be_valid } - end - end - - describe 'states' do - [Issue, MergeRequest].each do |klass| - klass.available_states.each do |state| - it "supports state #{state.first} for #{klass.name.underscore}" do - model = create(klass.name.underscore, state: state[0]) - key = model.class.name.underscore - event = build(described_class.name.underscore.to_sym, key => model, state: model.state) - - expect(event.state).to eq(state[0]) - end - end - end - end - - shared_examples 'a milestone action queryable resource event' do |expected_results_for_actions| - [Issue, MergeRequest].each do |klass| - expected_results_for_actions.each do |action, expected_result| - it "is #{expected_result} for action #{action} on #{klass.name.underscore}" do - model = create(klass.name.underscore) - key = model.class.name.underscore - event = build(described_class.name.underscore.to_sym, key => model, action: action) - - expect(event.send(query_method)).to eq(expected_result) - end - end - end - end - - describe '#added?' do - it_behaves_like 'a milestone action queryable resource event', { add: true, remove: false } do - let(:query_method) { :add? } - end - end - - describe '#removed?' do - it_behaves_like 'a milestone action queryable resource event', { add: false, remove: true } do - let(:query_method) { :remove? } - end - end - describe '#milestone_title' do let(:milestone) { create(:milestone, title: 'v2.3') } let(:event) { create(:resource_milestone_event, milestone: milestone) } |