diff options
Diffstat (limited to 'spec/presenters')
8 files changed, 51 insertions, 28 deletions
diff --git a/spec/presenters/blobs/notebook_presenter_spec.rb b/spec/presenters/blobs/notebook_presenter_spec.rb index 12f4ed67897..2f05dc98fb9 100644 --- a/spec/presenters/blobs/notebook_presenter_spec.rb +++ b/spec/presenters/blobs/notebook_presenter_spec.rb @@ -5,11 +5,11 @@ require 'spec_helper' RSpec.describe Blobs::NotebookPresenter do include RepoHelpers - let(:project) { create(:project, :repository) } - let(:repository) { project.repository } - let(:blob) { repository.blob_at('HEAD', 'files/ruby/regex.rb') } - let(:user) { project.first_owner } - let(:git_blob) { blob.__getobj__ } + let_it_be(:project) { create(:project, :repository) } + let_it_be(:repository) { project.repository } + let_it_be(:blob) { repository.blob_at('HEAD', 'files/ruby/regex.rb') } + let_it_be(:user) { project.first_owner } + let_it_be(:git_blob) { blob.__getobj__ } subject(:presenter) { described_class.new(blob, current_user: user) } diff --git a/spec/presenters/ci/pipeline_presenter_spec.rb b/spec/presenters/ci/pipeline_presenter_spec.rb index a278d4dad83..4539c3d06f6 100644 --- a/spec/presenters/ci/pipeline_presenter_spec.rb +++ b/spec/presenters/ci/pipeline_presenter_spec.rb @@ -100,7 +100,7 @@ RSpec.describe Ci::PipelinePresenter do context 'for a detached merge request pipeline' do let(:event_type) { :detached } - it { is_expected.to eq('Detached merge request pipeline') } + it { is_expected.to eq('Merge request pipeline') } end context 'for a merged result pipeline' do diff --git a/spec/presenters/clusters/cluster_presenter_spec.rb b/spec/presenters/clusters/cluster_presenter_spec.rb index 7349f444fac..755f1ea6078 100644 --- a/spec/presenters/clusters/cluster_presenter_spec.rb +++ b/spec/presenters/clusters/cluster_presenter_spec.rb @@ -119,18 +119,20 @@ RSpec.describe Clusters::ClusterPresenter do subject { cluster_presenter.health_data(clusterable_presenter) } it do - is_expected.to include('clusters-path': clusterable_presenter.index_path, - 'dashboard-endpoint': clusterable_presenter.metrics_dashboard_path(cluster), - 'documentation-path': help_page_path('user/infrastructure/clusters/manage/clusters_health'), - 'add-dashboard-documentation-path': help_page_path('operations/metrics/dashboards/index.md', anchor: 'add-a-new-dashboard-to-your-project'), - 'empty-getting-started-svg-path': match_asset_path('/assets/illustrations/monitoring/getting_started.svg'), - 'empty-loading-svg-path': match_asset_path('/assets/illustrations/monitoring/loading.svg'), - 'empty-no-data-svg-path': match_asset_path('/assets/illustrations/monitoring/no_data.svg'), - 'empty-no-data-small-svg-path': match_asset_path('illustrations/chart-empty-state-small.svg'), - 'empty-unable-to-connect-svg-path': match_asset_path('/assets/illustrations/monitoring/unable_to_connect.svg'), - 'settings-path': '', - 'project-path': '', - 'tags-path': '') + is_expected.to include( + 'clusters-path': clusterable_presenter.index_path, + 'dashboard-endpoint': clusterable_presenter.metrics_dashboard_path(cluster), + 'documentation-path': help_page_path('user/infrastructure/clusters/manage/clusters_health'), + 'add-dashboard-documentation-path': help_page_path('operations/metrics/dashboards/index.md', anchor: 'add-a-new-dashboard-to-your-project'), + 'empty-getting-started-svg-path': match_asset_path('/assets/illustrations/monitoring/getting_started.svg'), + 'empty-loading-svg-path': match_asset_path('/assets/illustrations/monitoring/loading.svg'), + 'empty-no-data-svg-path': match_asset_path('/assets/illustrations/monitoring/no_data.svg'), + 'empty-no-data-small-svg-path': match_asset_path('illustrations/chart-empty-state-small.svg'), + 'empty-unable-to-connect-svg-path': match_asset_path('/assets/illustrations/monitoring/unable_to_connect.svg'), + 'settings-path': '', + 'project-path': '', + 'tags-path': '' + ) end end diff --git a/spec/presenters/deployments/deployment_presenter_spec.rb b/spec/presenters/deployments/deployment_presenter_spec.rb new file mode 100644 index 00000000000..689451677f4 --- /dev/null +++ b/spec/presenters/deployments/deployment_presenter_spec.rb @@ -0,0 +1,15 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Deployments::DeploymentPresenter do + let(:deployment) { create(:deployment) } + let(:presenter) { described_class.new(deployment) } + + describe '#tags' do + it do + expect(deployment).to receive(:tags).and_return(['test']) + expect(presenter.tags).to eq([{ name: 'test', path: 'tags/test' }]) + end + end +end diff --git a/spec/presenters/packages/composer/packages_presenter_spec.rb b/spec/presenters/packages/composer/packages_presenter_spec.rb index 1f638e5b935..ae88acea61d 100644 --- a/spec/presenters/packages/composer/packages_presenter_spec.rb +++ b/spec/presenters/packages/composer/packages_presenter_spec.rb @@ -50,7 +50,7 @@ RSpec.describe ::Packages::Composer::PackagesPresenter do end describe '#provider' do - subject { presenter.provider} + subject { presenter.provider } let(:expected_json) do { diff --git a/spec/presenters/packages/conan/package_presenter_spec.rb b/spec/presenters/packages/conan/package_presenter_spec.rb index d35137cd820..9b74d2e637e 100644 --- a/spec/presenters/packages/conan/package_presenter_spec.rb +++ b/spec/presenters/packages/conan/package_presenter_spec.rb @@ -7,7 +7,7 @@ RSpec.describe ::Packages::Conan::PackagePresenter do let_it_be(:package) { create(:conan_package) } let_it_be(:project) { package.project } let_it_be(:package_file_pending_destruction) { create(:package_file, :pending_destruction, package: package) } - let_it_be(:conan_package_reference) { '123456789'} + let_it_be(:conan_package_reference) { '123456789' } let(:params) { { package_scope: :instance } } let(:presenter) { described_class.new(package, user, project, params) } diff --git a/spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb b/spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb index b2bcdf8f03d..39682a3311c 100644 --- a/spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb +++ b/spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb @@ -12,7 +12,7 @@ RSpec.describe Packages::Nuget::PackagesMetadataPresenter do describe '#count' do subject { presenter.count } - it {is_expected.to eq 1} + it { is_expected.to eq 1 } end describe '#items' do diff --git a/spec/presenters/project_presenter_spec.rb b/spec/presenters/project_presenter_spec.rb index df3e4b985ab..7ff19b1b770 100644 --- a/spec/presenters/project_presenter_spec.rb +++ b/spec/presenters/project_presenter_spec.rb @@ -102,7 +102,7 @@ RSpec.describe ProjectPresenter do expect(release).to be_truthy expect(presenter.releases_anchor_data).to have_attributes( is_link: true, - label: a_string_including("#{project.releases.count}"), + label: a_string_including("#{project.releases.count}"), link: presenter.project_releases_path(project) ) end @@ -216,7 +216,7 @@ RSpec.describe ProjectPresenter do it 'returns storage data' do expect(presenter.storage_anchor_data).to have_attributes( is_link: true, - label: a_string_including('0 Bytes'), + label: a_string_including('0 Bytes'), link: nil ) end @@ -270,7 +270,7 @@ RSpec.describe ProjectPresenter do it 'returns storage data without usage quotas link for non-admin users' do expect(presenter.storage_anchor_data).to have_attributes( is_link: true, - label: a_string_including('0 Bytes'), + label: a_string_including('0 Bytes'), link: nil ) end @@ -280,7 +280,7 @@ RSpec.describe ProjectPresenter do expect(presenter.storage_anchor_data).to have_attributes( is_link: true, - label: a_string_including('0 Bytes'), + label: a_string_including('0 Bytes'), link: presenter.project_usage_quotas_path(project) ) end @@ -293,7 +293,7 @@ RSpec.describe ProjectPresenter do expect(release).to be_truthy expect(presenter.releases_anchor_data).to have_attributes( is_link: true, - label: a_string_including("#{project.releases.count}"), + label: a_string_including("#{project.releases.count}"), link: presenter.project_releases_path(project) ) end @@ -484,6 +484,12 @@ RSpec.describe ProjectPresenter do end describe '#autodevops_anchor_data' do + it 'returns nil if builds feature is not available' do + allow(project).to receive(:feature_available?).with(:builds, user).and_return(false) + + expect(presenter.autodevops_anchor_data).to be_nil + end + context 'when Auto Devops is enabled' do it 'returns anchor data' do allow(project).to receive(:auto_devops_enabled?).and_return(true) @@ -566,7 +572,7 @@ RSpec.describe ProjectPresenter do it 'returns upload_anchor_data' do expect(presenter.upload_anchor_data).to have_attributes( is_link: false, - label: a_string_including('Upload file'), + label: a_string_including('Upload file'), data: { "can_push_code" => "true", "original_branch" => "master", @@ -613,7 +619,7 @@ RSpec.describe ProjectPresenter do end context 'empty repo' do - let(:project) { create(:project, :stubbed_repository)} + let(:project) { create(:project, :stubbed_repository) } context 'for a guest user' do it 'orders the items correctly' do |