diff options
Diffstat (limited to 'spec/requests/api/graphql/project/alert_management/alert/assignees_spec.rb')
-rw-r--r-- | spec/requests/api/graphql/project/alert_management/alert/assignees_spec.rb | 78 |
1 files changed, 78 insertions, 0 deletions
diff --git a/spec/requests/api/graphql/project/alert_management/alert/assignees_spec.rb b/spec/requests/api/graphql/project/alert_management/alert/assignees_spec.rb new file mode 100644 index 00000000000..4c048caaeee --- /dev/null +++ b/spec/requests/api/graphql/project/alert_management/alert/assignees_spec.rb @@ -0,0 +1,78 @@ +# frozen_string_literal: true + +require 'spec_helper' + +describe 'getting Alert Management Alert Assignees' do + include GraphqlHelpers + + let_it_be(:project) { create(:project) } + let_it_be(:current_user) { create(:user) } + let_it_be(:first_alert) { create(:alert_management_alert, project: project, assignees: [current_user]) } + let_it_be(:second_alert) { create(:alert_management_alert, project: project) } + + let(:params) { {} } + + let(:fields) do + <<~QUERY + nodes { + iid + assignees { + nodes { + username + } + } + } + QUERY + end + + let(:query) do + graphql_query_for( + 'project', + { 'fullPath' => project.full_path }, + query_graphql_field('alertManagementAlerts', params, fields) + ) + end + + let(:alerts) { graphql_data.dig('project', 'alertManagementAlerts', 'nodes') } + let(:assignees) { alerts.map { |alert| [alert['iid'], alert['assignees']['nodes']] }.to_h } + let(:first_assignees) { assignees[first_alert.iid.to_s] } + let(:second_assignees) { assignees[second_alert.iid.to_s] } + + before do + project.add_developer(current_user) + end + + it 'returns the correct assignees' do + post_graphql(query, current_user: current_user) + + expect(first_assignees.length).to eq(1) + expect(first_assignees.first).to include('username' => current_user.username) + expect(second_assignees).to be_empty + end + + it 'applies appropriate filters for non-visible users' do + allow(Ability).to receive(:allowed?).and_call_original + allow(Ability).to receive(:allowed?).with(current_user, :read_user, current_user).and_return(false) + + post_graphql(query, current_user: current_user) + + expect(first_assignees).to be_empty + expect(second_assignees).to be_empty + end + + it 'avoids N+1 queries' do + base_count = ActiveRecord::QueryRecorder.new do + post_graphql(query, current_user: current_user) + end + + # An N+1 would mean a new alert would increase the query count + third_alert = create(:alert_management_alert, project: project, assignees: [current_user]) + + expect { post_graphql(query, current_user: current_user) }.not_to exceed_query_limit(base_count) + + third_assignees = assignees[third_alert.iid.to_s] + + expect(third_assignees.length).to eq(1) + expect(third_assignees.first).to include('username' => current_user.username) + end +end |