diff options
Diffstat (limited to 'spec/requests/api/settings_spec.rb')
-rw-r--r-- | spec/requests/api/settings_spec.rb | 19 |
1 files changed, 17 insertions, 2 deletions
diff --git a/spec/requests/api/settings_spec.rb b/spec/requests/api/settings_spec.rb index a5b95bc59a5..e6dd1fecb69 100644 --- a/spec/requests/api/settings_spec.rb +++ b/spec/requests/api/settings_spec.rb @@ -38,6 +38,8 @@ describe API::Settings, 'Settings' do expect(json_response).not_to have_key('performance_bar_allowed_group_path') expect(json_response).not_to have_key('performance_bar_enabled') expect(json_response['snippet_size_limit']).to eq(50.megabytes) + expect(json_response['spam_check_endpoint_enabled']).to be_falsey + expect(json_response['spam_check_endpoint_url']).to be_nil end end @@ -50,7 +52,7 @@ describe API::Settings, 'Settings' do storages = Gitlab.config.repositories.storages .merge({ 'custom' => 'tmp/tests/custom_repositories' }) allow(Gitlab.config.repositories).to receive(:storages).and_return(storages) - Feature.get(:sourcegraph).enable + stub_feature_flags(sourcegraph: true) end it "updates application settings" do @@ -90,7 +92,9 @@ describe API::Settings, 'Settings' do push_event_activities_limit: 2, snippet_size_limit: 5, issues_create_limit: 300, - raw_blob_request_limit: 300 + raw_blob_request_limit: 300, + spam_check_endpoint_enabled: true, + spam_check_endpoint_url: 'https://example.com/spam_check' } expect(response).to have_gitlab_http_status(:ok) @@ -129,6 +133,8 @@ describe API::Settings, 'Settings' do expect(json_response['snippet_size_limit']).to eq(5) expect(json_response['issues_create_limit']).to eq(300) expect(json_response['raw_blob_request_limit']).to eq(300) + expect(json_response['spam_check_endpoint_enabled']).to be_truthy + expect(json_response['spam_check_endpoint_url']).to eq('https://example.com/spam_check') end end @@ -390,5 +396,14 @@ describe API::Settings, 'Settings' do expect(json_response['error']).to eq('sourcegraph_url is missing') end end + + context "missing spam_check_endpoint_url value when spam_check_endpoint_enabled is true" do + it "returns a blank parameter error message" do + put api("/application/settings", admin), params: { spam_check_endpoint_enabled: true } + + expect(response).to have_gitlab_http_status(:bad_request) + expect(json_response['error']).to eq('spam_check_endpoint_url is missing') + end + end end end |