1 files changed, 19 insertions, 1 deletions
diff --git a/spec/requests/pwa_controller_spec.rb b/spec/requests/pwa_controller_spec.rb
index 3971790c094..a80d083c11f 100644
--- a/spec/requests/pwa_controller_spec.rb
+++ b/spec/requests/pwa_controller_spec.rb
@@ -8,12 +8,13 @@ RSpec.describe PwaController, feature_category: :navigation do
       get manifest_path(format: :json)
 
       expect(response.body).to include('The complete DevOps platform.')
+      expect(Gitlab::Json.parse(response.body)).to include({ 'short_name' => 'GitLab' })
       expect(response).to have_gitlab_http_status(:success)
     end
 
     context 'with customized appearance' do
       let_it_be(:appearance) do
-        create(:appearance, title: 'Long name', short_title: 'Short name', description: 'This is a test')
+        create(:appearance, title: 'Long name', pwa_short_name: 'Short name', description: 'This is a test')
       end
 
       it 'uses custom values', :aggregate_failures do
@@ -27,6 +28,23 @@ RSpec.describe PwaController, feature_category: :navigation do
         expect(response).to have_gitlab_http_status(:success)
       end
     end
+
+    context 'when user is signed in' do
+      before do
+        user = create(:user)
+        allow(user).to receive(:role_required?).and_return(true)
+
+        sign_in(user)
+      end
+
+      it 'skips the required signup info storing of user location' do
+        expect_next_instance_of(described_class) do |instance|
+          expect(instance).not_to receive(:store_location_for).with(:user, manifest_path(format: :json))
+        end
+
+        get manifest_path(format: :json)
+      end
+    end
   end
 
   describe 'GET #offline' do