diff options
Diffstat (limited to 'spec/rubocop/cop/migration/migration_record_spec.rb')
-rw-r--r-- | spec/rubocop/cop/migration/migration_record_spec.rb | 59 |
1 files changed, 59 insertions, 0 deletions
diff --git a/spec/rubocop/cop/migration/migration_record_spec.rb b/spec/rubocop/cop/migration/migration_record_spec.rb new file mode 100644 index 00000000000..bab0ca469df --- /dev/null +++ b/spec/rubocop/cop/migration/migration_record_spec.rb @@ -0,0 +1,59 @@ +# frozen_string_literal: true + +require 'fast_spec_helper' +require_relative '../../../../rubocop/cop/migration/migration_record' + +RSpec.describe RuboCop::Cop::Migration::MigrationRecord do + subject(:cop) { described_class.new } + + shared_examples 'a disabled cop' do + it 'does not register any offenses' do + expect_no_offenses(<<~SOURCE) + class MyMigration < Gitlab::Database::Migration[2.0] + class Project < ActiveRecord::Base + end + end + SOURCE + end + end + + context 'outside of a migration' do + it_behaves_like 'a disabled cop' + end + + context 'in migration' do + before do + allow(cop).to receive(:in_migration?).and_return(true) + end + + context 'in an old migration' do + before do + allow(cop).to receive(:version).and_return(described_class::ENFORCED_SINCE - 5) + end + + it_behaves_like 'a disabled cop' + end + + context 'that is recent' do + before do + allow(cop).to receive(:version).and_return(described_class::ENFORCED_SINCE) + end + + it 'adds an offense if inheriting from ActiveRecord::Base' do + expect_offense(<<~RUBY) + class Project < ActiveRecord::Base + ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't inherit from ActiveRecord::Base but use MigrationRecord instead.[...] + end + RUBY + end + + it 'adds an offense if inheriting from ::ActiveRecord::Base' do + expect_offense(<<~RUBY) + class Project < ::ActiveRecord::Base + ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't inherit from ActiveRecord::Base but use MigrationRecord instead.[...] + end + RUBY + end + end + end +end |