diff options
Diffstat (limited to 'spec/rubocop')
-rw-r--r-- | spec/rubocop/cop/gitlab/bulk_insert_spec.rb | 12 | ||||
-rw-r--r-- | spec/rubocop/cop/gitlab/change_timezone_spec.rb | 2 | ||||
-rw-r--r-- | spec/rubocop/cop/qa/duplicate_testcase_link_spec.rb | 36 |
3 files changed, 43 insertions, 7 deletions
diff --git a/spec/rubocop/cop/gitlab/bulk_insert_spec.rb b/spec/rubocop/cop/gitlab/bulk_insert_spec.rb index bbc8f381d01..7cd003d0a70 100644 --- a/spec/rubocop/cop/gitlab/bulk_insert_spec.rb +++ b/spec/rubocop/cop/gitlab/bulk_insert_spec.rb @@ -6,17 +6,17 @@ require_relative '../../../../rubocop/cop/gitlab/bulk_insert' RSpec.describe RuboCop::Cop::Gitlab::BulkInsert do subject(:cop) { described_class.new } - it 'flags the use of Gitlab::Database.main.bulk_insert' do + it 'flags the use of ApplicationRecord.legacy_bulk_insert' do expect_offense(<<~SOURCE) - Gitlab::Database.main.bulk_insert('merge_request_diff_files', rows) - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use the `BulkInsertSafe` concern, [...] + ApplicationRecord.legacy_bulk_insert('merge_request_diff_files', rows) + ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use the `BulkInsertSafe` concern, [...] SOURCE end - it 'flags the use of ::Gitlab::Database.main.bulk_insert' do + it 'flags the use of ::ApplicationRecord.legacy_bulk_insert' do expect_offense(<<~SOURCE) - ::Gitlab::Database.main.bulk_insert('merge_request_diff_files', rows) - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use the `BulkInsertSafe` concern, [...] + ::ApplicationRecord.legacy_bulk_insert('merge_request_diff_files', rows) + ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use the `BulkInsertSafe` concern, [...] SOURCE end end diff --git a/spec/rubocop/cop/gitlab/change_timezone_spec.rb b/spec/rubocop/cop/gitlab/change_timezone_spec.rb index f3c07e44cc7..ff6365aa0f7 100644 --- a/spec/rubocop/cop/gitlab/change_timezone_spec.rb +++ b/spec/rubocop/cop/gitlab/change_timezone_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true require 'fast_spec_helper' -require_relative '../../../../rubocop/cop/gitlab/change_timzone' +require_relative '../../../../rubocop/cop/gitlab/change_timezone' RSpec.describe RuboCop::Cop::Gitlab::ChangeTimezone do subject(:cop) { described_class.new } diff --git a/spec/rubocop/cop/qa/duplicate_testcase_link_spec.rb b/spec/rubocop/cop/qa/duplicate_testcase_link_spec.rb new file mode 100644 index 00000000000..fb424da90e8 --- /dev/null +++ b/spec/rubocop/cop/qa/duplicate_testcase_link_spec.rb @@ -0,0 +1,36 @@ +# frozen_string_literal: true + +require 'fast_spec_helper' + +require_relative '../../../../rubocop/cop/qa/duplicate_testcase_link' + +RSpec.describe RuboCop::Cop::QA::DuplicateTestcaseLink do + let(:source_file) { 'qa/page.rb' } + + subject(:cop) { described_class.new } + + context 'in a QA file' do + before do + allow(cop).to receive(:in_qa_file?).and_return(true) + end + + it "registers an offense for a duplicate testcase link" do + expect_offense(<<-RUBY) + it 'some test', testcase: '/quality/test_cases/1892' do + end + it 'another test', testcase: '/quality/test_cases/1892' do + ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't reuse the same testcase link in different tests. Replace one of `/quality/test_cases/1892`. + end + RUBY + end + + it "doesnt offend if testcase link is unique" do + expect_no_offenses(<<-RUBY) + it 'some test', testcase: '/quality/test_cases/1893' do + end + it 'another test', testcase: '/quality/test_cases/1894' do + end + RUBY + end + end +end |