diff options
Diffstat (limited to 'spec/services/boards')
-rw-r--r-- | spec/services/boards/lists/create_service_spec.rb | 50 |
1 files changed, 28 insertions, 22 deletions
diff --git a/spec/services/boards/lists/create_service_spec.rb b/spec/services/boards/lists/create_service_spec.rb index 88b6c3098d1..d639fdbb46a 100644 --- a/spec/services/boards/lists/create_service_spec.rb +++ b/spec/services/boards/lists/create_service_spec.rb @@ -5,27 +5,29 @@ require 'spec_helper' RSpec.describe Boards::Lists::CreateService do describe '#execute' do shared_examples 'creating board lists' do - let(:user) { create(:user) } + let_it_be(:user) { create(:user) } - subject(:service) { described_class.new(parent, user, label_id: label.id) } - - before do + before_all do parent.add_developer(user) end + subject(:service) { described_class.new(parent, user, label_id: label.id) } + context 'when board lists is empty' do it 'creates a new list at beginning of the list' do - list = service.execute(board) + response = service.execute(board) - expect(list.position).to eq 0 + expect(response.success?).to eq(true) + expect(response.payload[:list].position).to eq 0 end end context 'when board lists has the done list' do it 'creates a new list at beginning of the list' do - list = service.execute(board) + response = service.execute(board) - expect(list.position).to eq 0 + expect(response.success?).to eq(true) + expect(response.payload[:list].position).to eq 0 end end @@ -34,9 +36,10 @@ RSpec.describe Boards::Lists::CreateService do create(:list, board: board, position: 0) create(:list, board: board, position: 1) - list = service.execute(board) + response = service.execute(board) - expect(list.position).to eq 2 + expect(response.success?).to eq(true) + expect(response.payload[:list].position).to eq 2 end end @@ -44,32 +47,35 @@ RSpec.describe Boards::Lists::CreateService do it 'creates a new list at end of the label lists' do list1 = create(:list, board: board, position: 0) - list2 = service.execute(board) + list2 = service.execute(board).payload[:list] expect(list1.reload.position).to eq 0 expect(list2.reload.position).to eq 1 end end - context 'when provided label does not belongs to the parent' do - it 'raises an error' do + context 'when provided label does not belong to the parent' do + it 'returns an error' do label = create(:label, name: 'in-development') service = described_class.new(parent, user, label_id: label.id) - expect { service.execute(board) }.to raise_error(ActiveRecord::RecordNotFound) + response = service.execute(board) + + expect(response.success?).to eq(false) + expect(response.errors).to include('Label not found') end end context 'when backlog param is sent' do it 'creates one and only one backlog list' do service = described_class.new(parent, user, 'backlog' => true) - list = service.execute(board) + list = service.execute(board).payload[:list] expect(list.list_type).to eq('backlog') expect(list.position).to be_nil expect(list).to be_valid - another_backlog = service.execute(board) + another_backlog = service.execute(board).payload[:list] expect(another_backlog).to eq list end @@ -77,17 +83,17 @@ RSpec.describe Boards::Lists::CreateService do end context 'when board parent is a project' do - let(:parent) { create(:project) } - let(:board) { create(:board, project: parent) } - let(:label) { create(:label, project: parent, name: 'in-progress') } + let_it_be(:parent) { create(:project) } + let_it_be(:board) { create(:board, project: parent) } + let_it_be(:label) { create(:label, project: parent, name: 'in-progress') } it_behaves_like 'creating board lists' end context 'when board parent is a group' do - let(:parent) { create(:group) } - let(:board) { create(:board, group: parent) } - let(:label) { create(:group_label, group: parent, name: 'in-progress') } + let_it_be(:parent) { create(:group) } + let_it_be(:board) { create(:board, group: parent) } + let_it_be(:label) { create(:group_label, group: parent, name: 'in-progress') } it_behaves_like 'creating board lists' end |