diff options
Diffstat (limited to 'spec/services/ci/create_pipeline_service')
3 files changed, 3 insertions, 14 deletions
diff --git a/spec/services/ci/create_pipeline_service/creation_errors_and_warnings_spec.rb b/spec/services/ci/create_pipeline_service/creation_errors_and_warnings_spec.rb index 9ccf289df7c..7193e5bd7d4 100644 --- a/spec/services/ci/create_pipeline_service/creation_errors_and_warnings_spec.rb +++ b/spec/services/ci/create_pipeline_service/creation_errors_and_warnings_spec.rb @@ -14,7 +14,6 @@ RSpec.describe Ci::CreatePipelineService do before do stub_ci_pipeline_yaml_file(config) - stub_feature_flags(ci_raise_job_rules_without_workflow_rules_warning: true) end context 'when created successfully' do @@ -35,18 +34,6 @@ RSpec.describe Ci::CreatePipelineService do /jobs:test may allow multiple pipelines to run/ ) end - - context 'when feature flag is disabled for the particular warning' do - before do - stub_feature_flags(ci_raise_job_rules_without_workflow_rules_warning: false) - end - - it 'does not contain warnings' do - expect(pipeline.error_messages.map(&:content)).to be_empty - - expect(pipeline.warning_messages.map(&:content)).to be_empty - end - end end context 'when no warnings are raised' do diff --git a/spec/services/ci/create_pipeline_service/cross_project_pipeline_spec.rb b/spec/services/ci/create_pipeline_service/cross_project_pipeline_spec.rb index b3b8e34dd8e..7fd32288893 100644 --- a/spec/services/ci/create_pipeline_service/cross_project_pipeline_spec.rb +++ b/spec/services/ci/create_pipeline_service/cross_project_pipeline_spec.rb @@ -53,6 +53,8 @@ RSpec.describe Ci::CreatePipelineService, '#execute' do end context 'when sidekiq processes the job', :sidekiq_inline do + let_it_be(:runner) { create(:ci_runner, :online) } + it 'transitions to pending status and triggers a downstream pipeline' do pipeline = create_pipeline! diff --git a/spec/services/ci/create_pipeline_service/needs_spec.rb b/spec/services/ci/create_pipeline_service/needs_spec.rb index 4521067cd52..3b4a6178b8f 100644 --- a/spec/services/ci/create_pipeline_service/needs_spec.rb +++ b/spec/services/ci/create_pipeline_service/needs_spec.rb @@ -211,7 +211,7 @@ RSpec.describe Ci::CreatePipelineService do deploy_a = processables.find { |processable| processable.name == 'deploy_a' } deploy_b = processables.find { |processable| processable.name == 'deploy_b' } - expect(pipeline).to be_persisted + expect(pipeline).to be_created_successfully expect(build_a.status).to eq('pending') expect(test_a.status).to eq('created') expect(test_b.status).to eq('pending') |