1 files changed, 80 insertions, 41 deletions

diff --git a/spec/services/projects/group_links/create_service_spec.rb b/spec/services/projects/group_links/create_service_spec.rb
index 4ea5f2b3a53..65d3085a850 100644
--- a/spec/services/projects/group_links/create_service_spec.rb
+++ b/spec/services/projects/group_links/create_service_spec.rb
@@ -5,65 +5,104 @@ require 'spec_helper'
 RSpec.describe Projects::GroupLinks::CreateService, '#execute' do
   let_it_be(:user) { create :user }
   let_it_be(:group) { create :group }
-  let_it_be(:project) { create :project }
+  let_it_be(:project) { create(:project, namespace: create(:namespace, :with_namespace_settings)) }
 
-  let(:group_access) { Gitlab::Access::DEVELOPER }
   let(:opts) do
     {
-      link_group_access: group_access,
+      link_group_access: Gitlab::Access::DEVELOPER,
       expires_at: nil
     }
   end
 
-  subject { described_class.new(project, user, opts) }
+  subject { described_class.new(project, group, user, opts) }
 
-  before do
-    group.add_developer(user)
-  end
+  shared_examples_for 'not shareable' do
+    it 'does not share and returns an error' do
+      expect do
+        result = subject.execute
 
-  it 'adds group to project' do
-    expect { subject.execute(group) }.to change { project.project_group_links.count }.from(0).to(1)
+        expect(result[:status]).to eq(:error)
+        expect(result[:http_status]).to eq(404)
+      end.not_to change { project.project_group_links.count }
+    end
   end
 
-  it 'updates authorization', :sidekiq_inline do
-    expect { subject.execute(group) }.to(
-      change { Ability.allowed?(user, :read_project, project) }
-        .from(false).to(true))
-  end
+  shared_examples_for 'shareable' do
+    it 'adds group to project' do
+      expect do
+        result = subject.execute
 
-  it 'returns false if group is blank' do
-    expect { subject.execute(nil) }.not_to change { project.project_group_links.count }
+        expect(result[:status]).to eq(:success)
+      end.to change { project.project_group_links.count }.from(0).to(1)
+    end
   end
 
-  it 'returns error if user is not allowed to share with a group' do
-    expect { subject.execute(create(:group)) }.not_to change { project.project_group_links.count }
-  end
+  context 'when user has proper membership to share a group' do
+    before do
+      group.add_guest(user)
+    end
 
-  context 'with specialized project_authorization workers' do
-    let_it_be(:other_user) { create(:user) }
+    it_behaves_like 'shareable'
 
-    before do
-      group.add_developer(other_user)
+    it 'updates authorization', :sidekiq_inline do
+      expect { subject.execute }.to(
+        change { Ability.allowed?(user, :read_project, project) }
+          .from(false).to(true))
+    end
+
+    context 'with specialized project_authorization workers' do
+      let_it_be(:other_user) { create(:user) }
+
+      before do
+        group.add_developer(other_user)
+      end
+
+      it 'schedules authorization update for users with access to group' do
+        expect(AuthorizedProjectsWorker).not_to(
+          receive(:bulk_perform_async)
+        )
+        expect(AuthorizedProjectUpdate::ProjectRecalculateWorker).to(
+          receive(:perform_async)
+            .with(project.id)
+            .and_call_original
+        )
+        expect(AuthorizedProjectUpdate::UserRefreshFromReplicaWorker).to(
+          receive(:bulk_perform_in)
+            .with(1.hour,
+                  array_including([user.id], [other_user.id]),
+                  batch_delay: 30.seconds, batch_size: 100)
+            .and_call_original
+        )
+
+        subject.execute
+      end
     end
 
-    it 'schedules authorization update for users with access to group' do
-      expect(AuthorizedProjectsWorker).not_to(
-        receive(:bulk_perform_async)
-      )
-      expect(AuthorizedProjectUpdate::ProjectRecalculateWorker).to(
-        receive(:perform_async)
-          .with(project.id)
-          .and_call_original
-      )
-      expect(AuthorizedProjectUpdate::UserRefreshFromReplicaWorker).to(
-        receive(:bulk_perform_in)
-          .with(1.hour,
-                array_including([user.id], [other_user.id]),
-                batch_delay: 30.seconds, batch_size: 100)
-          .and_call_original
-      )
-
-      subject.execute(group)
+    context 'when sharing outside the hierarchy is disabled' do
+      let_it_be(:shared_group_parent) do
+        create(:group,
+               namespace_settings: create(:namespace_settings, prevent_sharing_groups_outside_hierarchy: true))
+      end
+
+      let_it_be(:project, reload: true) { create(:project, group: shared_group_parent) }
+
+      it_behaves_like 'not shareable'
+
+      context 'when group is inside hierarchy' do
+        let(:group) { create(:group, :private, parent: shared_group_parent) }
+
+        it_behaves_like 'shareable'
+      end
     end
   end
+
+  context 'when user does not have permissions for the group' do
+    it_behaves_like 'not shareable'
+  end
+
+  context 'when group is blank' do
+    let(:group) { nil }
+
+    it_behaves_like 'not shareable'
+  end
 end