diff options
Diffstat (limited to 'spec/services/projects/update_pages_service_spec.rb')
| -rw-r--r-- | spec/services/projects/update_pages_service_spec.rb | 30 |
1 files changed, 14 insertions, 16 deletions
diff --git a/spec/services/projects/update_pages_service_spec.rb b/spec/services/projects/update_pages_service_spec.rb index d2c6c0eb971..a15f6bdbe2c 100644 --- a/spec/services/projects/update_pages_service_spec.rb +++ b/spec/services/projects/update_pages_service_spec.rb @@ -35,13 +35,11 @@ RSpec.describe Projects::UpdatePagesService do build.reload end - describe 'pages artifacts' do - it "doesn't delete artifacts after deploying" do - expect(execute).to eq(:success) + it "doesn't delete artifacts after deploying" do + expect(execute).to eq(:success) - expect(project.pages_metadatum).to be_deployed - expect(build.artifacts?).to eq(true) - end + expect(project.pages_metadatum).to be_deployed + expect(build.artifacts?).to eq(true) end it 'succeeds' do @@ -71,6 +69,16 @@ RSpec.describe Projects::UpdatePagesService do expect(project.pages_metadatum.reload.pages_deployment_id).to eq(deployment.id) end + it 'fails if another deployment is in progress' do + subject.try_obtain_lease do + expect do + execute + end.to raise_error("Failed to deploy pages - other deployment is in progress") + + expect(GenericCommitStatus.last.description).to eq("Failed to deploy pages - other deployment is in progress") + end + end + it 'does not fail if pages_metadata is absent' do project.pages_metadatum.destroy! project.reload @@ -105,16 +113,6 @@ RSpec.describe Projects::UpdatePagesService do end end - it 'does not create deployment when zip_pages_deployments feature flag is disabled' do - stub_feature_flags(zip_pages_deployments: false) - - expect do - expect(execute).to eq(:success) - end.not_to change { project.pages_deployments.count } - - expect(project.pages_metadatum.reload.pages_deployment_id).to be_nil - end - it 'limits pages size' do stub_application_setting(max_pages_size: 1) expect(execute).not_to eq(:success) |