summaryrefslogtreecommitdiff
path: root/spec/services/protected_branches/create_service_spec.rb
diff options
context:
space:
mode:
Diffstat (limited to 'spec/services/protected_branches/create_service_spec.rb')
-rw-r--r--spec/services/protected_branches/create_service_spec.rb29
1 files changed, 19 insertions, 10 deletions
diff --git a/spec/services/protected_branches/create_service_spec.rb b/spec/services/protected_branches/create_service_spec.rb
index 3ac42d41377..b42524e761c 100644
--- a/spec/services/protected_branches/create_service_spec.rb
+++ b/spec/services/protected_branches/create_service_spec.rb
@@ -3,7 +3,8 @@
require 'spec_helper'
RSpec.describe ProtectedBranches::CreateService do
- let(:project) { create(:project) }
+ let_it_be_with_reload(:project) { create(:project) }
+
let(:user) { project.first_owner }
let(:params) do
{
@@ -13,22 +14,28 @@ RSpec.describe ProtectedBranches::CreateService do
}
end
+ subject(:service) { described_class.new(project, user, params) }
+
describe '#execute' do
let(:name) { 'master' }
- subject(:service) { described_class.new(project, user, params) }
-
it 'creates a new protected branch' do
expect { service.execute }.to change(ProtectedBranch, :count).by(1)
expect(project.protected_branches.last.push_access_levels.map(&:access_level)).to eq([Gitlab::Access::MAINTAINER])
expect(project.protected_branches.last.merge_access_levels.map(&:access_level)).to eq([Gitlab::Access::MAINTAINER])
end
+ it 'refreshes the cache' do
+ expect_next_instance_of(ProtectedBranches::CacheService) do |cache_service|
+ expect(cache_service).to receive(:refresh)
+ end
+
+ service.execute
+ end
+
context 'when protecting a branch with a name that contains HTML tags' do
let(:name) { 'foo<b>bar<\b>' }
- subject(:service) { described_class.new(project, user, params) }
-
it 'creates a new protected branch' do
expect { service.execute }.to change(ProtectedBranch, :count).by(1)
expect(project.protected_branches.last.name).to eq(name)
@@ -52,16 +59,18 @@ RSpec.describe ProtectedBranches::CreateService do
end
context 'when a policy restricts rule creation' do
- before do
- policy = instance_double(ProtectedBranchPolicy, allowed?: false)
- expect(ProtectedBranchPolicy).to receive(:new).and_return(policy)
- end
-
it "prevents creation of the protected branch rule" do
+ disallow(:create_protected_branch, an_instance_of(ProtectedBranch))
+
expect do
service.execute
end.to raise_error(Gitlab::Access::AccessDeniedError)
end
end
end
+
+ def disallow(ability, protected_branch)
+ allow(Ability).to receive(:allowed?).and_call_original
+ allow(Ability).to receive(:allowed?).with(user, ability, protected_branch).and_return(false)
+ end
end