diff options
Diffstat (limited to 'spec/workers/new_issue_worker_spec.rb')
-rw-r--r-- | spec/workers/new_issue_worker_spec.rb | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/spec/workers/new_issue_worker_spec.rb b/spec/workers/new_issue_worker_spec.rb index 6386af8d253..7cba3487603 100644 --- a/spec/workers/new_issue_worker_spec.rb +++ b/spec/workers/new_issue_worker_spec.rb @@ -11,13 +11,13 @@ RSpec.describe NewIssueWorker do expect(EventCreateService).not_to receive(:new) expect(NotificationService).not_to receive(:new) - worker.perform(99, create(:user).id) + worker.perform(non_existing_record_id, create(:user).id) end it 'logs an error' do - expect(Rails.logger).to receive(:error).with('NewIssueWorker: couldn\'t find Issue with ID=99, skipping job') + expect(Gitlab::AppLogger).to receive(:error).with("NewIssueWorker: couldn't find Issue with ID=#{non_existing_record_id}, skipping job") - worker.perform(99, create(:user).id) + worker.perform(non_existing_record_id, create(:user).id) end end @@ -26,23 +26,23 @@ RSpec.describe NewIssueWorker do expect(EventCreateService).not_to receive(:new) expect(NotificationService).not_to receive(:new) - worker.perform(create(:issue).id, 99) + worker.perform(create(:issue).id, non_existing_record_id) end it 'logs an error' do issue = create(:issue) - expect(Rails.logger).to receive(:error).with('NewIssueWorker: couldn\'t find User with ID=99, skipping job') + expect(Gitlab::AppLogger).to receive(:error).with("NewIssueWorker: couldn't find User with ID=#{non_existing_record_id}, skipping job") - worker.perform(issue.id, 99) + worker.perform(issue.id, non_existing_record_id) end end context 'when everything is ok' do - let(:project) { create(:project, :public) } - let(:mentioned) { create(:user) } - let(:user) { create(:user) } - let(:issue) { create(:issue, project: project, description: "issue for #{mentioned.to_reference}") } + let_it_be(:user) { create_default(:user) } + let_it_be(:project) { create(:project, :public) } + let_it_be(:mentioned) { create(:user) } + let_it_be(:issue) { create(:issue, project: project, description: "issue for #{mentioned.to_reference}") } it 'creates a new event record' do expect { worker.perform(issue.id, user.id) }.to change { Event.count }.from(0).to(1) @@ -50,7 +50,7 @@ RSpec.describe NewIssueWorker do it 'creates a notification for the mentioned user' do expect(Notify).to receive(:new_issue_email).with(mentioned.id, issue.id, NotificationReason::MENTIONED) - .and_return(double(deliver_later: true)) + .and_return(double(deliver_later: true)) worker.perform(issue.id, user.id) end |