diff options
Diffstat (limited to 'spec/workers')
16 files changed, 236 insertions, 445 deletions
diff --git a/spec/workers/bulk_import_worker_spec.rb b/spec/workers/bulk_import_worker_spec.rb index d3a4144d606..8cf14ed6f8b 100644 --- a/spec/workers/bulk_import_worker_spec.rb +++ b/spec/workers/bulk_import_worker_spec.rb @@ -72,6 +72,21 @@ RSpec.describe BulkImportWorker do expect(bulk_import.entities.map(&:status_name)).to contain_exactly(:created, :started) end end + + context 'when exception occurs' do + it 'tracks the exception & marks import as failed' do + bulk_import = create(:bulk_import, :created) + create(:bulk_import_entity, :created, bulk_import: bulk_import) + + allow(BulkImports::EntityWorker).to receive(:perform_async).and_raise(StandardError) + + expect(Gitlab::ErrorTracking).to receive(:track_exception).with(kind_of(StandardError), bulk_import_id: bulk_import.id) + + subject.perform(bulk_import.id) + + expect(bulk_import.reload.failed?).to eq(true) + end + end end end end diff --git a/spec/workers/bulk_imports/entity_worker_spec.rb b/spec/workers/bulk_imports/entity_worker_spec.rb index 31515b31947..cd9a6f605b9 100644 --- a/spec/workers/bulk_imports/entity_worker_spec.rb +++ b/spec/workers/bulk_imports/entity_worker_spec.rb @@ -24,6 +24,20 @@ RSpec.describe BulkImports::EntityWorker do expect(entity.reload.jid).to eq(jid) end + + context 'when exception occurs' do + it 'tracks the exception & marks entity as failed' do + allow(BulkImports::Importers::GroupImporter).to receive(:new) { raise StandardError } + + expect(Gitlab::ErrorTracking) + .to receive(:track_exception) + .with(kind_of(StandardError), bulk_import_id: bulk_import.id, entity_id: entity.id) + + subject.perform(entity.id) + + expect(entity.reload.failed?).to eq(true) + end + end end context 'when started entity does not exist' do diff --git a/spec/workers/ci/pipeline_artifacts/create_quality_report_worker_spec.rb b/spec/workers/ci/pipeline_artifacts/create_quality_report_worker_spec.rb new file mode 100644 index 00000000000..be351032b58 --- /dev/null +++ b/spec/workers/ci/pipeline_artifacts/create_quality_report_worker_spec.rb @@ -0,0 +1,40 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe ::Ci::PipelineArtifacts::CreateQualityReportWorker do + describe '#perform' do + subject { described_class.new.perform(pipeline_id) } + + context 'when pipeline exists' do + let(:pipeline) { create(:ci_pipeline, :with_codequality_reports) } + let(:pipeline_id) { pipeline.id } + + it 'calls pipeline codequality report service' do + expect_next_instance_of(::Ci::PipelineArtifacts::CreateCodeQualityMrDiffReportService) do |quality_report_service| + expect(quality_report_service).to receive(:execute) + end + + subject + end + + it_behaves_like 'an idempotent worker' do + let(:job_args) { pipeline_id } + + it 'creates a pipeline artifact' do + expect { subject }.to change { pipeline.pipeline_artifacts.count }.by(1) + end + end + end + + context 'when pipeline does not exist' do + let(:pipeline_id) { non_existing_record_id } + + it 'does not call pipeline codequality report service' do + expect(Ci::PipelineArtifacts::CreateCodeQualityMrDiffReportService).not_to receive(:execute) + + subject + end + end + end +end diff --git a/spec/workers/ci/pipeline_artifacts/expire_artifacts_worker_spec.rb b/spec/workers/ci/pipeline_artifacts/expire_artifacts_worker_spec.rb index 9e9aa962b63..2bdd8345374 100644 --- a/spec/workers/ci/pipeline_artifacts/expire_artifacts_worker_spec.rb +++ b/spec/workers/ci/pipeline_artifacts/expire_artifacts_worker_spec.rb @@ -7,7 +7,7 @@ RSpec.describe Ci::PipelineArtifacts::ExpireArtifactsWorker do describe '#perform' do let_it_be(:pipeline_artifact) do - create(:ci_pipeline_artifact, expire_at: 1.week.ago) + create(:ci_pipeline_artifact, :with_coverage_report, expire_at: 1.week.ago) end it 'executes a service' do diff --git a/spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb b/spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb index e6592f7f204..ba6cf133b0c 100644 --- a/spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb +++ b/spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb @@ -82,6 +82,7 @@ RSpec.describe ContainerExpirationPolicies::CleanupContainerRepositoryWorker do it 'skips the repository' do expect(ContainerExpirationPolicies::CleanupService).not_to receive(:new) expect(worker).to receive(:log_extra_metadata_on_done).with(:container_repository_id, repository.id) + expect(worker).to receive(:log_extra_metadata_on_done).with(:project_id, repository.project.id) expect(worker).to receive(:log_extra_metadata_on_done).with(:cleanup_status, :skipped) expect { subject }.to change { ContainerRepository.waiting_for_cleanup.count }.from(1).to(0) @@ -213,8 +214,10 @@ RSpec.describe ContainerExpirationPolicies::CleanupContainerRepositoryWorker do end def expect_log_extra_metadata(service_response:, cleanup_status: :finished, truncated: false) - expect(worker).to receive(:log_extra_metadata_on_done).with(:cleanup_status, cleanup_status) expect(worker).to receive(:log_extra_metadata_on_done).with(:container_repository_id, repository.id) + expect(worker).to receive(:log_extra_metadata_on_done).with(:project_id, repository.project.id) + expect(worker).to receive(:log_extra_metadata_on_done).with(:cleanup_status, cleanup_status) + %i[cleanup_tags_service_original_size cleanup_tags_service_before_truncate_size cleanup_tags_service_after_truncate_size cleanup_tags_service_before_delete_size].each do |field| value = service_response.payload[field] expect(worker).to receive(:log_extra_metadata_on_done).with(field, value) unless value.nil? diff --git a/spec/workers/git_garbage_collect_worker_spec.rb b/spec/workers/git_garbage_collect_worker_spec.rb index 13089549086..3df64c35166 100644 --- a/spec/workers/git_garbage_collect_worker_spec.rb +++ b/spec/workers/git_garbage_collect_worker_spec.rb @@ -5,350 +5,22 @@ require 'fileutils' require 'spec_helper' RSpec.describe GitGarbageCollectWorker do - include GitHelpers - let_it_be(:project) { create(:project, :repository) } - let(:shell) { Gitlab::Shell.new } - let!(:lease_uuid) { SecureRandom.uuid } - let!(:lease_key) { "project_housekeeping:#{project.id}" } - let(:params) { [project.id, task, lease_key, lease_uuid] } - - subject { described_class.new } - - shared_examples 'it calls Gitaly' do - specify do - expect_any_instance_of(Gitlab::GitalyClient::RepositoryService).to receive(gitaly_task) - .and_return(nil) - - subject.perform(*params) - end - end - shared_examples 'it updates the project statistics' do - it 'updates the project statistics' do - expect_next_instance_of(Projects::UpdateStatisticsService, project, nil, statistics: [:repository_size, :lfs_objects_size]) do |service| - expect(service).to receive(:execute).and_call_original - end - - subject.perform(*params) - end + let(:lease_uuid) { SecureRandom.uuid } + let(:lease_key) { "project_housekeeping:#{project.id}" } + let(:task) { :full_repack } + let(:params) { [project.id, task, lease_key, lease_uuid] } - it 'does nothing if the database is read-only' do - allow(Gitlab::Database).to receive(:read_only?) { true } - - expect_any_instance_of(Projects::UpdateStatisticsService).not_to receive(:execute) - - subject.perform(*params) - end - end + subject { described_class.new } describe "#perform" do - let(:gitaly_task) { :garbage_collect } - let(:task) { :gc } - - context 'with active lease_uuid' do - before do - allow(subject).to receive(:get_lease_uuid).and_return(lease_uuid) - end - - it_behaves_like 'it calls Gitaly' - it_behaves_like 'it updates the project statistics' - - it "flushes ref caches when the task if 'gc'" do - expect(subject).to receive(:renew_lease).with(lease_key, lease_uuid).and_call_original - expect_any_instance_of(Repository).to receive(:expire_branches_cache).and_call_original - expect_any_instance_of(Repository).to receive(:branch_names).and_call_original - expect_any_instance_of(Repository).to receive(:has_visible_content?).and_call_original - expect_any_instance_of(Gitlab::Git::Repository).to receive(:has_visible_content?).and_call_original - - subject.perform(*params) - end - - it 'handles gRPC errors' do - expect_any_instance_of(Gitlab::GitalyClient::RepositoryService).to receive(:garbage_collect).and_raise(GRPC::NotFound) - - expect { subject.perform(*params) }.to raise_exception(Gitlab::Git::Repository::NoRepository) - end - end - - context 'with different lease than the active one' do - before do - allow(subject).to receive(:get_lease_uuid).and_return(SecureRandom.uuid) - end - - it 'returns silently' do - expect_any_instance_of(Repository).not_to receive(:expire_branches_cache).and_call_original - expect_any_instance_of(Repository).not_to receive(:branch_names).and_call_original - expect_any_instance_of(Repository).not_to receive(:has_visible_content?).and_call_original - - subject.perform(*params) - end - end - - context 'with no active lease' do - let(:params) { [project.id] } - - before do - allow(subject).to receive(:get_lease_uuid).and_return(false) - end - - context 'when is able to get the lease' do - before do - allow(subject).to receive(:try_obtain_lease).and_return(SecureRandom.uuid) - end - - it_behaves_like 'it calls Gitaly' - it_behaves_like 'it updates the project statistics' - - it "flushes ref caches when the task if 'gc'" do - expect(subject).to receive(:get_lease_uuid).with("git_gc:#{task}:#{project.id}").and_return(false) - expect_any_instance_of(Repository).to receive(:expire_branches_cache).and_call_original - expect_any_instance_of(Repository).to receive(:branch_names).and_call_original - expect_any_instance_of(Repository).to receive(:has_visible_content?).and_call_original - expect_any_instance_of(Gitlab::Git::Repository).to receive(:has_visible_content?).and_call_original - - subject.perform(*params) - end - - context 'when the repository has joined a pool' do - let!(:pool) { create(:pool_repository, :ready) } - let(:project) { pool.source_project } - - it 'ensures the repositories are linked' do - expect_any_instance_of(PoolRepository).to receive(:link_repository).once - - subject.perform(*params) - end - end - - context 'LFS object garbage collection' do - before do - stub_lfs_setting(enabled: true) - end - - let_it_be(:lfs_reference) { create(:lfs_objects_project, project: project) } - let(:lfs_object) { lfs_reference.lfs_object } - - it 'cleans up unreferenced LFS objects' do - expect_next_instance_of(Gitlab::Cleanup::OrphanLfsFileReferences) do |svc| - expect(svc.project).to eq(project) - expect(svc.dry_run).to be_falsy - expect(svc).to receive(:run!).and_call_original - end - - subject.perform(*params) - - expect(project.lfs_objects.reload).not_to include(lfs_object) - end - - it 'catches and logs exceptions' do - expect_any_instance_of(Gitlab::Cleanup::OrphanLfsFileReferences) - .to receive(:run!) - .and_raise(/Failed/) - - expect(Gitlab::GitLogger).to receive(:warn) - expect(Gitlab::ErrorTracking).to receive(:track_and_raise_for_dev_exception) - - subject.perform(*params) - end - - it 'does nothing if the database is read-only' do - allow(Gitlab::Database).to receive(:read_only?) { true } - expect_any_instance_of(Gitlab::Cleanup::OrphanLfsFileReferences).not_to receive(:run!) - - subject.perform(*params) - - expect(project.lfs_objects.reload).to include(lfs_object) - end - end - end - - context 'when no lease can be obtained' do - before do - expect(subject).to receive(:try_obtain_lease).and_return(false) - end - - it 'returns silently' do - expect(subject).not_to receive(:command) - expect_any_instance_of(Repository).not_to receive(:expire_branches_cache).and_call_original - expect_any_instance_of(Repository).not_to receive(:branch_names).and_call_original - expect_any_instance_of(Repository).not_to receive(:has_visible_content?).and_call_original - - subject.perform(*params) - end - end - end - - context "repack_full" do - let(:task) { :full_repack } - let(:gitaly_task) { :repack_full } - - before do - expect(subject).to receive(:get_lease_uuid).and_return(lease_uuid) + it 'calls the Projects::GitGarbageGitGarbageCollectWorker with the same params' do + expect_next_instance_of(Projects::GitGarbageCollectWorker) do |instance| + expect(instance).to receive(:perform).with(*params) end - it_behaves_like 'it calls Gitaly' - it_behaves_like 'it updates the project statistics' - end - - context "pack_refs" do - let(:task) { :pack_refs } - let(:gitaly_task) { :pack_refs } - - before do - expect(subject).to receive(:get_lease_uuid).and_return(lease_uuid) - end - - it "calls Gitaly" do - expect_any_instance_of(Gitlab::GitalyClient::RefService).to receive(task) - .and_return(nil) - - subject.perform(*params) - end - - it 'does not update the project statistics' do - expect(Projects::UpdateStatisticsService).not_to receive(:new) - - subject.perform(*params) - end - end - - context "repack_incremental" do - let(:task) { :incremental_repack } - let(:gitaly_task) { :repack_incremental } - - before do - expect(subject).to receive(:get_lease_uuid).and_return(lease_uuid) - end - - it_behaves_like 'it calls Gitaly' - it_behaves_like 'it updates the project statistics' - end - - shared_examples 'gc tasks' do - before do - allow(subject).to receive(:get_lease_uuid).and_return(lease_uuid) - allow(subject).to receive(:bitmaps_enabled?).and_return(bitmaps_enabled) - end - - it 'incremental repack adds a new packfile' do - create_objects(project) - before_packs = packs(project) - - expect(before_packs.count).to be >= 1 - - subject.perform(project.id, 'incremental_repack', lease_key, lease_uuid) - after_packs = packs(project) - - # Exactly one new pack should have been created - expect(after_packs.count).to eq(before_packs.count + 1) - - # Previously existing packs are still around - expect(before_packs & after_packs).to eq(before_packs) - end - - it 'full repack consolidates into 1 packfile' do - create_objects(project) - subject.perform(project.id, 'incremental_repack', lease_key, lease_uuid) - before_packs = packs(project) - - expect(before_packs.count).to be >= 2 - - subject.perform(project.id, 'full_repack', lease_key, lease_uuid) - after_packs = packs(project) - - expect(after_packs.count).to eq(1) - - # Previously existing packs should be gone now - expect(after_packs - before_packs).to eq(after_packs) - - expect(File.exist?(bitmap_path(after_packs.first))).to eq(bitmaps_enabled) - end - - it 'gc consolidates into 1 packfile and updates packed-refs' do - create_objects(project) - before_packs = packs(project) - before_packed_refs = packed_refs(project) - - expect(before_packs.count).to be >= 1 - - expect_any_instance_of(Gitlab::GitalyClient::RepositoryService) - .to receive(:garbage_collect) - .with(bitmaps_enabled, prune: false) - .and_call_original - - subject.perform(project.id, 'gc', lease_key, lease_uuid) - after_packed_refs = packed_refs(project) - after_packs = packs(project) - - expect(after_packs.count).to eq(1) - - # Previously existing packs should be gone now - expect(after_packs - before_packs).to eq(after_packs) - - # The packed-refs file should have been updated during 'git gc' - expect(before_packed_refs).not_to eq(after_packed_refs) - - expect(File.exist?(bitmap_path(after_packs.first))).to eq(bitmaps_enabled) - end - - it 'cleans up repository after finishing' do - expect_any_instance_of(Project).to receive(:cleanup).and_call_original - - subject.perform(project.id, 'gc', lease_key, lease_uuid) - end - - it 'prune calls garbage_collect with the option prune: true' do - expect_any_instance_of(Gitlab::GitalyClient::RepositoryService) - .to receive(:garbage_collect) - .with(bitmaps_enabled, prune: true) - .and_return(nil) - - subject.perform(project.id, 'prune', lease_key, lease_uuid) - end - end - - context 'with bitmaps enabled' do - let(:bitmaps_enabled) { true } - - include_examples 'gc tasks' - end - - context 'with bitmaps disabled' do - let(:bitmaps_enabled) { false } - - include_examples 'gc tasks' - end - end - - # Create a new commit on a random new branch - def create_objects(project) - rugged = rugged_repo(project.repository) - old_commit = rugged.branches.first.target - new_commit_sha = Rugged::Commit.create( - rugged, - message: "hello world #{SecureRandom.hex(6)}", - author: { email: 'foo@bar', name: 'baz' }, - committer: { email: 'foo@bar', name: 'baz' }, - tree: old_commit.tree, - parents: [old_commit] - ) - rugged.references.create("refs/heads/#{SecureRandom.hex(6)}", new_commit_sha) - end - - def packs(project) - Gitlab::GitalyClient::StorageSettings.allow_disk_access do - Dir["#{project.repository.path_to_repo}/objects/pack/*.pack"] + subject.perform(*params) end end - - def packed_refs(project) - path = "#{project.repository.path_to_repo}/packed-refs" - FileUtils.touch(path) - File.read(path) - end - - def bitmap_path(pack) - pack.sub(/\.pack\z/, '.bitmap') - end end diff --git a/spec/workers/jira_connect/sync_builds_worker_spec.rb b/spec/workers/jira_connect/sync_builds_worker_spec.rb index 7c58803d778..8fb8692fdf7 100644 --- a/spec/workers/jira_connect/sync_builds_worker_spec.rb +++ b/spec/workers/jira_connect/sync_builds_worker_spec.rb @@ -32,29 +32,5 @@ RSpec.describe ::JiraConnect::SyncBuildsWorker do subject end end - - context 'when the feature flag is disabled' do - before do - stub_feature_flags(jira_sync_builds: false) - end - - it 'does not call the sync service' do - expect_next(::JiraConnect::SyncService).not_to receive(:execute) - - subject - end - end - - context 'when the feature flag is enabled for this project' do - before do - stub_feature_flags(jira_sync_builds: pipeline.project) - end - - it 'calls the sync service' do - expect_next(::JiraConnect::SyncService).to receive(:execute) - - subject - end - end end end diff --git a/spec/workers/jira_connect/sync_deployments_worker_spec.rb b/spec/workers/jira_connect/sync_deployments_worker_spec.rb index 9485f4cd3a7..16fa2643d04 100644 --- a/spec/workers/jira_connect/sync_deployments_worker_spec.rb +++ b/spec/workers/jira_connect/sync_deployments_worker_spec.rb @@ -32,29 +32,5 @@ RSpec.describe ::JiraConnect::SyncDeploymentsWorker do subject end end - - context 'when the feature flag is disabled' do - before do - stub_feature_flags(jira_sync_deployments: false) - end - - it 'does not call the sync service' do - expect_next(::JiraConnect::SyncService).not_to receive(:execute) - - subject - end - end - - context 'when the feature flag is enabled for this project' do - before do - stub_feature_flags(jira_sync_deployments: deployment.project) - end - - it 'calls the sync service' do - expect_next(::JiraConnect::SyncService).to receive(:execute) - - subject - end - end end end diff --git a/spec/workers/jira_connect/sync_feature_flags_worker_spec.rb b/spec/workers/jira_connect/sync_feature_flags_worker_spec.rb index 035f4ebdd3c..038eed7b9f1 100644 --- a/spec/workers/jira_connect/sync_feature_flags_worker_spec.rb +++ b/spec/workers/jira_connect/sync_feature_flags_worker_spec.rb @@ -32,29 +32,5 @@ RSpec.describe ::JiraConnect::SyncFeatureFlagsWorker do subject end end - - context 'when the feature flag is disabled' do - before do - stub_feature_flags(jira_sync_feature_flags: false) - end - - it 'does not call the sync service' do - expect_next(::JiraConnect::SyncService).not_to receive(:execute) - - subject - end - end - - context 'when the feature flag is enabled for this project' do - before do - stub_feature_flags(jira_sync_feature_flags: feature_flag.project) - end - - it 'calls the sync service' do - expect_next(::JiraConnect::SyncService).to receive(:execute) - - subject - end - end end end diff --git a/spec/workers/merge_request_cleanup_refs_worker_spec.rb b/spec/workers/merge_request_cleanup_refs_worker_spec.rb index 88d7322536b..7401c6dd4d7 100644 --- a/spec/workers/merge_request_cleanup_refs_worker_spec.rb +++ b/spec/workers/merge_request_cleanup_refs_worker_spec.rb @@ -17,6 +17,18 @@ RSpec.describe MergeRequestCleanupRefsWorker do subject end end + + context 'when merge_request_refs_cleanup flag is disabled' do + before do + stub_feature_flags(merge_request_refs_cleanup: false) + end + + it 'does not clean up the merge request' do + expect(MergeRequests::CleanupRefsService).not_to receive(:new) + + perform_multiple(1) + end + end end context 'when merge request does not exist' do diff --git a/spec/workers/namespaces/in_product_marketing_emails_worker_spec.rb b/spec/workers/namespaces/in_product_marketing_emails_worker_spec.rb new file mode 100644 index 00000000000..722ecfc1dec --- /dev/null +++ b/spec/workers/namespaces/in_product_marketing_emails_worker_spec.rb @@ -0,0 +1,29 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Namespaces::InProductMarketingEmailsWorker, '#perform' do + context 'when the experiment is inactive' do + before do + stub_experiment(in_product_marketing_emails: false) + end + + it 'does not execute the in product marketing emails service' do + expect(Namespaces::InProductMarketingEmailsService).not_to receive(:send_for_all_tracks_and_intervals) + + subject.perform + end + end + + context 'when the experiment is active' do + before do + stub_experiment(in_product_marketing_emails: true) + end + + it 'calls the send_for_all_tracks_and_intervals method on the in product marketing emails service' do + expect(Namespaces::InProductMarketingEmailsService).to receive(:send_for_all_tracks_and_intervals) + + subject.perform + end + end +end diff --git a/spec/workers/namespaces/onboarding_pipeline_created_worker_spec.rb b/spec/workers/namespaces/onboarding_pipeline_created_worker_spec.rb index f1789fa8fbd..6d69ccb50bd 100644 --- a/spec/workers/namespaces/onboarding_pipeline_created_worker_spec.rb +++ b/spec/workers/namespaces/onboarding_pipeline_created_worker_spec.rb @@ -3,30 +3,15 @@ require 'spec_helper' RSpec.describe Namespaces::OnboardingPipelineCreatedWorker, '#perform' do - include AfterNextHelpers - let_it_be(:ci_pipeline) { create(:ci_pipeline) } - before do - OnboardingProgress.onboard(ci_pipeline.project.namespace) - end - - it 'registers an onboarding progress action' do - expect_next(OnboardingProgressService, ci_pipeline.project.namespace) - .to receive(:execute).with(action: :pipeline_created).and_call_original + it_behaves_like 'records an onboarding progress action', :pipeline_created do + let(:namespace) { ci_pipeline.project.namespace } - subject.perform(ci_pipeline.project.namespace_id) - - expect(OnboardingProgress.completed?(ci_pipeline.project.namespace, :pipeline_created)).to eq(true) + subject { described_class.new.perform(ci_pipeline.project.namespace_id) } end - context "when a namespace doesn't exist" do - it 'does not register an onboarding progress action' do - expect_next(OnboardingProgressService, ci_pipeline.project.namespace).not_to receive(:execute) - - subject.perform(nil) - - expect(OnboardingProgress.completed?(ci_pipeline.project.namespace, :pipeline_created)).to eq(false) - end + it_behaves_like 'does not record an onboarding progress action' do + subject { described_class.new.perform(nil) } end end diff --git a/spec/workers/namespaces/onboarding_user_added_worker_spec.rb b/spec/workers/namespaces/onboarding_user_added_worker_spec.rb index a773e160fab..14428c0ecb8 100644 --- a/spec/workers/namespaces/onboarding_user_added_worker_spec.rb +++ b/spec/workers/namespaces/onboarding_user_added_worker_spec.rb @@ -3,20 +3,9 @@ require 'spec_helper' RSpec.describe Namespaces::OnboardingUserAddedWorker, '#perform' do - include AfterNextHelpers + let_it_be(:namespace) { create(:group) } - let_it_be(:group) { create(:group) } + subject { described_class.new.perform(namespace.id) } - before do - OnboardingProgress.onboard(group) - end - - it 'registers an onboarding progress action' do - expect_next(OnboardingProgressService, group) - .to receive(:execute).with(action: :user_added).and_call_original - - subject.perform(group.id) - - expect(OnboardingProgress.completed?(group, :user_added)).to be(true) - end + it_behaves_like 'records an onboarding progress action', :user_added end diff --git a/spec/workers/projects/git_garbage_collect_worker_spec.rb b/spec/workers/projects/git_garbage_collect_worker_spec.rb new file mode 100644 index 00000000000..8c44643ae51 --- /dev/null +++ b/spec/workers/projects/git_garbage_collect_worker_spec.rb @@ -0,0 +1,78 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Projects::GitGarbageCollectWorker do + let_it_be(:project) { create(:project, :repository) } + + it_behaves_like 'can collect git garbage' do + let(:resource) { project } + let(:statistics_service_klass) { Projects::UpdateStatisticsService } + let(:statistics_keys) { [:repository_size, :lfs_objects_size] } + let(:expected_default_lease) { "projects:#{resource.id}" } + end + + context 'when is able to get the lease' do + let(:params) { [project.id] } + + subject { described_class.new } + + before do + allow(subject).to receive(:get_lease_uuid).and_return(false) + allow(subject).to receive(:find_resource).and_return(project) + allow(subject).to receive(:try_obtain_lease).and_return(SecureRandom.uuid) + end + + context 'when the repository has joined a pool' do + let!(:pool) { create(:pool_repository, :ready) } + let(:project) { pool.source_project } + + it 'ensures the repositories are linked' do + expect(project.pool_repository).to receive(:link_repository).once + + subject.perform(*params) + end + end + + context 'LFS object garbage collection' do + let_it_be(:lfs_reference) { create(:lfs_objects_project, project: project) } + let(:lfs_object) { lfs_reference.lfs_object } + + before do + stub_lfs_setting(enabled: true) + end + + it 'cleans up unreferenced LFS objects' do + expect_next_instance_of(Gitlab::Cleanup::OrphanLfsFileReferences) do |svc| + expect(svc.project).to eq(project) + expect(svc.dry_run).to be_falsy + expect(svc).to receive(:run!).and_call_original + end + + subject.perform(*params) + + expect(project.lfs_objects.reload).not_to include(lfs_object) + end + + it 'catches and logs exceptions' do + allow_next_instance_of(Gitlab::Cleanup::OrphanLfsFileReferences) do |svc| + allow(svg).to receive(:run!).and_raise(/Failed/) + end + + expect(Gitlab::GitLogger).to receive(:warn) + expect(Gitlab::ErrorTracking).to receive(:track_and_raise_for_dev_exception) + + subject.perform(*params) + end + + it 'does nothing if the database is read-only' do + allow(Gitlab::Database).to receive(:read_only?) { true } + expect(Gitlab::Cleanup::OrphanLfsFileReferences).not_to receive(:new) + + subject.perform(*params) + + expect(project.lfs_objects.reload).to include(lfs_object) + end + end + end +end diff --git a/spec/workers/schedule_merge_request_cleanup_refs_worker_spec.rb b/spec/workers/schedule_merge_request_cleanup_refs_worker_spec.rb index 0dd50efba1c..869818b257e 100644 --- a/spec/workers/schedule_merge_request_cleanup_refs_worker_spec.rb +++ b/spec/workers/schedule_merge_request_cleanup_refs_worker_spec.rb @@ -20,6 +20,18 @@ RSpec.describe ScheduleMergeRequestCleanupRefsWorker do worker.perform end + context 'when merge_request_refs_cleanup flag is disabled' do + before do + stub_feature_flags(merge_request_refs_cleanup: false) + end + + it 'does not schedule any merge request clean ups' do + expect(MergeRequestCleanupRefsWorker).not_to receive(:bulk_perform_in) + + worker.perform + end + end + include_examples 'an idempotent worker' do it 'schedules MergeRequestCleanupRefsWorker to be performed by batch' do expect(MergeRequestCleanupRefsWorker) diff --git a/spec/workers/wikis/git_garbage_collect_worker_spec.rb b/spec/workers/wikis/git_garbage_collect_worker_spec.rb new file mode 100644 index 00000000000..77c2e49a83a --- /dev/null +++ b/spec/workers/wikis/git_garbage_collect_worker_spec.rb @@ -0,0 +1,14 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Wikis::GitGarbageCollectWorker do + it_behaves_like 'can collect git garbage' do + let_it_be(:resource) { create(:project_wiki) } + let_it_be(:page) { create(:wiki_page, wiki: resource) } + + let(:statistics_service_klass) { Projects::UpdateStatisticsService } + let(:statistics_keys) { [:wiki_size] } + let(:expected_default_lease) { "project_wikis:#{resource.id}" } + end +end |