| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| |
| |
| |
| |
| | |
Enable Style/MultilineBlockChain rubocop style cop
Avoid multi-line chains of blocks.
See #17478.
See merge request !4349
|
| |
| |
| |
| | |
See #17478
|
|/
|
|
|
|
|
| |
Migrations shouldn't fail RuboCop checks - especially lint checks, such
as the nested method check. To avoid changing code in existing
migrations, add the magic comment to the top of each of them to skip
that file.
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Disable Rails/UniqBeforePluck rubocop cop
Rails/UniqBeforePluck seems to have some bugs
* https://github.com/bbatsov/rubocop/issues/3122
* https://github.com/bbatsov/rubocop/issues/3148
and we had some problems in EE with that https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/425#note_12245005
See merge request !4477
|
| | |
|
|\ \
| |/
|/|
| |
| |
| |
| |
| |
| | |
Enable Lint/AmbiguousOperator rubocop cop
Enforce using parentheses if ambiguous operators are detected, like `header *some_method` or `array.select &:even?`.
See #17478
See merge request !4454
|
| |
| |
| |
| | |
See #17478
|
|/
|
|
| |
See #17478
|
|\
| |
| |
| |
| |
| |
| |
| |
| | |
Enable Style/Semicolon rubocop style cop
Don't use semicolons to terminate expressions.
See #17478.
See merge request !4351
|
| |
| |
| |
| | |
See #17478
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Enable Style/For rubocop cop
> Do not use `for`, unless you know exactly why. Most of the time iterators should be used instead. `for` is implemented in terms of `each` (so you're adding a level of indirection), but with a twist - `for` doesn't introduce a new scope (unlike `each`) and variables defined in its block will be visible outside it.
See #17478
See merge request !4397
|
| |/
| |
| |
| |
| |
| | |
Do not use for, unless you know exactly why.
See #17478
|
|\ \
| |/
|/|
| |
| |
| |
| | |
Fix error 500 when sorting issues by milestone due date and filtering by labels
fixes #15557
See merge request !4327
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Enable Style/SpaceBeforeComma rubocop cop
No spaces before commas.
See #17478
See merge request !4360
|
| |/
| |
| |
| |
| |
| | |
No spaces before commas.
See #17478
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Enable Performance/TimesMap Rubocop cop
Use Array.new with a block instead of `.times.collect` / `.times.map`.
See #17478
See merge request !4357
|
| |/
| |
| |
| |
| |
| | |
Use Array.new with a block instead of `.times.collect` / `.times.map`.
See #17478
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Enable Style/NegatedIf Rubocop cop
Favor `unless` over `if` for negative conditions (or control flow ||).
```ruby
# bad
do_something if !some_condition
# bad
do_something if not some_condition
# good
do_something unless some_condition
# good
some_condition || do_something
```
See #17478
See merge request !4355
|
| |/
| |
| |
| |
| |
| |
| | |
Favor `unless` over `if` for negative conditions
(or control flow ||).
See #17478
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Enable Lint/LiteralInCondition rubocop cop
Detects literals used in conditions.
See #17478
See merge request !4354
|
| |/
| |
| |
| |
| |
| | |
Checks of literals used in conditions.
See #17478
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Enable Style/MultilineIfThen rubocop cop
Do not use then for multi-line if.
See #7478.
See merge request !4353
|
| |/
| |
| |
| |
| |
| | |
Do not use then for multi-line if.
See #7478.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Enable Style/MethodDefParentheses rubocop cop
Use def with parentheses when there are parameters.
See #17478
See merge request !4352
|
| |/
| |
| |
| |
| |
| | |
Use def with parentheses when there are parameters.
See #17478
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Enable Style/IndentAssignment Rubocop style cop
Checks the indentation of the first line of the right-hand-side of a multi-line assignment.
See #17478
See merge request !4348
|
| |/
| |
| |
| | |
See #17478
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Enable Style/WhileUntilDo rubocop style cop
Checks for redundant `do` after `while` or `until`.
See #17478
See merge request !4350
|
| |/
| |
| |
| | |
See #17478
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Enable Style/EndOfLine Rubocop style cop
Use Unix-style line endings.
Removed carriage return character from end of each line in `app/controllers/projects/find_file_controller.rb`
See #17478
See merge request !4347
|
| |/
| |
| |
| | |
Use Unix-style line endings. See #17478.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Enable Lint/BlockAlignment Rubocop cop
See #17478
See merge request !4346
|
| |/
| |
| |
| | |
See #17478
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Enable Style/RedundantParentheses rubocop cop
Checks for parentheses that seem not to serve any purpose.
See #17478
See merge request !4361
|
| |/
| |
| |
| | |
See #17478
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Enable Style/SpaceBeforeComment rubocop cop
See #17478
See merge request !4358
|
| |/
| |
| |
| | |
See #17478
|
|/
|
|
| |
See #17478
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Enable multiple compatible Rubocop cops
## What does this MR do?
This MR enables multiple Rubocop cops, that are already compatible with
our codebase. See #17406.
Cops enabled:
```text
Style/ArrayJoin:
Description: Use Array#join instead of Array#*.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#array-join
----------------
Style/Attr:
Description: Checks for uses of Module#attr.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#attr
----------------
Style/BlockComments:
Description: Do not use block comments.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-block-comments
----------------
Style/ClassMethods:
Description: Use self when defining module/class methods.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#def-self-class-methods
----------------
Style/EndBlock:
Description: Avoid the use of END blocks.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-END-blocks
----------------
Style/EvenOdd:
Description: Favor the use of Fixnum#even? && Fixnum#odd?
StyleGuide: https://github.com/bbatsov/ruby-style-guide#predicate-methods
----------------
Style/FileName:
Description: Use snake_case for source file names.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#snake-case-files
ExpectMatchingDefinition: false
----------------
Style/FirstMethodParameterLineBreak:
Description: Checks for a line break before the first parameter in a multi-line method
parameter definition.
----------------
Style/FlipFlop:
Description: Checks for flip flops
StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-flip-flops
----------------
Style/GlobalVars:
Description: Do not introduce global variables.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#instance-vars
Reference: http://www.zenspider.com/Languages/Ruby/QuickRef.html
----------------
Style/IfWithSemicolon:
Description: Do not use if x; .... Use the ternary operator instead.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-semicolon-ifs
----------------
Style/LambdaCall:
Description: Use lambda.call(...) instead of lambda.(...).
StyleGuide: https://github.com/bbatsov/ruby-style-guide#proc-call
EnforcedStyle: call
----------------
Style/MethodName:
Description: Use the configured style when naming methods.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#snake-case-symbols-methods-vars
EnforcedStyle: snake_case
----------------
Style/MultilineMethodDefinitionBraceLayout:
Description: Checks that the closing brace in a method definition is symmetrical with
respect to the opening brace and the method parameters.
----------------
Style/NestedModifier:
Description: Avoid using nested modifiers.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-nested-modifiers
----------------
Style/OpMethod:
Description: When defining binary operators, name the argument other.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#other-arg
----------------
Style/SignalException:
Description: Checks for proper usage of fail and raise.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#prefer-raise-over-fail
EnforcedStyle: only_raise
----------------
Style/SpaceAfterNot:
Description: Tracks redundant space after the ! operator.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-space-bang
----------------
Style/SpaceBeforeSemicolon:
Description: No spaces before semicolons.
----------------
Style/SpaceInsideRangeLiteral:
Description: No spaces inside range literals.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-space-inside-range-literals
----------------
Style/SpaceInsideStringInterpolation:
Description: Checks for padding/surrounding spaces inside string interpolation.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#string-interpolation
EnforcedStyle: no_space
----------------
Style/StabbyLambdaParentheses:
Description: Check for the usage of parentheses around stabby lambda arguments.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#stabby-lambda-with-args
EnforcedStyle: require_parentheses
----------------
Style/StringMethods:
Description: Checks if configured preferred methods are used over non-preferred.
PreferredMethods:
intern: to_sym
----------------
Style/VariableInterpolation:
Description: Don't interpolate global, instance and class variables directly in strings.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#curlies-interpolate
----------------
Style/VariableName:
Description: Use the configured style when naming variables.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#snake-case-symbols-methods-vars
EnforcedStyle: snake_case
----------------
Style/WhenThen:
Description: Use when x then ... for one-line cases.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#one-line-cases
----------------
Style/WhileUntilModifier:
Description: Favor modifier while/until usage when you have a single-line body.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#while-as-a-modifier
MaxLineLength: 80
```
Closes #17406
See merge request !4286
|
| |
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| | |
Closes #17406
|
|/
|
|
| |
Also removes the note from the development/testing.md guide
|
|
|
|
| |
[ci skip]
|
|
|
|
|
| |
Almost all cops are starting as disabled until we can fix their
violations.
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Enable multiple Rubocop cops that can be enabled
See https://gitlab.com/gitlab-org/gitlab-ce/issues/17406
This enabled following cops:
```text
Lint/CircularArgumentReference:
Description: Default values in optional keyword arguments and optional ordinal arguments
----------------
Lint/ConditionPosition:
Description: Checks for condition placed in a confusing position relative to the keyword.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#same-line-condition
----------------
Lint/Debugger:
Description: Check for debugger calls.
----------------
Lint/DefEndAlignment:
Description: Align ends corresponding to defs correctly.
----------------
Lint/DuplicateMethods:
Description: Check for duplicate method definitions.
----------------
Lint/DuplicatedKey:
Description: Check for duplicate keys in hash literals.
----------------
Lint/EachWithObjectArgument:
Description: Check for immutable argument given to each_with_object.
----------------
Lint/ElseLayout:
Description: Check for odd code arrangement in an else block.
----------------
Lint/EmptyEnsure:
Description: Checks for empty ensure block.
----------------
Lint/EmptyInterpolation:
Description: Checks for empty string interpolation.
----------------
Lint/EndAlignment:
Description: Align ends correctly.
----------------
Lint/EndInMethod:
Description: END blocks should not be placed inside method definitions.
----------------
Lint/EnsureReturn:
Description: Do not use return in an ensure block.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-return-ensure
----------------
Lint/Eval:
Description: The use of eval represents a serious security risk.
----------------
Lint/FloatOutOfRange:
Description: Catches floating-point literals too large or small for Ruby to represent.
----------------
Lint/FormatParameterMismatch:
Description: The number of parameters to format/sprint must match the fields.
----------------
Lint/ImplicitStringConcatenation:
Description: Checks for adjacent string literals on the same line, which could better
be represented as a single string literal.
----------------
Lint/InvalidCharacterLiteral:
Description: Checks for invalid character literals with a non-escaped whitespace character.
----------------
Lint/LiteralInInterpolation:
Description: Checks for literals used in interpolation.
----------------
Lint/NestedMethodDefinition:
Description: Do not use nested method definitions.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-nested-methods
----------------
Lint/NextWithoutAccumulator:
Description: Do not omit the accumulator when calling `next` in a `reduce`/`inject`
block.
----------------
Lint/RandOne:
Description: Checks for `rand(1)` calls. Such calls always return `0` and most likely
a mistake.
----------------
Lint/RequireParentheses:
Description: Use parentheses in the method call to avoid confusion about precedence.
----------------
Lint/UnreachableCode:
Description: Unreachable code.
----------------
Lint/UselessComparison:
Description: Checks for comparison of something with itself.
----------------
Lint/UselessElseWithoutRescue:
Description: Checks for useless `else` in `begin..end` without `rescue`.
----------------
Lint/UselessSetterCall:
Description: Checks for useless setter call to a local variable.
----------------
Lint/Void:
Description: Possible use of operator/literal/variable in void context.
----------------
Performance/DoubleStartEndWith:
Description: Use `str.{start,end}_with?(x, ..., y, ...)` instead of `str.{start,end}_with?(x,
...) || str.{start,end}_with?(y, ...)`.
----------------
Performance/RedundantSortBy:
Description: Use `sort` instead of `sort_by { |x| x }`.
----------------
Rails/FindBy:
Description: Prefer find_by over where.first.
Include:
- app/models/**/*.rb
----------------
Rails/FindEach:
Description: Prefer all.find_each over all.find.
Include:
- app/models/**/*.rb
----------------
Rails/PluralizationGrammar:
Description: Checks for incorrect grammar when using methods like `3.day.ago`.
----------------
Rails/ScopeArgs:
Description: Checks the arguments of ActiveRecord scopes.
Include:
- app/models/**/*.rb
```
See merge request !4261
|
| |
| |
| |
| |
| | |
This enables multiple Rubocop cops that already conform to our codebase
and do not require fixes.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Enable Style/SpaceAroundKeyword cop and fix offenses
Ref: https://gitlab.com/gitlab-org/gitlab-ce/issues/17478
See merge request !4259
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Update rubocop to 0.40.0
See merge request !4258
|