summaryrefslogtreecommitdiff
path: root/.rubocop.yml
Commit message (Collapse)AuthorAgeFilesLines
* Adds the Rubocop ReturnNil copAndrew Newdigate2019-03-061-0/+3
| | | | | This style change enforces `return if ...` instead of `return nil if ...` to save maintainers a few minor review points
* Adds inter-service OpenTracing propagationAndrew Newdigate2019-01-221-0/+1
| | | | | | | | | | | | | | This change allows the GitLab rails and sidekiq components to receive tracing spans from upstream services such as Workhorse and pass these spans on to downstream services including Gitaly and Sidekiq. This change will also emit traces for incoming and outgoing requests using the propagated trace information. This will allow operators and engineers to view traces across the Workhorse, GitLab Rails, Sidekiq and Gitaly components. Additional intra-service instrumentation will be added in future changes.
* Update specs to rails5 formatblackst0ne-convert-specs-rails5-styleblackst0ne2018-12-191-1/+1
| | | | | | | | | | Updates specs to use new rails5 format. The old format: `get :show, { some: params }, { some: headers }` The new format: `get :show, params: { some: params }, headers: { some: headers }`
* Added Cop for injecting EE modulesYorick Peterse2018-12-131-0/+6
| | | | | | | This Cop enforces the rule that injecting EE modules (using prepend, include, or extend) is done by placing the injection on the last line of a file, instead of somewhere in the middle. By placing these lines at the very end, merge conflicts will not happen.
* Enable Rubocop on lib/gitlabgfyoung2018-11-201-1/+0
| | | | | | | This should wrap up frozen string enablement for gitlab-ce. xref gitlab-org/gitlab-ce#47424.
* Merge branch 'qa-59-ldap-ssl-scenario' into 'master'Stan Hu2018-10-261-0/+3
|\ | | | | | | | | | | | | E2E Test - LDAP login with SSL Closes gitlab-qa#59 See merge request gitlab-org/gitlab-ce!22574
| * Rename SSL to TLSSanad Liaquat2018-10-251-2/+2
| |
| * Fix rubocop issuesSanad Liaquat2018-10-241-0/+3
| |
* | Put EE routes in EE files under EE directoriesLin Jen-Shin2018-10-261-0/+1
|/
* Merge branch 'even-more-frozen-string-lib' into 'master'Rémy Coutable2018-10-111-1/+2
|\ | | | | | | | | Enable even more frozen string in lib/**/*.rb See merge request gitlab-org/gitlab-ce!22206
| * Enable even more frozen string in lib/**/*.rbgfyoung2018-10-081-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enables frozen string for the following files: * lib/generators/**/*.rb * lib/gitaly/**/*.rb * lib/google_api/**/*.rb * lib/haml_lint/**/*.rb * lib/json_web_token/**/*.rb * lib/mattermost/**/*.rb * lib/microsoft_teams/**/*.rb * lib/object_storage/**/*.rb * lib/omni_auth/**/*.rb * lib/peek/**/*.rb * lib/rouge/**/*.rb * lib/rspec_flaky/**/*.rb * lib/system_check/**/*.rb Partially addresses #47424.
* | Initial commitSanad Liaquat2018-10-111-0/+1
| | | | | | | | | | | | | | | | | | | | Use ACCEPT_INSECURE_CERTS env var and fix step Simplify saml signin Fix rubo cop offence Add missing # frozen_string_literal: true
* | Inline RSpec/FilePath rubocop ruleJames Edwards-Jones2018-10-091-1/+10
|/ | | | | Moves RSpec/FilePath cop from gitlab-styles, so we can specify filepaths to ignore without hardcoding them in the gem.
* Check frozen string in style buildsgfyoung2018-09-281-0/+19
|
* Correct Gitlab Capitalization in code filesMarcel Amirault2018-09-211-1/+1
|
* Move N_ calls into separate filesMark Chao2018-08-141-0/+2
| | | | | | These are dynamic translations, so has to be marked explicitly using `N_`, but they are not used in runtime, so can exist in separate file. https://github.com/grosser/gettext_i18n_rails#unfound-translations-with-rake-gettextfind
* Explicitly disable the Style/SafeNavigation copRémy Coutable2018-08-101-0/+4
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Enable rubocop for db/**/* and ee/db/**/*49582-enable-cops-for-dbLin Jen-Shin2018-07-251-2/+4
|
* Merge branch 'fj-15329-services-callbacks-ssrf' into 'security-10-6'Douwe Maan2018-03-211-0/+3
| | | | | Server Side Request Forgery in Services and Web Hooks See merge request gitlab/gitlabhq!2337
* [CE] Add Naming/FileName rule checking expected class/module per filenameGabriel Mazetto2018-03-081-0/+72
|
* Exclude plugins dir from rubocop and codeclimate configDmitriy Zaporozhets2018-02-261-0/+1
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Port some RuboCop and doc changes from EERémy Coutable2018-02-131-2/+26
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Cache rubocop cache for CI42338-rubocop-cacheLin Jen-Shin2018-01-251-0/+1
|
* Require our own custom cops; Remove missing cops41480-require-custom-copsLin Jen-Shin2017-12-261-0/+3
| | | | Also try to use the same config from EE
* Use gitlab-stylesRémy Coutable2017-12-221-1212/+4
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Backport changes from EELin Jen-Shin2017-12-151-2/+2
|
* Move ModuleWithInstanceVariables to Gitlab namespaceLin Jen-Shin2017-11-221-1/+14
| | | | | And use .rubocop.yml to exclude paths we don't care, rather than using the cop itself to exclude.
* Decrease ABC threshold to 54.28Maxim Rydkin2017-10-221-1/+1
|
* Decrease Perceived Complexity threshold to 14Maxim Rydkin2017-10-201-1/+1
|
* Decrease Perceived Complexity threshold to 15Maxim Rydkin2017-09-121-1/+1
|
* Decrease Cyclomatic Complexity threshold to 13Maxim Rydkin2017-09-121-1/+1
|
* refactor `app/helpers/projects_helper.rb:21:3`Maxim Rydkin2017-09-071-1/+1
|
* Decrease ABC threshold to 55.25Maxim Rydkin2017-08-311-1/+1
|
* Decrease Metrics/PerceivedComplexity threshold to 17Maxim Rydkin2017-08-311-1/+1
|
* Merge branch '31362_decrease_cyclomatic_complexity_threshold_step2' into ↵Robert Speicher2017-08-291-1/+1
|\ | | | | | | | | | | | | 'master' Decrease Metrics/CyclomaticComplexity threshold to 15 See merge request !13905
| * Decrease Metrics/CyclomaticComplexity threshold to 15Maxim Rydkin2017-08-291-1/+1
| |
* | exclude spec/ and features/ from `Style/PredicateName` copMaxim Rydkin2017-08-291-0/+12
|/
* Update rubocop-gitlab-security to 0.1.0rs-update-rubocop-gitlab-securityRobert Speicher2017-08-281-0/+4
|
* Merge branch 'rs-more-public-send-whitelists' into 'master'Rémy Coutable2017-08-161-5/+9
|\ | | | | | | | | Whitelist or fix additional `Gitlab/PublicSend` cop violations See merge request !13467
| * Whitelist or fix additional `Gitlab/PublicSend` cop violationsrs-more-public-send-whitelistsRobert Speicher2017-08-141-5/+9
| | | | | | | | | | An upcoming update to rubocop-gitlab-security added additional violations.
* | Enable Layout/TrailingWhitespace cop and auto-correct offensesRobert Speicher2017-08-151-0/+4
|/
* Fix cop descriptionRémy Coutable2017-08-111-3/+2
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Enable the RSpec/HookArgument cop and auto-correct offensesRobert Speicher2017-08-101-0/+5
|
* Enable the Layout/SpaceBeforeBlockBraces coprc/enable-the-Layout/SpaceBeforeBlockBraces-copRémy Coutable2017-08-091-0/+7
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Re-enable SqlInjection and CommandInjectionBrian Neel2017-08-081-0/+33
|
* Disable the Rails/Delegate copRémy Coutable2017-08-031-1/+2
| | | | | | | See https://gitlab.com/gitlab-org/gitlab-ce/issues/35869 for the rationale. Signed-off-by: Rémy Coutable <remy@rymai.me>
* Bump rubocop to 0.49.1 and rubocop-rspec to 1.15.1Takuya Noguchi2017-08-011-195/+257
|
* Decrease ABC threshold to 56.96Maxim Rydkin2017-07-241-1/+1
|
* Disable RSpec/BeforeAfterAll and enable RSpec/ImplicitExpect copsenable-a-few-rubocop-rspec-copsRémy Coutable2017-06-301-0/+10
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Enable Style/DotPosition Rubocop :cop:Grzegorz Bizon2017-06-211-0/+5
|
View Lorry Controller Status