summaryrefslogtreecommitdiff
path: root/.rubocop_todo.yml
Commit message (Collapse)AuthorAgeFilesLines
* Enable Rubocop Performance/ReverseEachsh-rubocop-reverse-eachStan Hu2019-07-241-8/+0
| | | | | | | `Array.reverse_each` is faster than `Array.reverse.each` because: * reverse.each creates a new array then loops each element * reverse_each loops in reverse order (no intermediate array created)
* Enable Rubocop Performance/InefficientHashSearchsh-enable-rubocop-hash-searchStan Hu2019-07-241-11/+0
| | | | | | | | | When used with a Hash, `.keys.include?` is bad because: 1. It performs a O(n) search instead of the efficient `.has_key?` 2. It clones all keys into separate array. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64975
* Remove now unused KubernetesService methodsremove_unused_k8s_service_methodsJames Fargher2019-07-051-3/+0
| | | | | Now that KubernetesService can no longer be a DeploymentPlatform we can remove all kubernetes client code and KubernetesService edge cases.
* Make KubernetesService readonlyJames Fargher2019-06-181-1/+0
| | | | | | | | We are deprecating this service in favor of instance wide clusters. Therefore we removed some code that is not anymore needed for a readonly cluster and also we added some flags to allow for this deprecation. These flags are to be removed in the next release when we finally completelly remove KubernetesService.
* Update .rubocop_todo.ymlStan Hu2019-05-051-21/+20
|
* Regenerate Rubocop rulesStan Hu2019-05-051-122/+4
|
* Upgrade to Rubocop 0.68.1Stan Hu2019-05-051-148/+484
| | | | This adds Ruby 2.6 support.
* Revert "Remove HipChat integration from GitLab"Sean McGivern2019-04-101-0/+1
| | | | This reverts commit a5378665a1dc0b9c8dc3a4fa279a0eb78aac5aac.
* Remove HipChat integration from GitLabNick Thomas2019-02-081-1/+0
|
* Fix ReturnInVoidContext rubocop offenseSemyon Pupkov2019-02-011-5/+0
|
* Re-enable MethodCallWithoutArgsParentheses CopAndrew Newdigate2019-01-291-5/+0
| | | | | Re-enables and autocorrects all instances of the Style/MethodCallWithoutArgsParentheses rule
* Enable the Layout/ExtraSpacing cop56392-enable-the-layout-extraspacing-copRémy Coutable2019-01-241-6/+0
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* chore(rubocop): fix Style/TrivialAccessors issuesSemyon Pupkov2019-01-161-11/+0
|
* Merge branch 'fix-rspec-offcense' into 'master'Rémy Coutable2018-12-171-11/+0
|\ | | | | | | | | Fix RSpec/HookArgument rubocop offense See merge request gitlab-org/gitlab-ce!23776
| * Fix RSpec/HookArgument rubocop offenseSemyon Pupkov2018-12-111-11/+0
| |
* | Fix ConstantName rubocop offenseSemyon Pupkov2018-12-091-6/+0
|/
* Merge branch 'fix-todo-cops' into 'master'Rémy Coutable2018-10-041-79/+0
|\ | | | | | | | | Fix todo cops See merge request gitlab-org/gitlab-ce!21850
| * Fix UriDefaultParser copSemyon Pupkov2018-09-211-5/+0
| |
| * Fix UnneededRequireStatement copSemyon Pupkov2018-09-211-8/+0
| |
| * Remove unused cops from todoSemyon Pupkov2018-09-211-17/+0
| |
| * Fix DynamicAttributeDefinedStatically copSemyon Pupkov2018-09-211-18/+0
| |
| * Fix SpaceInsidePercentLiteralDelimiters copSemyon Pupkov2018-09-201-8/+0
| |
| * Fix SpaceInsideArrayLiteralBrackets copSemyon Pupkov2018-09-201-9/+0
| |
| * Fix SpaceBeforeFirstArg copSemyon Pupkov2018-09-201-14/+0
| |
* | Remove Gitlab::Git::Repository#rugged and Gollum codeAlejandro Rodríguez2018-10-021-1/+0
|/ | | | | | | | Cleanup code, and refactor tests that still use Rugged. After this, there should be no Rugged code that access the instance's repositories on non-test environments. There is still some rugged code for other tasks like the repository import task, but since it doesn't access any repository storage path it can stay.
* Fix rubocop Style/ZeroLengthPredicateSemyon Pupkov2018-09-181-14/+0
|
* Explicitly disable the Style/SafeNavigation copRémy Coutable2018-08-101-6/+0
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Update rubocop to get rid of a warning in other MRLin Jen-Shin2018-07-091-6/+0
|
* Enable Capybara/FeatureMethods copWinnie Hellmann2018-07-051-4/+0
|
* Move the trigger-build script into one location to serve both omnibus and ↵refactor-trigger-build-scriptMarin Jankovski2018-06-141-1/+1
| | | | cloud-native triggers.
* Removed API endpoint and specsfj-36819-remove-v3-apiFrancisco Javier López2018-05-301-5/+0
|
* Move spec helpers/matchers/shared examples/contexts to their relevant folderRémy Coutable2018-04-231-4/+4
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Moved o_auth/saml/ldap modules under gitlab/authHoratiu Eugen Vlad2018-02-281-3/+3
|
* Enable RuboCop Style/RegexpLiteralTakuya Noguchi2018-02-011-1/+3
|
* Update gitlab-styles and re-enable the RSpec/SingleLineHook cop again42385-enable-the-rspec-singlelinehook-copRémy Coutable2018-01-251-4/+0
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Update rubocop, rubocop-rspec, and gitlab-styles42187-update-gitlab-styles-to-2-3-0Rémy Coutable2018-01-181-73/+62
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Use gitlab-stylesRémy Coutable2017-12-221-98/+616
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* exclude spec/ and features/ from `Style/PredicateName` copMaxim Rydkin2017-08-291-10/+0
|
* add changelogMaxim Rydkin2017-08-291-3/+0
|
* replace `is_member_of` with `member_of?`Maxim Rydkin2017-08-291-3/+3
|
* replace `has_matching_label` with `has_matching_label?`Maxim Rydkin2017-08-291-0/+3
|
* replace `is_edited?` with `edited?`Maxim Rydkin2017-08-291-1/+3
|
* Enable Layout/TrailingWhitespace cop and auto-correct offensesRobert Speicher2017-08-151-5/+0
|
* Enable the RSpec/HookArgument cop and auto-correct offensesRobert Speicher2017-08-101-6/+0
|
* Enable the Layout/SpaceBeforeBlockBraces coprc/enable-the-Layout/SpaceBeforeBlockBraces-copRémy Coutable2017-08-091-7/+0
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Bump rubocop to 0.49.1 and rubocop-rspec to 1.15.1Takuya Noguchi2017-08-011-112/+113
|
* Disable RSpec/BeforeAfterAll and enable RSpec/ImplicitExpect copsenable-a-few-rubocop-rspec-copsRémy Coutable2017-06-301-10/+0
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Enable Style/DotPosition Rubocop :cop:Grzegorz Bizon2017-06-211-7/+0
|
* Enable the Style/PreferredHashMethods coprc/enable-PreferredHashMethods-copRémy Coutable2017-06-021-7/+0
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Merge branch 'rubocop-empty-example-group' into 'master'Robert Speicher2017-05-181-5/+0
|\ | | | | | | | | Enable the RSpec/EmptyExampleGroup cop See merge request !11497