summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Only search for MR revert commits on notes after MR was merged41807-15665-consistently-502s-because-it-fetches-every-commitSean McGivern2018-01-125-6/+99
| | | | | | | | | | If we search for notes before the MR was merged, we have to load every commit that was ever part of the MR, or mentioned in a push. In extreme cases, this can be tens of thousands of commits to load, but we know they can't revert the merge commit, because they are from before the MR was merged. In the (rare) case that we don't have a `merged_at` value for the MR, we can still search all notes.
* Merge branch 'master' into 'master'Achilleas Pipinellis2018-01-091-1/+1
|\ | | | | | | | | fix example in ci ssh_keys documentation See merge request gitlab-org/gitlab-ce!16079
| * fix example in ci ssh_keys documentationVincent Lae2017-12-211-1/+1
| |
* | Merge branch 'docs-push-web-hook-note' into 'master'Achilleas Pipinellis2018-01-091-0/+6
|\ \ | | | | | | | | | | | | Add note about only 20 commits being included in push payload See merge request gitlab-org/gitlab-ce!16149
| * | Add note about only 20 commits being included in push payloaddocs-push-web-hook-noteDrew Blessing2017-12-271-0/+6
| | |
* | | Merge branch 'docs/rs-fix-changelog-header-level' into 'master'Achilleas Pipinellis2018-01-091-1/+1
|\ \ \ | | | | | | | | | | | | | | | | Fix the header level for the Changelog Arguments documentation See merge request gitlab-org/gitlab-ce!16158
| * | | Fix the header level for the Changelog Arguments documentationdocs/rs-fix-changelog-header-levelRobert Speicher2017-12-281-1/+1
| | | |
* | | | Merge branch 'docs-19843-specify-archive-sha-options' into 'master'Achilleas Pipinellis2018-01-091-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Specifies the accepted refs for downloading an archive via the API Closes #19843 See merge request gitlab-org/gitlab-ce!16222
| * | | | Specifies the accepted refs for downloading an archive via the APIMark Fletcher2018-01-041-1/+1
| | | | |
* | | | | Merge branch 'patch-24' into 'master'Achilleas Pipinellis2018-01-091-1/+5
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Update irker documentation to mention an irker bug with key-protected channels. See merge request gitlab-org/gitlab-ce!16274
| * | | | | Update irker documentation to mention an irker bug with key-protected channels.Mattia Rizzolo2018-01-081-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Mattia Rizzolo <mattia@debian.org>
* | | | | | Merge branch 'fj-41681-add-param-disable-commit-stats-api' into 'master'Douwe Maan2018-01-097-3/+63
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add option to disable commit stats to commit API Closes #41681 See merge request gitlab-org/gitlab-ce!16309
| * | | | | | Add option to disable commit stats to commit APIFrancisco Javier López2018-01-097-3/+63
|/ / / / / /
* | | | | | Merge branch 'doc-development-architecture.md-remove-unnecessary-line' into ↵Achilleas Pipinellis2018-01-091-2/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Fix: remove unnecessary line Closes #41501 See merge request gitlab-org/gitlab-ce!16289
| * | | | | | Fix: remove unnecessary lineOnuwa Nnachi Isaac2018-01-081-2/+0
| | | | | | |
* | | | | | | Merge branch 'jej/backport-authorized-keys-to-ce' into 'master'Douwe Maan2018-01-0918-14/+749
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport authorized_keys Closes gitlab-ee#3953 See merge request gitlab-org/gitlab-ce!16014
| * | | | | | | Adds changelog for backport of authorized_keys DB lookup from EEjej/backport-authorized-keys-to-ceJames Edwards-Jones2018-01-081-0/+5
| | | | | | | |
| * | | | | | | Fix spec in shell_spec.rbJames Edwards-Jones2018-01-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The spec for "#add_key does nothing" would always have passed, since the expectation was on both the wrong object and message.
| * | | | | | | Fix typo in spec/requests/api/internal_spec.rbJames Edwards-Jones2018-01-081-1/+1
| | | | | | | |
| * | | | | | | Backport spec fixes in spec/lib/gitlab/shell_spec.rbValery Sizov2018-01-081-10/+12
| | | | | | | |
| * | | | | | | Make Gitlab::CurrentSettings available when getting settingsSean McGivern2018-01-081-8/+8
| | | | | | | |
| * | | | | | | Avoid adding index if already existsPaco Guzman2018-01-081-1/+2
| | | | | | | |
| * | | | | | | Backport authorized_keys_enabled defaults to true'Michael Kozono2018-01-085-7/+289
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Originally from branch 'fix-authorized-keys-enabled-default-2738' via merge request https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2240 Removed background migrations which were intended to fix state after using Gitlab without a default having been set Squashed commits: Locally, if Spring was not restarted, `current_application_settings` was still cached, which prevented the migration from editing the file. This will also ensure that any app server somehow hitting old cache data will properly default this setting regardless. Retroactively fix migration This allows us to identify customers who ran the broken migration. Their `authorized_keys_enabled` column does not have a default at this point. We will fix the column after we fix the `authorized_keys` file. Fix authorized_keys file if needed Add default to authorized_keys_enabled setting Reminder: The original migration was fixed retroactively a few commits ago, so people who did not ever run GitLab 9.3.0 already have a column that defaults to true and disallows nulls. I have tested on PostgreSQL and MySQL that it is safe to run this migration regardless. Affected customers who did run 9.3.0 are the ones who need this migration to fix the authorized_keys_enabled column. The reason for the retroactive fix plus this migration is that it allows us to run a migration in between to fix the authorized_keys file only for those who ran 9.3.0. Tweaks to address feedback Extract work into background migration Move batch-add-logic to background migration Do the work synchronously to avoid multiple workers attempting to add batches of keys at the same time. Also, make the delete portion wait until after adding is done. Do read and delete work in background migration Fix Rubocop offenses Add changelog entry Inform the user of actions taken or not taken Prevent unnecessary `select`s and `remove_key`s Add logs for action taken Fix optimization Reuse `Gitlab::ShellAdapter` Guarantee the earliest key Fix migration spec for MySQL
| * | | | | | | Use ApplicationSetting.current in Admin::ApplicationSettingsControllerRémy Coutable2018-01-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See merge request gitlab-org/gitlab-ee!3323 Backported as part of authorized_keys in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16014
| * | | | | | | Combine ssh docs and rename the docErnst van Nierop2018-01-083-70/+194
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport to CE, originally branch 'evn-ssh-clarify-docs See merge request gitlab-org/gitlab-ee!3753
| * | | | | | | Backport option to disable writing to `authorized_keys` fileMichael Kozono2018-01-0811-13/+217
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Originally branch 'mk-toggle-writing-to-auth-keys-1631' See merge request !2004 Squashed commits: Add authorized_keys_enabled to Application Settings Ensure default settings are exposed in UI Without this change, `authorized_keys_enabled` is unchecked when it is nil, even if it should be checked by default. Add “Speed up SSH operations” documentation Clarify the reasons for disabling writes Add "How to go back" section Tweak copy Update Application Setting screenshot
| * | | | | | | Backport authorized_keys branch 'find-key-by-fingerprint'Pablo Carranza2018-01-085-0/+117
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add find key by base64 key or fingerprint to the internal API See merge request !250 Squashed changes: Add unique index to fingerprint Add new index to schema Add internal api to get ssh key by fingerprint Change API endpoint to authorized_keys Add InsecureKeyFingerprint that calculates the fingerprint without shelling out Add require for gitlab key fingerprint Remove uniqueness of fingerprint index Remove unique option from migration Fix spec style in fingerprint test Fix rubocop complain Extract insecure key fingerprint to separate file Change migration to support building index concurrently Remove those hideous tabs
* | | | | | | | Merge branch '36906_Reordering_issues_to_the_bottom' into 'master'Phil Hughes2018-01-093-1/+18
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixing re-ordering of an issue when dragging it to the bottom a long issue list in the board Closes #36906 See merge request gitlab-org/gitlab-ce!16250
| * | | | | | | | Fixing re-ordering of an issue when dragging it to the bottom a long issue ↵David Kuri2018-01-093-1/+18
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | list in the board
* | | | | | | | Merge branch 'move-markdown-preview' into 'master'Phil Hughes2018-01-093-184/+182
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove preview_markdown from the global obj See merge request gitlab-org/gitlab-ce!16025
| * | | | | | | | Remove preview_markdown from the global objJacob Schatz2018-01-093-184/+182
| | | | | | | | |
* | | | | | | | | Merge branch '41404-pipelines-charts' into 'master'Phil Hughes2018-01-093-8/+16
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Pipeline graph uses inconsistent colors for its legend and its content" Closes #41404 See merge request gitlab-org/gitlab-ce!16260
| * | | | | | | | | Change pipeline charts colors to match legend41404-pipelines-chartsAnnabel Dunstone Gray2018-01-083-8/+16
| | | | | | | | | |
* | | | | | | | | | Merge branch 'check-environment-regex-ce' into 'master'Grzegorz Bizon2018-01-092-2/+3
|\ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport "Fix environment scope regex" to CE Closes gitlab-ee#4308 See merge request gitlab-org/gitlab-ce!15945
| * | | | | | | | | Add speccheck-environment-regex-ceShinya Maeda2018-01-081-1/+2
| | | | | | | | | |
| * | | | | | | | | Merge branch 'check-environment-regex' into 'master'Grzegorz Bizon2018-01-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix environment scope regex See merge request gitlab-org/gitlab-ee!3641
* | | | | | | | | | Merge branch 'sh-store-user-in-api-logs' into 'master'Sean McGivern2018-01-095-1/+38
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Save user ID and username in Grape API log (api_json.log) See merge request gitlab-org/gitlab-ce!16264
| * | | | | | | | | | Save user ID and username in Grape API log (api_json.log)sh-store-user-in-api-logsStan Hu2018-01-085-1/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will enable admins to identify who actually made the API request. Relates to #36960
* | | | | | | | | | | Merge branch '41723-axios-mock-adapter' into 'master'Phil Hughes2018-01-091-1/+1
|\ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Install dev dependencies as devDependencies instead of dependencies" See merge request gitlab-org/gitlab-ce!16288
| * | | | | | | | | | Resolve "Install dev dependencies as devDependencies instead of dependencies"Filipa Lacerda2018-01-091-1/+1
|/ / / / / / / / / /
* | | | | | | | | | Merge branch 'improve-table-pagination-spec' into 'master'Jacob Schatz2018-01-091-1/+1
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve table pagination spec See merge request gitlab-org/gitlab-ce!16099
| * | | | | | | | | | Improve table pagination specClement Ho2018-01-091-1/+1
|/ / / / / / / / / /
* | | | | | | | | | Merge branch '41683-timeout-is-not-set-for-gitaly-fetch_remote-calls' into ↵Stan Hu2018-01-083-5/+24
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Resolve "Timeout is not set for gitaly fetch_remote calls" Closes #41683 See merge request gitlab-org/gitlab-ce!16245
| * | | | | | | | | | Pass timeout to RepositoryService.FetchRemote Gitaly RPC calls41683-timeout-is-not-set-for-gitaly-fetch_remote-callsAlejandro Rodríguez2018-01-053-5/+24
| | | | | | | | | | |
* | | | | | | | | | | Merge branch 'dispatcher-dashboard-todos' into 'master'Jacob Schatz2018-01-084-7/+10
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor dashboard todos inside dispatcher See merge request gitlab-org/gitlab-ce!16065
| * | | | | | | | | | | Refactor dashboard todos inside dispatcherClement Ho2018-01-084-7/+10
|/ / / / / / / / / / /
* | | | | | | | | | | Merge branch 'winh-fix-merge-request-spec' into 'master'Clement Ho2018-01-081-4/+11
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make tasklist:changed test in merge_request_spec.js async Closes #34649 See merge request gitlab-org/gitlab-ce!16097
| * | | | | | | | | | | Make tasklist:changed test in merge_request_spec.js asyncwinh-fix-merge-request-specWinnie Hellmann2018-01-081-4/+11
| | | | | | | | | | | |
* | | | | | | | | | | | Merge branch 'osw-merge-request-metrics-population-scheduler-improvement' ↵Stan Hu2018-01-081-31/+1
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | into 'master' Remove unnecessary queries on Merge Request Metrics population scheduler Closes gitlab-org/release/tasks#13 See merge request gitlab-org/gitlab-ce!16292
| * | | | | | | | | | | | Remove unnecessary queries on Merge Request Metrics population schedulerOswaldo Ferreira2018-01-081-31/+1
| | |_|/ / / / / / / / / | |/| | | | | | | | | |