delta/gitlab/gitlab-ce.git - gitlab.com: gitlab-org/gitlab-ce.git

	Commit message (Collapse)	Author	Age	Files	Lines
*	remove Ability.abilities	http://jneen.net/	2016-08-30	18	-61/+37
\|
*	make almost everything on Ability private	http://jneen.net/	2016-08-30	1	-46/+44
\|
*	don't double-cache project_abilites	http://jneen.net/	2016-08-30	1	-11/+2
\|
*	remove six, and use a Set instead	http://jneen.net/	2016-08-30	6	-20/+22
\|
*	delete project_security_spec	http://jneen.net/	2016-08-30	1	-112/+0
\| \| \| \| \|	re a conversation with @rspeicher, this spec isn't really testing anything.
*	re-enable the cyclomatic complexity checker	http://jneen.net/	2016-08-30	1	-1/+0
\|
*	Merge branch 'artifacts-from-ref-and-build-name' into 'master'	Douwe Maan	2016-08-30	34	-109/+501
\|\ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Add a download buttons for Build Artifacts ## What does this MR do? This MR adds a download buttons for build artifacts of latest succesful pipeline in: - dashboard of project, - branches and tags views, - and tree viewer Implement #4255 ## What are the relevant issue numbers? Closes #4255, Closes #14419 ## Screenshots ### Project main ![](/uploads/29ee2154a214416059a875f2715d4fa3/Screen_Shot_2016-08-24_at_8.00.31_PM.png) ### Branches ![](/uploads/9220c593288370986fbc1d42a1425ef7/Screen_Shot_2016-08-24_at_8.02.01_PM.png) ### Tags ![](/uploads/a843e8103221fea475a0cf9d62a1999d/Screen_Shot_2016-08-24_at_8.03.32_PM.png) ### Source Tree ![](/uploads/63cd3c8c91b6f427c166dc90d8e3c059/Screen_Shot_2016-08-24_at_8.04.56_PM.png) ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] Download buttons - [x] Models - [x] Routes - [x] Projects::ArtifactsController - [x] API - Tests - Rails - [x] Project#builds_for - [x] branch name with slashes - [x] only success builds - [x] only latest builds - [x] feature tests for download buttons - API - [x] branch name with slashes - [x] only success builds - [x] only latest builds - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5142
\| *	Fix CHANGELOGartifacts-from-ref-and-build-name	Lin Jen-Shin	2016-08-26	1	-2/+0
\| \|
\| *	Merge remote-tracking branch 'upstream/master' into ↵	Lin Jen-Shin	2016-08-26	145	-750/+1721
\| \|\ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	artifacts-from-ref-and-build-name * upstream/master: (107 commits) Fix external issue tracker "Issues" link leading to 404s Fix CHANGELOG entries related to 8.11 release. Fix changelog Reduce contributions calendar data payload Add lock_version to merge_requests table Add hover color to emoji icon Fix wrong Koding link Capitalize mentioned issue timeline notes Fix groups sort dropdown alignment Use icon helper Fix inline emoji text alignment Adds response mime type to transaction metric action when it's not HTML Moved two 8.11 changelog entries to 8.12 Fix markdown link in doc_styleguide.md Display project icon from default branch Reduce number of database queries on builds tab Update CHANGELOG Update Issue board documentation Label list shows all issues (opened or closed) with that label Update CHANGELOG ...
\| * \|	Fix tests	Lin Jen-Shin	2016-08-26	1	-3/+1
\| \| \|
\| * \|	Extract ref_name and path in before_action, feedback:	Lin Jen-Shin	2016-08-26	1	-5/+10
\| \| \| \| \| \| \| \| \| \| \| \|	https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14469768
\| * \|	Add a download icon for artifacts, too. Feedback:	Lin Jen-Shin	2016-08-25	1	-0/+1
\| \| \| \| \| \| \| \| \| \| \| \|	https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14400694
\| * \|	Just use instance variable instead, feedback:	Lin Jen-Shin	2016-08-25	1	-7/+2
\| \| \| \| \| \| \| \| \| \| \| \|	https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14400736
\| * \|	Update CHANGELOG from v8.11.0 to v8.12.0	Lin Jen-Shin	2016-08-24	1	-1/+1
\| \| \|
\| * \|	Merge remote-tracking branch 'upstream/master' into ↵	Lin Jen-Shin	2016-08-24	250	-663/+3388
\| \|\ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	artifacts-from-ref-and-build-name * upstream/master: (192 commits) Added CHANGELOG Added unfold test to parallel and added 'diff discussion' context Fix Spinach branches spec Better first match on this MR also Change merge_error column from string to text type Fix typo in gitlab_flow.md entities: make Environment inherit EnvironmentBasic Updated to optimized specs from !5864 Added 'with an unfolded line should not allow commenting' scenario (line 125) Added addtional 'renderable' validator to check 'data-note-type' attr exists Allow passing an index to selectRowAtIndex Fixed enter key in search input not working Fix file links on project page Files view Fix incorrect "stopped impersonation" log message 8.11 is released, long live 8.12 Also check if Akismet is enabled, before showing the `Submit as spam` button. fix location of markdown help location Fix for update 8.10-to-8.11.md doc. Appease the linter. Add Ruby 2.3 upgrade notes. ...
\| * \| \|	Aggressively merge views, feedback:	Lin Jen-Shin	2016-08-24	10	-85/+37
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14347679 https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14347470
\| * \| \|	Path could also have slashes! Feedback:	Lin Jen-Shin	2016-08-24	4	-10/+36
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14347729
\| * \| \|	Use only one before block, feedback:	Lin Jen-Shin	2016-08-24	1	-2/+0
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142/diffs#note_14347758
\| * \| \|	Make sure the branch we're testing is on the 1st page!	Lin Jen-Shin	2016-08-19	1	-2/+2
\| \| \| \|
\| * \| \|	Unify pipeline_for(ref, nil) and pipeline_for(ref), feedback:	Lin Jen-Shin	2016-08-19	1	-1/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14073464
\| * \| \|	Merge remote-tracking branch 'upstream/master' into ↵	Lin Jen-Shin	2016-08-19	191	-443/+7859
\| \|\ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	artifacts-from-ref-and-build-name * upstream/master: (195 commits) Fix expansion of discussions in diff Improve performance of MR show page Fix jumping between discussions on changes tab Update doorkeeper to 4.2.0 Fix MR note discussion ID Handle legacy sort order values Refactor `find_for_git_client` and its related methods. Remove right margin on Jump button icon Fix bug causing “Jump to discussion” button not to show Small refactor and syntax fixes. Removed unnecessary service for user retrieval and improved API error message. Added documentation and CHANGELOG item Added checks for 2FA to the API `/sessions` endpoint and the Resource Owner Password Credentials flow. Fix behavior around commands with optional arguments Fix behavior of label_ids and add/remove_label_ids Remove unneeded aliases Do not expose projects on deployments Incorporate feedback Docs for API endpoints Expose project for environments ...
\| * \ \ \	Merge remote-tracking branch 'upstream/master' into ↵	Lin Jen-Shin	2016-08-18	213	-465/+20807
\| \|\ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	artifacts-from-ref-and-build-name * upstream/master: (359 commits) Add new image to show the 'Reset template' button Refactor description templates documentation Remove index from pipeline toggles Hide `Create new list button` on Issues and MRs pages Remove params from build; general refactor Style build container box; add check mark to active build Display jobs as scrolling list in sidebar Move stages and jobs to build sidebar Removed vue assets Move skipped tests to end of array Remove unused data attributes Update changelog Style build dropdowns Populate dropdowns with current build on pageload Selecting stage updates builds dropdown Add data attributes to builds Change active state of list items; style dropdown items Hide dropdown if all tests fit on one line; add counter to dropdown Add overflow tests to dropdown Order by build status ...
\| * \| \| \| \|	Not sure why I missed this renaming	Lin Jen-Shin	2016-08-18	1	-1/+1
\| \| \| \| \| \|
\| * \| \| \| \|	Use path rather than URL because it should work for http 302:	Lin Jen-Shin	2016-08-18	2	-6/+6
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Feedback: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14035941
\| * \| \| \| \|	Use switch case in a helper, feedback:	Lin Jen-Shin	2016-08-17	2	-7/+18
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13988401
\| * \| \| \| \|	Use partials for downloading artifacts button	Lin Jen-Shin	2016-08-17	5	-63/+26
\| \| \| \| \| \|
\| * \| \| \| \|	Fixed a missing rename	Lin Jen-Shin	2016-08-17	1	-1/+1
\| \| \| \| \| \|
\| * \| \| \| \|	Merge remote-tracking branch 'upstream/master' into ↵	Lin Jen-Shin	2016-08-17	191	-792/+3532
\| \|\ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	artifacts-from-ref-and-build-name * upstream/master: (109 commits) Update CHANGELOG for 8.10.6, 8.9.7, and 8.8.8 Updated Akismet documentation Add hover state to todos (!5361) Load issues and merge requests templates from repository Backport EE assertions in protected branch related specs. Revert "Merge branch '19957-write-tests-for-adding-comments-for-different-line-types-in-diff' into 'master'" Fix a missed `before_action` for `AutocompleteController`. Backport `AutocompleteController#load_project` from EE!581. Fix API::BranchesSpec. Fix failing tests relating to backporting ee!581. Revert unrelevant changes Fix the protected branches factory. Improve EE compatibility with protected branch access levels. Move the "update" portion of the protected branch view into a partial. Don't select an access level if already selected. Backport changes from gitlab-org/gitlab-ee!581 to CE. Further refactor and syntax fixes. Upgrade httpclient gem from 2.7.0.1 to 2.8.2. Make rubocop happy Make rubocop happy ...
\| * \| \| \| \| \|	Not sure why missed this one	Lin Jen-Shin	2016-08-16	1	-1/+1
\| \| \| \| \| \| \|
\| * \| \| \| \| \|	Rename to latest_succeeded, feedback:	Lin Jen-Shin	2016-08-16	5	-7/+8
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13908017
\| * \| \| \| \| \|	An empty line after guard, feedback:	Lin Jen-Shin	2016-08-16	1	-0/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13904931
\| * \| \| \| \| \|	Add unclickable state to running build artifacts	Annabel Dunstone	2016-08-15	5	-4/+10
\| \| \| \| \| \| \|
\| * \| \| \| \| \|	Fixed bug when a pipeline for latest SHA does not exist	Kamil Trzcinski	2016-08-15	5	-4/+9
\| \| \| \| \| \| \|
\| * \| \| \| \| \|	Fix test by assigning the proper SHA	Lin Jen-Shin	2016-08-16	1	-1/+1
\| \| \| \| \| \| \|
\| * \| \| \| \| \|	It's project, not @project	Lin Jen-Shin	2016-08-16	1	-1/+1
\| \| \| \| \| \| \|
\| * \| \| \| \| \|	Use URL helper, feedback:	Lin Jen-Shin	2016-08-16	1	-3/+7
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13880889
\| * \| \| \| \| \|	Fix tests, explicitly set the status	Lin Jen-Shin	2016-08-16	1	-1/+2
\| \| \| \| \| \| \|
\| * \| \| \| \| \|	Fix tests which broke in the merge	Lin Jen-Shin	2016-08-16	2	-3/+3
\| \| \| \| \| \| \|
\| * \| \| \| \| \|	Merge remote-tracking branch 'upstream/master' into ↵	Lin Jen-Shin	2016-08-16	241	-3263/+5279
\| \|\ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	artifacts-from-ref-and-build-name * upstream/master: (123 commits) Limit the size of SVGs when viewing them as blobs Add a spec for ProjectsFinder project_ids_relation option Fix ProjectsFinder spec Pass project IDs relation to ProjectsFinder instead of using a block Speed up todos queries by limiting the projects set we join with Used phantomjs variable Ability to specify branches for pivotal tracker integration Fix a memory leak caused by Banzai::Filter::SanitizationFilter Update phantomjs link Remove sleeping and replace escaped text. Filters test fix Fixed filtering tests Removed screenshot command :poop: Updated failing tests Used mirrored version on GitLab Updated tests Fix `U2fSpec` for PhantomJS versions > 2. Fix file downloading Install latest stable phantomjs Use new PhantomJS version ...
\| * \| \| \| \| \| \|	Add a CHANGELOG entry	Lin Jen-Shin	2016-08-11	1	-0/+1
\| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \|	Show latest pipeline status if what provided artifacts aren't latest	Lin Jen-Shin	2016-08-11	4	-4/+16
\| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \|	Make Pipeline.latest_successful_for return the record	Lin Jen-Shin	2016-08-11	6	-11/+7
\| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \|	Remove Pipeline#latest in favour of Project#pipeline_for(ref)	Lin Jen-Shin	2016-08-11	2	-25/+7
\| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \|	Fix mock	Lin Jen-Shin	2016-08-11	1	-2/+2
\| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \|	Fetch the current SHA if SHA was not passed	Lin Jen-Shin	2016-08-11	2	-13/+28
\| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \|	Reverse ref and sha in args and rename pipeline to pipeline_for	Lin Jen-Shin	2016-08-11	8	-10/+12
\| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \|	It's latest_for, not just latest	Lin Jen-Shin	2016-08-10	1	-1/+1
\| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \|	This might be fixed on master already, but well	Lin Jen-Shin	2016-08-10	1	-1/+0
\| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \|	Empty lines around blocks	Lin Jen-Shin	2016-08-10	5	-16/+30
\| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \|	Introduce Pipeline#latest and Pipeline.latest_for:	Lin Jen-Shin	2016-08-10	2	-4/+56
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	So that we could easily access it for the view