summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix buttons with different height in merge request widget37331-button-MR-widgetFilipa Lacerda2017-09-012-4/+11
|
* Merge branch 'rs-filtered-issue-search-speed' into 'master'Sean McGivern2017-09-011-424/+114
|\ | | | | | | | | Reduce duration and complexity of spec/features/issues/filtered_search/filter_issues_spec.rb See merge request !13973
| * Shorten the search input for "text with other filters" specrs-filtered-issue-search-speedRobert Speicher2017-09-011-1/+1
| | | | | | | | | | | | The assignee wasn't important to the test, and shortening the query allowed us to avoid the "horizontal scroll" failure without having to stub the `sidebar_collapsed?` helper.
| * Turns out that short name was important, who knew!Robert Speicher2017-09-011-1/+6
| | | | | | | | We now document that fact.
| * Combine multiple `it` blocks in filter_issues_specRobert Speicher2017-09-011-18/+9
| |
| * Remove more redundant specs in filter_issues_specRobert Speicher2017-09-011-72/+17
| | | | | | | | | | We were essentially testing "all of the filters" four times, so now we just do it once at the top level.
| * Re-order top-level `let`s, so that labels are groupedRobert Speicher2017-09-011-1/+1
| |
| * Remove unused select_search_at_index helperRobert Speicher2017-09-011-4/+0
| |
| * Reduce duplication in RSS feed specs for filter_issues_specRobert Speicher2017-09-011-26/+24
| |
| * Remove the top-level closed issue from filter_issues_specRobert Speicher2017-09-011-6/+6
| |
| * Remove unused labels from filter_issues_specRobert Speicher2017-09-011-4/+1
| |
| * Reduce issues and milestones created in global filter_issues_spec setupRobert Speicher2017-09-011-18/+24
| | | | | | | | | | | | Three issues were only used in one test each, and one milestone with its accompanying issue were only used in one test, so we now scope those locally.
| * Clean up the still-way-too-complex filter_issues_spec setupRobert Speicher2017-09-011-33/+26
| | | | | | | | | | | | | | | | | | | | | | Removes unnecessary `let!` usage since we explicitly access these in the `before. Re-uses `user2` as the author for issues we otherwise don't care about the author for, to avoid creating a new user in each one. Makes use of the `labeled_issue` factory to avoid assigning variables just so we can add labels to an issue.
| * Remove an unnecessary issue creationRobert Speicher2017-09-011-4/+3
| | | | | | | | This seemed to only exist to increment an issue counter by 1.
| * Remove unnecessary attributes from factoriesRobert Speicher2017-09-011-3/+4
| |
| * Scope group creation to the specs that actually require itRobert Speicher2017-09-011-4/+8
| | | | | | | | | | Only one context tested group behavior, but we were performing group and membership creation on every example unnecessarily.
| * Use a positive assertion for have_no_selector rather than the inverseRobert Speicher2017-09-011-1/+1
| |
| * Remove unnecessary include from filter_issues_specRobert Speicher2017-09-011-1/+0
| |
| * Remove redundant specs from filter_issues_specRobert Speicher2017-09-011-254/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | While testing the various search tokens, we would add the token and a search term, then verify the correct issues were returned. Then we'd add a new token, search again, and verify again. Then another, and another. This was entirely redundant. If the search with higher specificity returned the same results as the search with lower specificity, we can be sure the lower specificity searches also worked without actually testing them. Because this entire spec performs very extensive setup, it's important to limit the number of times we perform that setup.
* | Merge branch 'backstage/gb/optimize-notification-specs' into 'master'Robert Speicher2017-09-012-67/+33
|\ \ | | | | | | | | | | | | Optimize notification emails specs See merge request !13986
| * | Remove some empty lines from notify specsbackstage/gb/optimize-notification-specsGrzegorz Bizon2017-09-011-3/+0
| | |
| * | Optimize notification emails specsGrzegorz Bizon2017-09-012-65/+34
| | |
* | | Merge branch 'fly-out-nav-hiding-fix' into 'master'Filipa Lacerda2017-09-013-4/+42
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | Fixes the fly-out navigation flashing in & out Closes #37022 See merge request !13929
| * | Fixes the fly-out navigation flashing in & outfly-out-nav-hiding-fixPhil Hughes2017-08-313-4/+42
| | | | | | | | | | | | Closes #37022
* | | Merge branch 'bvl-validate-po-files' into 'master'Douwe Maan2017-09-0132-13/+2413
|\ \ \ | | | | | | | | | | | | | | | | Validate PO files in static analysis See merge request !13000
| * | | Validate unescaped `%` chars in PO filesBob Van Landuyt2017-09-015-4/+140
| | | |
| * | | Fetch all translation keys using a regexBob Van Landuyt2017-08-312-6/+2
| | | |
| * | | Take `nplurals` into account when validating translations.Bob Van Landuyt2017-08-319-112/+120
| | | |
| * | | Check for newlines in different methods on TranslationEntryBob Van Landuyt2017-08-315-2/+59
| | | |
| * | | Split translation & metadata entries into classesBob Van Landuyt2017-08-318-238/+271
| | | |
| * | | Validate the number of plurals in an entryBob Van Landuyt2017-08-316-37/+177
| | | |
| * | | Move detailed information of an entry into a separate classBob Van Landuyt2017-08-314-34/+153
| | | |
| * | | Move `PoLinter` into `Gitlab::I18n`Bob Van Landuyt2017-08-314-194/+196
| | | |
| * | | Only perform `join_message` in `validate_variable_usage`Bob Van Landuyt2017-08-312-10/+8
| | | |
| * | | Check newlines in translationsBob Van Landuyt2017-08-313-2/+41
| | | |
| * | | Add spec for languages without pluralsBob Van Landuyt2017-08-314-1/+75
| | | |
| * | | Add documentation about PO-lintingBob Van Landuyt2017-08-311-0/+41
| | | |
| * | | Fix currently invalid po filesBob Van Landuyt2017-08-318-10/+61
| | | |
| * | | Add a linter for PO filesBob Van Landuyt2017-08-3112-2/+1690
| | | |
| * | | Ignore fuzzy translationsBob Van Landuyt2017-08-311-1/+4
| | | |
| * | | Track the locale in Sentry so we know which ones are failingBob Van Landuyt2017-08-312-0/+15
| | | |
* | | | Merge branch 'docs/migrating-from-perforce' into 'master'Marcia Ramos2017-09-012-0/+51
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Add perforce migration doc See merge request !13890
| * | | | Add vs heading in perforce docdocs/migrating-from-perforceAchilleas Pipinellis2017-08-301-0/+2
| | | | |
| * | | | Add perforce migration docAchilleas Pipinellis2017-08-292-0/+49
| | | | |
* | | | | Merge branch 'delete-branches-with-prefixes' into 'master'Douwe Maan2017-09-012-9/+10
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Simplify Git interactions in AfterImportService See merge request !13962
| * | | | | Simplify Git interactions in AfterImportServiceJacob Vosmaer (GitLab)2017-09-012-9/+10
|/ / / / /
* | | | | Merge branch '37202-revert-changes-to-signing-enabled' into 'master'Douwe Maan2017-09-0112-33/+31
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rollback changes made to signing_enabled. Closes #37202 See merge request !13956
| * | | | | Rollsback changes made to signing_enabled.Tiago Botelho2017-09-0112-33/+31
| | | | | |
* | | | | | Merge branch 'add_message_to_the_404_page' into 'master'Douwe Maan2017-09-012-1/+7
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changed message and title on the 404 page See merge request !13982
| * | | | | | Changed title on 404 pageBranka Martinovic2017-09-011-1/+1
| | | | | | |