| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
We might also want to consider reduce the number of
connections in the tests. However I just tried setting it to 1
and that doesn't seem enough for feature tests.
|
|\
| |
| |
| |
| | |
Replace 'project/wiki.feature' spinach test with an rspec analog
See merge request !13856
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Add gitaly to patch update doc
Closes gitlab-ee#3389
See merge request !14184
|
| |/ |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Emoji was rendered as italic
Closes #31676
See merge request !13974
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | | |
Replace 'project/group_links.feature' spinach test with an rspec analog
See merge request !14169
|
| |/ |
|
|\ \
| | |
| | |
| | |
| | | |
Document how to swap database tables.
See merge request !14183
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Adds Event polyfill for IE
Closes #37633
See merge request !14159
|
|/ / / |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
into 'master'
Backport the EE signature of Gitlab::Workhorse#send_artifacts_entry
See merge request !14144
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Expand filtered parameters to include `token`
See merge request !14174
|
| | |_|/
| |/| |
| | | |
| | | |
| | | | |
Now that we are logging API requests in `api_json.log`, we see that
the runner token was not filtered properly.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
'master'
Resolve Follow-up from Update Helm Chart docs from CE - docs
Closes #37647
See merge request !14166
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Replace the 'profile/emails.feature' spinach test with an rspec analog
See merge request !14172
|
| | |/ / /
| |/| | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Replace the 'project/team_management.feature' spinach test with an rspec analog
See merge request !14173
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
'37644-update-prometheus-metric-library-to-support-multiple-series-and-colors' into 'master'
Update Prometheus Metric Library to support multiple series and colors
Closes #37644
See merge request !14155
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Read import sources from setting at first initialization
See merge request !14141
|
| | |/ / / /
| |/| | | | |
|
|\ \ \ \ \ \
| |_|_|_|_|/
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fixed changes bar jumping on merge requests
Closes #37589
See merge request !14157
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Closes #37589
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Rework how recent push events are retrieved
Closes #35990
See merge request !13995
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Whenever you push to a branch GitLab will show a button to create a
merge request (should one not exist already). The underlying code to
display this data was quite inefficient. For example, it involved
multiple slow queries just to figure out what the most recent push event
was.
This commit changes the way this data is retrieved so it's much faster.
This is achieved by caching the ID of the last push event on every push,
which is then retrieved when loading certain pages. Database queries are
only executed if necessary and the cached data is removed automatically
once a merge request has been created, or 2 hours after being stored.
A trade-off of this approach is that we _only_ track the last event.
Previously if you were to push to branch A and B then create a merge
request for branch B we'd still show the widget for branch A. As of this
commit this is no longer the case, instead we will only show the widget
for the branch you pushed to most recently. Once a merge request exists
the widget is no longer displayed. Alternative solutions are either too
complex and/or too slow, hence the decision was made to settle for this
trade-off.
Performance Impact
------------------
In the best case scenario (= a user didn't push anything for more than 2
hours) we perform a single Redis GET per page. Should there be cached
data we will run a single (and lightweight) SQL query to get the
event data from the database. If a merge request already exists we will
run an additional DEL to remove the cache key.
The difference in response timings can vary a bit per project. On
GitLab.com the 99th percentile of time spent in User#recent_push hovers
between 100 milliseconds and 1 second, while the mean hovers around 50
milliseconds. With the changes in this MR the expected time spent in
User#recent_push is expected to be reduced down to just a few
milliseconds.
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/35990
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Remove ignore rule for GpgSignature#valid_signature
See merge request !14050
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This reverts commit cce9afa38a8aa3f3e5a43ab952e1c022c9dd9385.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Remove unused extra hr in preferences
Closes #37603
See merge request !14127
|
| | |_|_|_|_|/ /
| |/| | | | | | |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Reduce top and bottom margin on file viewer on mobile
See merge request !14114
|
| |/ / / / / / / |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Correctly associate ConvDev Index nav link with its controller
Closes #37583
See merge request !14124
|
| |/ / / / / / / |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Remove confidential toggle checkbox while editing issue inline
Closes #37454
See merge request !14142
|
| | | | | | | | | |
|
|\ \ \ \ \ \ \ \ \
| |/ / / / / / / /
|/| | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Check for sidebar cookie instead of class when resizing window
Closes #37642
See merge request !14151
|
|/ / / / / / / / |
|
|\ \ \ \ \ \ \ \
| |_|_|_|_|/ / /
|/| | | | | | |
| | | | | | | |
| | | | | | | | |
Bump grape_logging gem to 1.7.0 to get status codes for error messages
See merge request !14175
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This recent update fixes an issue in grape_logging where the status
code would be "fail" for any non-20x responses. For more details, see:
https://github.com/aserafin/grape_logging/issues/29
|