summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Add changelog.ab-approximate-countsAndreas Brandl2018-11-271-0/+5
|
* Move strategies in their own filesAndreas Brandl2018-11-278-279/+323
| | | | This improves readability quite a bit.
* Fix comment.Andreas Brandl2018-11-271-1/+1
|
* Refactor estimate queryAndreas Brandl2018-11-271-19/+18
|
* Limit some specs to PostgreSQL only.Andreas Brandl2018-11-271-2/+2
|
* Fix rubocop offenses.Andreas Brandl2018-11-272-7/+9
|
* Add feature flag for tablesample counting.Andreas Brandl2018-11-272-0/+8
|
* Implement TablesampleCountStrategy.Andreas Brandl2018-11-272-20/+161
| | | | | | | | | | | A tablesample count executes in two phases: * Estimate table sizes based on reltuples. * Based on the estimate: * If the table is considered 'small', execute an exact relation count. * Otherwise, count on a sample of the table using TABLESAMPLE. The size of the sample is chosen in a way that we always roughly scan the same amount of rows (see TABLESAMPLE_ROW_TARGET).
* Finish refactoring specs.Andreas Brandl2018-11-271-56/+15
| | | | The goal is to reflect separation of concern also in specs.
* Move things to their right scope in specs.Andreas Brandl2018-11-271-44/+45
|
* More specs for fallback testing.Andreas Brandl2018-11-272-0/+36
|
* Refactor specs to separate concerns.Andreas Brandl2018-11-272-27/+64
|
* Flexible approximate counts with fallback strategies.Andreas Brandl2018-11-272-21/+32
|
* Simplify to use models instead of tables.Andreas Brandl2018-11-272-25/+25
|
* Add ExactCountStrategy.Andreas Brandl2018-11-272-0/+23
|
* Extract ReltuplesCountStrategy.Andreas Brandl2018-11-272-21/+38
|
* Merge branch 'fix/gb/update-mrs-troubleshooting-page-link' into 'master'Douwe Maan2018-11-271-1/+1
|\ | | | | | | | | Update merge requests troubleshooting docs link See merge request gitlab-org/gitlab-ce!23344
| * Update merge requests troubleshooting docs linkGrzegorz Bizon2018-11-271-1/+1
| |
* | Merge branch 'leipert-fix-unsecure-npm-deps' into 'master'Mike Greiling2018-11-272-178/+110
|\ \ | | | | | | | | | | | | Fix unsecure node dependencies See merge request gitlab-org/gitlab-ce!23378
| * | Fix unsecure node dependenciesLukas Eipert2018-11-272-178/+110
|/ /
* | Merge branch 'diff-header-styling-fixes' into 'master'Filipa Lacerda2018-11-276-27/+38
|\ \ | | | | | | | | | | | | | | | | | | Fixed UI bugs with sticky diff header Closes #54503 See merge request gitlab-org/gitlab-ce!23374
| * | Fixed UI bugs with sticky diff headerPhil Hughes2018-11-276-27/+38
| | | | | | | | | | | | Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54503
* | | Merge branch 'docs/fix-some-grammar' into 'master'Achilleas Pipinellis2018-11-2714-14/+14
|\ \ \ | | | | | | | | | | | | | | | | Fix minor grammar issues See merge request gitlab-org/gitlab-ce!23372
| * | | Fix minor grammar issuesEvan Read2018-11-2714-14/+14
| | | |
* | | | Merge branch '51792-dont-delete-failed-install-pods' into 'master'Dmitriy Zaporozhets2018-11-275-26/+47
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't remove failed install pods Closes #51792 See merge request gitlab-org/gitlab-ce!23350
| * | | | Don't remove failed install podsDylan Griffith2018-11-275-26/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We want to keep failed install pods around so that it is easier to debug why a failure occured. With this change we also need to ensure that we remove a previous pod with the same name before installing so that re-install does not fail. Another change here is that we no longer need to catch errors from delete_pod! in CheckInstallationProgressService as we now catch the ResourceNotFoundError in Helm::Api. The catch statement in CheckInstallationProgressService was also probably too broad before and should have been narrowed down simply to ResourceNotFoundError.
* | | | | Merge branch '53778-remove-site-statistics' into 'master'Sean McGivern2018-11-2710-224/+27
|\ \ \ \ \ | |_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | Remove Site Statistic Closes #53778 See merge request gitlab-org/gitlab-ce!23314
| * | | | Remove Site Statistic53778-remove-site-statisticsGabriel Mazetto2018-11-2610-224/+27
| | | | | | | | | | | | | | | | | | | | | | | | | This approach caused many different problems as we tightened the query execution timeout.
* | | | | Merge branch 'if-ce-54109-fix_user_by_any_email' into 'master'Grzegorz Bizon2018-11-273-6/+37
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | User#find_by_any_email to respect confirmed flag on secondary emails See merge request gitlab-org/gitlab-ce!23181
| * | | | | Update ce-54109-fix_user_by_any_email.ymlif-ce-54109-fix_user_by_any_emailGrzegorz Bizon2018-11-271-1/+1
| | | | | |
| * | | | | User#find_by_any_email to respect confirmed flag on secondary emailsImre Farkas2018-11-263-6/+37
| | | | | |
* | | | | | Merge branch 'winh-parse-boolean' into 'master'Phil Hughes2018-11-2731-57/+106
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add parseBoolean helper function See merge request gitlab-org/gitlab-ce!23283
| * | | | | | Replace `=== true` with `parseBoolean()`Winnie Hellmann2018-11-2715-18/+36
| | | | | | |
| * | | | | | Replace convertPermissionToBoolean with parseBooleanWinnie Hellmann2018-11-2714-38/+35
| | | | | | |
| * | | | | | Add parseBoolean helper functionWinnie Hellmann2018-11-272-1/+35
| | |_|_|_|/ | |/| | | |
* | | | | | Merge branch 'gt-update-env-metrics-empty-state' into 'master'Filipa Lacerda2018-11-273-36/+32
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update environments metrics empty state Closes #51745 See merge request gitlab-org/gitlab-ce!23074
| * | | | | | Update environments metrics empty stateGeorge Tsiolis2018-11-263-36/+32
| | | | | | |
* | | | | | | Merge branch 'upgrade_kubeclient_400' into 'master'Kamil Trzciński2018-11-275-28/+18
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Upgrade kubeclient to 4.0.0 See merge request gitlab-org/gitlab-ce!23261
| * | | | | | | Remove monkeypatch as now present in upstreamThong Kuah2018-11-271-15/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://github.com/abonas/kubeclient/blob/v4.0.0/lib/kubeclient/common.rb#L395
| * | | | | | | Upgrade kubeclient to 4.0.0Thong Kuah2018-11-274-13/+18
| | |_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | Bumps kubeclient and its dependencies from 3.1.0 to 4.0.0.
* | | | | | | Merge branch 'triggermesh-phase2-external-ip' into 'master'Kamil Trzciński2018-11-2718-52/+191
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Expose External IP address for Knative's gateway See merge request gitlab-org/gitlab-ce!23162
| * | | | | | | Expose external_ip to knative cluster applicationChris Baumbauer2018-11-2618-52/+191
| | | | | | | |
* | | | | | | | Merge branch '53988-remove-notes-index-on-updated-at' into 'master'Sean McGivern2018-11-273-2/+38
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove notes index on updated_at Closes #53988 See merge request gitlab-org/gitlab-ce!23356
| * | | | | | | | Remove notes index on updated_atLin Jen-Shin2018-11-273-2/+38
| | | | | | | | |
* | | | | | | | | Merge branch 'rs-new-menu-spec' into 'master'Rémy Coutable2018-11-273-183/+144
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Convert "New menu" feature spec to a view spec Closes #54157 See merge request gitlab-org/gitlab-ce!23355
| * | | | | | | | | Condense the "new_dropdown" layout partialRobert Speicher2018-11-261-16/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After converting the test that verifies this partial's behavior from a feature spec to a view spec, we're able to remove a few CSS classes that were only used for scoping tests found in the feature spec. All the view spec needs is the `have_link` matcher which allows us to check for a specific `href` attribute.
| * | | | | | | | | Convert "New menu" feature spec to a view specRobert Speicher2018-11-262-167/+134
| | |_|_|_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A feature spec to test this simple behavior takes about 2 minutes to run in CI. Everything it's testing is conditionals and `href` attributes, which can easily be done in a view spec that runs in about 8 seconds.
* | | | | | | | | Merge branch 'rs-signed-commits-spec' into 'master'Rémy Coutable2018-11-272-63/+37
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Speed up "show GPG badge" feature specs See merge request gitlab-org/gitlab-ce!23359
| * | | | | | | | | Use have_link over have_content for GPG featureRobert Speicher2018-11-261-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's more semantically accurate for what we're verifying.
| * | | | | | | | | Simplify "changes to verified" GPG feature specsRobert Speicher2018-11-261-30/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, we wasted time creating a maintainer and signing them in, then loaded the entire commit list just to verify the GPG status of a single commit. Now, we rely on the project being public so no user needs to be authenticated, and load just the page for the commit we care about.