summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Actually render old and new sections of parallel diff next to each otherbetter-parallel-diffDouwe Maan2016-07-134-103/+65
|
* Merge branch 'api-docs-typos' into 'master' Achilleas Pipinellis2016-07-092-44/+51
|\ | | | | | | | | Fix typos in API documentation See merge request !4949
| * projects: add container_registry_enabled to API docsBen Boeckel2016-06-271-0/+7
| |
| * update_service: remove trailing whitespaceBen Boeckel2016-06-271-1/+1
| |
| * docs: fix some typosBen Boeckel2016-06-272-44/+44
| |
* | Merge branch 'patch-3' into 'master' Achilleas Pipinellis2016-07-091-1/+1
|\ \ | | | | | | | | | | | | | | | | | | Fix phpunit command in the docker example. Closes https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/issues/1478 See merge request !5147
| * | gitlab-org/gitlab-ci-multi-runner#1478 Fixed phpunit command in the official ↵kujiy2016-07-081-1/+1
| | | | | | | | | | | | | | | doc didn't work. Curl command has to follow redirects now.
* | | Merge branch 'patch-3' into 'master' Achilleas Pipinellis2016-07-091-1/+1
|\ \ \ | | | | | | | | | | | | | | | | Fix wrong gitlab-shell version in 8.9-8.10 update guide See merge request !5153
| * | | Wrong gitlab-shell versionChristian Decker2016-07-081-1/+1
| | | |
* | | | Merge branch 'doc-custom-hooks' into 'master' Achilleas Pipinellis2016-07-091-1/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix typo and explain the precedence of STDERR and STDOUT ## What does this MR do? Addresses comments https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5088#note_12884564 See merge request !5169
| * | | | Fix typo and explain the precedence of STDERR and STDOUTAchilleas Pipinellis2016-07-091-1/+2
| | | | |
* | | | | Merge branch 'dz-subnav-darker' into 'master' Dmitriy Zaporozhets2016-07-092-9/+7
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make subnavigation a bit darker color See merge request !5166
| * | | | | Make subnavigation a bit darker colorDmitriy Zaporozhets2016-07-092-9/+7
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | | | | Merge branch 'dz-button-capitalize' into 'master' Dmitriy Zaporozhets2016-07-091-1/+2
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update ui_guide.md with button capitalize rule cc @jschatz1 @hazelyang @skyruler See merge request !5161
| * | | | | Update ui_guide.md with button capitalize ruledz-button-capitalizeDmitriy Zaporozhets2016-07-081-1/+2
|/ / / / /
* | | | | Merge branch 'new-snippet-button-permissions' into 'master' Fatih Acet2016-07-085-44/+47
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update New Snippet buttons. ## What does this MR do? No longer shows New Snippet button to users who aren't able to create a new snippet in the given context. Also removes the plus icon from the New Snippet buttons, as they're no longer used in other creation buttons. ## Are there points in the code the reviewer needs to double check? Make sure the snippets pages don't break or show the buttons to users who shouldn't have access to them. ## Why was this MR needed? Users that weren't logged in would click the New Snippet button and get a 404 error. You would also get 404 errors from the New Snippet button on project snippets for projects you weren't able to create snippets for. ## What are the relevant issue numbers? Fixes #14595. ## Screenshots (if relevant) Before: ![before1](/uploads/2c222cd981332d30772054cefadafa28/before1.png) ![before2](/uploads/2734f8a84ae293b08dd982f2ed7da028/before2.png) After: ![after1](/uploads/c84aa9aec17056095271b0f24c6e9b5b/after1.png) ![after2](/uploads/70fe37ad7be5054bf20439ca0a1f5ccc/after2.png) ![after3](/uploads/afcd435c211482e9df25cb8971f1e65e/after3.png) ![after4](/uploads/9eab87440aae4991b508373ff36e3c7a/after4.png) ![after5](/uploads/f5ec167cb3e1115d3b3a43bd5231bc60/after5.png) ![after6](/uploads/c774cbb1f9babe3382ff69af7060b9c5/after6.png) ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !4998
| * | | | | Use btn-danger for delete button.Connor Shea2016-07-081-1/+1
| | | | | |
| * | | | | Update New Snippet buttons.Connor Shea2016-07-085-43/+46
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | No longer shows New Snippet button to users who aren't able to create a new snippet in the given context. Also removes the plus icon from the New Snippet buttons, as they're no longer used in other creation buttons. Fixes #14595.
* | | | | Merge branch 'cs-cropper' into 'master' Fatih Acet2016-07-0818-4/+25
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Split Cropper.js from the main JavaScript manifest. ## What does this MR do? Splits Cropper.js from the main JavaScript file. ## Are there points in the code the reviewer needs to double check? That the avatar uploader works. (It did in my testing) ## Why was this MR needed? Smaller JS payload. ## What are the relevant issue numbers? #14372 ## Does this MR meet the acceptance criteria? - Tests - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !4978
| * | | | | Fix preferences tests.cs-cropperConnor Shea2016-06-3010-3/+12
| | | | | |
| * | | | | Add a helper function for getting the page path from JS.Connor Shea2016-06-292-3/+6
| | | | | |
| * | | | | Split Cropper.js from the main JavaScript manifest.Connor Shea2016-06-298-2/+11
| | | | | |
* | | | | | Merge branch 'improve-project-limit-field' into 'master' Rémy Coutable2016-07-082-1/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add min attribute to projects_limit field on user's form This PR adds `min=0` attribute to `:projects_limit` field on user's form in the admin panel. It improves UX disallowing user to enter negative values in this field. ![](http://take.ms/70V8W) See merge request !3622
| * | | | | | Add min attribute to project_limit field on user's formAndrey Krivko2016-07-082-1/+2
| | | | | | |
* | | | | | | Merge branch 'fix_gemfile' into 'master' Rémy Coutable2016-07-081-50/+50
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix gemfile 1. replace `"` to `'` in Gemfile. 2. change `require: nil` to `require: false`. `require: nil` and `require: false` get same result, but i think we shouldn't write it differently in other places. 3. set version for gems. better gem's version control for prevent dependency errors. See merge request !5078
| * | | | | | | set version for gems.bogdanvlviv2016-07-041-15/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | better gem's version control for prevent dependency errors.
| * | | | | | | change `require: nil` to `require: false`bogdanvlviv2016-07-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | require: nil and require: false get same result, but i think we shouldn't write it differently in other places.
| * | | | | | | replace " to ' in Gemfilebogdanvlviv2016-07-041-36/+36
| | | | | | | |
* | | | | | | | Merge branch 'rubocop/enable-identical-conditional-branches-cop' into 'master' Robert Speicher2016-07-085-30/+13
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enable Style/IdenticalConditionalBranches Rubocop cop ## What does this MR do? This MR enables Rubocop cop that checks for identical lines at the end of each branch of a conditional statement. Examples: ```ruby @bad if condition do_x do_z else do_y do_z end @good if condition do_x else do_y end do_z ``` ## What are the relevant issue numbers? #17478 See merge request !5011
| * | | | | | | | Remove legacy conditional from irker service coderubocop/enable-identical-conditional-branches-copGrzegorz Bizon2016-07-081-8/+0
| | | | | | | | |
| * | | | | | | | Enable Style/IdenticalConditionalBranches Rubocop copGrzegorz Bizon2016-07-085-23/+14
| | | | | | | | |
* | | | | | | | | Merge branch 'retrieve-mr-closes-issues-just-when-required' into 'master' Rémy Coutable2016-07-084-9/+8
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid calculation of closes_issues. ## What does this MR do? Avoid unneeded calls to MR closes issues ## Are there points in the code the reviewer needs to double check? I'm not sure if calling this method from a view is a good practice, but I cannot see another simple way of avoiding this problem. In case we want to avoid this in the controller we need to specify the action, format and status of the merge request, because in that case we know that the `_open` partial will render. We could add some lazy evaluation but it not a thing I see in use along the app but feedback is welcome ## What are the relevant issue numbers? #14202 , #19490 ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - ~~[ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~ - ~~[ ] API support added~~ - Tests - ~~[ ] Added for this feature/bug~~ - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5140
| * | | | | | | | | Avoid calculation of closes_issues.retrieve-mr-closes-issues-just-when-requiredPaco Guzman2016-07-074-9/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We just need to get merge requests closes issues when we’re going to show them
* | | | | | | | | | Merge branch 'fix-broken-mysql-migration' into 'master' Robert Speicher2016-07-081-2/+2
|\ \ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix broken migration in MySQL `keys` is a reserved name in MySQL, so if this migration actually attempted to remove any duplicate keys it would fail. Closes #19344 See merge request !5005
| * | | | | | | | | Fix missing quote_table_nameStan Hu2016-06-291-1/+1
| | | | | | | | | |
| * | | | | | | | | Fix broken migration in MySQLStan Hu2016-06-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #19344
* | | | | | | | | | Merge branch 'edgemaster/gitlab-ce-patch-missing-api-docs'Rémy Coutable2016-07-081-0/+3
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See !4096. Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | | | | | | | | | API Docs: Add missing project option shared_runners_enabledThomas Wood2016-05-091-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduced into the API in e80e3f53 [ci skip]
* | | | | | | | | | | Merge branch 'clarify-github-integration-docs' into 'master' Rémy Coutable2016-07-081-1/+1
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix documentation for Github integration authorization callback url. There are two callbacks that could be used with Github integration: * /import/github/callback (used by project import) * /users/auth/github/callback (used by OmniAuth) Github's documentation suggests that authorization callback url should be set to the longest common path. https://developer.github.com/v3/oauth/#redirect-urls Configuring according to the previous documentation resulted in a redirect_uri_mismatch error from Github when logging in via OmniAuth. See merge request !4111
| * | | | | | | | | | | Fix documentation for Github integration authorization callback url.Eric K Idema2016-05-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are two callbacks that could be used with Github integration: * /import/github/callback (used by project import) * /users/auth/github/callback (used by OmniAuth) Github's documentation suggests that authorization callback url should be set to the longest common path. https://developer.github.com/v3/oauth/#redirect-urls Configuring according to the previous documentation resulted in a redirect_uri_mismatch error from Github when logging in via OmniAuth.
* | | | | | | | | | | | Merge branch 'fix-changelog-typo' into 'master' Stan Hu2016-07-081-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix CHANGELOG typo: by_pass -> bypass See merge request !5048
| * | | | | | | | | | | | Fix CHANGELOG typo: by_pass -> bypassStan Hu2016-07-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | | | | | | | Merge branch 'yatish27/gitlab-ce-project-commit-range-comment' into 'master' Rémy Coutable2016-07-081-2/+2
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix comment for project argument in commit_range.rb ## What does this MR do? It fixes the documentation for commit_range project argument ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? ## What are the relevant issue numbers? ## Screenshots (if relevant) ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - [ ] Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !4805
| * | | | | | | | | | | | | Fix comment for project argument in commit_range.rbYatish Mehta2016-06-201-2/+2
| | | | | | | | | | | | | |
* | | | | | | | | | | | | | Merge branch '1548-average-commits-per-day' into 'master' Rémy Coutable2016-07-082-1/+40
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix: Infinity Bug in Commit Statistics ## What does this MR do? It fixes a logic bug in the commits statistics: The code assumed that the amount of days involved in a commit range is equal to the difference between the first and last date. This is not true, though, as (from a human standpoint), a commit yesterday and a commit today involve two days, not one. Similarly, a fresh project with only commits made today already 'used' one day. Since the number of involved days used to be zero for new projects, the result for commits per day quite often amounted to `Infinity`… ## Are there points in the code the reviewer needs to double check? The test file. I hope it is up to the standards of GitLab. ## Why was this MR needed? The bug occurres especially for new users with their first project while exploring GitLab. ## What are the relevant issue numbers? This bug was reported as #1548. ## Screenshots (if relevant) See merge request !4231
| * | | | | | | | | | | | | | Infinity Bug in Commit StatisticsJonas Weber2016-05-202-1/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixes #1548
* | | | | | | | | | | | | | | Merge branch 'dont-render-discussion-notes-on-not-html-requests'Douwe Maan2016-07-083-24/+35
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | | | Don't render discussion notes when requesting diff tab through AJAXdont-render-discussion-notes-on-not-html-requestsPaco Guzman2016-07-083-24/+35
| | |_|_|_|_|_|_|_|_|_|_|_|/ / | |/| | | | | | | | | | | | |
* | | | | | | | | | | | | | | Merge branch 'patch-1' into 'master' Rémy Coutable2016-07-081-1/+1
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed Typo in README.md ## What does this MR do? Found a Typo in the README.md file. before_script should be with ":" Script didn't work for me without ":" ## Why was this MR needed? Missing ":" can be irritating for new users. See merge request !4419
| * | | | | | | | | | | | | | | Fixed Typo in README.mdPhilipp Kraus2016-06-011-1/+1
| | | | | | | | | | | | | | | |