summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'ce-9445-kerberos-clone-url-is-no-longer-visible' into 'master'cherry-pick-c9e5ce8dKushal Pandya2019-03-062-2/+4
| | | | | | | | | Backport Kerberos clone URL to CE See merge request gitlab-org/gitlab-ce!25750 (cherry picked from commit c9e5ce8dbd25203484b43c48f0a55a5d7bf396e8) c0a97cf5 Backport Kerberos clone URL to CE
* Update VERSION to 11.8.1v11.8.1GitLab Release Tools Bot2019-02-281-1/+1
|
* Update CHANGELOG.md for 11.8.1GitLab Release Tools Bot2019-02-2822-107/+27
| | | [ci skip]
* Merge branch '11-8-security-2774-milestones-detail' into '11-8-stable'Robert Speicher2019-02-274-4/+112
|\ | | | | | | | | Display only information visible to current user on Milestone detail See merge request gitlab/gitlabhq!2917
| * Display only informaton visible to current userJarka Košanová2019-02-274-4/+112
|/ | | | | | Display only labels and assignees of issues visible by the currently logged user Display only issues visible to user in the burndown chart
* Merge branch 'security-id-fix-mr-visibility-11-8' into '11-8-stable'Yorick Peterse2019-02-277-213/+335
|\ | | | | | | | | Display the correct number of MRs a user has access to See merge request gitlab/gitlabhq!2929
| * Display the correct number of MRs a user has access toIgor Drozdov2019-02-277-213/+335
|/
* Merge branch 'security-2818_filter_impersonated_sessions-11-8' into ↵Yorick Peterse2019-02-278-52/+38
|\ | | | | | | | | | | | | '11-8-stable' Filter impersonated sessions from active sessions and remove ability to revoke session See merge request gitlab/gitlabhq!2981
| * Remove ability to revoke active sessionImre Farkas2019-02-276-49/+7
| | | | | | | | | | | | Session ID is used as a parameter for the revoke session endpoint but it should never be included in the HTML as an attacker could obtain it via XSS.
| * Filter active sessions belonging to an admin impersonating the userImre Farkas2019-02-274-4/+32
| |
* | Merge branch 'security-id-restricted-access-to-private-repo-11-8' into ↵Yorick Peterse2019-02-275-60/+137
|\ \ | | | | | | | | | | | | | | | | | | '11-8-stable' Forbid creating discussions for users with restricted access See merge request gitlab/gitlabhq!2890
| * | Forbid creating discussions for users with restricted accessIgor Drozdov2019-02-075-60/+137
| | |
* | | Merge branch '11-8-security-2773-milestones-fix' into '11-8-stable'Yorick Peterse2019-02-2719-73/+187
|\ \ \ | | | | | | | | | | | | | | | | Check issue milestone availability See merge request gitlab/gitlabhq!2904
| * | | Check issue milestone availabilityJarka Košanová2019-02-1319-73/+187
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add project when creating milestone in specs We validate milestone is from the same project/parent group as issuable -> we need to set project in specs correctly Improve methods names and specs organization
* | | | Merge branch 'security-tags-oracle-11-8' into '11-8-stable'Yorick Peterse2019-02-273-0/+23
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Prevent Releases links API to leak tag existence See merge request gitlab/gitlabhq!2908
| * | | | Prevent Releases links API to leak tag existanceAlessio Caiazza2019-02-133-0/+23
| |/ / /
* | | | Merge branch 'security-2798-fix-boards-policy-11-8' into '11-8-stable'Yorick Peterse2019-02-273-8/+19
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Disable issue board policies when issues are disabled See merge request gitlab/gitlabhq!2910
| * | | | Disable board policies when issues are disabledHeinrich Lee Yu2019-02-143-8/+19
| | | | | | | | | | | | | | | | | | | | Board list policies are also included
* | | | | Merge branch '11-8-security-2797-milestone-mrs' into '11-8-stable'Yorick Peterse2019-02-274-4/+61
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Show only MRs visible to user on milestone detail See merge request gitlab/gitlabhq!2923
| * | | | | Show only MRs visible to user on milestone detailJarka Košanová2019-02-144-4/+61
| |/ / / /
* | | | | Merge branch 'security-commit-private-related-mr-11-8' into '11-8-stable'Yorick Peterse2019-02-276-6/+65
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Don't allow non-members to see private related MRs See merge request gitlab/gitlabhq!2930
| * | | | | Don't allow non-members to see private related MRsPatrick Bajao2019-02-156-6/+65
| | | | | |
* | | | | | Merge branch 'security-kubernetes-google-login-csrf-11-8' into '11-8-stable'Yorick Peterse2019-02-273-30/+67
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Validate session key when authorizing with GCP to create a cluster See merge request gitlab/gitlabhq!2934
| * | | | | | Validate session key when authorizing with GCP to create a clusterTiger2019-02-193-30/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was previously possible to link a GCP account to another user's GitLab account by having them visit the callback URL, as there was no check that they were the initiator of the request. We now reject the callback unless the state parameter matches the one added to the initiating user's session.
* | | | | | | Merge branch 'security-50334-11-8' into '11-8-stable'Yorick Peterse2019-02-275-66/+82
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix git clone revealing private repo's presence See merge request gitlab/gitlabhq!2938
| * | | | | | | Fix git clone revealing private repo's presenceMark Chao2019-02-195-66/+82
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ensure redirection to path with .git suffix regardless whether project exists or not.
* | | | | | | Merge branch 'security-56348-11-8' into '11-8-stable'Yorick Peterse2019-02-275-2/+60
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Check snippet attached file to be moved is within designated directory See merge request gitlab/gitlabhq!2941
| * | | | | | | Check snippet attached file to be moved is within designated directoryMark Chao2019-02-215-2/+60
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously one could move any temp/ sub folder around. Align spec with actual usage, as currently we pass temp file path to FileMover.
* | | | | | | Merge branch 'security-55468-check-validity-before-querying-11-8' into ↵Yorick Peterse2019-02-273-19/+53
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '11-8-stable' Fix blind SSRF in Prometheus Integration See merge request gitlab/gitlabhq!2944
| * | | | | | | Check validity of prometheus_service before queryReuben Pereira2019-02-273-19/+53
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Check validity before querying so that if the dns entry for the api_url has been changed to something invalid after the model was saved and checked for validity, it will not query. This is to solve a toctou (time of check to time of use) issue.
* | | | | | | Merge branch 'security-protect-private-repo-information-11-8' into '11-8-stable'Yorick Peterse2019-02-276-22/+85
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix leaking private repository information in API See merge request gitlab/gitlabhq!2948
| * | | | | | | Add changelog entryLuke Duncalfe2019-02-211-0/+5
| | | | | | | |
| * | | | | | | Removing sensitive properties from ProjectTypeLuke Duncalfe2019-02-201-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | defaultBranch and ciConfigPath should only be available to users with the :download_code permission for the Project, as the respository might be private. When implementing the authorize check on these properties, it was found that our current Graphql::Authorize::Instrumentation class does not work with fields that resolve to subclasses of GraphQL::Schema::Scalar, like GraphQL::STRING_TYPE. After discussion with other Create Team members, it has been decided that because the GraphQL API is not GA, to remove these properties from ProjectType, and instead implement them as part of epic https://gitlab.com/groups/gitlab-org/-/epics/711 Issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/55316
| * | | | | | | Prevent leaking of private repo data through APILuke Duncalfe2019-02-204-20/+80
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | default_branch, statistics and config_ci_path are now only exposed if the user has permissions to the repository.
* | | | | | | | Merge branch 'security-fj-diff-import-file-read-fix-11-8' into '11-8-stable'Yorick Peterse2019-02-2710-4/+103
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Arbitrary file read via MergeRequestDiff See merge request gitlab/gitlabhq!2951
| * | | | | | | | Arbitrary file read via MergeRequestDiffFrancisco Javier López2019-02-2710-4/+103
|/ / / / / / / /
* | | | | | | | Merge branch '11-8-security-2799-emails' into '11-8-stable'Yorick Peterse2019-02-275-17/+60
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove link after issue move when no permissions See merge request gitlab/gitlabhq!2955
| * | | | | | | | Remove link after issue move when no permissionsJarka Košanová2019-02-225-17/+60
| | |_|_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't show new issue link after move when a user does not have permissions to display the new issue
* | | | | | | | Merge branch 'security-kubernetes-local-ssrf-11-8' into '11-8-stable'Yorick Peterse2019-02-275-1/+60
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Block local URLs for Kubernetes integration See merge request gitlab/gitlabhq!2959
| * | | | | | | | Do not allow local urls in Kubernetes formThong Kuah2019-02-215-1/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use existing `public_url` validation to block various local urls. Note that this validation will allow local urls if the "Allow requests to the local network from hooks and services" admin setting is enabled. Block KubeClient from using local addresses It will also respect `allow_local_requests_from_hooks_and_services` so if that is enabled KubeClinet will allow local addresses
* | | | | | | | | Merge branch ↵Yorick Peterse2019-02-2710-13/+85
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'security-add-public-internal-groups-as-members-to-your-project-idor-11-8' into '11-8-stable' Add public/internal groups as members to your Project(IDOR) See merge request gitlab/gitlabhq!2962
| * | | | | | | | | Change policy regarding group visibilityMałgorzata Ksionek2019-02-2010-13/+85
| | |_|/ / / / / / | |/| | | | | | |
* | | | | | | | | Merge branch 'security-osw-stop-linking-to-packages-11-8' into '11-8-stable'Yorick Peterse2019-02-2720-51/+207
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Stop linking to unrecognized package sources See merge request gitlab/gitlabhq!2969
| * | | | | | | | | Add changelogOswaldo Ferreira2019-02-261-0/+5
| | | | | | | | | |
| * | | | | | | | | Raise not implemented error on BaseLinker for package_urlOswaldo Ferreira2019-02-251-0/+4
| | | | | | | | | |
| * | | | | | | | | Stop linking to unrecognized package sourcesOswaldo Ferreira2019-02-2419-51/+198
| | |_|/ / / / / / | |/| | | | | | |
* | | | | | | | | Merge branch 'security-issue_54789_2-11-8' into '11-8-stable'Yorick Peterse2019-02-273-0/+44
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [11.8] Prevent disclosing project milestone titles See merge request gitlab/gitlabhq!2973
| * | | | | | | | | Prevent disclosing project milestone titlesFelipe Artur2019-02-253-0/+44
| |/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prevent unauthorized users having access to milestone titles through autocomplete endpoint.
* | | | | | | | | Merge branch 'security-mermaid-11-8' into '11-8-stable'Yorick Peterse2019-02-273-0/+27
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | Limit number of characters allowed in mermaidjs See merge request gitlab/gitlabhq!2978
| * | | | | | | | Limit number of characters allowed in mermaidjsRajat Jain2019-02-273-0/+27
| | |/ / / / / / | |/| | | | | |