| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
It's possible that area is not present in a role, then we should handle
`nil` value too.
|
| |\
| |
| |
| |
| | |
Don't set tags for the reports jobs
See merge request gitlab-org/gitlab-ce!32276
|
| | |
| |
| |
| | |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Replace prepend_entity with prepend_if_ee helper
Closes gitlab-ee#13639
See merge request gitlab-org/gitlab-ce!32214
|
| |/ /
| |
| |
| | |
(cherry picked from commit 897a9d308db46b620b738b98f2b0e5630ac7d2dd)
|
| |\ \
| |/
|/|
| |
| | |
CE-backport: Move create cluster Vue apps to create_cluster directory.
See merge request gitlab-org/gitlab-ce!32220
|
| |/
|
|
|
|
|
|
|
|
|
| |
This commit creates a create_cluster directory to collect
all Vue applications related to creating kubernetes applications
using gitlab.
It also moves the gke_cluster_dropdowns collection of apps to
the create_cluster directory. gke_cluster_dropdowns contains
dropdown components used to select configuration options to
create a Kubernetes cluster in Google Cloud.
|
| |\
| |
| |
| |
| |
| |
| |
| |
| | |
'65312-use-group-labels-instead-of-legacy-team-labels-for-danger-picking-test-reviewers' into 'master'
Detect the new stage labels in `Gitlab::Danger::Teammate`
Closes #65312
See merge request gitlab-org/gitlab-ce!32261
|
| | |
| |
| |
| | |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
'66641-broken-master-real-http-connections-are-disabled-unregistered-request' into 'master'
Use `stub_full_request` to fix spec failure
Closes #66641
See merge request gitlab-org/gitlab-ce!32259
|
| | | |
| | |
| | |
| | | |
Also change test URL sequest to .test TLD
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Removes trailing whitespace to fix linting
See merge request gitlab-org/gitlab-ce!32265
|
| |/ / / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add nil check for Gitlab.config.prometheus
Closes #13806
See merge request gitlab-org/gitlab-ce!32201
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Update the syntax of DAG example
See merge request gitlab-org/gitlab-ce!32137
|
| | | | | | |
|
| |\ \ \ \ \
| |_|_|_|/
|/| | | |
| | | | |
| | | | | |
Update DB migrations style guide: prefer atomic migrations when possible
See merge request gitlab-org/gitlab-ce!31915
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently, the DB migrations guide says that "you must" use non-blocking
operations (such as CREATE INDEX CONCURRENTLY), always.
But this does not make sense in cases of empty tables and leads to
splitting the work to multiple non-atomic
(with disable_ddl_transaction!) DB migrations.
To follow KISS principle, to have fewer DB migrations steps,
to have them atomic when it's possible and simplify deployment
and troubleshooting, the following exceptions were added
to the doc:
- index creation,
- index dropping,
- defining an FK,
- adding a column with DEFAULT,
|
| |\ \ \ \
| |_|_|/
|/| | |
| | | |
| | | | |
Run markdownlint before Nanoc checks
See merge request gitlab-org/gitlab-ce!32256
|
| |/ / /
| | |
| | |
| | |
| | | |
Make it simpler to run markdownlint by moving it before
we do those hacks to run Nanoc.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Promote Label to Group Label via API endpoint
Closes #57657
See merge request gitlab-org/gitlab-ce!25218
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Update index of feature flags
See merge request gitlab-org/gitlab-ce!32217
|
| |/ / / /
| | | |
| | | |
| | | |
| | | | |
Made it clear the pages are about feature flags,
and not documentation.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Update capitalization in /dev docs
See merge request gitlab-org/gitlab-ce!32189
|
| |/ / / /
| | | |
| | | |
| | | |
| | | | |
Clean up capitalization in /development /gitlab-basics and
/install
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Update capitalization in /integrations and /raketasks
See merge request gitlab-org/gitlab-ce!32241
|
| |/ / / /
| | | |
| | | |
| | | | |
Also updates redirect text in /project-services
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Remove N+1 SQL query loading project feature in dashboard
Closes #66482
See merge request gitlab-org/gitlab-ce!32169
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Projects that have a pipeline may need to check whether the user has
permission to read the build (`can?(current_user, :read_build,
project)`), which requires checking the `project_features` table.
This would cause an N+1 SQL query for each project.
This change also has a beneficial side effect that may avoid a race
condition. When a user deletes a project, the project is queued for
deletion and the user is redirected back to the dashboard page. However,
the following may happen:
1. The dashboard page may load this deleted project in the list of
20 projects.
2. The view will load the project pipeline status from the cache and
attempt to show each project.
3. When the view encounters the deleted project, it calls
`can?(current_user, :read_build, project)` to determine whether to
display the pipeline status.
4. Sidekiq deletes the project from the database.
5. However, since the deleted project is still loaded in memory, it will
attempt to call `project.project_feature.access_level`.
6. Since `project_feature` was not eager loaded, a lazy `SELECT` call is
made to the database.
7. This `SELECT` call returns nothing, and the user sees a 500 error.
By eager loading `project_feature`, we can ensure that we have a
consistent view and avoid records from being deleted later.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66482
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[#2838] add cache override explanation
See merge request gitlab-org/gitlab-ce!32024
|
| |/ / / / / |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Update `only` `chat` statement to correct singular form
See merge request gitlab-org/gitlab-ce!32116
|
| |/ / / / / |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Remove passing tests from quarantine
Closes gitlab-org/quality/nightly#127
See merge request gitlab-org/gitlab-ce!32237
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Add missing blank line to omniauth doc
See merge request gitlab-org/gitlab-ce!32250
|
| |/ / / / / / |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Resolve "Store deploy tokens encrypted"
Closes #63502
See merge request gitlab-org/gitlab-ce!30679
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | | |
|
