| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
This solves an N+1 query problem where we'd run multiple queries when
getting the namespace owners of the displayed projects.
|
| |\
| |
| |
| |
| |
| |
| | |
Rework how recent push events are retrieved
Closes #35990
See merge request !13995
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Whenever you push to a branch GitLab will show a button to create a
merge request (should one not exist already). The underlying code to
display this data was quite inefficient. For example, it involved
multiple slow queries just to figure out what the most recent push event
was.
This commit changes the way this data is retrieved so it's much faster.
This is achieved by caching the ID of the last push event on every push,
which is then retrieved when loading certain pages. Database queries are
only executed if necessary and the cached data is removed automatically
once a merge request has been created, or 2 hours after being stored.
A trade-off of this approach is that we _only_ track the last event.
Previously if you were to push to branch A and B then create a merge
request for branch B we'd still show the widget for branch A. As of this
commit this is no longer the case, instead we will only show the widget
for the branch you pushed to most recently. Once a merge request exists
the widget is no longer displayed. Alternative solutions are either too
complex and/or too slow, hence the decision was made to settle for this
trade-off.
Performance Impact
------------------
In the best case scenario (= a user didn't push anything for more than 2
hours) we perform a single Redis GET per page. Should there be cached
data we will run a single (and lightweight) SQL query to get the
event data from the database. If a merge request already exists we will
run an additional DEL to remove the cache key.
The difference in response timings can vary a bit per project. On
GitLab.com the 99th percentile of time spent in User#recent_push hovers
between 100 milliseconds and 1 second, while the mean hovers around 50
milliseconds. With the changes in this MR the expected time spent in
User#recent_push is expected to be reduced down to just a few
milliseconds.
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/35990
|
| |\ \
| | |
| | |
| | |
| | | |
Remove ignore rule for GpgSignature#valid_signature
See merge request !14050
|
| | | |
| | |
| | |
| | | |
This reverts commit cce9afa38a8aa3f3e5a43ab952e1c022c9dd9385.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Remove unused extra hr in preferences
Closes #37603
See merge request !14127
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Reduce top and bottom margin on file viewer on mobile
See merge request !14114
|
| | |/ / / |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Correctly associate ConvDev Index nav link with its controller
Closes #37583
See merge request !14124
|
| | |/ / / |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Remove confidential toggle checkbox while editing issue inline
Closes #37454
See merge request !14142
|
| | | | | | |
|
| |\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Check for sidebar cookie instead of class when resizing window
Closes #37642
See merge request !14151
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Bump grape_logging gem to 1.7.0 to get status codes for error messages
See merge request !14175
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
This recent update fixes an issue in grape_logging where the status
code would be "fail" for any non-20x responses. For more details, see:
https://github.com/aserafin/grape_logging/issues/29
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Remove bootlint which takes 1 second of render time on development
Closes #37657
See merge request !14167
|
| |/ / / / |
|
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | | |
Adds drop shadow to the expanded sidebar
Closes #36750 and #13983
See merge request !13994
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
Shadow is added in sm & md breakpoints. Clicking the anything outside of
the sidebar also hides collapses the sidebar at these breakpoints.
Closes #13983
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Revert "Add option to change navigation color palette"
See merge request !14148
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
'35012-navigation-add-option-to-change-navigation-color-palette' into 'master'"
This reverts merge request !13619
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
[CE] Fix small typos in LDAP documentation
See merge request !14153
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Docs: quick fix - indexes project settings
See merge request !14158
|
| | | | | | | |
|
| | | | | | | |
|
| |/ / / / / |
|
| |\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
Fix GitLab QA for new navigation enabled by default
See merge request !14134
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Update dependencies license list for 10.0
See merge request !14137
|
| | |/ / / / |
|
| |\ \ \ \ \
| |_|/ / /
|/| | | |
| | | | |
| | | | | |
Update license templates for 10.0
See merge request !14136
|
| | |/ / / |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Docs new index for project's settings
Closes #35719
See merge request !13552
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Fix tooltip width on collapsed issue board column titles
See merge request !14129
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Clarify yaml hidden keys (jobs)
Closes #37480
See merge request !14110
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Tweak column widths on two factor warning messages
See merge request !14112
|
| |/ / / / / |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Adds a better explanation for alignment section
Closes #32071
See merge request !14109
|
| |/ / / / / |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Resolve "Wrong link for write test in CONTRIBUTING.md"
Closes #37618
See merge request !14138
|
| | | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
update gpg_signed_commit to use 0xLONG format for gpg list keys
See merge request !13839
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Print notes number explained in the graph.
Closes #37224
See merge request !13949
|
