| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Hopefully reduce the rate of this intermittent failure in CI
Closes #31128
See merge request !12567
|
| | |
| |
| |
| | |
14 to 2, but these shared examples are used twice. This was already done in another context further down the file.
|
| | | |
|
| | |
| |
| |
| | |
By default it is 2 tries in CI.
|
| |\ \
| | |
| | |
| | |
| | | |
Strings ready for translation; Pipeline charts
See merge request !12480
|
| | | |
| | |
| | |
| | |
| | | |
Earlier, this was part of another MR, but that got split. Didn't pick
that commit, as there were many merge conflicts. Vim macros seemed faster.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
CE counterpart of: Namespace license checks for multiple assignees
See merge request !11825
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Set the assignee to last user in the array if multiple assignees aren't
allowed.
Also, use `parse_params` where possible.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
To make it simpler to assign users to an Issuable, make MergeRequest
support the attribute `assignee_ids`.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The /reassign quick command works even when no multiple assignees are allowed of
there isn't any assignee yet. So for consistency, it's also be backported to
CE. But it functions the same as the /assign quick action.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Avoid conflicts when merge CE to EE by backporting code from EE.
Instead of checking in `SlashCommands::InterpretService` what the issuable the
type of the issuable is, ask the issuable if it is capable to do those thing and
implement it in the issuable itself. The issuable will check if it's possible
and if the licensed feature is available.
This should also make it easier to ever add multiple assignees to MergeRequests.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The list of attributes for the filtered search input was getting long, so use a
helper method to fill that hash.
Also, for multiple issue assignees, a helper is more convenient because it would
allow EE to override the behavior if MIA is supported.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Avoid code duplication and limit the number of CE -> EE merge conflict by
reusing `FormHelper#issue_assignees_dropdown_options` to set some assignee
dropdown attributes.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
To make the code back in line with EE.
[ci skip]
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Only EE supports multiple issue assignees, so this CE code should not contain
code to have multiple assignees. EE will override the multiple issue assignees
feature by overriding this method.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Allow unauthenticated access to the `/api/v4/users` API
Closes #34141
See merge request !12445
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Rather than using an explicit check to turn off authentication for the
`/users` endpoint, simply call `authenticate_non_get!`.
- All `GET` endpoints we wish to restrict already call
`authenticated_as_admin!`, and so remain inacessible to anonymous users.
- This _does_ open up the `/users/:id` endpoint to anonymous access. It contains
the same access check that `/users` users, and so is safe for use here.
- More context: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12445#note_34031323
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Fix duplicate `prevent` declaration
- Add spec for `GlobalPolicy`
|
| | |\ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
34141-allow-unauthenticated-access-to-the-users-api
- Modify policy code to work with the `DeclarativePolicy` refactor
in 37c401433b76170f0150d70865f1f4584db01fa8.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- Use `GlobalPolicy` to authorize the users that a non-authenticated user can
fetch from `/api/v4/users`. We allow access if the `Gitlab::VisibilityLevel::PUBLIC`
visibility level is not restricted.
- Further, as before, `/api/v4/users` is only accessible to unauthenticated users if
the `username` parameter is passed.
- Turn off `authenticate!` for the `/api/v4/users` endpoint by matching on the actual
route + method, rather than the description.
- Change the type of `current_user` check in `UsersFinder` to be more
compatible with EE.
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- The issue filtering frontend code needs access to this API for non-logged-in
users + public projects. It uses the API to fetch information for a user by
username.
- We don't authenticate this API anymore, but instead - if the `current_user` is
not present:
- Verify that the `username` parameter has been passed. This disallows an
unauthenticated user from grabbing a list of all users on the instance. The
`UsersFinder` class performs an exact match on the `username`, so we are
guaranteed to get 0 or 1 users.
- Verify that the resulting user (if any) is accessible to be viewed publicly
by calling `can?(current_user, :read_user, user)`
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
wait_for_requests is not needed when AJAX is not in play
Closes #34647
See merge request !12626
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Also, using page.current_path instead of current_url and move the URL
expectation after the page content expectations.
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Don't resolve fork relationships for projects pending delete
See merge request !12603
|
| | | | | | | | | |
|
| | | | | | | | | |
|
| |\ \ \ \ \ \ \ \
| |_|/ / / / / /
|/| | | | | | |
| | | | | | | |
| | | | | | | | |
Clean up Gitaly tests
See merge request !12526
|
| | | | | | | | | |
|
| | | | | | | | | |
|
| | | | | | | | | |
|
| | | |_|/ / / /
| |/| | | | | |
|
| |\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
DeleteMergedBranchesService should not delete protected branches
Closes #34553
See merge request !12624
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
When deleting all the branches that are merged, the protected branches
should not be deleted.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Optimize creation of commit API by using Repository#commit instead of Repository#commits
See merge request !12623
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Repository#commits
Repository#commits is expensive because it has to use Rugged to walk the Git
tree as opposed to doing a direct ref lookup.
Improves performance in #34533
|
| |\ \ \ \ \ \ \ \
| |_|/ / / / / /
|/| | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Hide archived project labels from the group issue tracker
Closes #26389
See merge request !12547
|
| | | | | | | | | |
|
| |\ \ \ \ \ \ \ \
| |_|/ / / / / /
|/| | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Fixed the y_label not setting correctly for each graph on the monitoring dashboard
Closes #34599
See merge request !12613
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
dashboard
|
| | | | | | | | |
| | | | | | | |
| | | | | | | | |
[ci skip]
|
| |\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Update GITLAB_SHELL_VERSION to 5.1.1
See merge request !12615
|
| | | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Update to >= 5.1.0 needed for https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2240 on EE.
Updated here to keep CE and EE on the same version.
5.1.1 includes https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/142 to revert changes which were causing problems with Post Receive hooks.
|
| |\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Make autosize fields more performant and remove broken autosize handle
See merge request !12532
|
| |/ / / / / / / / / |
|
| |\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Make Project#ensure_repository force create a repo
Closes gitlab-ee#2800
See merge request !12580
|
| | | | | | | | | | | |
|
| | | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
In Geo, Project#ensure_repository is used to make sure that a Git repo
is available to be fetched on a secondary. If a project were a fork,
this directory would never be created.
Closes gitlab-org/gitlab-ee#2800
|
