| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
This will make it easier to perform in place adjustments, etc for future
MRs involving group clusters.
|
|
|
|
|
|
|
|
|
|
| |
Extracted from `Projects::ClustersController#new`, `#create_gcp`,
`#create_user` into new common module, with shared views and shared
examples. This will allow when we have Groups::ClustersController to
share most of the code.
Address ModuleWithInstanceVariables warnings by moving to render with
locals
|
|\
| |
| |
| |
| | |
Project::ClustersController spec improvement
See merge request gitlab-org/gitlab-ce!22346
|
| |
| |
| |
| |
| |
| | |
It has been pointed out that `go` is used quite extensively so it's not
an unknown idiam here at GitLab. And we have arguments with `go` which
is a plus.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Swap out `go` method with subject which is the convention.
Re-organize 'PUT update' to remove un-necessary context nesting.
DRY up repeated blocks to `add_maintainer` and `sign_in`
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
into 'master'
Resolve "Prometheus not showing as installed, even though it is"
Closes #51972
See merge request gitlab-org/gitlab-ce!22356
|
| | |
| | |
| | |
| | |
| | | |
Before this commit updating Prometheus (e.g. adding alerts) made it
"updated" therefore not installed.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Make source param optional according to EE change
See merge request gitlab-org/gitlab-ce!22283
|
| | | | |
|
|\ \ \ \
| |_|/ /
|/| | |
| | | |
| | | |
| | | |
| | | | |
Use InvalidUTF8ErrorHandler only for rails 4
Closes #51908
See merge request gitlab-org/gitlab-ce!22340
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In Rails 5 catches invalid UTF8 characters in querystring in a
params middleware, errors are handled by a params middleware and
raises a BadRequest exception. This means that these UTF8 errors
are not raised deeper in application stack and these can't also
be handled on application level.
If we would want to have custom handler for these errors, we would
have to create a new middleware and insert it before actionpack's
params middleware and rescue BadRequest exceptions there. But there
is no need to do this currently (see discussion on
https://gitlab.com/gitlab-org/gitlab-ce/issues/51908)
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Fix typo: 9.5.8 => 9.5.10
See merge request gitlab-org/gitlab-ce!22368
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Fix link to 'when delayed' YAML configuration item
See merge request gitlab-org/gitlab-ce!22349
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Does not allow a SSH URI when importing a project
See merge request gitlab-org/gitlab-ce!22309
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Revert "Merge branch 'ce-6983-promote-starting-a-gitlab-com-trial' into 'master'"
See merge request gitlab-org/gitlab-ce!22315
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
'master'"
This reverts merge request !21551
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Docs: Fixes image shadow
See merge request gitlab-org/gitlab-ce!22366
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Define Stage labels in issue workflow
See merge request gitlab-org/gitlab-ce!22313
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
'master'
docs remove reference to push rules as not yet implemented for groups
See merge request gitlab-org/gitlab-ce!22305
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| |_|_|_|/ / / /
|/| | | | | | |
| | | | | | | |
| | | | | | | | |
Replace `<i>` in vue components with `<icon>`
See merge request gitlab-org/gitlab-ce!20748
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Remove Koding integration and documentation
Closes #39697
See merge request gitlab-org/gitlab-ce!22334
|
| | | | | | | | |
|
| | |_|/ / / /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This integration no longer works and does not appear to be supported.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/39697
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
'52532-unable-to-toggle-issuable-sidebar-out-of-collapsed-state' into 'master'
Allow Issue and Merge Request sidebar to be toggled from collapsed state
Closes #52532
See merge request gitlab-org/gitlab-ce!22353
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
In [!21565][0] we removed the loadCheck function from the LazyLoader for
images. The function seemed to be obsolete before anyhow, because we
make use of the MutationObserver in order to detect elements added /
removed from the DOM.
[0]: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21565
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Add a new QA::ElementWithPattern cop
Closes #52516
See merge request gitlab-org/gitlab-ce!22298
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| | |_|_|/ / / /
| |/| | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This cop forbids the use of `element :foo, 'pattern'` and
`element :bar, /pattern/` in QA files.
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Allow getting the merge base of multiple revisions
Closes #52573
See merge request gitlab-org/gitlab-ce!22295
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
As we now support getting the merge base for multiple revisions in
gitaly, we can provide this functionality in our API
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Add documentation how to assign a merge request for review
See merge request gitlab-org/gitlab-ce!21327
|
| |/ / / / / / / / |
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Remove dependencies on Linguist
Closes #35450
See merge request gitlab-org/gitlab-ce!21008
|
| | |_|_|/ / / / /
| |/| | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
This saves about 128 MB of baseline RAM usage per Unicorn and
Sidekiq process (!).
Linguist wasn't detecting languages anymore from CE/EE since
9ae8b57467ac8b38f1fa9020a466d94a93cbb9dd. However, Linguist::BlobHelper
was still being depended on by BlobLike and others.
This removes the Linguist gem, given it isn't required anymore.
EscapeUtils were pulled in as dependency, but given Banzai depends on
it, it is now added explicitly.
Previously, Linguist was used to detect the best ACE mode. Instead,
we rely on ACE to guess the best mode based on the file extension.
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Refactor Cluster services to enable groups or projects
See merge request gitlab-org/gitlab-ce!22181
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
This enables us to have other options in the future such as passing in
`group:`.
Also, remove project arg from UpdateService, as un-used.
This will help group cluster controller to re-use this services.
|
|\ \ \ \ \ \ \ \ \ \
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
Fixes close/reopen quick actions preview for issues and merge_requests
Closes #52669
See merge request gitlab-org/gitlab-ce!22343
|
| | |_|_|_|_|_|_|/ /
| |/| | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Close/reopen quick actions preview wasn't shown properly, now the
preview is shown as expected.
|
|\ \ \ \ \ \ \ \ \ \
| |_|_|_|_|_|_|_|/ /
|/| | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
'master'
Fix code reuse issue in Projects::Clusters::ApplicationController#index
See merge request gitlab-org/gitlab-ce!22182
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Remove the inheritance from ::BaseService which is causing us to inherit
the initializer that has project as the first arg, as we will not have
access to project with forthcoming group clusters.
Also call install service from create service - 1 less thing to re-use
Extract TestRequest code into a spec helper. Given that we need
different behaviour for Rails 5.0 (and again in Rails 5.1!), it's handy
to have that branching behaviour in one place
|
| | |/ / / / / / /
| |/| | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
This should help with code re-use when we create applications for group
level cluster next.
Change `find_or_initialize_by` to explicitly find or build the right
association based on the application name. The benefit here is that we
use the associations on @cluster rather than querying from the other
side of the association.
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
'49417-improve-settings-pages-design-by-prioritizing-content-group-settings' into 'master'
Prioritize group settings, improve panel titles, disable submit without changes
Closes #49417
See merge request gitlab-org/gitlab-ce!21115
|