summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'sh-fix-issue-54189' into 'master'Steve Azzopardi2018-11-204-1/+37
|\ | | | | | | | | [master] Prevent templated services from being imported See merge request gitlab/gitlabhq!2634
| * Prevent templated services from being importedStan Hu2018-11-194-1/+37
| | | | | | | | | | | | | | Templated services should only be created by admins and does not apply to project import/export. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54189
* | Merge branch 'security-2717-xss-username-autocomplete' into 'master'Steve Azzopardi2018-11-203-10/+39
|\ \ | |/ |/| | | | | [master] Escape user fullname while rendering autocomplete template to prevent XSS See merge request gitlab/gitlabhq!2605
| * Add changelog entryKushal Pandya2018-11-121-0/+5
| |
| * Fix user name autocomplete XSS when name contains HTMLKushal Pandya2018-11-122-10/+34
| |
* | Update CHANGELOG.md for 11.4.6GitLab Release Tools Bot2018-11-181-0/+7
| | | | | | [ci skip]
* | Update CHANGELOG.md for 11.3.10GitLab Release Tools Bot2018-11-181-0/+7
| | | | | | [ci skip]
* | Merge branch '53700-hashed-storagemigration' into 'master'Stan Hu2018-11-163-1/+14
|\ \ | | | | | | | | | | | | | | | | | | Hashed Storage: allow migration to be retried in partially migrated projects Closes #53700 See merge request gitlab-org/gitlab-ce!23087
| * | Allow partially migrated repositories to continue migration53700-hashed-storagemigrationGabriel Mazetto2018-11-153-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | Previously we verified if the projecthave at least migrated their repository to hashed storage and prevented the migration command to start a new migration. The new version checks for the latest storage version available (fully migrated), otherwise it allows migration to be triggered again.
* | | Merge branch 'winh-application-css-pages' into 'master'Clement Ho2018-11-161-0/+2
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Provide application.css from master branch via GitLab Pages Closes gitlab-ui#95 See merge request gitlab-org/gitlab-ce!23156
| * | | Provide application.css from master branch via GitLab PagesWinnie Hellmann2018-11-161-0/+2
| | | |
* | | | Merge branch 'remove-unneeded-license-refs' into 'master'Clement Ho2018-11-162-9/+1
|\ \ \ \ | |/ / / |/| | | | | | | | | | | Remove unneeded licenses for gitlab-org npm namsepace See merge request gitlab-org/gitlab-ce!23155
| * | | Remove unneeded licenses for gitlab-org npm namsepaceMike Greiling2018-11-162-9/+1
| | | |
* | | | Merge branch 'docs-milestones-sprints-releases' into 'master'Victor Wu2018-11-161-0/+20
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Docs agile sprints and releases See merge request gitlab-org/gitlab-ce!22855
| * | | | Docs agile sprints and releasesVictor Wu2018-11-161-0/+20
|/ / / /
* | | | Merge branch '53813-test-compilation-against-multiple-node-versions' into ↵Mike Greiling2018-11-161-0/+33
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Check compilation of FE assets against multiple node versions Closes #53813 See merge request gitlab-org/gitlab-ce!23068
| * | | Check compilation of FE assets against multiple node versions53813-test-compilation-against-multiple-node-versionsLukas Eipert2018-11-141-0/+33
| | | |
* | | | Merge branch 'npm-namespace' into 'master'Mike Greiling2018-11-16105-122/+210
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use @gitlab npm namespace Closes gitlab-ui#65 See merge request gitlab-org/gitlab-ce!22629
| * | | | Use @gitlab npm namespaceClement Ho2018-11-16105-122/+210
|/ / / /
* | | | Merge branch 'docs-patch-31' into 'master'Achilleas Pipinellis2018-11-161-0/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | minor: format fix for GH import page See merge request gitlab-org/gitlab-ce!23152
| * | | | minor: format fix for GH import pagedocs-patch-31Cynthia Ng2018-11-161-0/+1
|/ / / /
* | | | Merge branch 'git-protocol-v2-docs' into 'master'yorick-revert-test-masterAchilleas Pipinellis2018-11-161-1/+9
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Add information on support for git v2 in docs See merge request gitlab-org/gitlab-ce!23138
| * | | | Add information on support for git v2 in docsBalasankar "Balu" C2018-11-161-1/+9
|/ / / /
* | | | Merge branch 'lm-update-architecture-docs' into 'master'Achilleas Pipinellis2018-11-161-23/+166
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Update architecture.md to have a component by component overview See merge request gitlab-org/gitlab-ce!22472
| * | | | Update architecture.md to have a component by component overviewLee Matos2018-11-161-23/+166
|/ / / /
* | | | Merge branch 'docs/fix_changelog_type_documentation' into 'master'Achilleas Pipinellis2018-11-161-9/+9
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Add missing `performance` to changelog type doc See merge request gitlab-org/gitlab-ce!22733
| * | | | Add missing `performance` to changelog type docdocs/fix_changelog_type_documentationPhilippe Lafoucrière2018-11-011-9/+9
| | | | |
* | | | | Merge branch 'validate-that-foreign-keys-are-created' into 'master'Sean McGivern2018-11-165-6/+189
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Validate that foreign keys are indexed and created Closes #50875 See merge request gitlab-org/gitlab-ce!22808
| * | | | | Add missing cluster_id on knativevalidate-that-foreign-keys-are-createdKamil Trzciński2018-11-152-0/+3
| | | | | |
| * | | | | Update CHANGELOGKamil Trzciński2018-11-152-7/+2
| | | | | |
| * | | | | Remove indexes for FKKamil Trzciński2018-11-151-1/+26
| | | | | |
| * | | | | Backport EE changesKamil Trzciński2018-11-151-1/+7
| | | | | |
| * | | | | Validate foreign keys being indexedKamil Trzciński2018-11-156-6/+160
| | | | | |
| * | | | | Merge remote-tracking branch 'origin/remove-rails5-gemfile'Kamil Trzciński2018-11-151-7/+0
| |\ \ \ \ \
* | \ \ \ \ \ Merge branch '41875-allow-pipelines-to-be-deleted-by-project-owners' into ↵Grzegorz Bizon2018-11-168-0/+193
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Resolve "Allow pipelines to be deleted by project owners" Closes #41875 See merge request gitlab-org/gitlab-ce!22988
| * | | | | | | Add spec for Pipeline DELETE for developers41875-allow-pipelines-to-be-deleted-by-project-ownersMatija Čupić2018-11-131-4/+21
| | | | | | | |
| * | | | | | | Raise exception when user is not authorizedMatija Čupić2018-11-132-9/+3
| | | | | | | |
| * | | | | | | Authorize DestroyPipelineService against pipelineMatija Čupić2018-11-135-4/+25
| | | | | | | |
| * | | | | | | Move pipeline delete docs to endMatija Čupić2018-11-131-17/+17
| | | | | | | |
| * | | | | | | Add docs for deleting a pipeline via APIMatija Čupić2018-11-121-0/+17
| | | | | | | |
| * | | | | | | Add CHANGELOG entryMatija Čupić2018-11-121-0/+5
| | | | | | | |
| * | | | | | | Destroy pipeline in serviceMatija Čupić2018-11-125-16/+93
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move all logic for destroying a Pipeline into a service so it's easily reusable.
| * | | | | | | Implement MVC for Pipeline deletion APIMatija Čupić2018-11-122-0/+62
| | | | | | | |
* | | | | | | | Merge branch 'gt-rename-diffs-store-variable' into 'master'Phil Hughes2018-11-165-9/+14
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename diffs store variable See merge request gitlab-org/gitlab-ce!23123
| * | | | | | | | Rename diffs store variableGeorge Tsiolis2018-11-155-9/+14
| | | | | | | | |
* | | | | | | | | Merge branch 'gt-replace-weight-icon-ce' into 'master'Kushal Pandya2018-11-161-0/+4
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace weight icon See merge request gitlab-org/gitlab-ce!23144
| * | | | | | | | | Replace weight iconGeorge Tsiolis2018-11-161-0/+4
| | | | | | | | | |
* | | | | | | | | | Merge branch 'refactor-enums-for-ee' into 'master'Robert Speicher2018-11-167-34/+82
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor how a few ActiveRecord enums are defined See merge request gitlab-org/gitlab-ce!23024
| * | | | | | | | | | Refactor how a few ActiveRecord enums are definedrefactor-enums-for-eeYorick Peterse2018-11-157-34/+82
| | |/ / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In a few models we define ActiveRecord enums that are redefined in EE using the following pattern: enum :some_enum, { ... }.merge(EE_ENUM_VALUES) This particular approach is problematic to deal with, because it requires that we `prepend` and EE module _before_ defining the enum. This typically translates to the `prepend` being the first line in the model in EE, but this can easily lead to merge conflicts when developers add more `include` and/or `prepend` lines. As part of https://gitlab.com/gitlab-org/gitlab-ee/issues/8244 and https://gitlab.com/gitlab-org/gitlab-ee/issues/8241 we are moving `prepend` to the last line in a file, reducing the chances of running into merge conflicts. This poses a bit of a problem with the pattern above, because this pattern does not allow us to move the `prepend` further down a file. To resolve this problem, we simply move the Hash value of the enum to a separate class method. This method is defined in a separate module where necessary, allowing us to use it like so: enum :failure_reasons, ::SomeModelEnums.failure_reasons The method in turn is defined in a very straightforward manner: module SomeModelEnums def self.failure_reasons { ... } end end This makes it easy for EE to add values without requiring the `prepend` to be placed before the `enum` is defined. For more information, see the following issues and merge requests: * https://gitlab.com/gitlab-org/gitlab-ee/issues/8244 * https://gitlab.com/gitlab-org/gitlab-ee/issues/8241 * https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8424
* | | | | | | | | | Merge branch 'image-discussion-ff-fix' into 'master'Filipa Lacerda2018-11-163-13/+10
|\ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed image discussion styling Closes #54110 See merge request gitlab-org/gitlab-ce!23127