summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Improve TeamcityService and its specsfix-trailing-slash-in-teamcity_url-3515Rémy Coutable2016-04-133-58/+203
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Fix a bug with trailing slash in teamcity_urlCharles May2016-04-122-13/+21
| | | | See https://gitlab.com/gitlab-org/gitlab-ce/issues/3515
* Merge branch 'dashboard-filter-milestone' into 'master' Jacob Schatz2016-04-112-1/+61
|\ | | | | | | | | | | | | Fixed issue with dashboard/issues not filtering by milestone Closes #15128 See merge request !3650
| * Fixed issue with dashboard/issues not filtering by milestonedashboard-filter-milestonePhil Hughes2016-04-112-1/+61
| | | | | | | | Closes #15128
* | Merge branch 'complexity/descrease-abc-size-threshold' into 'master' Dmitriy Zaporozhets2016-04-111-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | Decrease threshold for ABC Size metric in Rubocop To 55. References #3444 See merge request !3598
| * | Decrease threshold for ABC Size metric in Rubocopcomplexity/descrease-abc-size-thresholdGrzegorz Bizon2016-04-111-1/+1
| | | | | | | | | | | | To 60.
* | | Merge branch 'metrics-measure-block-transaction' into 'master' Yorick Peterse2016-04-115-40/+67
|\ \ \ | | | | | | | | | | | | | | | | Store block timings as transaction values See merge request !3649
| * | | Fixed stubbing for Gitlab::Metrics specsYorick Peterse2016-04-112-5/+13
| | | | | | | | | | | | | | | | | | | | | | | | If the measure method uses Transaction.current directly the SQL subscriber (Subscribers::ActiveRecord) will add timings of queries triggered by DB cleaner.
| * | | Track call counts in Gitlab::Metrics.measure_blockmetrics-measure-block-transactionYorick Peterse2016-04-113-3/+8
| | | |
| * | | Added specs for Gitlab::Metrics::System.cpu_timeYorick Peterse2016-04-111-0/+6
| | | |
| * | | Store block timings as transaction valuesYorick Peterse2016-04-114-39/+47
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | This makes it easier to query, simplifies the code, and makes it possible to figure out what transaction the data belongs to (simply because it's now stored _in_ the transaction). This new setup keeps track of both the real/wall time _and_ CPU time spent in a block, both measured using milliseconds (to keep all units the same).
* | | Merge branch 'rs-form_errors' into 'master' Dmitriy Zaporozhets2016-04-1133-153/+105
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Standardize the way we check for and display form errors - Some views had a "Close" button. We've removed this, because we don't want users accidentally hiding the validation errors and not knowing what needs to be fixed. - Some views used `li`, some used `p`, some used `span`. We've standardized on `li`. - Some views only showed the first error. We've standardized on showing all of them. - Some views added an `#error_explanation` div, which we've made standard. See merge request !3531
| * | | Standardize the way we check for and display form errorsrs-form_errorsRobert Speicher2016-04-0433-153/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Some views had a "Close" button. We've removed this, because we don't want users accidentally hiding the validation errors and not knowing what needs to be fixed. - Some views used `li`, some used `p`, some used `span`. We've standardized on `li`. - Some views only showed the first error. We've standardized on showing all of them. - Some views added an `#error_explanation` div, which we've made standard.
* | | | Merge branch 'rs-code-review-guide' into 'master' Dmitriy Zaporozhets2016-04-112-0/+80
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | First pass at a Code Review guide Largely borrowed from thoughtbot's code review guide, so attribution is included. [ci skip] See merge request !3639
| * | | | Re-add a note about sarcasm to the Code Review guiders-code-review-guideRobert Speicher2016-04-101-0/+3
| | | | | | | | | | | | | | | | | | | | [ci skip]
| * | | | First pass at a Code Review guideRobert Speicher2016-04-092-0/+77
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Largely borrowed from thoughtbot's code review guide, so attribution is included. [ci skip]
* | | | | Merge branch 'mr-ui-update' into 'master' Jacob Schatz2016-04-1122-115/+297
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updated UI for new merge request Closes #2540 ![Screen_Shot_2016-03-29_at_12.53.18](/uploads/426e603675171f0dc4e0af83c7762eba/Screen_Shot_2016-03-29_at_12.53.18.png) ![Screen_Shot_2016-03-29_at_12.53.13](/uploads/645ad7955acfb9f7693245fcc048ee49/Screen_Shot_2016-03-29_at_12.53.13.png) See merge request !3228
| * | | | | Merge request mobile spacingmr-ui-updatePhil Hughes2016-04-111-2/+11
| | | | | |
| * | | | | Fixed dropdown title overlapPhil Hughes2016-04-111-2/+2
| | | | | |
| * | | | | Addressed feedbackPhil Hughes2016-04-115-16/+19
| | | | | | | | | | | | | | | | | | | | | | | | Removed important from css
| * | | | | Fixed testsPhil Hughes2016-04-071-1/+1
| | | | | |
| * | | | | Build fixPhil Hughes2016-04-062-3/+12
| | | | | |
| * | | | | Fixed buildsPhil Hughes2016-04-067-23/+30
| | | | | |
| * | | | | Fixed spacing in MR footerPhil Hughes2016-04-061-1/+1
| | | | | |
| * | | | | Removed un-used get requestPhil Hughes2016-04-061-2/+0
| | | | | |
| * | | | | Fixed target project updatePhil Hughes2016-04-066-38/+42
| | | | | |
| * | | | | Filters by text on elementPhil Hughes2016-04-062-7/+31
| | | | | |
| * | | | | Checkmarks in dropdowns for already selected valuesPhil Hughes2016-04-062-7/+8
| | | | | |
| * | | | | Use new dropdowns for MR comparePhil Hughes2016-04-065-32/+82
| | | | | |
| * | | | | Fixed failing testsPhil Hughes2016-04-061-2/+2
| | | | | |
| * | | | | Updated UI for new merge requestPhil Hughes2016-04-0610-61/+138
| | | | | | | | | | | | | | | | | | | | | | | | Closes #2540
* | | | | | Merge branch 'rs-remove-markdown-tips' into 'master' Dmitriy Zaporozhets2016-04-112-30/+0
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove `random_markdown_tip` helper Only usage got removed in !3442 See merge request !3637
| * | | | | Remove `random_markdown_tip` helperrs-remove-markdown-tipsRobert Speicher2016-04-092-30/+0
| | | | | | | | | | | | | | | | | | | | | | | | Only usage got removed in !3442
* | | | | | Merge branch 'patch-1' into 'master' Achilleas Pipinellis2016-04-111-7/+6
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Correct documentation on enabling artifacts. The docs say to enable artifacts that settings should be set to "false". This updates the documents to change the setting to "true". See merge request !3630
| * | | | | | fix typoBenjamin Montgomery2016-04-101-1/+3
| | | | | | |
| * | | | | | Make the purpose of artifact config options clearerBenjamin Montgomery2016-04-101-9/+6
| | | | | | |
| * | | | | | actually enable artifactsBenjamin Montgomery2016-04-091-2/+2
| | | | | | |
* | | | | | | Merge branch 'add-missing-mixin' into 'master' Stan Hu2016-04-111-4/+6
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use false/true mixin in migration from !3640 See merge request !3646
| * | | | | | | Use false/true mixin in migration from !3640Stan Hu2016-04-101-4/+6
|/ / / / / / /
* | | | | | | Merge branch 'fix-raw-sql-migrations' into 'master' Stan Hu2016-04-114-12/+18
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix more SQL migrations to use raw commands gitlab-org/gitlab-development-kit#109 See merge request !3640
| * | | | | | | Fix more SQL migrations to use raw commandsStan Hu2016-04-104-12/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gitlab-org/gitlab-development-kit#109
* | | | | | | | Merge branch 'upgrade-annotate' into 'master' Robert Speicher2016-04-112-4/+4
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Upgrade annotate from 2.6.10 to 2.7.0 We don’t have any tests for this, so no need to run them. [ci skip] Includes compatibility with Rails 5. Changelog: https://github.com/ctran/annotate_models/releases/tag/v2.7.0 Working towards #14286. See merge request !3645
| * | | | | | | | Upgrade annotate from 2.6.10 to 2.7.0connorshea2016-04-102-4/+4
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Includes compatibility with Rails 5. We don’t have any tests for this, so no need to run them. [ci skip] Changelog: https://github.com/ctran/annotate_models/releases/tag/v2.7.0 Working towards #14286.
* | | | | | | | Merge branch 'upgrade-premailer-rails' into 'master' Robert Speicher2016-04-111-3/+3
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Upgrade premailer-rails from 1.9.0 to 1.9.2 Includes compatibility with Rails 5. Changelog: https://github.com/fphilipe/premailer-rails/blob/master/CHANGELOG.md#v192 Working towards #14286. See merge request !3643
| * | | | | | | | Upgrade premailer-rails from 1.9.0 to 1.9.2connorshea2016-04-101-3/+3
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Includes compatibility with Rails 5. Changelog: https://github.com/fphilipe/premailer-rails/blob/master/CHANGELOG.md#v19 2 Working towards #14286.
* | | | | | | | Merge branch 'fix-milestone-seedfu' into 'master' Robert Speicher2016-04-111-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix seed_fu failure with inserting milestones into test DB Milestones were not being saved due to "invalid state" validation errors See merge request !3641
| * | | | | | | | Fix seed_fu failure with inserting milestones into test DBStan Hu2016-04-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Milestones were not being saved due to "invalid state" validation errors
* | | | | | | | | Merge branch 'issue_14353' into 'master' Jacob Schatz2016-04-111-1/+2
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ignore toggling the sidebar for resolutions over 1200px width Closes #14353 ![sidebar1](/uploads/4b8d0eaa1b320c319239cb572932f740/sidebar1.gif) See merge request !3547
| * | | | | | | | | Use existence operator insteadissue_14353Alfredo Sumaran2016-04-101-1/+1
| | | | | | | | | |
| * | | | | | | | | Check existence of variable methodAlfredo Sumaran2016-04-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This happens because tab's `shown` event is triggered first if we enter directly to the diff page therefore Breakpoints class is not initialized yet.