summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Don't use the same repository on disk in create_merge_request_handler_specjprovazn-testfixJan Provaznik2017-12-071-15/+11
| | | | | | | | Use of skip_disk_validation causes failing tests, as a hotfix the test which depends on the repository is temporarily commented out (it will be fixed in a followup patch). Closes #40900
* Merge branch 'mk-add-old-attachments-to-uploads-table' into 'master'Stan Hu2017-12-0714-4/+1323
|\ | | | | | | | | Add old files to uploads table See merge request gitlab-org/gitlab-ce!15270
| * Fix specs for MySQLMichael Kozono2017-12-062-0/+5
| |
| * Fix specs after rebaseMichael Kozono2017-12-064-89/+20
| | | | | | | | | | | | | | | | Later migrations added fields to the EE DB which were used by factories which were used in these specs. And in CE on MySQL, a single appearance row is enforced. The migration and migration specs should not depend on the codebase staying the same.
| * Process normal paths in batch containing bad pathsMichael Kozono2017-12-052-4/+45
| |
| * Guarantee all IDs are includedMichael Kozono2017-12-051-5/+5
| |
| * Make sure empty uploads doesn’t break anythingMichael Kozono2017-12-041-1/+9
| |
| * Follow symlinksMichael Kozono2017-12-041-1/+1
| | | | | | | | In particular, the Omnibus uploads directory is generally a symlink.
| * Handle race conditionMichael Kozono2017-12-011-1/+2
| |
| * Add tests for disable_quote optionMichael Kozono2017-12-011-0/+16
| |
| * Address Rubocop offensesMichael Kozono2017-12-012-39/+82
| |
| * Fix test for MySQLMichael Kozono2017-12-011-4/+6
| |
| * Ensure consistent column orderMichael Kozono2017-12-011-1/+1
| |
| * Don’t quote `NOW()` for created_at columnMichael Kozono2017-12-012-3/+9
| | | | | | | | To fix for MySQL.
| * RefactorMichael Kozono2017-12-011-6/+6
| |
| * Don’t recreate deleted uploadsMichael Kozono2017-12-013-12/+51
| |
| * Get rid of timestamps on untracked files tableMichael Kozono2017-12-011-3/+2
| | | | | | | | `updated_at` is now unnecessary and `created_at` is less useful due to removing the tracked field.
| * Bulk insert uploadsMichael Kozono2017-12-011-49/+14
| |
| * Filter existing uploads with one queryMichael Kozono2017-12-012-92/+68
| |
| * RefactorMichael Kozono2017-12-012-16/+13
| |
| * Get rid of tracked fieldMichael Kozono2017-12-013-29/+7
| | | | | | | | It makes a debugging slightly easier, but is not necessary, and is a waste of resources.
| * RefactorMichael Kozono2017-12-011-10/+3
| |
| * Fix datetime inserts on MySQLMichael Kozono2017-12-011-3/+1
| |
| * Fix Rubocop offenseMichael Kozono2017-12-011-0/+1
| |
| * Use bulk insertsMichael Kozono2017-12-013-71/+184
| |
| * Use ionice absolute pathMichael Kozono2017-12-011-2/+3
| |
| * Attempt to fix spec in CIMichael Kozono2017-12-011-1/+1
| |
| * Log the find command usedMichael Kozono2017-12-011-0/+2
| |
| * Move temp table creation into the prepare jobMichael Kozono2017-12-016-77/+76
| | | | | | | | | | * Hopefully fixes spec failures in which the table doesn’t exist * Decouples the background migration from the post-deploy migration, e.g. we could easily run it again even though the table is dropped when finished.
| * Fix migration for pre-Postgres 9.5Michael Kozono2017-12-011-1/+15
| |
| * Fix Rubocop offensesMichael Kozono2017-12-014-11/+9
| |
| * Drop temporary tracking table when finishedMichael Kozono2017-12-016-92/+131
| |
| * Refactor specsMichael Kozono2017-12-014-337/+183
| |
| * Speed up insertsMichael Kozono2017-12-011-2/+4
| |
| * Fallback on checksum jobsMichael Kozono2017-12-011-0/+2
| | | | | | | | Since `calculate_checksum` depends on `Uploader` classes which are not defined in this background migration and may change at any time.
| * Remove irrelevant copy-pasted codeMichael Kozono2017-12-011-20/+0
| |
| * Fix uploads.path length for long filenamesMichael Kozono2017-12-012-1/+26
| | | | | | | | This will prevent our other migration for adding old files to the uploads table from breaking.
| * Fix MySQL path field lengthMichael Kozono2017-12-011-1/+1
| | | | | | | | | | | | I believe the field only needs to fit 519 at the moment but I’m rounding up to be a little safer. See the migration spec for more detail on the magic number 519.
| * Store paths relative to CarrierWave.rootMichael Kozono2017-12-015-68/+79
| | | | | | | | | | | | So the path on source installs cannot be too long for our column. And fix the column length test since Route.path is limited to 255 chars, it doesn’t matter how many nested groups there are.
| * Fix `ionice` prependMichael Kozono2017-12-011-1/+1
| |
| * Exclude `untracked_files_for_uploads` from schemaMichael Kozono2017-12-011-10/+0
| | | | | | | | | | | | Because it is a temporary table meant only to facilitate a migration of data. It is referenced only by the post-deploy migration and 2 related background migrations. It should be dropped when the data migration is finished.
| * Clean up after testMichael Kozono2017-12-011-1/+7
| |
| * Remove unnecessary clearingMichael Kozono2017-12-012-7/+2
| | | | | | | | Since duplicate inserts are now ignored.
| * Reword testMichael Kozono2017-12-011-1/+1
| |
| * Rename table to untracked_files_for_uploadsMichael Kozono2017-12-017-157/+157
| |
| * Refactor, no change in behaviorMichael Kozono2017-12-015-39/+53
| |
| * Use `find` `-prune` option for performanceMichael Kozono2017-12-011-2/+4
| |
| * Make regexes more readableMichael Kozono2017-12-012-13/+13
| |
| * Avoid instantiating an AR object and ignore dupesMichael Kozono2017-12-011-1/+15
| |
| * Add changelog entryMichael Kozono2017-12-011-0/+5
| |