summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Improve the Unsubscribe confirmation pagemaxiperezc/gitlab-ce-issues_17198Rémy Coutable2016-09-201-5/+9
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Fix initial implementation to actually render the unsubscribe pageRémy Coutable2016-09-204-13/+54
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Fix "Unsubscribe" link in notification emails that is triggered by anti-virusMaximiliano Perez Coto2016-09-209-20/+174
| | | | | | | | | * Created a force=true param that will continue with the previous behaviour of the unsubscribe method * Created a filter for not-logged users so they see a unsubsribe confirmation page * Added the List-Unsubscribe header on emails so the email client can display it on top
* Merge branch 'rs-trailing-spaces-in-regex-messages' into 'master' Rémy Coutable2016-09-201-3/+3
|\ | | | | | | | | Remove trailing spaces from messages in Gitlab::Regex See merge request !6426
| * Remove trailing spaces from messages in Gitlab::Regexrs-trailing-spaces-in-regex-messagesRobert Speicher2016-09-201-3/+3
| |
* | Merge branch 'sh-fix-last-activity-at-specs' into 'master' Rémy Coutable2016-09-203-11/+25
|\ \ | | | | | | | | | | | | | | | | | | | | | Fix broken spec due to last_activity_at updates being throttled In https://gitlab.com/gitlab-org/gitlab-ce/builds/4218398, the build failed because the last_activity_at column was only being updated once per hour. We can fix this spec by stubbing out the throttling and adjusting the spec to test the right event timestamp. See merge request !6424
| * | Fix broken spec due to last_activity_at updates being throttledStan Hu2016-09-193-11/+25
| | | | | | | | | | | | | | | | | | | | | In https://gitlab.com/gitlab-org/gitlab-ce/builds/4218398, the build failed because the last_activity_at column was only being updated once per hour. We can fix this spec by stubbing out the throttling and adjusting the spec to test the right event timestamp.
* | | Merge branch 'fix-download-artifacts-button-link' into 'master' Douwe Maan2016-09-206-5/+22
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix download artifacts button link ## What does this MR do? Fix download artifacts button link. ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] Added for this feature/bug ## What are the relevant issue numbers? Closes #22294 See merge request !6407
| * \ \ Merge remote-tracking branch 'upstream/master' into ↵Lin Jen-Shin2016-09-2087-442/+2049
| |\ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fix-download-artifacts-button-link * upstream/master: (80 commits) Contributing via GH no longer encouraged. Update README.md to really fix icon Update README.md to fix icon Allow to set request_access_enabled for groups and projects using API Restrict last_activity_at updates to one per hour Solve code review comments Properly support Gitlab::Auth::Result Revert all changes introduced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6043 Move Gitlab::Auth.Result to separate file Added CHANGELOG Fix spec failures Support pushing via SSH Fix specs failures Don't leak build tokens in build logs Fix permissions for creating container images Fix old CHANGELOG entries Add linting for duplicate CHANGELOG versions (!6039) Ensure validation messages are shown within the milestone form Fix validation regexs (+1 squashed commit) Squashed commits: [f9a9315] Use : to test invalid environment name Fix scope of the CI config key nodes in jobs entry ...
* | | | Merge branch 'workhorse-0.8.2' into 'master' Douwe Maan2016-09-203-3/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use gitlab-workhorse 0.8.2 Fixes rejected API git archive extensions; improves Sentry errors. https://gitlab.com/gitlab-org/gitlab-workhorse/blob/master/CHANGELOG See merge request !6388
| * | | | Use gitlab-workhorse 0.8.2Jacob Vosmaer2016-09-163-3/+3
| | | | | | | | | | | | | | | | | | | | Fixes rejected API git archive extensions; improves Sentry errors.
* | | | | Merge branch 'ldap_user_attr_method' into 'master' Douwe Maan2016-09-201-1/+5
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move LDAP user attributes to a method ## What does this MR do? This is a change that supports an EE fix. This small change needs to be made in CE to prevent future merge conflicts. See https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/736 for the EE changes. See merge request !6377
| * | | | | Move LDAP user attributes to a methodDrew Blessing2016-09-151-1/+5
| | | | | |
* | | | | | Merge branch 'strip-key-comments-for-gitlab-shell' into 'master' Robert Speicher2016-09-203-6/+40
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Strip comments before sending keys to gitlab-shell ## Why was this MR needed? https://gitlab.com/gitlab-org/gitlab-ce/issues/22167 encoding issues in comment text. ## What are the relevant issue numbers? https://gitlab.com/gitlab-org/gitlab-ce/issues/22167 See merge request !6381
| * | | | | | Strip comments before sending keys to gitlab-shellJacob Vosmaer2016-09-163-6/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid issues with text encoding by not sending out non-7-bit ASCII text. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/22167
* | | | | | | Merge branch '22065-group-members-api-returning-null-user-details' into ↵Robert Speicher2016-09-205-17/+27
|\ \ \ \ \ \ \ | |_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Ensure invitees are not returned in Members API ## What are the relevant issue numbers? Closes #22065 See merge request !6370
| * | | | | | Better assertion in API members specs22065-group-members-api-returning-null-user-detailsRémy Coutable2016-09-161-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | | | | | Ensure invitees are not returned in Members APIRémy Coutable2016-09-165-17/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | | | | | Merge branch 'lint-for-changelog' into 'master' Robert Speicher2016-09-202-7/+11
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add linting for duplicate CHANGELOG entries ## What does this MR do? Extend `scripts/lint-doc.sh` so that it checks that there are no duplicate versions in CHANGELOG. See merge request !6039
| * | | | | | | Fix old CHANGELOG entrieswinniehell2016-09-191-7/+2
| | | | | | | |
| * | | | | | | Add linting for duplicate CHANGELOG versions (!6039)winniehell2016-09-191-0/+9
| | | | | | | |
* | | | | | | | Merge branch 'diff-table-width-fix' into 'master' Jacob Schatz2016-09-202-4/+6
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed large comments messing with diff table widths ## What does this MR do? Fixes the width of the diff table so that the content inside it can't increase or decrease the width of the table cells. ## Screenshots (if relevant) ![Screen_Shot_2016-09-12_at_14.44.44](/uploads/2ca483399d867153e6ae608360ffea5f/Screen_Shot_2016-09-12_at_14.44.44.png) ## What are the relevant issue numbers? Closes #20694 See merge request !6309
| * | | | | | | | Fixed large comments messing with diff table widthsdiff-table-width-fixPhil Hughes2016-09-122-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #20694
* | | | | | | | | Merge branch 'fix-build-trace-anchors' into 'master' Jacob Schatz2016-09-201-2/+11
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve build trace scroll controls ## What does this MR do? The trace step buttons now correctly scroll to the top or bottom of the build trace, rather than jumping inconsistently and never full reaching the top due to the fixed position of the header/navigation area. ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? Build trace UX ## Screenshots (if relevant) ![2016-09-09_20.04.32](/uploads/efee5145fb505f8c9ae2a4cf24d842d3/2016-09-09_20.04.32.gif) ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Contributes to #21832. See merge request !6288
| * | | | | | | | | Now anchors to the top or bottom of the build trace with the correct offsetfix-build-trace-anchorsLuke Bennett2016-09-092-8/+8
| | | | | | | | | |
| * | | | | | | | | trace step buttons now scroll 50px up or down at a timeLuke Bennett2016-09-092-4/+13
| | | | | | | | | |
* | | | | | | | | | Merge branch '21961-issues-filtering-issue-with-labels-that-contain-spaces' ↵Jacob Schatz2016-09-204-11/+40
|\ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | into 'master' Fixes labels multi-encode and selecting labels with single quotes ## What does this MR do? Replaced single quotes with escaped single quotes when setting item `.is-active` and when removing its field. Adds a test to test selecting 2 different labels _(one with a single quote)_ with a full page load inbetween, it checks the labels are selected as well as shown as `.is-active` in the list. ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? The javascript handles the url encoding when it is sent to the server so we shouldn't let the javascript begin processing an already encoded string but we needed to stop single quotes from breaking a jquery selector. ## Screenshots (if relevant) https://youtu.be/-H0_L2hV9tM ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #21961 Closes #21880 Closes #21248 Closes #20759 Closes #21935 See merge request !6313
| * | | | | | | | | Merge branch 'master' into ↵21961-issues-filtering-issue-with-labels-that-contain-spacesLuke "Jared" Bennett2016-09-19229-1715/+3642
| |\ \ \ \ \ \ \ \ \ | |/ / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '21961-issues-filtering-issue-with-labels-that-contain-spaces' # Conflicts: # app/assets/javascripts/gl_dropdown.js
* | | | | | | | | | Merge branch 'issue_20978' into 'master' Rémy Coutable2016-09-198-70/+117
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow to set request_access_enabled for groups and projects using API Closes #20978 See merge request !6359
| * | | | | | | | | | Allow to set request_access_enabled for groups and projects using APIFelipe Artur2016-09-198-70/+117
| | | | | | | | | | |
* | | | | | | | | | | Contributing via GH no longer encouraged.Sid Sijbrandij2016-09-191-1/+1
| | | | | | | | | | |
* | | | | | | | | | | Update README.md to really fix iconSid Sijbrandij2016-09-191-1/+1
| | | | | | | | | | |
* | | | | | | | | | | Update README.md to fix iconSid Sijbrandij2016-09-191-1/+1
| | | | | | | | | | |
* | | | | | | | | | | Merge branch 'sh-prevent-duplicate-protected-branches-on-push' into 'master' Rémy Coutable2016-09-193-1/+17
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only create a protected branch upon a push to a new branch if a rule for that branch doesn't exist A customer ran into an issue where a Sidekiq task retried over and over, leading to duplicate master branches in their protected branch list. Closes #22177 See merge request !6399
| * | | | | | | | | | | Only create a protected branch upon a push to a new branch if a rule for ↵sh-prevent-duplicate-protected-branches-on-pushStan Hu2016-09-173-1/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | that branch doesn't exist A customer ran into an issue where a Sidekiq task retried over and over, leading to duplicate master branches in their protected branch list. Closes #22177
* | | | | | | | | | | | Merge branch 'throttle-last-activity-at' into 'master' Rémy Coutable2016-09-193-13/+48
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Restrict last_activity_at updates to one per hour This MR reduces the number of updates to `projects.last_activity_at` to once per hour. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/22213 See merge request !6391
| * | | | | | | | | | | | Restrict last_activity_at updates to one per hourYorick Peterse2016-09-193-13/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The lock in turn is only obtained when actually needed, reducing some load on Redis. Fixes gitlab-org/gitlab-ce#22213
* | | | | | | | | | | | | Merge branch 'cs-add-cii-badge' into 'master' Rémy Coutable2016-09-191-0/+1
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add Core Infrastructure Initiative badge to README Our Core Infrastructure Initiative Badge page: https://bestpractices.coreinfrastructure.org/projects/42 CII is a program by the Linux Foundation to track compliance with best practices in various large open source projects, we currently have a 100% passing rate for the badge. We didn't list this before, even though we probably should. I asked Sid and he said there was no reason not to add it, so here we go :) See merge request !6077
| * | | | | | | | | | | | | Add CII badge to README [ci skip]cs-add-cii-badgeConnor Shea2016-08-281-0/+1
| | | | | | | | | | | | | |
* | | | | | | | | | | | | | Merge branch 'per-build-token-without-lfs' into 'master' Rémy Coutable2016-09-1930-201/+985
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make CI to use the permission of the user who is trigger the build This is continuation of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5735, but with removed all LFS code that is added by: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6043. This also incorporates most of LFS code added in !6043 to simplify further merge. See merge request !6409
| * | | | | | | | | | | | | | Solve code review commentsKamil Trzcinski2016-09-192-1/+10
| | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | Properly support Gitlab::Auth::ResultKamil Trzcinski2016-09-192-8/+8
| | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | Revert all changes introduced by ↵Kamil Trzcinski2016-09-1913-245/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6043
| * | | | | | | | | | | | | | Move Gitlab::Auth.Result to separate fileKamil Trzcinski2016-09-192-14/+17
| | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | Added CHANGELOGKamil Trzcinski2016-09-191-0/+1
| | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | Merge branch 'master' into per-build-tokenKamil Trzcinski2016-09-19150-1176/+1674
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | |/ / / / / / / / / / / / | | |/| | | | | | | | | | | |
| * | | | | | | | | | | | | | Fix spec failuresKamil Trzcinski2016-09-192-2/+2
| | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | Support pushing via SSHKamil Trzcinski2016-09-192-1/+12
| | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | Don't leak build tokens in build logsKamil Trzcinski2016-09-195-15/+113
| | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | Fix permissions for creating container imagesKamil Trzcinski2016-09-191-1/+1
| | | | | | | | | | | | | | |