summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fallback early to nil fallback valuesmk/asymmetric-exists-cacheMichael Kozono2018-09-271-1/+1
|
* Remove send-in-send for safety and readabilityMichael Kozono2018-09-271-13/+28
| | | | | | | | | | | | | I attempted to refactor so that the caller of `wrap_method` passes in a block, rather than a method name, but I was unsuccessful. I kept getting the following error: NoMethodError: undefined method `cache_method_output' for Repository:Class If you can figure this out, then feel free to dry up these class methods again without doing a send-within-a-send.
* Add changelog entryMichael Kozono2018-09-271-0/+6
|
* Expire RequestStore cache properlyMichael Kozono2018-09-272-0/+15
|
* Cache `Repository#exists?` false in RequestStoreMichael Kozono2018-09-277-2/+273
| | | | | * Only truthy values are cached in Redis. * All values are cached in RequestStore and in an instance variable.
* Extract `Repository.memoize_method` methodMichael Kozono2018-09-273-48/+132
| | | | | | | | | | | And reuse `Gitlab::Utils::StrongMemoize`. There is a subtle behavior change required to reuse StrongMemoize in this case. The early fallback check now occurs *before* reading the memoized value instead of after. I think this is fine since a memoized value should only exist if `exists?` is also already memoized as `true`.
* Merge branch 'fa-handle_invalid_utf8_errors' into 'master'Stan Hu2018-09-255-0/+73
|\ | | | | | | | | Render 412 when invalid UTF-8 is passed as parameter See merge request gitlab-org/gitlab-ce!21774
| * Render 412 for invalid UTF-8 parametersfa-handle_invalid_utf8_errorsFelipe Artur2018-09-225-0/+73
| | | | | | | | | | Renders 412 error page when invalid UTF-8 is passed as parameters in controllers.
* | Merge branch 'osw-clean-up-phase-for-diff-files-removal' into 'master'Yorick Peterse2018-09-252-0/+28
|\ \ | | | | | | | | | | | | | | | | | | Add clean-up phase for ScheduleDiffFilesDeletion migration Closes #51469 See merge request gitlab-org/gitlab-ce!21734
| * | Add clean-up phase for ScheduleDiffFilesDeletionOswaldo Ferreira2018-09-252-0/+28
| | | | | | | | | | | | | | | Process any remaining ScheduleDiffFilesDeletion workers and remove temporary added index.
* | | Merge branch 'ml-qa-register-ldap' into 'master'Dan Davison2018-09-255-8/+62
|\ \ \ | | | | | | | | | | | | | | | | QA: Allow registration when LDAP is enabled See merge request gitlab-org/gitlab-ce!21846
| * | | Allow registration when LDAP is enabledml-qa-register-ldapMark Lapierre2018-09-245-8/+62
| | | | | | | | | | | | | | | | | | | | Update the login page object and related code so that a user can be registered when LDAP is enabled
* | | | Merge branch 'enable-force-write-auth-keys-restore' into 'master'Nick Thomas2018-09-253-3/+50
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Enable the ability to use the force env for rebuilding authorized_keys during a restore See merge request gitlab-org/gitlab-ce!21896
| * | | | Enable write to auth_keys file during restoreCindy Pallares2018-09-253-3/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fast lookup of authorized SSH keys in the database was ported to CE in v10.4. This change adds the option to enable the setting via the restore rake task and assumes yes if the force env variable is set.
* | | | | Merge branch 'ide-remove-stage-buttons' into 'master'Filipa Lacerda2018-09-256-69/+3
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove stage/unstage buttons from IDE commit list items Closes #51695 See merge request gitlab-org/gitlab-ce!21845
| * | | | | Fixed alignment of changed icon in commit headide-remove-stage-buttonsPhil Hughes2018-09-251-0/+1
| | | | | |
| * | | | | Updated specs to account for removed buttonsPhil Hughes2018-09-214-65/+2
| | | | | |
| * | | | | Remove stage/unstage buttons from IDE commit list itemsPhil Hughes2018-09-201-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51695
* | | | | | Merge branch 'winh-destroy-mr-widget-polling' into 'master'Phil Hughes2018-09-252-0/+6
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cleanup polling of merge request widget in tests Closes gitlab-ee#7728 See merge request gitlab-org/gitlab-ce!21906
| * | | | | Cleanup polling of merge request widget in testsWinnie Hellmann2018-09-252-0/+6
|/ / / / /
* | | | | Merge branch 'ce-7013-add-epics-close-support' into 'master'Douglas Barbosa Alexandre2018-09-258-7/+58
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | CE port of Adding state to epics See merge request gitlab-org/gitlab-ce!21771
| * | | | | Bacport FE changes from Closing Epicsce-7013-add-epics-close-supportJarka Košanová2018-09-246-1/+31
| | | | | | | | | | | | | | | | | | | | | | | | Backport of js and vue files from closing epics
| * | | | | Add name definition for table methodJarka Košanová2018-09-241-0/+4
| | | | | |
| * | | | | Add specs for closing and reopening issueJarka Košanová2018-09-241-6/+23
| | | | | |
* | | | | | Merge branch ↵Douglas Barbosa Alexandre2018-09-255-4/+29
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '51747-gitlab-com-unable-to-import-a-project-that-was-just-exported' into 'master' Resolve "gitlab.com: Unable to import a project that was just exported" Closes #43840, #43896, and #51747 See merge request gitlab-org/gitlab-ce!21875
| * | | | | | Add changelog. Add more specs.51747-gitlab-com-unable-to-import-a-project-that-was-just-exportedJames Lopez2018-09-243-0/+10
| | | | | | |
| * | | | | | Fix null pipeline problemJames Lopez2018-09-244-4/+19
| | | | | | |
* | | | | | | Merge branch 'docs/version-and-tiers-guidance' into 'master'Marcia Ramos2018-09-251-3/+15
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add clarity to EE feature styles for features introduced before and after 9.2 See merge request gitlab-org/gitlab-ce!21874
| * | | | | | | Add clarity to EE feature styles for features introduced before and after 9.2Evan Read2018-09-251-3/+15
|/ / / / / / /
* | | | | | | Merge branch 'mk/improve-usage-of-request-store' into 'master'Yorick Peterse2018-09-2537-155/+485
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Provide NullStore for RequestStore" Closes #51718 See merge request gitlab-org/gitlab-ce!21848
| * | | | | | | Refactor Feature.flipper methodmk/improve-usage-of-request-storeMichael Kozono2018-09-242-14/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix typo in context 'when request store is active' * Rearrange test since the instance variable always gets set now, even if RequestStore is active
| * | | | | | | Use `Gitlab::SafeRequestStore` in more placesMichael Kozono2018-09-2420-81/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Even if it doesn’t save lines of code, since people will tend to use code they’ve seen. And `SafeRequestStore` is safer since you don’t have to remember to check `RequestStore.active?`.
| * | | | | | | Add note to docs about `Gitlab::SafeRequestStore`Michael Kozono2018-09-241-2/+3
| | | | | | | |
| * | | | | | | Simplify by using Gitlab::SafeRequestStoreMichael Kozono2018-09-2411-60/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These are clear wins.
| * | | | | | | Use a null object with RequestStoreMichael Kozono2018-09-244-0/+384
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Makes it easier and safer to use RequestStore because you don't need to check `RequestStore.active?` before using it. You just have to use `Gitlab::SafeRequestStore` instead.
* | | | | | | | Merge branch 'nik-doc-postgres-alignment' into 'master'Yorick Peterse2018-09-251-28/+45
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Postgres alignment padding – logic fixed See merge request gitlab-org/gitlab-ce!21764
| * | | | | | | | Postgres alignment padding – logic fixed:nik-doc-postgres-alignmentNikolay OOO Sep 14 / Moscow timezone Sep 15-222018-09-201-28/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | alignment padding is applied based on the next column's data type, so, for example, we cannot state that for "boolean" (1 byte of data), the alignment is not needed. This commit fixes the logic in the doc. Update ordering_table_columns.md Typos fixed more polishing of text Minor improvements of text style Get rid of two "following" words in one line, having different meanings More text style polishing according @eread's comments
* | | | | | | | | Merge branch 'patch-28' into 'master'Rémy Coutable2018-09-251-1/+1
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update ldap.md If you escape the '\' character when using a "domain\user" scheme for the bind_dn name, it will fail. gitlab-ctl reconfigure escapes characters, and if you pre-escape the '\', the resultant yaml file will have four (4) '\' characters See merge request gitlab-org/gitlab-ce!20460
| * | | | | | | | | Update ldap.mdEd Goforth2018-07-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you escape the '\' character when using a "domain\user" scheme for the bind_dn name, it will fail. gitlab-ctl reconfigure escapes characters, and if you pre-escape the '\', the resultant yaml file will have four (4) '\' characters.
* | | | | | | | | | Merge branch 'deploy-tokens' into 'master'Rémy Coutable2018-09-251-2/+2
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | use redirect instead of render to avoid creating keys when refresh - resolves #47942 Closes #47942 See merge request gitlab-org/gitlab-ce!20363
| * | | | | | | | | | use redirect instead of render to avoid creating keys when refresh - ↵Muhammad Nuzaihan2018-07-041-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | resolves #47942
* | | | | | | | | | | Merge branch 'update-frontend-dependencies' into 'master'Tim Zallmann2018-09-252-508/+866
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update frontend tooling dependencies See merge request gitlab-org/gitlab-ce!21818
| * | | | | | | | | | | Upgrade webpack-bundle-analyzer to latestupdate-frontend-dependenciesMike Greiling2018-09-242-41/+144
| | | | | | | | | | | |
| * | | | | | | | | | | Upgrade webpack and webpack-cliMike Greiling2018-09-242-199/+151
| | | | | | | | | | | |
| * | | | | | | | | | | Bump monaco-editor-webpack-plugin to latestMike Greiling2018-09-242-4/+4
| | | | | | | | | | | |
| * | | | | | | | | | | Upgrade several webpack loadersMike Greiling2018-09-242-15/+15
| | | | | | | | | | | |
| * | | | | | | | | | | Update karma dependenciesMike Greiling2018-09-241-133/+124
| | | | | | | | | | | |
| * | | | | | | | | | | Bump nodemon and commander dependenciesMike Greiling2018-09-242-6/+10
| | | | | | | | | | | |
| * | | | | | | | | | | Update babel test dependenciesMike Greiling2018-09-242-54/+181
| | | | | | | | | | | |
| * | | | | | | | | | | Update webpack-dev-server to v3.1.8Mike Greiling2018-09-242-113/+187
| | | | | | | | | | | |