summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Add extensible data-qa-* selection mechanismsqa-extensible-data-qa-selectorsddavison2019-08-272-1/+24
| | | | | | Primarily this will prevent the necessity to match on text. By providing this mechanism, we add the ability to match on dynamic content
* Merge branch 'docs/update-api-snippets' into 'master'Achilleas Pipinellis2019-08-271-0/+58
|\ | | | | | | | | Add example requests for snippets API See merge request gitlab-org/gitlab-ce!31964
| * Add example requests for snippets APIRainer Kern2019-08-271-0/+58
|/
* Merge branch 'qa-autodevops-smoke-check' into 'master'Dan Davison2019-08-274-12/+36
|\ | | | | | | | | Ensure autodevops is enabled before running Smoke test See merge request gitlab-org/gitlab-ce!31867
| * Ensure autodevops is enabled before running Smoke testqa-autodevops-smoke-checkddavison2019-08-154-12/+36
| | | | | | | | | | | | Extract #enable_autodevops to new page object Change Smoke test naming to only running pipeline Generate AutoDevOps project with SecureRandom suffix
* | Merge branch 'docs-document-category-labels' into 'master'Achilleas Pipinellis2019-08-274-134/+195
|\ \ | | | | | | | | | | | | Improve documentation of stage, group, category, feature labels See merge request gitlab-org/gitlab-ce!32053
| * | Introduce facet labelsdocs-document-category-labelsRémy Coutable2019-08-271-0/+18
| | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | Improve documentation of stage, group, category, feature labelsRémy Coutable2019-08-274-138/+181
| | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | Merge branch 'ashmckenzie/remove-mdl-gem' into 'master'Achilleas Pipinellis2019-08-272-11/+0
|\ \ \ | | | | | | | | | | | | | | | | Remove the mdl gem as it's no longer in use See merge request gitlab-org/gitlab-ce!32253
| * | | Remove the mdl gem as it's no longer in useashmckenzie/remove-mdl-gemAsh McKenzie2019-08-272-11/+0
| | | |
* | | | Merge branch 'qa/issue-boards-navigation' into 'master'Sanad Liaquat2019-08-272-1/+10
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Update view for testability and update page object See merge request gitlab-org/gitlab-ce!32224
| * | | | Update issues submenuqa/issue-boards-navigationWalmyr Lima2019-08-261-0/+9
| | | | | | | | | | | | | | | | | | | | With a new element and a new method to go to issue boards.
| * | | | Update view to add testabilityWalmyr Lima2019-08-261-1/+1
| | | | |
* | | | | Merge branch 'remove-docker-tag-for-reports-jobs' into 'master'Nick Thomas2019-08-271-3/+0
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Don't set tags for the reports jobs See merge request gitlab-org/gitlab-ce!32276
| * | | | | Don't set tags for the reports jobsremove-docker-tag-for-reports-jobsRémy Coutable2019-08-271-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | | | | Merge branch 'winh-prepend-entity' into 'master'Yorick Peterse2019-08-272-2/+27
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace prepend_entity with prepend_if_ee helper Closes gitlab-ee#13639 See merge request gitlab-org/gitlab-ce!32214
| * | | | | | Replace prepend_entity with prepend_if_eeWinnie Hellmann2019-08-272-2/+27
|/ / / / / / | | | | | | | | | | | | | | | | | | (cherry picked from commit 897a9d308db46b620b738b98f2b0e5630ac7d2dd)
* | | | | | Merge branch 'ce-ealcantara-eks-move-gke-dropdown-directory' into 'master'Mike Greiling2019-08-2723-17/+17
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | CE-backport: Move create cluster Vue apps to create_cluster directory. See merge request gitlab-org/gitlab-ce!32220
| * | | | | Move gke_cluster_dropdowns to create_cluster dirEnrique Alcantara2019-08-2723-17/+17
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit creates a create_cluster directory to collect all Vue applications related to creating kubernetes applications using gitlab. It also moves the gke_cluster_dropdowns collection of apps to the create_cluster directory. gke_cluster_dropdowns contains dropdown components used to select configuration options to create a Kubernetes cluster in Google Cloud.
* | | | | Merge branch ↵Lin Jen-Shin2019-08-272-3/+3
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '65312-use-group-labels-instead-of-legacy-team-labels-for-danger-picking-test-reviewers' into 'master' Detect the new stage labels in `Gitlab::Danger::Teammate` Closes #65312 See merge request gitlab-org/gitlab-ce!32261
| * | | | | Detect the new stage labels in Gitlab::Danger::Teammate65312-use-group-labels-instead-of-legacy-team-labels-for-danger-picking-test-reviewersRémy Coutable2019-08-272-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | | | | Merge branch ↵Jan Provaznik2019-08-273-16/+24
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '66641-broken-master-real-http-connections-are-disabled-unregistered-request' into 'master' Use `stub_full_request` to fix spec failure Closes #66641 See merge request gitlab-org/gitlab-ce!32259
| * | | | | | Use `stub_full_request` to fix spec failure66641-broken-master-real-http-connections-are-disabled-unregistered-requestHeinrich Lee Yu2019-08-273-16/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Also change test URL sequest to .test TLD
* | | | | | | Merge branch 'docs/fix-linting-problems' into 'master'Kushal Pandya2019-08-271-5/+5
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removes trailing whitespace to fix linting See merge request gitlab-org/gitlab-ce!32265
| * | | | | | | Removes trailing whitespace to fix lintingEvan Read2019-08-271-5/+5
|/ / / / / / /
* | | | | | | Merge branch '13806-fix' into 'master'Lin Jen-Shin2019-08-272-2/+13
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add nil check for Gitlab.config.prometheus Closes #13806 See merge request gitlab-org/gitlab-ce!32201
| * | | | | | | Add nil check for Gitlab.config.prometheus13806-fixrpereira22019-08-262-2/+13
| | | | | | | |
* | | | | | | | Merge branch 'docs-update-needs-example' into 'master'Kamil Trzciński2019-08-271-4/+4
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update the syntax of DAG example See merge request gitlab-org/gitlab-ce!32137
| * | | | | | | | Update syntax of needs exampledocs-update-needs-exampleAlexander Tanayno2019-08-231-4/+4
| | | | | | | | |
* | | | | | | | | Merge branch 'nik-db-migrations-prefer-atomic-docs' into 'master'Evan Read2019-08-272-44/+99
|\ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | Update DB migrations style guide: prefer atomic migrations when possible See merge request gitlab-org/gitlab-ce!31915
| * | | | | | | | Migrations guide: use atomic steps, when possibleMayra Cabrera2019-08-272-44/+99
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, the DB migrations guide says that "you must" use non-blocking operations (such as CREATE INDEX CONCURRENTLY), always. But this does not make sense in cases of empty tables and leads to splitting the work to multiple non-atomic (with disable_ddl_transaction!) DB migrations. To follow KISS principle, to have fewer DB migrations steps, to have them atomic when it's possible and simplify deployment and troubleshooting, the following exceptions were added to the doc: - index creation, - index dropping, - defining an FK, - adding a column with DEFAULT,
* | | | | | | | Merge branch 'docs/markdownlint-before-nanoc' into 'master'Evan Read2019-08-271-2/+3
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | Run markdownlint before Nanoc checks See merge request gitlab-org/gitlab-ce!32256
| * | | | | | | Run markdownlint before Nanoc checksAchilleas Pipinellis2019-08-271-2/+3
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make it simpler to run markdownlint by moving it before we do those hacks to run Nanoc.
* | | | | | | Merge branch '57657-promote-label-to-group-label-via-api-endpoint' into 'master'Sean McGivern2019-08-274-0/+113
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Promote Label to Group Label via API endpoint Closes #57657 See merge request gitlab-org/gitlab-ce!25218
| * | | | | | | Incorporate review feedbackRobert Schilling2019-08-261-9/+9
| | | | | | | |
| * | | | | | | Make tests passRobert Schilling2019-08-261-10/+12
| | | | | | | |
| * | | | | | | Update docs targeting 12.3Robert Schilling2019-08-262-2/+2
| | | | | | | |
| * | | | | | | Move promote to put and add more specsRobert Schilling2019-08-263-8/+32
| | | | | | | |
| * | | | | | | Add docs and first specsRobert Schilling2019-08-263-3/+60
| | | | | | | |
| * | | | | | | API: Promote project labels to group labelsRobert Schilling2019-08-262-0/+30
| | | | | | | |
* | | | | | | | Merge branch 'docs-sethgitlab-featureflags' into 'master'Achilleas Pipinellis2019-08-271-2/+2
|\ \ \ \ \ \ \ \ | |_|_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | Update index of feature flags See merge request gitlab-org/gitlab-ce!32217
| * | | | | | | Update index of feature flagsSeth Berger2019-08-271-2/+2
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Made it clear the pages are about feature flags, and not documentation.
* | | | | | | Merge branch 'docs-capitalization-2' into 'master'Achilleas Pipinellis2019-08-2722-95/+93
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update capitalization in /dev docs See merge request gitlab-org/gitlab-ce!32189
| * | | | | | | Update capitalization in /dev docsMarcel Amirault2019-08-2722-95/+93
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clean up capitalization in /development /gitlab-basics and /install
* | | | | | | Merge branch 'docs-capitalization-3' into 'master'Achilleas Pipinellis2019-08-2735-79/+82
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update capitalization in /integrations and /raketasks See merge request gitlab-org/gitlab-ce!32241
| * | | | | | | Update capitalization in /integrations and /raketasksMarcel Amirault2019-08-2735-79/+82
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | Also updates redirect text in /project-services
* | | | | | | Merge branch 'sh-project-feature-nplus-one' into 'master'Jan Provaznik2019-08-273-0/+28
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove N+1 SQL query loading project feature in dashboard Closes #66482 See merge request gitlab-org/gitlab-ce!32169
| * | | | | | | Remove N+1 SQL query loading project feature in dashboardsh-project-feature-nplus-oneStan Hu2019-08-233-0/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Projects that have a pipeline may need to check whether the user has permission to read the build (`can?(current_user, :read_build, project)`), which requires checking the `project_features` table. This would cause an N+1 SQL query for each project. This change also has a beneficial side effect that may avoid a race condition. When a user deletes a project, the project is queued for deletion and the user is redirected back to the dashboard page. However, the following may happen: 1. The dashboard page may load this deleted project in the list of 20 projects. 2. The view will load the project pipeline status from the cache and attempt to show each project. 3. When the view encounters the deleted project, it calls `can?(current_user, :read_build, project)` to determine whether to display the pipeline status. 4. Sidekiq deletes the project from the database. 5. However, since the deleted project is still loaded in memory, it will attempt to call `project.project_feature.access_level`. 6. Since `project_feature` was not eager loaded, a lazy `SELECT` call is made to the database. 7. This `SELECT` call returns nothing, and the user sees a 500 error. By eager loading `project_feature`, we can ensure that we have a consistent view and avoid records from being deleted later. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66482
* | | | | | | | Merge branch 'patch-25' into 'master'Evan Read2019-08-271-0/+23
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [#2838] add cache override explanation See merge request gitlab-org/gitlab-ce!32024
| * | | | | | | | [#2838] add cache override explanationJace Bennest2019-08-271-0/+23
|/ / / / / / / /