delta/gitlab/gitlab-ce.git - gitlab.com: gitlab-org/gitlab-ce.git

	Commit message (Collapse)	Author	Age	Files	Lines
...
\| * \| \| \| \| \| \| \|	Change qa-* class references to rspec-* in ↵	Tanya Pazitny	2019-07-29	3	-8/+8
\|/ / / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	spec/features/contextual_sidebar_spec.rb
* \| \| \| \| \| \| \|	Merge branch 'tp-qtt182-7' into 'master'	Mayra Cabrera	2019-07-29	2	-2/+2
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Change qa-issuable-form-description to rspec-issuable-form-description Closes gitlab-org/quality/team-tasks#182 See merge request gitlab-org/gitlab-ce!31209
\| * \| \| \| \| \| \| \|	Change qa-* class references to rspec-*tp-qtt182-7	Tanya Pazitny	2019-07-26	2	-2/+2
\| \|/ / / / / / /
* \| \| \| \| \| \| \|	Merge branch 'tp-qtt182-5' into 'master'	Mayra Cabrera	2019-07-29	2	-3/+3
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Change qa-full-name to rspec-full-name Closes gitlab-org/quality/team-tasks#182 See merge request gitlab-org/gitlab-ce!31206
\| * \| \| \| \| \| \| \|	Change qa-full-name to rspec-full-name	Tanya Pazitny	2019-07-29	2	-3/+3
\|/ / / / / / / /
* \| \| \| \| \| \| \|	Merge branch 'tp-qtt182-8' into 'master'	Mayra Cabrera	2019-07-29	4	-8/+8
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Change qa-* class references to rspec-* for repository settings Closes gitlab-org/quality/team-tasks#182 See merge request gitlab-org/gitlab-ce!31210
\| * \| \| \| \| \| \| \|	Change qa-* class references to rspec-* for repository settings	Tanya Pazitny	2019-07-29	4	-8/+8
\|/ / / / / / / /
* \| \| \| \| \| \| \|	Merge branch 'tp-qtt182-3' into 'master'	Mayra Cabrera	2019-07-29	2	-2/+2
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Change qa-create-page-button to rspec-create-page-button Closes gitlab-org/quality/team-tasks#182 See merge request gitlab-org/gitlab-ce!31204
\| * \| \| \| \| \| \| \|	Change qa-* class references to rspec-*tp-qtt182-3	Tanya Pazitny	2019-07-26	2	-2/+2
\| \|/ / / / / / /
* \| \| \| \| \| \| \|	Merge branch 'tp-qtt182-4' into 'master'	Mayra Cabrera	2019-07-29	2	-2/+2
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Change qa-* to rspec-* for save-merge-request-changes Closes gitlab-org/quality/team-tasks#182 See merge request gitlab-org/gitlab-ce!31205
\| * \| \| \| \| \| \| \|	Change qa-* class references to rspec-*tp-qtt182-4	Tanya Pazitny	2019-07-26	2	-2/+2
\| \|/ / / / / / /
* \| \| \| \| \| \| \|	Merge branch 'tp-qtt182-2' into 'master'	Mayra Cabrera	2019-07-29	2	-8/+8
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Change qa-* class references to rspec-* for `allowed-to-{push\|merge}-dropdown` Closes gitlab-org/quality/team-tasks#182 See merge request gitlab-org/gitlab-ce!31203
\| * \| \| \| \| \| \| \|	Change qa-* class references to rspec-*tp-qtt182-2	Tanya Pazitny	2019-07-26	2	-8/+8
\| \|/ / / / / / /
* \| \| \| \| \| \| \|	Merge branch 'ab-add-index-on-environments' into 'master'	Mayra Cabrera	2019-07-29	3	-1/+24
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Create index on environments by state See merge request gitlab-org/gitlab-ce!31231
\| * \| \| \| \| \| \| \|	Create index on environments by state	Andreas Brandl	2019-07-29	3	-1/+24
\|/ / / / / / / /
* \| \| \| \| \| \| \|	Merge branch 'sh-add-cmaps-for-pdfjs' into 'master'	Mike Greiling	2019-07-29	5	-47/+107
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Make pdf.js render CJK characters Closes #62152 See merge request gitlab-org/gitlab-ce!31220
\| * \| \| \| \| \| \| \|	Make pdf.js render CJK characterssh-add-cmaps-for-pdfjs	Stan Hu	2019-07-28	5	-47/+107
\| \| \|/ / / / / / \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	As mentioned in https://github.com/wojtekmaj/react-pdf/blob/master/README.md, pdf.js needs the bundled cMaps files to work. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62152
* \| \| \| \| \| \| \|	Merge branch '11090-export-design-management-1-issue-migration' into 'master'	Mayra Cabrera	2019-07-29	6	-1/+108
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Migrations for adding issue_id to versions table (CE) See merge request gitlab-org/gitlab-ce!30765
\| * \| \| \| \| \| \| \|	Migrations for adding issue_id to versions table	Luke Duncalfe	2019-07-29	6	-1/+108
\|/ / / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	These migrations do the following: - Adds a new `issue_id` column to `versions`. This fixes an n+1 problem when loading versions for an issue in GraphQL as AR can now load from cache - Change the unique restraint on versions.sha to be scoped to `issue_id` as in order to import version data, we need to allow duplicate `sha` values for versions - Update all versions with an `issue_id` https://gitlab.com/gitlab-org/gitlab-ee/issues/11090
* \| \| \| \| \| \| \|	Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq	Robert Speicher	2019-07-29	44	-298/+764
\|\ \ \ \ \ \ \ \
\| * \| \| \| \| \| \| \|	Update CHANGELOG.md for 11.11.7	GitLab Release Tools Bot	2019-07-29	8	-35/+15
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	[ci skip]
\| * \| \| \| \| \| \| \|	Update CHANGELOG.md for 12.1.2	GitLab Release Tools Bot	2019-07-26	2	-5/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	[ci skip]
\| * \| \| \| \| \| \| \|	Merge branch 'security-60143-patch-additional-xss-vector-in-wikis' into 'master'	GitLab Release Tools Bot	2019-07-26	9	-92/+233
\| \|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Extract SanitizeNodeLink and apply to WikiLinkFilter See merge request gitlab/gitlabhq!3143
\| \| * \| \| \| \| \| \| \|	Extract SanitizeNodeLink and apply to WikiLinkFilter	Kerri Miller	2019-07-26	9	-92/+233
\| \|/ / / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The SanitizationFilter was running before the WikiFilter. Since WikiFilter can modify links, we could see links that _should_ be stopped by SanatizationFilter being rendered on the page. I (kerrizor) had previously addressed the bug in: https://gitlab.com/gitlab-org/gitlab-ee/commit/7bc971915bbeadb950bb0e1f13510bf3038229a4 However, an additional exploit was discovered after that was merged. Working through the issue, we couldn't simply shuffle the order of filters, due to some implicit assumptions about the order of filters, so instead we've extracted the logic that sanitizes a Nokogiri-generated Node object, and applied it to the WikiLinkFilter as well. On moving filters around: Once we start moving around filters, we get cascading failures; fix one, another one crops up. Many of the existing filters in the WikiPipeline chain seem to assume that other filters have already done their work, and thus operate on a "transform anything that's left" basis; WikiFilter, for instance, assumes any link it finds in the markdown should be prepended with the wiki_base_path.. but if it does that, it also turns `href="@user"` into `href="/path/to/wiki/@user"`, which the UserReferenceFilter doesn't see as a user reference it needs to transform into a user profile link. This is true for all the reference filters in the WikiPipeline.
\| * \| \| \| \| \| \| \|	Merge branch 'security-fix-badges-leaked-to-unauthorized-users' into 'master'	GitLab Release Tools Bot	2019-07-26	3	-31/+101
\| \|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Don't display badges when builds are restricted Closes #2864 See merge request gitlab/gitlabhq!3175
\| \| * \| \| \| \| \| \| \|	Don't display badges when builds are restricted	Fabio Pitino	2019-07-11	3	-31/+101
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Badges were leaked to unauthorized users even when Public Builds project setting is disabled. Added guard clause to the controller to check if user can read build.
\| * \| \| \| \| \| \| \| \|	Merge branch 'security-github-ssrf-redirect' into 'master'	GitLab Release Tools Bot	2019-07-26	6	-3/+100
\| \|\ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Do not allow localhost url redirection in GitHub Integration See merge request gitlab/gitlabhq!3188
\| \| * \| \| \| \| \| \| \| \|	Do not allow localhost url redirection in GitHub Integration	manojmj	2019-07-05	6	-3/+100
\| \| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \| \|	Merge branch 'security-remove-take-trigger-ownership-feature' into 'master'	GitLab Release Tools Bot	2019-07-26	11	-141/+9
\| \|\ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Drop feature to take ownership of a trigger token Closes #2868 See merge request gitlab/gitlabhq!3198
\| \| * \| \| \| \| \| \| \| \| \|	Drop feature to take ownership of a trigger token	Fabio Pitino	2019-07-10	11	-141/+9
\| \| \| \|/ / / / / / / / \| \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Removing API and frontend interactions that allowed users to take ownership of a trigger token. Removed mentions from the documentation.
\| * \| \| \| \| \| \| \| \| \|	Merge branch 'security-mr-pipeline-permissions' into 'master'	GitLab Release Tools Bot	2019-07-26	4	-6/+102
\| \|\ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	MR pipeline permissions Closes #2871 See merge request gitlab/gitlabhq!3204
\| \| * \| \| \| \| \| \| \| \| \|	Use MergeRequest#source_project as permissions reference for ↵	drew cimino	2019-07-05	4	-6/+102
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	MergeRequest#all_pipelines MergeRequest#all_pipelines fetches Ci::Pipeline records from the source project, so we should specifically check that project for permissions. This was already happening for intra-project merge requests, but in the event that the target and source projects both have private builds, we should ensure that the project permissions are respected.
\| * \| \| \| \| \| \| \| \| \| \|	Merge branch 'security-dns-ssrf-bypass' into 'master'	GitLab Release Tools Bot	2019-07-26	4	-14/+49
\| \|\ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Server Side Request Forgery mitigation bypass Closes #2872 See merge request gitlab/gitlabhq!3205
\| \| * \| \| \| \| \| \| \| \| \| \|	Fix Server Side Request Forgery mitigation bypass	Francisco Javier López	2019-07-15	4	-14/+49
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	When we can't resolve the hostname or it is invalid, we shouldn't even perform the request. This fix also fixes the problem the SSRF rebinding attack. We can't stub feature flags outside example blocks. Nevertheless, there are some actions that calls the UrlBlocker, that are performed outside example blocks, ie: `set` instruction. That's why we have to use some signalign mechanism outside the scope of the specs.
\| * \| \| \| \| \| \| \| \| \| \| \|	Merge branch 'security-60551-fix-upload-scope' into 'master'	GitLab Release Tools Bot	2019-07-26	7	-2/+48
\| \|\ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Queries for Upload should be scoped by model See merge request gitlab/gitlabhq!3229
\| \| * \| \| \| \| \| \| \| \| \| \| \|	Queries for Upload should be scoped by model	Adam Hegyi	2019-07-11	7	-2/+48
\| \| \| \|_\|/ / / / / / / / / \| \| \|/\| \| \| \| \| \| \| \| \| \|
\| * \| \| \| \| \| \| \| \| \| \| \|	Merge branch 'security-hide_moved_issue_id' into 'master'	GitLab Release Tools Bot	2019-07-26	3	-1/+44
\| \|\ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Do not show moved issue ids for user not authorized Closes #2878 See merge request gitlab/gitlabhq!3230
\| \| * \| \| \| \| \| \| \| \| \| \| \|	Do not show moved issue ids for user not authorized	Felipe Artur	2019-07-11	3	-1/+44
\| \| \|/ / / / / / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Do not show moved issue id for users that cannot read issue
\| * \| \| \| \| \| \| \| \| \| \| \|	Merge branch 'security-bvl-filter-mr-params' into 'master'	GitLab Release Tools Bot	2019-07-26	4	-8/+83
\| \|\ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Filter params in MR build service Closes #2879 See merge request gitlab/gitlabhq!3237
\| \| * \| \| \| \| \| \| \| \| \| \| \|	Filter params in MR build service	Bob Van Landuyt	2019-07-17	4	-8/+83
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Reusing the existing `IssuableBaseService#filter_params` which uses the policies to determine what params a user can set, and which values it can be set to. This also removed the need for the seperate call to `IssuableBaseService#ensure_milestone_available`. The `Issues::BuildService` does not suffer from this because it limits the params that are assignable to the `title`, `description` and `milestone_id`.
\| * \| \| \| \| \| \| \| \| \| \| \| \|	Update CHANGELOG.md for 12.1.2	GitLab Release Tools Bot	2019-07-25	1	-0/+15
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	[ci skip]
* \| \| \| \| \| \| \| \| \| \| \| \| \|	Merge branch 'sh-fix-pdfjs-page-ordering' into 'master'	Mike Greiling	2019-07-29	3	-9/+16
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fix pdf.js rendering pages in the wrong order Closes #64467 See merge request gitlab-org/gitlab-ce!31222
\| * \| \| \| \| \| \| \| \| \| \| \| \| \|	Simplify pdf.js logicsh-fix-pdfjs-page-ordering	Lukas Eipert	2019-07-29	2	-15/+11
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Instead of complicated splicing, we can simply return all pages. Promise.all will take care of the correct ordering for us.
\| * \| \| \| \| \| \| \| \| \| \| \| \| \|	Fix pdf.js rendering pages in the wrong order	Stan Hu	2019-07-29	2	-1/+12
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	There was an implicit assumption that the pages returned from the Promise of `pdf.getPage(num)` would return in order, but no such guarantee exists. To handle this, we explicitly set which array index based on the page number and then trigger a Vue update via `splice`. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64467
* \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Merge branch 'resolve-spec-differences' into 'master'	Lin Jen-Shin	2019-07-29	5	-9/+53
\|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Resolve EE specific differences in the spec/ directory See merge request gitlab-org/gitlab-ce!31109
\| * \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fix whitespace in wiki link filtering specsresolve-spec-differences	Yorick Peterse	2019-07-29	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This ensures this spec is the same in both CE and EE.
\| * \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Make usage content spec the same for CE and EE	Yorick Peterse	2019-07-29	1	-1/+9
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This changes the spec in question so that it is the same for both CE and EE. This requires an `if Gitlab.ee?` since EE requires that we stub an EE specific module, but doing so in CE will break the spec there.
\| * \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Make protected tags spec the same for CE and EE	Yorick Peterse	2019-07-29	1	-0/+6
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This changes a protected tags feature spec so that it is the same in both CE and EE. This requires the use of a `if Gitlab.ee?` check, as the added lines don't work in CE but do work in EE. Removing them entirely in turn breaks the EE spec.
\| * \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Backport ToDo feature specs from EE	Yorick Peterse	2019-07-29	1	-7/+35
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This ensures that both CE and EE have the same specs.
\| * \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Backport EE changes for the schema specs	Yorick Peterse	2019-07-29	1	-0/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This backports two EE specific changes made to the schema changes. We do not yet backport the EE prepend, as this will/can be done when https://gitlab.com/gitlab-org/gitlab-ce/issues/58170 is implemented.