summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Use Grape DSL to document methods and their paramsrc-members-services-based-on-18583Rémy Coutable2016-09-083-98/+80
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* New AccessRequestsFinderRémy Coutable2016-09-087-6/+124
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Improve Members::DestroyServiceRémy Coutable2016-09-088-74/+131
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* New Members::ApproveAccessRequestServiceRémy Coutable2016-09-084-12/+120
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* New Members::RequestAccessServiceRémy Coutable2016-09-0811-62/+123
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhqDmitriy Zaporozhets2016-09-083-1/+6
|\ | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhqDmitriy Zaporozhets2016-09-083-1/+5
| |\
| | * Merge branch 'fix/gitlab-export-confidential' into 'master' Rémy Coutable2016-09-053-1/+5
| | |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix confidential issues made public after import Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/21803 The gitlab.com import was ignoring the confidential attribute, hence making all issues public after being imported. The API has changed in order to also expose this field. See merge request !1992
| | | * Fixed gitlab.com importer missing confidential attributeJames Lopez2016-09-053-1/+5
| | |/
* | | Merge branch 'awards-control-margin' into 'master' Annabel Dunstone Gray2016-09-084-7/+8
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix margin for awards-control buttons ## What does this MR do? Fixes margin in awards-control ## Screenshots (if relevant) Before: ![Screen_Shot_2016-09-06_at_10.58.03_AM](/uploads/b3fcd4103669bc7ae54a22093f492391/Screen_Shot_2016-09-06_at_10.58.03_AM.png) After: ![Screen_Shot_2016-09-06_at_10.54.54_AM](/uploads/dcd0e57a8cff82fe70990a9a8e2b1232/Screen_Shot_2016-09-06_at_10.54.54_AM.png) ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? https://gitlab.com/gitlab-org/gitlab-ce/issues/21896 See merge request !6233
| * | | fix padding top/bottomawards-control-margintauriedavis2016-09-071-1/+1
| | | |
| * | | minor refactortauriedavis2016-09-071-5/+2
| | | |
| * | | fix margin for multi-line emojistauriedavis2016-09-073-1/+7
| | | |
| * | | fix margin for awards-control buttonstauriedavis2016-09-062-3/+1
| | | |
* | | | Merge branch 'dz-mr-version-compare' into 'master' Douwe Maan2016-09-0810-32/+147
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow compare merge request versions ## What does this MR do? Add new functionality to the merge request page. It allows you easily compare merge request versions in one click. ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? To improve code review experience. ## Screenshots (if relevant) See discussion ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] ~~API support added~~ - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? https://gitlab.com/gitlab-org/gitlab-ce/issues/13570 See merge request !6127
| * | | | Refactor compared_diff_version method in merge requests controllerdz-mr-version-compareDmitriy Zaporozhets2016-09-071-6/+2
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | Refactor merge request version compare featureDmitriy Zaporozhets2016-09-073-9/+11
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | Improve merge request version featureDmitriy Zaporozhets2016-09-076-41/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Use version numbers instead of sha as more user-friendly * Make it clear that we compare later version (left) with older one (right) * Improve wording of version switch panel Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | Expand abbreviations in merge request version path helperDmitriy Zaporozhets2016-09-072-4/+4
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | Add changelog entry and documentation for merge request versions compareDmitriy Zaporozhets2016-09-072-0/+7
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | Refactor code for merge request version compare featureDmitriy Zaporozhets2016-09-072-47/+60
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | Add more tests for merge request versions featureDmitriy Zaporozhets2016-09-072-3/+26
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | Improve merge request version switch/compare dropdownDmitriy Zaporozhets2016-09-074-39/+65
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | Compare merge request version against other version on changes pageDmitriy Zaporozhets2016-09-073-13/+34
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | Add link to compare merge request versionsDmitriy Zaporozhets2016-09-072-0/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It adds a dropdown to the right of merge request version dropdown and allow you to choose older version for compare. Once clicked it will take user to compare page with older and newer versions sha pre-filled Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | | | Merge branch 'enable-rspec-formatter' into 'master' Kamil Trzciński2016-09-081-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enable rspec documentation formatter and color output Current rspec just outputs a `=` as each test runs. This enables the documentation formatter and color output to make it easier to know what is going on with each spec. See merge request !5924
| * | | | | Add color to rspec outputenable-rspec-formatterStan Hu2016-08-201-1/+1
| | | | | |
| * | | | | Enable rspec documentation formatterStan Hu2016-08-201-1/+1
| | | | | |
* | | | | | Merge branch ↵Douwe Maan2016-09-086-71/+125
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '21109-discussion-resolve-runs-a-single-update-query-per-note-but-should-run-a-single-update-query-for-all-notes-instead' into 'master' Optimize discussion notes resolving and unresolving ## What does this MR do? Optimize discussion notes resolving and unresolving ## Are there points in the code the reviewer needs to double check? Some changes had to be made to the discussion spec to account for the fact that notes are not individually updated now. I only focused on adapting them for the purpose of the regression fix, but admittedly they could be further improved in readability. ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #21109 See merge request !6141
| * | | | | | Optimize discussion notes resolving and unresolving21109-discussion-resolve-runs-a-single-update-query-per-note-but-should-run-a-single-update-query-for-all-notes-insteadAlejandro Rodríguez2016-09-066-71/+125
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use `update_all` to only require one query per discussion to update the notes resolved status. Some changes had to be made to the discussion spec to accout for the fact that notes are not individually updated now
* | | | | | | Merge branch 'ref-update-multiple-commits' into 'master' Douwe Maan2016-09-082-16/+53
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow updating a branch by multiple commits In https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6130 we made Repository#commit_with_hooks a bit too strict; it only allowed updating a branch by one commit. It turns out there is a feature in GitLab Enterprise Edition where we update by multiple commits. This change makes that possible, adds tests, and renames the method to the more appropriate 'update_branch_with_hooks'. See merge request !6246
| * | | | | | | Express intentions as expectationsJacob Vosmaer2016-09-071-5/+19
| | | | | | | |
| * | | | | | | Rename {commit,update_branch}_with_hooksJacob Vosmaer2016-09-072-17/+17
| | | | | | | |
| * | | | | | | Allow adding multiple commits in commit_with_hooksJacob Vosmaer2016-09-072-1/+24
| | | | | | | |
* | | | | | | | Merge branch 'update-changelog-with-8-11-5' into 'master' Stan Hu2016-09-081-9/+8
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update CHANGELOG entries for 8.11.5. See merge request !6255
| * | | | | | | | Update CHANGELOG entries for 8.11.5.update-changelog-with-8-11-5Ruben Davila2016-09-071-9/+8
| | |_|_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | I've also removed some duplicates from 8.11.4.
* | | | | | | | Merge branch 'change-update-interval-of-runners' into 'master' Yorick Peterse2016-09-084-5/+8
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change update interval of runners when trying to preserve contacted_at See merge request !6126
| * | | | | | | | Change update interval of runners when trying to preserve contacted_atchange-update-interval-of-runnersKamil Trzcinski2016-09-074-5/+8
| | | | | | | | |
* | | | | | | | | Merge branch '21772-expand-gl-method-names-in-importer-classes' into 'master' Rémy Coutable2016-09-086-10/+10
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename `gl_user_id` to `gitlab_user_id` in importer classes Closes #21772 See merge request !6254
| * | | | | | | | | Rename `gl_user_id` to `gitlab_user_id` in importer classesAndrew Smith2016-09-086-10/+10
| | |/ / / / / / / | |/| | | | | | |
* | | | | | | | | Merge branch 'sh-update-db-schema' into 'master' Yorick Peterse2016-09-081-1/+1
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | Fix DB schema to match latest migration See merge request !6256
| * | | | | | | | Fix DB schema to match latest migrationsh-update-db-schemaStan Hu2016-09-081-1/+1
|/ / / / / / / /
* | | | | | | | Merge branch 'fix-random-failing-tests' into 'master' Stan Hu2016-09-081-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix randomly failing specs (possibly caused by DatabaseCleaner) ## What does this MR do? This MR ensures that DatabaseCleaner.clean runs AFTER Capybara's cleanup. This is needed because it *seems* like database is being truncated before capybara session ends, which leads to `undefined method ... for nil:NilClass` exceptions causing tests to randomly fail. ## Are there points in the code the reviewer needs to double check? Failing spec is https://gitlab.com/gitlab-org/gitlab-ce/blob/master/spec/features/boards/boards_spec.rb. Here are some examples of failed builds: - https://gitlab.com/gitlab-org/gitlab-ce/builds/3352437 - https://gitlab.com/certik/gitlab-ce/builds/3359940 - https://gitlab.com/gitlab-org/gitlab-ee/builds/3365914 ## Why was this MR needed? I've noticed that many branches suffer from random failures and it's not very comfortable for big test suite. Re-running builds until they pass is not a solution so I tried to come up with a fix. Unfortunately I can't be 100% sure about this fix (flaky test is always green on my local environment, so I can't be sure if green build on CI is false-positive or not), but if database is really being cleaned too early (which is clearly proved by logs provided here https://gitlab.com/gitlab-org/gitlab-ce/issues/21841#note_14926675 then it's very likely that this fix will help to get rid of random failures. Also it's officially recommended in DatabaseCleaner README to use `append_after` hook instead of just `after` because of the way RSpec runs after hooks (in reverse order): > It's also recommended to use append_after to ensure DatabaseCleaner.clean runs after the after-test cleanup capybara/rspec installs. ([source](https://github.com/DatabaseCleaner/database_cleaner#rspec-with-capybara-example)) ## What are the relevant issue numbers? #21197 See merge request !6198
| * | | | | | | | Make sure DatabaseCleaner.clean runs AFTER Capybara's cleanupAirat Shigapov2016-09-041-1/+1
| | | | | | | | |
* | | | | | | | | Merge branch 'feature/prune-old-events' into 'master' Yorick Peterse2016-09-074-0/+45
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added cron to prune events older than 12 months. See merge request !6200
| * | | | | | | | | Optimized event pruning query to avoid two queries.Olaf Tomalka2016-09-072-4/+12
| | | | | | | | | |
| * | | | | | | | | Limited amount of pruned Event rows per runOlaf Tomalka2016-09-073-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Old deployments of Gitlab might have a big number of old events to be deleted. Such numbers cause the worker to timeout. I've limited the amount of rows that should be destroyed at once to 10000, and increased how often pruning shall take place to 4 times a day.
| * | | | | | | | | Added cron to prune events older than 12 months.Olaf Tomalka2016-09-074-0/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since contribution calendar shows only 12 months of activity, events older than that time are not visible anywhere and can be safely pruned saving big amount of database storage. Fixes #21164
* | | | | | | | | | Merge branch 'blame-ui-fix' into 'master' Annabel Dunstone Gray2016-09-074-21/+8
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix layout issues with blame table ## What does this MR do? Fixes layout issues with the blame before. Previously the content would expanded out of the table making it look ugly! ## Screenshots (if relevant) ![Screen_Shot_2016-09-06_at_10.36.17](/uploads/719fc7cdf909b18afbe8afafbae7d99a/Screen_Shot_2016-09-06_at_10.36.17.png) ## What are the relevant issue numbers? Closes #21216 See merge request !6218
| * | | | | | | | | | Fix layout issues with blame tableblame-ui-fixPhil Hughes2016-09-064-21/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #21216