summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* remove issue_show webpack bundle in favor of pages/projects/issues/show/index.jsremove-issues-showMike Greiling2018-02-233-5/+1
|
* Merge branch 'docs-fix-empty-line' into 'master'Jacob Schatz2018-02-231-3/+3
|\ | | | | | | | | Add missing empty line at the end of file See merge request gitlab-org/gitlab-ce!17303
| * Add missing empty line at the end of filedocs-fix-empty-lineClement Ho2018-02-221-3/+3
| |
* | Merge branch 'dispatcher-if' into 'master'Mike Greiling2018-02-231-24/+27
|\ \ | | | | | | | | | | | | Convert switch into if statement See merge request gitlab-org/gitlab-ce!17304
| * | Convert switch into if statementdispatcher-ifClement Ho2018-02-221-24/+27
| | |
* | | Merge branch 'dm-stuck-import-jobs-verify' into 'master'Sean McGivern2018-02-233-38/+65
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Verify project import status again before marking as failed Closes #43539 See merge request gitlab-org/gitlab-ce!17319
| * | | Remove changelog item that already went into EEDouwe Maan2018-02-231-5/+0
| | | |
| * | | Verify project import status again before marking as failedDouwe Maan2018-02-233-31/+48
| | | |
| * | | Adds scheduled import jobs to the stuck import jobs detection worker.Tiago Botelho2018-02-233-11/+26
| | | |
* | | | Merge branch ↵bjk/kube_state_metricsKamil Trzciński2018-02-233-3/+8
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '43496-error-message-for-gke-clusters-persists-in-the-next-page' into 'master' Resolve "Error message for GKE clusters persists in the next page" Closes #43496 See merge request gitlab-org/gitlab-ce!17299
| * | | | Add CHANGELOG entry43496-error-message-for-gke-clusters-persists-in-the-next-pageMatija Čupić2018-02-221-0/+5
| | | | |
| * | | | Do not persist Google Project Billing Failure errors after a reloadMatija Čupić2018-02-222-3/+3
| | |_|/ | |/| |
* | | | Merge branch '42545-milestion-quick-actions-for-groups' into 'master'Douwe Maan2018-02-239-60/+75
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Milestone Quick Action not displayed with no project milestones but with group milestones" Closes #42545 See merge request gitlab-org/gitlab-ce!17239
| * | | | Resolve "Milestone Quick Action not displayed with no project milestones but ↵🙈 jacopo beschi 🙉2018-02-239-60/+75
|/ / / / | | | | | | | | | | | | with group milestones"
* | | | Merge branch 'users-autocomplete' into 'master'Douwe Maan2018-02-2311-19/+78
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | Improve performance of searching for and auto completing of users See merge request gitlab-org/gitlab-ce!17158
| * | | Added changelog for user search improvementsusers-autocompleteYorick Peterse2018-02-223-5/+8
| | | |
| * | | Optimise searching for users using short queriesYorick Peterse2018-02-226-5/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This optimises searching for users when using queries consisting out of one or two characters such as "ab". We optimise such cases by searching for `LOWER(name)` and `LOWER(username)` instead of using `ILIKE`. Using `LOWER` produces a _much_ better performing query. For example, when searching for all users matching the term "a" we'd produce the following plan: Limit (cost=637.69..637.74 rows=20 width=805) (actual time=41.983..41.995 rows=20 loops=1) Buffers: shared hit=8330 -> Sort (cost=637.69..638.61 rows=368 width=805) (actual time=41.982..41.990 rows=20 loops=1) Sort Key: (CASE WHEN ((name)::text = 'a'::text) THEN 0 WHEN ((username)::text = 'a'::text) THEN 1 WHEN ((email)::text = 'a'::text) THEN 2 ELSE 3 END), name Sort Method: top-N heapsort Memory: 35kB Buffers: shared hit=8330 -> Bitmap Heap Scan on users (cost=75.47..627.89 rows=368 width=805) (actual time=9.452..41.305 rows=277 loops=1) Recheck Cond: (((name)::text ~~* 'a'::text) OR ((username)::text ~~* 'a'::text) OR ((email)::text = 'a'::text)) Rows Removed by Index Recheck: 7601 Heap Blocks: exact=7636 Buffers: shared hit=8327 -> BitmapOr (cost=75.47..75.47 rows=368 width=0) (actual time=8.290..8.290 rows=0 loops=1) Buffers: shared hit=691 -> Bitmap Index Scan on index_users_on_name_trigram (cost=0.00..38.85 rows=180 width=0) (actual time=4.369..4.369 rows=4071 loops=1) Index Cond: ((name)::text ~~* 'a'::text) Buffers: shared hit=360 -> Bitmap Index Scan on index_users_on_username_trigram (cost=0.00..34.41 rows=188 width=0) (actual time=3.896..3.896 rows=4140 loops=1) Index Cond: ((username)::text ~~* 'a'::text) Buffers: shared hit=328 -> Bitmap Index Scan on users_email_key (cost=0.00..1.94 rows=1 width=0) (actual time=0.022..0.022 rows=0 loops=1) Index Cond: ((email)::text = 'a'::text) Buffers: shared hit=3 Planning time: 3.912 ms Execution time: 42.171 ms With the changes in this commit we now produce the following plan instead: Limit (cost=13257.48..13257.53 rows=20 width=805) (actual time=1.567..1.579 rows=20 loops=1) Buffers: shared hit=287 -> Sort (cost=13257.48..13280.93 rows=9379 width=805) (actual time=1.567..1.572 rows=20 loops=1) Sort Key: (CASE WHEN ((name)::text = 'a'::text) THEN 0 WHEN ((username)::text = 'a'::text) THEN 1 WHEN ((email)::text = 'a'::text) THEN 2 ELSE 3 END), name Sort Method: top-N heapsort Memory: 35kB Buffers: shared hit=287 -> Bitmap Heap Scan on users (cost=135.66..13007.91 rows=9379 width=805) (actual time=0.194..1.107 rows=277 loops=1) Recheck Cond: ((lower((name)::text) = 'a'::text) OR (lower((username)::text) = 'a'::text) OR ((email)::text = 'a'::text)) Heap Blocks: exact=277 Buffers: shared hit=287 -> BitmapOr (cost=135.66..135.66 rows=9379 width=0) (actual time=0.152..0.152 rows=0 loops=1) Buffers: shared hit=10 -> Bitmap Index Scan on yorick_test_users (cost=0.00..124.75 rows=9377 width=0) (actual time=0.101..0.101 rows=277 loops=1) Index Cond: (lower((name)::text) = 'a'::text) Buffers: shared hit=4 -> Bitmap Index Scan on index_on_users_lower_username (cost=0.00..1.94 rows=1 width=0) (actual time=0.035..0.035 rows=1 loops=1) Index Cond: (lower((username)::text) = 'a'::text) Buffers: shared hit=3 -> Bitmap Index Scan on users_email_key (cost=0.00..1.94 rows=1 width=0) (actual time=0.014..0.014 rows=0 loops=1) Index Cond: ((email)::text = 'a'::text) Buffers: shared hit=3 Planning time: 0.303 ms Execution time: 1.687 ms Here we can see the new query is 25 times faster compared to the old query.
| * | | Removed pagination from AutocompleteUsersFinderYorick Peterse2018-02-224-11/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The frontend code doesn't use this so there's no practical point in supporting this. We also hardcode the limit to 20 so users can no longer request their own limit, which could overload the database (depending on any upper bounds perhaps enforced by Kaminari).
| * | | Don't pluck IDs in AutocompleteUsersFinderYorick Peterse2018-02-221-3/+7
| |/ / | | | | | | | | | | | | | | | We can instead just use a UNION. This removes the need for plucking hundreds if not thousands of IDs into memory when a project has many members.
* | | Merge branch 'dm-go-get-api-token' into 'master'Nick Thomas2018-02-234-17/+97
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Allow token authentication on go-get request Closes #42817 See merge request gitlab-org/gitlab-ce!17148
| * | | Allow token authentication on go-get requestDouwe Maan2018-02-234-17/+97
|/ / /
* | | Merge branch '43261-fix-import-from-url-name-collision-active-tab' into 'master'Phil Hughes2018-02-234-9/+28
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Keep "Import project" tab/form active when validation fails trying to import "Repo by URL" Closes #43261 See merge request gitlab-org/gitlab-ce!17136
| * | | Make import tab/form active when importing project by URL and validation fails43261-fix-import-from-url-name-collision-active-tabEric Eastwood2018-02-204-9/+28
| | | | | | | | | | | | | | | | See https://gitlab.com/gitlab-org/gitlab-ce/issues/43261
* | | | Merge branch 'bvl-external-auth-port' into 'master'Douwe Maan2018-02-23114-348/+2509
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Port `read_cross_project` ability from EE See merge request gitlab-org/gitlab-ce!17208
| * | | | Use `Redactor` to hide cross project informationbvl-external-auth-portBob Van Landuyt2018-02-226-93/+70
| | | | | | | | | | | | | | | | | | | | | | | | | Since the redactor can be run on multiple documents at once and query results are stored in the request store.
| * | | | Port `read_cross_project` ability from EEBob Van Landuyt2018-02-22115-346/+2530
| | | | |
* | | | | Merge branch '42938-add-tip-push-to-create' into 'master'Phil Hughes2018-02-2311-10/+118
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add Tip about Push to Create project on New Project page Closes #42938 See merge request gitlab-org/gitlab-ce!17154
| * | | | | Add Tip about Push to Create project on New Project pageAndré Luís2018-02-2311-10/+118
|/ / / / /
* | | | | Merge branch '41619-turn-on-legacy-authorization-for-new-clusters-on-gke' ↵Kamil Trzciński2018-02-224-3/+15
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | into 'master' Enable "Legacy Authorization" by default when creating a Cluster on GCP Closes #41619 See merge request gitlab-org/gitlab-ce!17302
| * | | | | Modify cluster creation API method to enable legacy_apac as defaultMayra Cabrera2018-02-224-3/+15
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GKE 1.8 has RBAC on by default, since GKE has bumped the default version to 1.8.7 RBAC is now on, and we don't support that out of the box. This was also avoiding cluster applications (tiller, prometheus, etc), to be installed. Closes #41619
* | | | | Merge branch '42431-add-auto-devops-and-clusters-button-to-projects' into ↵Rémy Coutable2018-02-2228-449/+1156
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Add a button on the project page to set up a Kubernetes cluster and enable Auto DevOps Closes #42431 See merge request gitlab-org/gitlab-ce!16900
| * | | | | Unify use of can_current_user_push_code Presenter42431-add-auto-devops-and-clusters-button-to-projectsOswaldo Ferreira2018-02-222-2/+2
| | | | | |
| * | | | | Use select instead rejectOswaldo Ferreira2018-02-221-2/+2
| | | | | |
| * | | | | Move can_current_user_push_to_branch to PresenterOswaldo Ferreira2018-02-223-8/+10
| | | | | |
| * | | | | Simplify project check with duck typingOswaldo Ferreira2018-02-221-1/+1
| | | | | |
| * | | | | Move project presenter instance creation to controllerOswaldo Ferreira2018-02-223-2/+2
| | | | | |
| * | | | | Update enabled Kubernetes cluster button to "Kubernetes configured"Eric Eastwood2018-02-223-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16900#note_60175507
| * | | | | Merge branch 'master' into 42431-add-auto-devops-and-clusters-button-to-projectsEric Eastwood2018-02-22895-10376/+10646
| |\ \ \ \ \
| * | | | | | Remove indent and reduce bloat with link_to_ifEric Eastwood2018-02-221-10/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16900#note_60163789 - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16900#note_60164324
| * | | | | | Fix enabled filtering on stat anchorsEric Eastwood2018-02-211-4/+4
| | | | | | |
| * | | | | | Link "add a Kubernetes cluster" to new cluster pageEric Eastwood2018-02-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16900#note_59936315
| * | | | | | Make ruby-lint happyOswaldo Ferreira2018-02-211-2/+2
| | | | | | |
| * | | | | | Use method call instead hash accessesOswaldo Ferreira2018-02-211-4/+4
| | | | | | |
| * | | | | | Memoize method which is called multiple times on presenterOswaldo Ferreira2018-02-201-4/+7
| | | | | | |
| * | | | | | Add unit tests to presenter methodsOswaldo Ferreira2018-02-202-33/+315
| | | | | | |
| * | | | | | Use OpenStruct instead Hash for statistics buttonsOswaldo Ferreira2018-02-202-100/+62
| | | | | | |
| * | | | | | Improve methods namingOswaldo Ferreira2018-02-203-9/+9
| | | | | | |
| * | | | | | Move default_project_view tests to presenterOswaldo Ferreira2018-02-204-102/+97
| | | | | | |
| * | | | | | Move button list logic to project presenterOswaldo Ferreira2018-02-2015-381/+416
| | | | | | |
| * | | | | | Switch back to using a single partialEric Eastwood2018-02-202-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16900#note_59334967 https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16900#note_59714883
View Lorry Controller Status