summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* ensure webpack dev server proxy connects regardless of request headersfix-webpack-dev-server-proxyMike Greiling2017-02-271-6/+6
|
* Merge branch 'remove-require-context-application-bundle' into 'master' Alfredo Sumaran2017-02-241-11/+170
|\ | | | | | | | | Remove require.context from application.js See merge request !9491
| * add missing require statement and don't require selfremove-require-context-application-bundleMike Greiling2017-02-231-1/+1
| |
| * remove require.context from application.jsMike Greiling2017-02-231-11/+170
| |
* | Merge branch 'user-callouts' into 'master' Filipa Lacerda2017-02-2410-0/+185
|\ \ | | | | | | | | | | | | | | | | | | Added user-callouts Closes #27269 See merge request !9249
| * | Corrected indentation on the template stringuser-calloutsJose Ivan Vargas2017-02-241-10/+9
| | | | | | | | | | | | Also removed eslint disabled rules
| * | Fix failing specsAlfredo Sumaran2017-02-231-5/+9
| | |
| * | Modified the user_callout behaviourJose Ivan Vargas2017-02-237-45/+44
| | | | | | | | | | | | | | | Now it appends a template instead of relying in a partial to show it.
| * | Removed disabled rules from the user_callout_spec.jsJose Ivan Vargas2017-02-234-17/+12
| | | | | | | | | | | | | | | | | | | | | Also changed the cookie sets to true and false values to make it consistent with the rest of the javascript. Fixed some haml and a missing new line
| * | Moved the dismiss-icon listener to close the callout to a buttonJose Ivan Vargas2017-02-235-7/+7
| | |
| * | Changed the javascript class from using the global scope to exporting it via ↵Jose Ivan Vargas2017-02-239-78/+73
| | | | | | | | | | | | | | | | | | webpack Also improved accesibility and change the id from user_callouts to a class
| * | Added CHANGELOG and corrected linter errorsJose Ivan Vargas2017-02-235-4/+7
| | |
| * | Created unit tests, fixtures and integration testsJose Ivan Vargas2017-02-2310-33/+142
| | | | | | | | | | | | | | | Also changed the user_callout haml to a partial and added the corresponding SVG icon
| * | Initial version of the user-calloutsJose Ivan Vargas2017-02-235-2/+83
| | |
* | | Merge branch 'remove-require-context-profile-bundle' into 'master' Alfredo Sumaran2017-02-241-3/+2
|\ \ \ | | | | | | | | | | | | | | | | Remove require.context from profile_bundle See merge request !9492
| * | | remove require.context from profile_bundleremove-require-context-profile-bundleMike Greiling2017-02-231-3/+2
| | | |
* | | | Merge branch 'remove-require-context-protected-branches-bundle' into 'master' Alfredo Sumaran2017-02-241-3/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Remove require.context from protected_branches_bundle See merge request !9493
| * | | | remove require.context from protected_branches_bundleremove-require-context-protected-branches-bundleMike Greiling2017-02-231-3/+5
| |/ / /
* | | | Merge branch 'remove-require-context-snippet-bundle' into 'master' Alfredo Sumaran2017-02-241-4/+0
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Remove require.context from snippet_bundle See merge request !9494
| * | | | remove require.context from snippet_bundleremove-require-context-snippet-bundleMike Greiling2017-02-231-4/+0
| |/ / /
* | | | Merge branch 'remove-require-context-users-bundle' into 'master' Alfredo Sumaran2017-02-241-3/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Remove require.context from users_bundle See merge request !9496
| * | | | remove require.context from users_bundleremove-require-context-users-bundleMike Greiling2017-02-231-3/+1
| |/ / /
* | | | Merge branch 'remove-jquery-ui-plugins' into 'master' Jacob Schatz2017-02-2413-63/+76
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Removed jQuery UI highlight & autocomplete See merge request !8420
| * | | | Removed jQuery UI highlight & autocompleteremove-jquery-ui-pluginsPhil Hughes2017-02-0913-63/+76
| | | | | | | | | | | | | | | | | | | | In an effort to tackle #18437 this removes 2 of the jQuery UI plugins. Highlight & autocomplete, both used once in our code. Highlight was just removed easily, autocomplete was replaced with GL dropdown
* | | | | Merge branch '28366-renamed-file-tooltip-contains-html' into 'master' Filipa Lacerda2017-02-242-2/+6
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Renamed file tooltip contains html" Closes #28366 See merge request !9374
| * | | | | Remove markup showing in tooltip for renamed files in diff view28366-renamed-file-tooltip-contains-htmlSam Rose2017-02-202-2/+6
| | | | | |
* | | | | | Merge branch 'refactor-graphs-bundle' into 'master' Filipa Lacerda2017-02-248-558/+507
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor graphs bundle to ES module syntax See merge request !9502
| * | | | | | refactor stat_graph_contributors to es6 module syntaxrefactor-graphs-bundleMike Greiling2017-02-242-102/+100
| | | | | | |
| * | | | | | refactor stat_graph_contributors_graph to es6 module syntaxMike Greiling2017-02-244-282/+274
| | | | | | |
| * | | | | | refactor stat_graph_contributors_util to es6 module syntaxMike Greiling2017-02-244-137/+135
| | | | | | |
| * | | | | | remove unused StatGraph classMike Greiling2017-02-243-39/+0
| | |_|/ / / | |/| | | |
* | | | | | Merge branch 'boards-card-template-to-js' into 'master' Filipa Lacerda2017-02-246-74/+239
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Issue boards card template in JS See merge request !9477
| * | | | | | Fixed eslint errorsboards-card-template-to-jsPhil Hughes2017-02-232-11/+15
| | | | | | |
| * | | | | | Issue boards card in JSPhil Hughes2017-02-236-74/+235
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moved the issue boards card template into the JS. This helps to improve the code coverage & will eventually make it easier to move this to .vue files
* | | | | | | Merge branch '28367-fix-unfold-diff-line-number-copy-paste' into 'master' Jacob Schatz2017-02-242-2/+6
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixes line number copy issue for unfolded parallel view diff Closes #28367 See merge request !9365
| * | | | | | | fixes line number copy issue for unfolded parallel view diff28367-fix-unfold-diff-line-number-copy-pasteNur Rony2017-02-202-2/+6
| | | | | | | |
* | | | | | | | Merge branch '27847-auth0-doc-typo' into 'master' Achilleas Pipinellis2017-02-241-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix typo in auth0.md doc Closes #27847 See merge request !9059
| * | | | | | | | Fix typo in auth0.md doc 27847-auth0-doc-typoReb2017-02-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Removed spurious character from Omnibus example
* | | | | | | | | Merge branch '12726-preserve-issues-after-deleting-users' into 'master' Douwe Maan2017-02-2418-18/+320
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Deleting a user shouldn't delete associated issues. Closes #12726 See merge request !7393
| * | | | | | | | | Fix specs for the ghost user feature.12726-preserve-issues-after-deleting-usersTimothy Andrew2017-02-242-3/+5
| | | | | | | | | |
| * | | | | | | | | Don't allow deleting a ghost user.Timothy Andrew2017-02-248-5/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Add a `destroy_user` ability. This didn't exist before, and was implicit in other abilities (only admins could access the admin area, so only they could destroy all users; a user can only access their own account page, and so can destroy only themselves). - Grant this ability to admins, and when the current user is trying to destroy themselves. Disallow destroying ghost users in all cases. - Modify the `Users::DestroyService` to check this ability. Also check it in views to decide whether or not to show the "Delete User" button. - Add a short summary of the Ghost User to the bio.
| * | | | | | | | | Implement final review comments from @DouweM and @rymaiTimothy Andrew2017-02-246-61/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Have `Uniquify` take a block instead of a Proc/function. This is more idiomatic than passing around a function in Ruby. - Block a user before moving their issues to the ghost user. This avoids a data race where an issue is created after the issues are migrated to the ghost user, and before the destroy takes place. - No need to migrate issues (to the ghost user) in a transaction, because we're using `update_all` - Other minor changes
| * | | | | | | | | Remove the default value for the `users.ghost` database column.Timothy Andrew2017-02-242-7/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The default (false) is not strictly required, and this lets us avoid a potentially expensive migration
| * | | | | | | | | Implement review comments from @rymai and @yorickpeterseTimothy Andrew2017-02-244-81/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Refactoring and specs in the `Uniquify` class. 2. Don't use the `AdvisoryLocking` class. Similar functionality is provided (backed by Redis) in the `ExclusiveLease` class.
| * | | | | | | | | Use a `ghost` boolean to track ghost users.Timothy Andrew2017-02-246-6/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rather than using a separate `ghost` state. This lets us have the benefits of both ghost and blocked users (ghost: true, state: blocked) without having to rewrite a number of queries to include cases for `state: ghost`.
| * | | | | | | | | Implement review comments from @DouweM and @nick.thomas.Timothy Andrew2017-02-243-2/+85
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Use an advisory lock to guarantee the absence of concurrency in `User.ghost`, to prevent data races from creating more than one ghost, or preventing the creation of ghost users by causing validation errors. 2. Use `update_all` instead of updating issues one-by-one.
| * | | | | | | | | Extract code from `Namespace#clean_path` for ghost user generation.Timothy Andrew2017-02-244-24/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Create a `Uniquify` class, which generalizes the process of generating unique strings, by accepting a function that defines what "uniqueness" means in a given context. 2. WIP: Make sure tests for `Namespace` pass, add more if necessary. 3. WIP: Add tests for `Uniquify`
| * | | | | | | | | Deleting a user shouldn't delete associated issues.Timothy Andrew2017-02-245-4/+129
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - "Associated" issues are issues the user has created + issues that the user is assigned to. - Issues that a user owns are transferred to a "Ghost User" (just a regular user with `state = 'ghost'` that is created when `User.ghost` is called). - Issues that a user is assigned to are moved to the "Unassigned" state. - Fix a spec failure in `profile_spec` — a spec was asserting that when a user is deleted, `User.count` decreases by 1. After this change, deleting a user creates (potentially) a ghost user, causing `User.count` not to change. The spec has been updated to look for the relevant user in the assertion.
| * | | | | | | | | Don't send notifications to ghost users.Timothy Andrew2017-02-241-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We already skip sending notifications to blocked users. Simply add ghost users to this list.
| * | | | | | | | | Add CE CHANGELOG for #12726.Timothy Andrew2017-02-241-0/+4
| | | | | | | | | |