| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
This continues our emerging standard of including this attribute for
resources that have web-accessible endpoints.
|
|\
| |
| |
| |
| |
| |
| | |
Fixed boards card dragging styling
Closes #61050
See merge request gitlab-org/gitlab-ce!27802
|
| |
| |
| |
| | |
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61050
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fix base domain help text update
Closes #61036
See merge request gitlab-org/gitlab-ce!27746
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Internationalisation of javascript/m* directories
See merge request gitlab-org/gitlab-ce!27723
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is one of many MRs opened in order to improve the overall
internationalisation of the GitLab codebase.
i18n documentation
https://docs.gitlab.com/ee/development/i18n/externalization.html
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Internationalisation of vue_shared directory
See merge request gitlab-org/gitlab-ce!27751
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is one of many MRs opened in order to improve the overall
internationalisation of the GitLab codebase.
This commit only targets the Vanilla JS files.
i18n documentation
https://docs.gitlab.com/ee/development/i18n/externalization.html
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Update dependency @gitlab/ui to ^3.7.0
See merge request gitlab-org/gitlab-ce!27832
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
into 'master'
Resolve "Project is being serialized when enqueueing to sidekiq"
Closes #59265
See merge request gitlab-org/gitlab-ce!27825
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`Todos::Destroy::EntityLeaveService#project_ids` was returning
ActiveRecord objects with IDs, not simply IDs. That means we were
serialising more than we needed to in Sidekiq.
We can simply rename this method to `#projects` as this class doesn't
use any of the superclass methods that would use `#project_ids`.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Prevent concurrent execution of PipelineScheduleWorker
Closes gitlab-com/gl-infra/production#805
See merge request gitlab-org/gitlab-ce!27781
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Currently, PipelineScheduleWorker is fired in a short period on
our production server. We can stop this behavior by locking the
execution thread with in_lock method.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Change comments to point to the new path of sidekiq-cluster
See merge request gitlab-org/gitlab-ce!27707
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`sidekiq-cluster` is moved from `bin/` to `ee/bin` in EE code. This
is a corresponding change in CE.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Upgrade letter_opener_web to support Rails 5.1
See merge request gitlab-org/gitlab-ce!27829
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Before this commit using `/rails/letter_opener` in `development`
environment failed with:
undefined method `before_filter'
See https://github.com/fgrehm/letter_opener_web/issues/68
This commit upgrades `letter_opener_web` to 1.3.4 so Rails 5.1 is
supported.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Add full backtrace for RSpec output
See merge request gitlab-org/gitlab-ce!27686
|
| | |_|/ / / /
| |/| | | | |
| | | | | | |
| | | | | | | |
Attempt to debug https://gitlab.com/gitlab-org/gitlab-ce/issues/60953
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Upgrade Gitaly to v1.36.0
See merge request gitlab-org/gitlab-ce!27831
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Make `CI_COMMIT_REF_NAME` and `SLUG` variable idempotent
Closes #60822
See merge request gitlab-org/gitlab-ce!27663
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
With Pipelines for Merge Requests feature, users cannout keep using
$CI_COMMIT_REF_NAME and _SLUG predefined variables for dynamic
environments. We fix this problem by explicitly looking at the source
ref.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Move test method to the bottom
See merge request gitlab-org/gitlab-ce!27816
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
The reason for the change is that reading the code it should be si-
milar to reading a newspaper, where high-level information is at
the top, like the title and summary of the news, and low level, or
more specific information, are at the bottom.
This improves code readability.
|
|\ \ \ \ \ \ \ \ \
| |_|_|_|_|_|/ / /
|/| | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Internationalisation of cycle_analytics directory
See merge request gitlab-org/gitlab-ce!27674
|
|/ / / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This is one of many MRs opened in order to improve the overall
internationalisation of the GitLab codebase.
i18n documentation
https://docs.gitlab.com/ee/development/i18n/externalization.html
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Format extra help page text like wiki
Closes #55948
See merge request gitlab-org/gitlab-ce!26782
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
The instance specific help text was not rendered in any way compatible
with the look and feel of the rest of the page. Just re-use the wiki
style like the rest of the page.
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
CE Backport: Prefer usage of helper `expanded_by_default?`
See merge request gitlab-org/gitlab-ce!27729
|
|/ / / / / / / / /
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Stop using `Rails.env.test?` in views.
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
CE: Fixes EE differences for app/views/projects/new.html.haml
See merge request gitlab-org/gitlab-ce!27617
|
| | | | | | | | | | |
|
|\ \ \ \ \ \ \ \ \ \
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
Use keyword args for databuilder push
See merge request gitlab-org/gitlab-ce!24088
|
| | | | | | | | | | | |
|
|\ \ \ \ \ \ \ \ \ \ \ |
|
| |\ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | | |
Internationalisation of groups directory
See merge request gitlab-org/gitlab-ce!27679
|
| |/ / / / / / / / / / /
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
This is one of many MRs opened in order to improve the overall
internationalisation of the GitLab codebase.
i18n documentation
https://docs.gitlab.com/ee/development/i18n/externalization.html
|
| |\ \ \ \ \ \ \ \ \ \ \
| | |_|_|_|_|_|/ / / / /
| |/| | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
Fix slow performance with compiling HAML templates
Closes gitlab-ee#11198
See merge request gitlab-org/gitlab-ce!27782
|
| | | | | | | | | | | | |
|
| |/ / / / / / / / / /
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
In Rails 5, including `ActionView::Context` can have a significant and
hidden performance penalty because this module also includes
`ActionView::CompiledTemplates`. This means that any module that
includes ActionView::Context becomes a descendant of
`CompiledTemplates`.
When a partial is rendered for the first time, it runs
`ActionView::CompiledTemplates#module_eval`, which will evaluate a
string that defines a new method for that partial. For example, the
source of partial might be this string:
```
def _app_views_project_show_html_haml___12345(local_assigns, output)
"hello world"
end
```
When this string is evaluated, the Ruby interpreter will define the
method and clear the global method cache for all descendants of
`ActionView::CompiledTemplates`. Previous to this change, we
inadvertently made a number of modules fall into this category:
* GroupChildEntity
* NoteUserEntity
* Notify
* MergeRequestUserEntity
* AnalyticsCommitEntity
* CommitEntity
* UserEntity
* Kaminari::Helpers::Paginator
* CurrentUserEntity
* ActionView::Base
* ActionDispatch::DebugExceptions::DebugView
* MarkupHelper
* MergeRequestPresenter
After this change:
* Kaminari::Helpers::Paginator
* ActionView::Base
* ActionDispatch::DebugExceptions::DebugView
Each time a partial is rendered for the first time, all methods for
those modules will have to be redefined. This can exact a significant
performance penalty.
How bad is this penalty? Using the following benchmark script, we can
use DTrace to sample the Ruby interpreter:
```
Benchmark.bm do |x|
x.report do
1000.times do
ActionView::CompiledTemplates.module_eval("def testme\nend")
end
end
end
```
This revealed a 11x jump in the time spent in `core#define_method`
alone.
Rails 6 fixes this behavior by moving the `include CompiledTemplates`
into ActionView::Base so that including `ActionView::Context` doesn't
quietly affect other modules in this way.
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11198
|
| |\ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
Fix text based on example
See merge request gitlab-org/gitlab-ce!27787
|
| |/ / / / / / / / / / |
|
| |\ \ \ \ \ \ \ \ \ \
| | |_|_|_|/ / / / / /
| |/| | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
Fix links to wiki pages with subdirectories in search
Closes #56234
See merge request gitlab-org/gitlab-ce!27400
|
| |/ / / / / / / / /
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
This commit contains the patch suggested by @fjsanpedro in the issue
covering broken links in wiki search results.
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/56234
|
| |\ \ \ \ \ \ \ \ \
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
Upgrade CI images to use Chrome V73
See merge request gitlab-org/gitlab-ce!27762
|
| | | | | | | | | | | |
|