| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Projects that have a pipeline may need to check whether the user has
permission to read the build (`can?(current_user, :read_build,
project)`), which requires checking the `project_features` table.
This would cause an N+1 SQL query for each project.
This change also has a beneficial side effect that may avoid a race
condition. When a user deletes a project, the project is queued for
deletion and the user is redirected back to the dashboard page. However,
the following may happen:
1. The dashboard page may load this deleted project in the list of
20 projects.
2. The view will load the project pipeline status from the cache and
attempt to show each project.
3. When the view encounters the deleted project, it calls
`can?(current_user, :read_build, project)` to determine whether to
display the pipeline status.
4. Sidekiq deletes the project from the database.
5. However, since the deleted project is still loaded in memory, it will
attempt to call `project.project_feature.access_level`.
6. Since `project_feature` was not eager loaded, a lazy `SELECT` call is
made to the database.
7. This `SELECT` call returns nothing, and the user sees a 500 error.
By eager loading `project_feature`, we can ensure that we have a
consistent view and avoid records from being deleted later.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66482
|
|\
| |
| |
| |
| |
| |
| | |
Add label_id parameter to label API for PUT and DELETE
Closes #62322
See merge request gitlab-org/gitlab-ce!31804
|
|/
|
|
| |
Add specs for new parameter and updated documentation as well.
|
|\
| |
| |
| |
| | |
Handle when server info doesn't have the storage in question
See merge request gitlab-org/gitlab-ce!32023
|
| | |
|
| |
| |
| | |
[ci skip]
|
|\ \
| | |
| | |
| | |
| | | |
Eliminate Gitaly N+1 queries with notes API
See merge request gitlab-org/gitlab-ce!32089
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Similar to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31834,
we see that in https://gitlab.com/gitlab-org/gitlab-ce/issues/65957
there can be hundreds, even thousands, of Gitaly requests in the
`/api/:version/projects/:id/merge_requests/:noteable_id/notes` endpoint.
Previously, the API to retrieve notes generated hundreds of Gitaly calls
to determine whether a system note should be shown to the user. It did
this by:
1. Rendering the Markdown
2. Extracting cross-references from the Markdown
3. Issuing a Gitaly `FindCommit` RPC for every reference to validate
that the commit exists.
The last step is unnecessary because we don't need to display a commit
if the user doesn't have access to the project in the first place.
`RendersNotes#prepare_notes_for_rendering` is already used in
`MergeRequestsController`, which is why we don't see N+1 Gitaly calls
there. We use it here to optimize the note redaction process.
|
|\ \ \
| |_|/
|/| |
| | |
| | | |
Quarantine filter issue comments test
See merge request gitlab-org/gitlab-ce!32152
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Docs health check failure examples
Closes #64193
See merge request gitlab-org/gitlab-ce!31945
|
|/ / / |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
CE: Update sort options for issues list
See merge request gitlab-org/gitlab-ce!31849
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Increase sort options for issues list from updated_at and create_at,
to include more options close to what is required in actual issue list
UI.
This helps us to use REST API for issues list with sorting capabilities
https://gitlab.com/gitlab-org/gitlab-ce/issues/57402
|
|\ \ \ \
| |_|/ /
|/| | |
| | | |
| | | | |
Fail E2E tests early if template not found via API
See merge request gitlab-org/gitlab-ce!31955
|
|/ / / |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
62514 - update prometheus metrics docs
Closes #62514
See merge request gitlab-org/gitlab-ce!31987
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Strikeout for metrics that aren't reported anymore
- added :thumbsup: for all the metrics that appear to be still
available
- Added :new: for the new metrics.
- Determine Release when the new metrics appeared
- Add descriptions for the new metrics
- remove the adornments :new: and :thumbsup:
- removce the lines with strikeout
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Reduce dedup calls to gc only
See merge request gitlab-org/gitlab-ce!32083
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Hide duplicate board list while dragging
See merge request gitlab-org/gitlab-ce!32099
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Update dependencies api doc
See merge request gitlab-org/gitlab-ce!32061
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Document uploads development guidelines
Closes #63097
See merge request gitlab-org/gitlab-ce!31290
|
|/ / / /
| | | |
| | | |
| | | | |
Explain Workhorse acceleration features
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Add frozen_string_literal to lib part 2
See merge request gitlab-org/gitlab-ce!32094
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Using the sed script from
https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
into 'master'
Resolve "Git clone URL box on Wiki git access page is broken"
Closes #66022
See merge request gitlab-org/gitlab-ce!31898
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Some CSS fixes to fix the position of the git clone box on the
wiki git access page. This fix also includes fixes for various
responsive states.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
fix charts scroll handle icon
See merge request gitlab-org/gitlab-ce!31825
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Add Redis interceptor tracing
See merge request gitlab-org/gitlab-ce!30238
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This change adds Distributed Tracing support for two new types of events
1. Redis Calls
1. ActiveSupport (Rails) Caching Operations
The intention is to help application developers and infrastructure
SREs to understand the pressure that caching operations can have on
the application when running at scale.
The Redis and Caching spans can be viewed in the Jaeger UI by clicking
the "Trace" link in the performance bar when running on GDK.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Optimise UpdateBuildQueueService
Closes #66438
See merge request gitlab-org/gitlab-ce!32095
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This makes BuildQueueService to force refresh runners
that are considered to have recent queue.
Such runners are the ones that connected within online
interval + time to expire runner cache.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Update documentation screenshot
See merge request gitlab-org/gitlab-ce!31995
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Add version 12 upgrade recommendations
Closes #63907
See merge request gitlab-org/gitlab-ce!30201
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
Updates doc/policy/maintenance.md, adds upgrade path from 11 -> 12
|
|\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | |
| | | | | |
| | | | | | |
Update capitalization in /administration, /api, others
See merge request gitlab-org/gitlab-ce!32136
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
Update capitalization in /administration, /api, /ci
and /customization
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
'49392-exempt-jwt-auth-for-user-gitlab-ci-token-from-rate-limiting' into 'master'
Exempt `jwt/auth` for user `gitlab-ci-token` from rate limiting
Closes #49392
See merge request gitlab-org/gitlab-ce!31909
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Resolve "Failure in qa/specs/features/browser_ui/3_create/repository/user_views_commit_diff_patch_spec.rb"
Closes gitlab-org/quality/staging#69
See merge request gitlab-org/gitlab-ce!32087
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Optionally check for quotes and escape the name
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Add logic for respecting browser DNT setting
See merge request gitlab-org/gitlab-ce!32030
|
|/ / / / / / |
|