summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Added username to issue & merge request headerusername-issue-headerPhil Hughes2016-03-012-0/+2
| | | | Closes #13771
* Merge branch 'fix/commit-status-api-improvement' into 'master' Douwe Maan2016-03-013-58/+117
|\ | | | | | | | | | | | | | | | | | | Return empty array when commit has no statuses in API This makes API endpoint for Commit Statuses return empty array instead of 404 when commit exists, but has no statuses. Closes #3080 See merge request !3010
| * Improve commit status API specsfix/commit-status-api-improvementGrzegorz Bizon2016-03-011-30/+19
| |
| * Check if commit exists first in commit status APIGrzegorz Bizon2016-03-011-1/+1
| |
| * Add Changelog entry for commit status API changesGrzegorz Bizon2016-02-291-0/+1
| |
| * Improve commit status API specs (refactoring)Grzegorz Bizon2016-02-291-41/+76
| |
| * Return empty array when commit has no statuses in APIGrzegorz Bizon2016-02-292-41/+75
| | | | | | | | | | | | | | This makes API endpoint for Commit Statuses return empty array instead of 404 when commit exists, but has no statuses. Closes #3080
* | Merge branch 'rel-url-fix' into 'master' Douwe Maan2016-03-016-13/+30
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix relative URL See https://github.com/gitlabhq/gitlabhq/issues/10053 1. Same configuration way for relative URL like with Omnibus 2. Loading the relative configuration from Rakefile as Rails do not load initializers for `asset:precompile` First point has another positive side effect: no collisions (due to git controlled `application.rb`) any more during the upgrades of source based installations and relative url configuration - [x] tests on the source based installation - [x] tests on the centos&ubuntu omnibus packages Fixes: gitlab-org/gitlab-ce#13730, gitlab-org/gitlab-ce#13727, gitlab-org/omnibus-gitlab#1143 and https://github.com/gitlabhq/gitlabhq/issues/10053 See merge request !2979
| * | Include relative url configuration in rake tasksArtem Sidorenko2016-02-292-0/+4
| | | | | | | | | | | | | | | | | | initializers are not loaded during the rake task assets:precompile, so assets generation runs without relative url configuration in Rails and produces broken assets.
| * | Use dedicated relative_url.rb initializerArtem Sidorenko2016-02-294-13/+26
| | | | | | | | | | | | in order to have it the same way like in omnibus
* | | Merge branch 'login-flash' into 'master' Dmitriy Zaporozhets2016-03-011-0/+4
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add bottom margin for flash container on login page Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> cc @jschatz1 @skyruler Fixes #13935 See merge request !3040
| * | | Add bottom margin for flash container on login pageDmitriy Zaporozhets2016-03-011-0/+4
| | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | | Merge branch 'sidebar-overlap-fix' into 'master' Dmitriy Zaporozhets2016-03-013-3/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix issue with overlap of sidebar links. Thanks @iamphill for the help with this one. ![Screen_Shot_2016-03-01_at_10.19.52_AM](/uploads/f203fde79ae397ad18f23c4108f1c306/Screen_Shot_2016-03-01_at_10.19.52_AM.png) cc @iamphill @alfredo1 @dzaporozhets @rymai See merge request !3043
| * | | | Fix issue with overlap of sidebar links.Jacob Schatz2016-03-013-3/+3
| |/ / /
* | | | Merge branch 'rs-wiki-toc' into 'master' Douwe Maan2016-03-013-8/+85
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace Gollum `[[_TOC_]]` tag with result of TableOfContentsFilter Closes #2494 See merge request !2952
| * | | | Replace Gollum `[[_TOC_]]` tag with result of TableOfContentsFilterrs-wiki-tocRobert Speicher2016-02-233-8/+85
| | | | | | | | | | | | | | | | | | | | Closes #2494
* | | | | Merge branch 'rs-avatar-validation' into 'master' Douwe Maan2016-03-012-2/+16
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only validate avatar cropping values when avatar is present AND changed Closes #13905 See merge request !3018
| * | | | | Only validate avatar cropping values when avatar is present AND changedrs-avatar-validationRobert Speicher2016-02-292-2/+16
| | | | | | | | | | | | | | | | | | | | | | | | Closes #13905
* | | | | | Merge branch 'rs-fix-user-namespace_uniq' into 'master' Douwe Maan2016-03-011-1/+2
|\ \ \ \ \ \ | |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Properly check for a pre-existing error in `User#namespace_uniq` Rails adds an empty error to the Errors object even if you just call `#[]` on it: ``` [1] pry(main)> u = User.last [2] pry(main)> u.errors.keys => [] [3] pry(main)> u.errors[:username].present? => false [4] pry(main)> u.errors.keys => [:username] ``` See merge request !3017
| * | | | | Properly check for a pre-existing error in `User#namespace_uniq`rs-fix-user-namespace_uniqRobert Speicher2016-02-291-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails adds an empty error to the Errors object even if you just call `#[]` on it: ``` [1] pry(main)> u = User.last [2] pry(main)> u.errors.keys => [] [3] pry(main)> u.errors[:username].present? => false [4] pry(main)> u.errors.keys => [:username] ```
* | | | | | Merge branch 'rs-improve-grace-period' into 'master' Douwe Maan2016-03-014-10/+16
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't show any "2FA required" message if it's not actually required Prior, if the user had enabled and then disabled 2FA, they would be shown a "You must enable Two-factor Authentication for your account." message when going back to re-activate it, even if 2FA enforcement was disabled. See merge request !3014
| * | | | | | Don't show any "2FA required" message if it's not actually requiredrs-improve-grace-periodRobert Speicher2016-02-291-5/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior, if the user had enabled and then disabled 2FA, they would be shown a "You must enable Two-factor Authentication for your account." message when going back to re-activate it, even if 2FA enforcement was disabled.
| * | | | | | Reset `otp_grace_period_started_at` after disabling 2FARobert Speicher2016-02-293-5/+9
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior, if the user enabled 2FA, then disabled it and came back some time after the grace period expired, they would be forced to enable 2FA immediately.
* | | | | | Merge branch 'fix-failing-tests' into 'master' Kamil Trzciński2016-03-011-0/+6
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Precompile assets before all spinach tests Try to fix failing tests. cc @jschatz1 See merge request !3041
| * | | | | Precompile assets before all spinach testsKamil Trzcinski2016-03-011-0/+6
|/ / / / /
* | | | | Merge branch 'mr-prefix-activity-view' into 'master' Jacob Schatz2016-03-016-6/+7
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changed # to ! on merge requests on activity view Closes #9082 ![Screen_Shot_2016-02-23_at_11.59.55](/uploads/87b859ae63282ae24025168404beb158/Screen_Shot_2016-02-23_at_11.59.55.png) See merge request !2938
| * | | | | Changed page titlePhil Hughes2016-03-011-1/+1
| | | | | |
| * | | | | Fixed issue based on feedback with link text outputPhil Hughes2016-03-011-1/+1
| | | | | |
| * | | | | Removed un-used variablesPhil Hughes2016-03-012-3/+1
| | | | | |
| * | | | | Replaced prefix with to_reference method callsPhil Hughes2016-03-015-11/+7
| | | | | |
| * | | | | Changed # to ! on merge requests on activity viewPhil Hughes2016-03-014-5/+12
| | | | | | | | | | | | | | | | | | | | | | | | Closes #9082
* | | | | | Merge branch 'comment-batch-size' into 'master' Douwe Maan2016-03-011-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Batch size >1000 does not pay off We did a small experiment to see how a full scan of the Redis keys on gitlab.com speeds up as we increase the batch size. The values on the right are time in seconds for a full scan (no delete operations). ``` count: 10); 284.500529021 count: 100); 86.21216934 count: 1_000); 60.931676195 count: 10_000); 60.96355610 count: 100_000); 62.378172541 ``` It looks like 1,000 is a good number. See merge request !2970
| * | | | | | Batch size >1000 does not pay offcomment-batch-sizeJacob Vosmaer2016-02-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We did a small experiment to see how a full scan of the Redis keys on gitlab.com speeds up as we increase the batch size. The values on the right are time in seconds for a full scan (no delete operations). count: 10); 284.500529021 count: 100); 86.21216934 count: 1_000); 60.931676195 count: 10_000); 60.96355610 count: 100_000); 62.378172541 It looks like 1,000 is a good number.
* | | | | | | Merge branch 'safe-content-type' into 'master' Douwe Maan2016-03-013-12/+23
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Explain why we mangle blob content types Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/9079 See merge request !2956
| * | | | | | Explain why we mangle blob content typessafe-content-typeJacob Vosmaer2016-02-243-12/+23
| | | | | | |
* | | | | | | Merge branch 'rs-update-rails' into 'master' Dmitriy Zaporozhets2016-03-012-31/+31
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update Rails to 4.2.5.2 See https://groups.google.com/forum/#!msg/rubyonrails-security/ddY6HgqB2z4/we0RasMZIAAJ and https://groups.google.com/forum/#!msg/rubyonrails-security/ly-IH-fxr_Q/WLoOhcMZIAAJ See merge request !3019
| * | | | | | | Update Rails to 4.2.5.2Robert Speicher2016-02-292-31/+31
| | |_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | See https://groups.google.com/forum/#!msg/rubyonrails-security/ddY6HgqB2z4/we0RasMZIAAJ and https://groups.google.com/forum/#!msg/rubyonrails-security/ly-IH-fxr_Q/WLoOhcMZIAAJ
* | | | | | | Merge branch 'issue_13851' into 'master' Rémy Coutable2016-03-011-1/+14
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Brings back missing "Gitlab" text on the logo Closes #13851 See merge request !2989
| * | | | | | | Bring back Gitlab textissue_13851Alfredo Sumaran2016-02-291-1/+14
| | | | | | | |
* | | | | | | | Merge branch 'fix/contributions-forked-projects' into 'master' Douwe Maan2016-03-013-1/+20
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | include contributions from forked projects on profile calendar Shows contributions from forked projects in the calendar Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/3612 See merge request !2918
| * \ \ \ \ \ \ \ Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into ↵James Lopez2016-02-29194-865/+5348
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fix/contributions-forked-projects
| * | | | | | | | | include contributions from forked projects on profile calendarJames Lopez2016-02-223-1/+20
| | | | | | | | | |
* | | | | | | | | | Merge branch 'feature/slacky-builds-v2' into 'master' James Lopez2016-03-011-1/+1
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add commit message to slack script Ass suggested by @rdavila, this adds the current commit message as of HEAD to the slack script. See merge request !3027
| * | | | | | | | | | fix syntax errorJames Lopez2016-03-011-1/+1
| | | | | | | | | | |
| * | | | | | | | | | added commit message to slack scriptJames Lopez2016-03-011-1/+1
|/ / / / / / / / / /
* | | | | | | | | | Merge branch 'triggers_link' into 'master' Achilleas Pipinellis2016-03-011-1/+3
|\ \ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add link to triggers doc in variables section Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/13901 See merge request !3025
| * | | | | | | | | Add link to triggers doc in variables sectionAchilleas Pipinellis2016-03-011-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | | | | Merge branch 'issue_13212' into 'master' Jacob Schatz2016-02-293-1/+15
|\ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes padding loss after editing a diff comment Also applies .timeago() to comment datetimes when diff page is entered directly. Also fixes the vertical position of the comment count icon. See merge request !3012
| * | | | | | | | | Merge branch 'master' into issue_13212issue_13212Alfredo Sumaran2016-02-2956-185/+688
| |\ \ \ \ \ \ \ \ \
| * | | | | | | | | | Comment icon vertically alignedAlfredo Sumaran2016-02-291-0/+1
| | | | | | | | | | |