summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Eliminate constants warnings by:Lin Jen-Shin2018-06-019-22/+24
| | | | | * Replace `require` or `require_relative` with `require_dependency` * Remove unneeded `autoload`
* Preserve warnings even if it passedLin Jen-Shin2018-06-011-10/+10
|
* Merge branch 'fix-snippets-embed' into 'master'Annabel Gray2018-05-312-21/+5
|\ | | | | | | | | | | | | Fix snippets embed form Closes #46948 See merge request gitlab-org/gitlab-ce!19219
| * Fix snippets embed formClement Ho2018-05-312-21/+5
|/
* Merge branch 'rails5-active-sup-subscriber' into 'master'Rémy Coutable2018-05-312-1/+6
|\ | | | | | | | | | | | | Make ActiveRecordSubscriber rails 5 compatible Closes #44702 See merge request gitlab-org/gitlab-ce!19276
| * Make ActiveRecordSubscriber rails 5 compatibleJarka Kadlecová2018-05-312-1/+6
| |
* | Merge branch 'issue_45082' into 'master'Douwe Maan2018-05-315-230/+452
|\ \ | | | | | | | | | | | | | | | | | | Add merge requests list endpoint for groups Closes #45082 See merge request gitlab-org/gitlab-ce!18915
| * | Add merge requests list endpoint for groupsFelipe Artur2018-05-315-230/+452
|/ /
* | Merge branch '46552-fixes-redundant-message-for-failure-reasons' into 'master'Grzegorz Bizon2018-05-315-13/+26
|\ \ | | | | | | | | | | | | | | | | | | Fixes redudant script failure message Closes #46552 and #44271 See merge request gitlab-org/gitlab-ce!19138
| * | Moves script_failure conditional over lambda46552-fixes-redundant-message-for-failure-reasonsMayra Cabrera2018-05-301-2/+2
| | | | | | | | | | | | So the 'failed' message can actually indicate if the build failed or not
| * | Removes redundant error message for script failuresMayra Cabrera2018-05-245-13/+26
| | | | | | | | | | | | | | | | | | | | | Script failure message was redundant so it was removed. Also 'check your job log' message was removed from all the error messages. Closes #44271
* | | Merge branch '41587-osw-mr-metrics-migration-take-two' into 'master'Grzegorz Bizon2018-05-3112-5/+138
|\ \ \ | | | | | | | | | | | | | | | | Take two for MR metrics population background migration See merge request gitlab-org/gitlab-ce!19097
| * | | Ensure metrics regardless of being imported on MRs41587-osw-mr-metrics-migration-take-twoOswaldo Ferreira2018-05-303-2/+2
| | | |
| * | | Take two for MR metrics population background migrationOswaldo Ferreira2018-05-309-3/+136
| | | |
* | | | Merge branch 'add-yarn-clean-step' into 'master'Mike Greiling2018-05-312-1/+8
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Add yarn clean step, to delete production compiled assets See merge request gitlab-org/gitlab-ce!19212
| * | | | Add yarn clean step, to delete production compiled assetsadd-yarn-clean-stepJose2018-05-292-1/+8
| | | | |
* | | | | Merge branch '46799-fix-tabs-bs4' into 'master'Clement Ho2018-05-315-26/+36
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix active tab styling Closes #46799 See merge request gitlab-org/gitlab-ce!19264
| * | | | | Fix active tab stylingAnnabel Gray2018-05-315-26/+36
|/ / / / /
* | | | | Merge branch 'winh-capybara-html-hack-docs' into 'master'Clement Ho2018-05-311-0/+4
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Add link to hack for styling Capybara HTML dumps See merge request gitlab-org/gitlab-ce!19205
| * | | | | Add link to hack for styling Capybara HTML dumpsWinnie Hellmann2018-05-311-0/+4
|/ / / / /
* | | | | Merge branch '44184-issues_ical_feed' into 'master'Douwe Maan2018-05-3169-186/+569
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Export assigned issues in iCalendar feed Closes #44184 See merge request gitlab-org/gitlab-ce!17783
| * | | | | Export assigned issues in iCalendar feedImre Farkas2018-05-3169-186/+569
|/ / / / /
* | | | | Merge branch 'sh-fix-issue-api-perf-n-plus-one' into 'master'Nick Thomas2018-05-312-1/+6
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Eliminate cached N+1 queries for projects in Issue API See merge request gitlab-org/gitlab-ce!19269
| * | | | | Eliminate cached N+1 queries for projects in Issue APIStan Hu2018-05-312-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In CE, every `Issue` entity is also a `ProjectEntity`, which calls `entity&.project.try(:id)` to show the project ID. In an API request with 100 issues, this would hit the Rails statement cache 100 times for the same project and cause unnecessary overhead as related models would also be loaded. In EE, we call `Issue#supports_weight?` for each issue, which then calls `project&.feature_available?(:issue_weights)`. If the project is not preloaded, this incurs additional overhead, as each individual Project object has to be queried. This can lead to a significant performance hit. In loading the CE project with 100 issues, this contributed to at least 22% of the load time. See https://gitlab.com/gitlab-org/gitlab-ce/issues/47031 for why testing this is a bit tricky.
* | | | | | Merge branch 'rails5-fix-46230' into 'master'Rémy Coutable2018-05-312-6/+11
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use strings as properties key in kubernetes service spec. See merge request gitlab-org/gitlab-ce!19265
| * | | | | | Use strings as properties key in kubernetes service spec.Jasper Maes2018-05-302-6/+11
| | | | | | |
* | | | | | | Merge branch 'gitignore-vendor-gitaly-ruby' into 'master'Rémy Coutable2018-05-311-0/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add /vendor/gitaly-ruby to gitignore See merge request gitlab-org/gitlab-ce!19261
| * | | | | | | Add /vendor/gitaly-ruby to gitignoreJacob Vosmaer2018-05-301-0/+1
| |/ / / / / /
* | | | | | | Merge branch 'rails5-calendar' into 'master'Yorick Peterse2018-05-311-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace .having with .where in calendar query Closes #46964 See merge request gitlab-org/gitlab-ce!19230
| * | | | | | | Replace .having with .where in calendar queryJan Provaznik2018-05-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the current syntax doesn't work properly in Rails 5, the resulting query looks like: HAVING "events"."project_id" IN (0) instead of: HAVING "events"."project_id" IN (SELECT "projects"."id" FROM... Also we should not use ActiveRecord internal methods. In this case we can filter projects in WHERE clause instead of doing this in HAVING clause. Usage of WHERE should be also more efficient because grouping is then done on much smaller subset of records.
* | | | | | | | Merge branch 'rails5-exists-query' into 'master'Yorick Peterse2018-05-311-5/+3
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace `.exists` with `EXISTS ()` Closes #46277 See merge request gitlab-org/gitlab-ce!19178
| * | | | | | | | Replace `.exists` with `EXISTS ()`Jan Provaznik2018-05-281-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `.exists` should not be used because it's an internal ActiveRecord method, but we can easily generate the same sql query with `EXISTS`.
* | | | | | | | | Merge branch 'gitaly-0.104.0' into 'master'Douwe Maan2018-05-311-1/+1
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use Gitaly 0.104.0 See merge request gitlab-org/gitlab-ce!19258
| * | | | | | | | | Use Gitaly 0.104.0Jacob Vosmaer2018-05-301-1/+1
| | |_|/ / / / / / | |/| | | | | | |
* | | | | | | | | Merge branch '46445-fix-gitaly-tree-entry-encoding' into 'master'Douwe Maan2018-05-316-5/+13
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix encoding bug in Gitaly::Commit::TreeEntry Closes #46445 and gitaly#1208 See merge request gitlab-org/gitlab-ce!19243
| * | | | | | | | | Fix encoding error in Gitaly::Commit::TreeEntryKim "BKC" Carlbäcker2018-05-306-5/+13
| |/ / / / / / / /
* | | | | | | | | Merge branch ↵Phil Hughes2018-05-316-148/+84
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '45520-remove-links-from-web-ide-unexpectedly-navigate-you-to-a-different-page' into 'master' Resolve "Remove links from Web IDE unexpectedly navigate you to a different page" Closes #45520 See merge request gitlab-org/gitlab-ce!19129
| * | | | | | | | Resolve "Remove links from Web IDE unexpectedly navigate you to a different ↵Sam Beckham2018-05-316-148/+84
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | page"
* | | | | | | | Merge branch 'leipert-port-project-settings' into 'master'Rémy Coutable2018-05-316-42/+50
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cleanup code for General Project Settings See merge request gitlab-org/gitlab-ce!19245
| * | | | | | | | Cleanup code for General Project SettingsLukas Eipert2018-05-316-42/+50
|/ / / / / / / /
* | | | | | | | Merge branch '46903-osw-fix-permitted-params-filtering-on-merge-scheduling' ↵Sean McGivern2018-05-313-4/+9
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | into 'master' Adjust permitted params filtering on merge scheduling Closes #46903 See merge request gitlab-org/gitlab-ce!19255
| * | | | | | | | Adjust permitted params filtering on merge scheduling46903-osw-fix-permitted-params-filtering-on-merge-schedulingOswaldo Ferreira2018-05-303-4/+9
| |/ / / / / / /
* | | | | | | | Merge branch ↵Sean McGivern2018-05-311-2/+2
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '46991-unable-to-start-rails-console-if-using-master-from-gitlab-shell' into 'master' Resolve "Unable to start rails console if using master from gitlab-shell" Closes #46991 See merge request gitlab-org/gitlab-ce!19251
| * | | | | | | | better handle a missing gitlab-shell versionBrett Walker2018-05-301-2/+2
| | | | | | | | |
* | | | | | | | | Merge branch 'rails5-cattr' into 'master'Douwe Maan2018-05-311-3/+1
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix cattr_accessor definition Closes #46282 See merge request gitlab-org/gitlab-ce!19192
| * | | | | | | | | Fix cattr_accessor definitionJan Provaznik2018-05-281-3/+1
| | |_|/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use cattr_accessor directly inside the defined class, otherwise in Rails 5 this accessor returns nil.
* | | | | | | | | Merge branch 'fj-36819-remove-v3-api' into 'master'Douwe Maan2018-05-3197-16029/+356
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removal of API v3 from the codebase Closes #36819 See merge request gitlab-org/gitlab-ce!18970
| * | | | | | | | | Removed API endpoint and specsfj-36819-remove-v3-apiFrancisco Javier López2018-05-3097-16029/+356
| | |_|/ / / / / / | |/| | | | | | |
* | | | | | | | | Merge branch '46971-extra-whitespace' into 'master'Phil Hughes2018-05-311-1/+1
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Extra whitespace when hovering commit sha in MR widget" Closes #46971 See merge request gitlab-org/gitlab-ce!19267
| * \ \ \ \ \ \ \ \ Merge branch 'master' into 46971-extra-whitespaceFilipa Lacerda2018-05-3178-993/+892
| |\ \ \ \ \ \ \ \ \ | | | |_|_|_|/ / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (32 commits) Update CHANGELOG.md for 10.8.3 Update "col-xs" usage to bootstrap4 Add missing usage_ping_enabled to API settings Make Repository#blob_data_at a public method Fix UI broken in line profiling modal due to Bootstrap 4 Only preload member records for the relevant projects/groups/user in projects API Fix   after sign-in with Google button Fix a wrong link reference in docs Simplify spec: `2.times.each` -> `2.times` Replace grape-route-helpers with our own grape-path-helpers Add archived param to the json response Consider we might have prefix for stable branches Convert spec/javascripts/.eslintrc to yml format as well Remove version lock on awesome_print dependency Fix import project by url layout Fix missing timeout value in object storage pre-authorization call fix last lints disable no-multi-assign fix `spaced-comment` remove unused createComponentWithMixin from vue spec helpers ...