| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
| |
[ci skip]
|
|\
| |
| |
| |
| | |
Set max-age and secure flag for pages auth cookies
See merge request gitlab/gitlabhq!3380
|
|/ |
|
| |
|
|
|
| |
[ci skip]
|
|
|
|
|
|
|
|
|
|
| |
'66641-broken-master-real-http-connections-are-disabled-unregistered-request' into 'master'
Use `stub_full_request` to fix spec failure
Closes #66641
See merge request gitlab-org/gitlab-ce!32259
|
|
|
|
| |
This reverts commit 4f6293e2a0fc636de6de8b105b1de06f906ef33a.
|
|\
| |
| |
| |
| |
| |
| | |
'security-fix-something-went-wrong-on-when-not-logged-in-ce-12-1' into '12-1-stable'
Return NO_ACCESS if user is nil
See merge request gitlab/gitlabhq!3389
|
| |
| |
| |
| | |
Also change test URL sequest to .test TLD
|
|/ |
|
| |
|
|
|
| |
[ci skip]
|
|\
| |
| |
| |
| | |
Avoid exposing unaccessible repo data upon GFM post processing
See merge request gitlab/gitlabhq!3383
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When post-processing relative links to absolute links
RelativeLinkFilter didn't take into consideration that
internal repository data could be exposed for users
that do not have repository access to the project.
This commit solves that by checking whether the user
can `download_code` at this repository, avoiding any
processing of this filter if the user can't.
Additionally, if we're processing for a group (
no project was given), we check if the user can
read it in order to expand the href as an extra.
That doesn't seem necessarily a breach now,
but an extra check doesn't hurt as after all
the user needs to be able to `read_group`.
|
|\
| |
| |
| |
| | |
Prevent disclosure of merge request id via email
See merge request gitlab/gitlabhq!3351
|
| |
| |
| |
| |
| | |
Do not disclosure merge request id via email for unauthorized users
when closing issues.
|
|\ \
| | |
| | |
| | |
| | | |
Send TODOs for comments on commits correctly
See merge request gitlab/gitlabhq!3366
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
At present, the TodoService uses the `:read_project` ability to decide
whether a user can read a note on a commit. However, commits can have a
visibility level that is more restricted than the project, so this is a
security issue.
This commit changes the code to use the `:read_commit` ability in this
case instead, which ensures TODOs are only generated for commit notes
if the users can see the commit.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
'12-1-stable'
Require a captcha after unique failed logins from the same IP
See merge request gitlab/gitlabhq!3295
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add method to store session ids by ip
Add new specs for storing session ids
Add cleaning up records after login
Add retrieving anonymous sessions
Add login recaptcha setting
Add new setting to sessions controller
Add conditions for showing captcha
Add sessions controller specs
Add admin settings specs for login protection
Add new settings to api
Add stub to devise spec
Add new translation key
Add cr remarks
Rename class call
Add cr remarks
Change if-clause for consistency
Add cr remarks
Add code review remarks
Refactor AnonymousSession class
Add changelog entry
Move AnonymousSession class to lib
Move store unauthenticated sessions to sessions controller
Move link to recaptcha info
Regenerate text file
Improve copy on the spam page
Change action filter for storing anonymous sessions
Fix rubocop offences
Add code review remarks
Fix schema
Update schema version
|
|\ \
| | |
| | |
| | |
| | | |
Use image proxy to mitigate stealing ip addresses
See merge request gitlab/gitlabhq!3231
|
| | |
| | |
| | |
| | |
| | |
| | | |
User images and videos will get proxied through
the Camo server in order to keep malicious
sites from collecting the IP address of users.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Limit the size of issuable description and comments
See merge request gitlab/gitlabhq!3271
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Limiting the size of issuable description and comments to 1_000_000,
which is close to ~1MB of ASCII characters, which represents 99.9% of
all descriptions and comments we have in DB at the moment. This should
help prevent DoS attacks when comments contain refference strings.
Also this change updates regexp matching the namespaces paths by
limiting the namespaces paths to Namespace::NUMBER_OF_ANCESTORS_ALLOWED,
as we allow 20 levels deep groups.
see https://gitlab.com/gitlab-org/gitlab-ce/issues/61974#note_191274234
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Permission fix for MergeRequestsController#pipeline_status
See merge request gitlab/gitlabhq!3278
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Use set_pipeline_variables to filter for visible pipelines
- Mimic response of nonexistent pipeline if not found
- Provide set_pipeline_variables as a before_filter for other actions
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Enforce max chars and max render time in markdown math
See merge request gitlab/gitlabhq!3287
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
KaTeX math will now render progressivly and asynchronously. There
are upper limits on the character count of each formula, and on
cumulative render time.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
DNS Rebind SSRF in Kubernetes Integration
See merge request gitlab/gitlabhq!3289
|
| | |_|_|/
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Kubeclient uses rest-client. We hack into to access the net/http object
so that we can patch to connect to the resolved IP + set
hostname_override.
Add specs for discord. The discord integration also uses rest-client, so
since we patched rest-client, spec that the DNS rebinding protection
works
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
into '12-1-stable'
Fix HTML injection for label description
See merge request gitlab/gitlabhq!3298
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
'12-1-stable'
Ensure only authorised users can create notes on merge requests and issues
See merge request gitlab/gitlabhq!3307
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Prevent creating notes on inaccessible MRs
This applies the notes rules at the MR scope. Rather than adding extra
rules to the Project level policy, preventing :create_note here is
better since it only prevents creating notes on MRs.
* Prevent creating notes in inaccessible Issues
without this policy, non-team-members are allowed to comment on issues
even when the project has the private-issues policy set. This means that
without this change, users are allowed to comment on issues that they
cannot read.
* Add CHANGELOG entry
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
'12-1-stable'
Filter out old system notes for epics in notes api endpoint response
See merge request gitlab/gitlabhq!3310
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix DNS rebind vulnerability for JIRA integration
See merge request gitlab/gitlabhq!3311
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | | |
Uses Gitlab::HTTP for JIRA requests instead of Net::Http.
Gitlab::Http comes with some built in SSRF protections.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
'12-1-stable'
Add merge note type as cross reference
See merge request gitlab/gitlabhq!3327
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Project visibility restriction bypass
See merge request gitlab/gitlabhq!3331
|
| | |_|_|/ /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Add Gitlab::VisibilityLevelChecker that verifies
selected project visibility level (or overridden param)
is not restricted when creating or importing a project
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Bump Gitaly version to 1.53.3
See merge request gitlab/gitlabhq!3336
|
| | |_|_|_|/
| |/| | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Introduce JobActivity limit for alive jobs
See merge request gitlab/gitlabhq!3342
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This is a port from EE changes where
we introduce a new limit for Plan model.
https://dev.gitlab.org/gitlab/gitlab-ee/merge_requests/1182
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
'12-1-stable'
Clear reset_password_tokens when login (email or username) change
See merge request gitlab/gitlabhq!3347
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Devise checks before updating any of the authentication_keys if it
needs to clear the reset_password_tokens.
This should fix:
https://gitlab.com/gitlab-org/gitlab-ce/issues/42733 (Weak
authentication and session management)
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Restrict MergeRequests#test_reports to authenticated users with read-access on Builds
See merge request gitlab/gitlabhq!3355
|