summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| | * | | | | | | | | | | | created services for keyshaseeb2017-09-1518-49/+103
| |/ / / / / / / / / / / /
| * | | | | | | | | | | | Merge branch '21331-improve-confusing-compare-page' into 'master'Phil Hughes2017-09-155-17/+28
| |\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make the labels in the Compare form less confusing Closes #21331 See merge request gitlab-org/gitlab-ce!14225
| | * | | | | | | | | | | | Make the labels in the Compare form less confusing21331-improve-confusing-compare-pageRémy Coutable2017-09-155-17/+28
| | |/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Improve the descriptive text * Rename "from" to "Target" and "to" to "Source" * Swap "Target" and "Source" to have the same order as in MRs * Reworded "Switch base of comparison" to "Swap versions" Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | | | | | | | | | | | Merge branch 'projects-controller-show' into 'master'Rémy Coutable2017-09-157-16/+121
| |\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SQL performance improvements for ProjectsController#show See merge request gitlab-org/gitlab-ce!14226
| | * | | | | | | | | | | | Memoize the latest builds of a pipelineprojects-controller-showYorick Peterse2017-09-144-15/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This ensures that if a pipeline is present for the last commit on a project's homepage we only run 1 query to get the builds, instead of running 2 queries. See https://gitlab.com/gitlab-org/gitlab-ce/issues/36878#note_40073339 for more information.
| | * | | | | | | | | | | | Memoize pipelines for project download buttonsYorick Peterse2017-09-144-1/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds Project#latest_successful_pipeline_for and Project#latest_successful_pipeline_for_default_branch. The 2nd method memoizes the result (taking nil values into account) to ensure the underlying query isn't executed multiple times when viewing a project's homepage. See https://gitlab.com/gitlab-org/gitlab-ce/issues/36878#note_40073607 for more information.
| * | | | | | | | | | | | | Merge branch 'winh-protected-branch-modal-merged' into 'master'36436-repo-button-back-button-not-consistentPhil Hughes2017-09-154-5/+20
| |\ \ \ \ \ \ \ \ \ \ \ \ \ | | |_|/ / / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Display whether branch has been merged when deleting protected branch Closes #32295 See merge request gitlab-org/gitlab-ce!14220
| | * | | | | | | | | | | | Display whether branch has been merged when deleting protected branchWinnie Hellmann2017-09-154-5/+20
| |/ / / / / / / / / / / /
| * | | | | | | | | | | | Merge branch 'revert-sidebar-title-attribute' into 'master'Filipa Lacerda2017-09-157-48/+39
| |\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove title attribute from sidebar elements See merge request gitlab-org/gitlab-ce!14140
| | * | | | | | | | | | | | fixed merge request specrevert-sidebar-title-attributePhil Hughes2017-09-131-1/+1
| | | | | | | | | | | | | |
| | * | | | | | | | | | | | Remove title attribute from sidebar elementsPhil Hughes2017-09-136-47/+38
| | | | | | | | | | | | | |
| * | | | | | | | | | | | | Merge branch 'docs/environment-vars-clarify' into 'master'Rémy Coutable2017-09-153-57/+69
| |\ \ \ \ \ \ \ \ \ \ \ \ \ | | |_|_|_|_|_|_|_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clarify what variables can be used under `environment:` See merge request gitlab-org/gitlab-ce!14277
| | * | | | | | | | | | | | Clarify what variables can be used under `environment:`docs/environment-vars-clarifyAchilleas Pipinellis2017-09-143-57/+69
| | | |_|_|_|_|_|_|_|_|/ / | | |/| | | | | | | | | |
| * | | | | | | | | | | | Merge branch '20824-scope-users-to-members-in-group-issuable-list' into 'master'Phil Hughes2017-09-157-2/+57
| |\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Scope users by group inside dropdowns if I'm on group page (Issue, MRs)" Closes #20824 See merge request gitlab-org/gitlab-ce!14249
| | * | | | | | | | | | | | Return only group's members in user dropdowns on issuables list pages20824-scope-users-to-members-in-group-issuable-listRémy Coutable2017-09-146-0/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| | * | | | | | | | | | | | Scope users by group in issuable search barbarthc2017-09-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | | | | | | | | | | | | Merge branch '37844-layout-nav-space' into 'master'Phil Hughes2017-09-151-1/+1
| |\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove extra space between profile header and navbar Closes #37844 See merge request gitlab-org/gitlab-ce!14275
| | * | | | | | | | | | | | | Remove extra space between profile header and navbar37844-layout-nav-spaceAnnabel Dunstone Gray2017-09-141-1/+1
| | | |/ / / / / / / / / / / | | |/| | | | | | | | | | |
| * | | | | | | | | | | | | Merge branch '37886-typo-in-protected-runners-setting-checkbox' into 'master'Grzegorz Bizon2017-09-151-1/+1
| |\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Typo in Protected Runners setting checkbox" Closes #37886 See merge request gitlab-org/gitlab-ce!14284
| | * | | | | | | | | | | | | Fix typo37886-typo-in-protected-runners-setting-checkboxFabio Busatto2017-09-141-1/+1
| | | |_|_|_|_|_|_|_|/ / / / | | |/| | | | | | | | | | |
| * | | | | | | | | | | | | Merge branch 'patch-26' into 'master'Stan Hu2017-09-151-1/+4
| |\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add info about UX label to feature proposal to CONTRIBUTING.md See merge request gitlab-org/gitlab-ce!14281
| | * | | | | | | | | | | | | add info about UX label to feature proposal to CONTRIBUTING.mdSarrah Vesselov2017-09-141-1/+4
| | | | | | | | | | | | | | |
| * | | | | | | | | | | | | | Merge branch '37896-minor-improvements-to-prometheus-docs' into 'master'Achilleas Pipinellis2017-09-152-3/+2
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | |_|/ / / / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Minor improvements to prometheus docs Closes #37896 See merge request gitlab-org/gitlab-ce!14288
| | * | | | | | | | | | | | | update screenshot37896-minor-improvements-to-prometheus-docsJoshua Lambert2017-09-151-0/+0
| | | | | | | | | | | | | | |
| | * | | | | | | | | | | | | fix minor typoJoshua Lambert2017-09-151-3/+2
| |/ / / / / / / / / / / / /
| * | | | | | | | | | | | | Merge branch 'indexes-for-recent-push-events' into 'master'Robert Speicher2017-09-142-2/+42
| |\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add missing index for getting recent push events See merge request gitlab-org/gitlab-ce!14273
| | * | | | | | | | | | | | | Add missing index for getting recent push eventsindexes-for-recent-push-eventsYorick Peterse2017-09-142-2/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This index is required to allow fast retrieval of recent push events without merge requests. Without this index in place the query would lead to PostgreSQL scanning over 150 000 index entries all the time, easily taking up between 200 and 500 milliseconds. This index reduces the time spent in this process to around 40 milliseconds on GitLab.com.
| * | | | | | | | | | | | | | Merge branch 'changes-overflow-fix' into 'master'Annabel Dunstone Gray2017-09-142-3/+11
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | |_|/ / / / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed overflow issue in changes dropdown See merge request gitlab-org/gitlab-ce!14181
| | * | | | | | | | | | | | | Fixed overflow issue in changes dropdownchanges-overflow-fixPhil Hughes2017-09-132-3/+11
| | | |_|_|/ / / / / / / / / | | |/| | | | | | | | | | |
| * | | | | | | | | | | | | Merge branch '37872-fix-nasty-gdk-nuke' into 'master'Robert Speicher2017-09-142-37/+51
| |\ \ \ \ \ \ \ \ \ \ \ \ \ | | |_|/ / / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "`bin/rspec`/`bin/karma` can nuke the GDK entirely" Closes #37872 See merge request gitlab-org/gitlab-ce!14276
| | * | | | | | | | | | | | Make TestInit.setup_gitlab_shell and TestInit.setup_gitaly more robust37872-fix-nasty-gdk-nukeRémy Coutable2017-09-141-36/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| | * | | | | | | | | | | | Abort when `TestEnv.init` is not called in the `test` environmentRémy Coutable2017-09-141-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| | * | | | | | | | | | | | Force `RAILS_ENV` to `test` in `spec/spec_helper.rb`Rémy Coutable2017-09-141-1/+1
| | | |_|_|/ / / / / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | | | | | | | | | | | Merge branch 'docs-my-reaction-filter' into 'master'Achilleas Pipinellis2017-09-141-2/+2
| |\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Docs filter by my reaction See merge request gitlab-org/gitlab-ce!14197
| | * | | | | | | | | | | | Docs filter by my reactionVictor Wu2017-09-141-2/+2
| |/ / / / / / / / / / / /
| * | | | | | | | | | | | Merge branch 'ci-environment-status-performance' into 'master'Stan Hu2017-09-145-3/+32
| |\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Constrain environment deployments to project IDs Closes #36877 See merge request gitlab-org/gitlab-ce!14252
| | * | | | | | | | | | | | Disallow NULL values for environments.project_idci-environment-status-performanceYorick Peterse2017-09-133-2/+23
| | | | | | | | | | | | | |
| | * | | | | | | | | | | | Constrain environment deployments to project IDsYorick Peterse2017-09-132-1/+9
| | | |_|_|/ / / / / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When querying the deployments of an environment the query Rails produces will be along the lines of the following: SELECT * FROM deployments WHERE environment_id = X For queries such as this (or queries that use this as their base and add more conditions) there is no meaningful index that can be used as long as deployments.project_id is not part of a WHERE clause. To work around this we change that "has_many :deployments" relation to always add a "WHERE project_id = X" condition. This means that queries filtering deployments can make better use of the existing indexes. For example, when filtering by deployments.iid this will result in the following query: SELECT * FROM deployments WHERE environment_id = X AND project_id = Y AND iid = Z This means PostgreSQL can use the existing index on (project_id, environment_id, iid) instead of having to use a different index (or none at all) and having to scan over a large amount of data. Query plan wise this means that instead of this query and plan: EXPLAIN (BUFFERS, ANALYZE) SELECT deployments.* FROM deployments WHERE deployments.environment_id = 5 AND deployments.iid = 225; Index Scan using index_deployments_on_project_id_and_iid on deployments (cost=0.42..14465.75 rows=1 width=117) (actual time=6.394..38.048 rows=1 loops=1) Index Cond: (iid = 225) Filter: (environment_id = 5) Rows Removed by Filter: 839 Buffers: shared hit=4534 Planning time: 0.076 ms Execution time: 38.073 ms We produce the following query and plan: EXPLAIN (BUFFERS, ANALYZE) SELECT deployments.* FROM deployments WHERE deployments.environment_id = 5 AND deployments.iid = 225 AND deployments.project_id = 1292351; Index Scan using index_deployments_on_project_id_and_iid on deployments (cost=0.42..4.45 rows=1 width=117) (actual time=0.018..0.018 rows=1 loops=1) Index Cond: ((project_id = 1292351) AND (iid = 225)) Filter: (environment_id = 5) Buffers: shared hit=4 Planning time: 0.088 ms Execution time: 0.039 ms On GitLab.com these changes result in a (roughly) 11x improvement in SQL timings for the CI environment status endpoint. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36877
| * | | | | | | | | | | | Merge branch 'change-dashed-border-button-color' into 'master'Annabel Dunstone Gray2017-09-143-1/+8
| |\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changed dashed border button color to be darker See merge request gitlab-org/gitlab-ce!14041
| | * | | | | | | | | | | | changed dashed border button color to be darkerchange-dashed-border-button-colorDimitrie Hoekstra2017-09-143-1/+8
| | | |/ / / / / / / / / / | | |/| | | | | | | | | |
| * | | | | | | | | | | | Merge branch 'uipolish-fix-remember-me-checkbox' into 'master'Annabel Dunstone Gray2017-09-143-3/+12
| |\ \ \ \ \ \ \ \ \ \ \ \ | | |_|_|_|_|_|_|_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add missing classes to omniauth remember-me checkbox and add correct font-size See merge request gitlab-org/gitlab-ce!14111
| | * | | | | | | | | | | Add missing classes to omniauth remember-me checkbox and add correct font-sizeJedidiah2017-09-143-3/+12
| |/ / / / / / / / / / /
| * | | | | | | | | | | Merge branch 'bvl-extend-query-recorder' into 'master'Rémy Coutable2017-09-143-7/+39
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Extend the QueryRecorder matcher See merge request gitlab-org/gitlab-ce!14267
| | * | | | | | | | | | | Use the new query-recorder features as a PoCbvl-extend-query-recorderBob Van Landuyt2017-09-142-5/+5
| | | | | | | | | | | | |
| | * | | | | | | | | | | Extend the QueryRecorder matcherBob Van Landuyt2017-09-141-2/+34
| | |/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | So it can report the queries that we're run more compared to the control point.
| * | | | | | | | | | | Merge branch 'gitlab-git-user' into 'master'Rémy Coutable2017-09-147-39/+45
| |\ \ \ \ \ \ \ \ \ \ \ | | |_|_|_|_|_|_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename Gitlab::Git::Committer to User See merge request gitlab-org/gitlab-ce!14254
| | * | | | | | | | | | Rename Gitlab::Git::Committer to UserJacob Vosmaer2017-09-147-39/+45
| | | | | | | | | | | |
| * | | | | | | | | | | Merge branch 'refactor-animate-js' into 'master'Clement Ho2017-09-144-57/+5
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reduce footprint of animate.js See merge request gitlab-org/gitlab-ce!14187
| | * | | | | | | | | | | Remove animate.js and the issuable label pulse animation.refactor-animate-jsBryce Johnson2017-09-134-57/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Nobody tell @jschatz1 :P
| * | | | | | | | | | | | Merge branch '37739-improve-nginx-ingress-configuration-docs' into 'master'Achilleas Pipinellis2017-09-141-4/+4
| |\ \ \ \ \ \ \ \ \ \ \ \ | | |_|_|_|_|_|/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve nginx ingress configuration docs Closes #37739 See merge request gitlab-org/gitlab-ce!14203